I say that it is more readable because I understood you wanted the return
code as soon as possible, but, anyway, what would you propose as code for
this function?
Would the following work for you?
+
+ if ( !pSrcFile )
+ return D3DXERR_INVALIDDATA;
+ else
+ {
+ LPWSTR pSrcFileW = NULL;
+
""Luis C. Busquets Pérez"" <[EMAIL PROTECTED]> wrote:
> Changed the if clauses to make the implementation more readable.
...
> + if ( !pSrcFile )
> + return D3DXERR_INVALIDDATA;
> + else
> + {
> + len = MultiByteToWideChar( CP_ACP, 0, pSrcFile, -1, NULL, 0 );
> + pSrcFileW = HeapAlloc( Ge
Hi Lei,
I think a new file for user dir look up in the shell32 is of no use.
Rather than we can add it to the xdg.c and xdg.h, as it contains the
generic xdg code for shell32.
Its like having all xdg specific code at one place.
This is my personal opinion about those patches.
Thanks,
VJ
Hi Rob,
+ok(*(DWORD *)wireip == 0x44, "wireip + 0x0 should be 0x4c
instead of 0x%08x\n", *(DWORD *)wireip);
+wireip += sizeof(DWORD);
+ok(*(DWORD *)wireip == 0x44, "wireip + 0x8 should be 0x4c
instead of 0x%08x\n", *(DWORD *)wireip);
Shouldn't these be "should be 0x44 inst
Juan Lang wrote:
> Hi Rob,
>
> @@ -232,6 +239,198 @@ static DWORD registry_read_credential(HKEY hkey,
> PCREDENTIALW credential,
> return ret;
> }
>
> +static DWORD mac_read_credential_from_item(SecKeychainItemRef item,
> BOOL require_password,
> + PC
Hi Rob,
@@ -232,6 +239,198 @@ static DWORD registry_read_credential(HKEY hkey,
PCREDENTIALW credential,
return ret;
}
+static DWORD mac_read_credential_from_item(SecKeychainItemRef item,
BOOL require_password,
+ PCREDENTIALW credential,
char *buffer
On Nov 25, 2007 10:10 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> So far, 82 bugs have been nominated to be fixed for 1.0.
Forgot to mention:
http://wiki.winehq.org/WineReleaseCriteria
has a handy link to a bugzilla query that shows the list of 1.0 bugs.
Am Montag, 26. November 2007 12:17:07 schrieb Rafał Miłecki:
> 2007/11/7, Rafał Miłecki <[EMAIL PROTECTED]>:
> > Bug is quite well decribed in:
> > http://bugs.winehq.org/show_bug.cgi?id=5623 but if you don't
> > understand this, I can try to explain more detailed.
> >
> > So my request is someone
Am Montag, 26. November 2007 11:37:28 schrieb [EMAIL PROTECTED]:
> ---
> dlls/d3dx8/d3dx8_main.c | 22 --
> include/d3dx8core.h |4 ++--
> 2 files changed, 18 insertions(+), 8 deletions(-)
Please watch out with indentions. You are mixing tabs and spaces in
D3DXAssemb
Hi,
> In Wine HeapAlloc gets wrapped in different places, each using a
> different name and even a different naming convention. This makes the
> code harder to understand for people that browse the code (people doing
> janitorial work) as they have to check every time if the function is yet
> anot
Dan Hipschman <[EMAIL PROTECTED]> writes:
> This is essentially the same as the last attempt but doesn't add a wine-
> internal function to kernel32. It just puts the code directly in the
> widl-generated exception handler. An alternative is to handle these access-
> based page faults for which
<[EMAIL PROTECTED]> wrote:
> + LPWSTR pSrcFileW = NULL;
> + DWORD len;
> + HRESULT ret;
> + if (pSrcFile)
> + {
> +len = MultiByteToWideChar( CP_ACP, 0, pSrcFile, -1, NULL, 0 );
> +pSrcFileW = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) );
> +MultiByteToWide
2007/11/7, Rafał Miłecki <[EMAIL PROTECTED]>:
> Bug is quite well decribed in:
> http://bugs.winehq.org/show_bug.cgi?id=5623 but if you don't
> understand this, I can try to explain more detailed.
>
> So my request is someone try to fix this bug. Anyone have a free
> moment for this, please?
Reall
Hello!
(Jacek, this is not directed at you but a general rant).
HeapAlloc is an awful API and even its creators wrap it in a couple of
DLLs. In Wine HeapAlloc gets wrapped in different places, each using a
different name and even a different naming convention. This makes the
code harder to underst
14 matches
Mail list logo
