re: ntdll: fix uninitialized buffers, found via valgrind

2007-11-21 Thread Dan Kegel
James wrote: > Why did you move the variable declaration? Because the variable is only used inside the loop. Moving the declaration to the top of the loop is the right scoping. - Dan

Re: d3dx8 [patch 7/7] Implement D3DXMatrixTransformation

2007-11-21 Thread Ivan Gyurdiev
Any chance the formatting can be improved to include whitespace between blocks and proper indentation?

Re: ntdll: fix uninitialized buffers, found via valgrind

2007-11-21 Thread James Hawkins
On Nov 21, 2007 6:56 PM, Dan Hipschman <[EMAIL PROTECTED]> wrote: > > On Wed, Nov 21, 2007 at 06:53:27PM -0600, James Hawkins wrote: > > On Nov 21, 2007 6:08 PM, Zac Brown <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > > > Fixes valgrind error: &g

Re: ntdll: fix uninitialized buffers, found via valgrind

2007-11-21 Thread Dan Hipschman
On Wed, Nov 21, 2007 at 06:53:27PM -0600, James Hawkins wrote: > On Nov 21, 2007 6:08 PM, Zac Brown <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Fixes valgrind error: > > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > > > Changelog

Re: ntdll: fix uninitialized buffers, found via valgrind

2007-11-21 Thread James Hawkins
On Nov 21, 2007 6:08 PM, Zac Brown <[EMAIL PROTECTED]> wrote: > Hi, > > Fixes valgrind error: > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt > > Changelog: > * Initialize buffers used in test using memset > > -- > Zac Brown > > >

Re: wineprefixcreate: get xdg-user-dirs environment variables [1/2]

2007-11-21 Thread Lei Zhang
On Nov 21, 2007 4:09 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Lei Zhang" <[EMAIL PROTECTED]> writes: > > > We need to get the "well known" XDG user directories so we can symlink to > > them. > > This should be done inside shell32, not in wineprefixcreate. > > -- > Alexandre Julliard >

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

2007-11-21 Thread Stefan Dösinger
Am Donnerstag, 22. November 2007 00:15:30 schrieb Roman Mamedov: > Hello. > > Presently, if an ATI card uses open-source DRI drivers from the Mesa > project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to > Windows applications as being some generic nVIDIA model, based on D3D > capa

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

2007-11-21 Thread Roman Mamedov
James Hawkins wrote: >> If you send in a fixed patch, you need to add some variation of 'try >> X' in the subject, where X is the number of tries you're on. On top >> of this, you need to say in the body what you've changed between >> submissions. Thank you. I think I did mention the change in th

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

2007-11-21 Thread James Hawkins
On Nov 21, 2007 5:15 PM, Roman Mamedov <[EMAIL PROTECTED]> wrote: > Hello. > > Presently, if an ATI card uses open-source DRI drivers from the Mesa > project ( http://dri.freedesktop.org/wiki/ATI ), Wine will report it to > Windows applications as being some generic nVIDIA model, based on D3D > cap

Re: WineD3D: Implement detection of ATI cards with Mesa DRI drivers

2007-11-21 Thread James Hawkins
On Nov 21, 2007 4:51 PM, Roman Mamedov <[EMAIL PROTECTED]> wrote: > Sorry, a small mistake. Always check everything twice, and when you > checked twice - check the third time :( > > --- > dlls/wined3d/directx.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/win

No release this week

2007-11-21 Thread Alexandre Julliard
Folks, Because of the Thanksgiving weekend, there won't be a release this Friday. 0.9.50 will most likely be on next Friday. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Removing Windows and Solaris from the Downloads page

2007-11-21 Thread Paul Millar
On Sunday 18 November 2007 12:42:40 Paul Millar wrote: > That sounds promising. I should be able to tweak the winetest.exe build > infrastructure so it also build DLLs and executables without too much > trouble. OK, this now seems stable. The DLLs and executables are built and packaged whenever

Re: d3dx8 [patch 5/7] Implement D3DXQuaternionLn

2007-11-21 Thread Andrew Talbot
[EMAIL PROTECTED] wrote: > Hi David, There was no code in this patch. -- Andy.

something wrong with patches?

2007-11-21 Thread Kirill K. Smirnov
Hi, Is there anything wrong with the following patches? "winhelp: add basic support for ancient win3.0 help files" http://www.winehq.org/pipermail/wine-patches/2007-November/046886.html and comctl32: Implemented algorithm is a mergesort, not a quicksort http://www.winehq.org/pipermail/wine-patc

Re: Use GCC's -Wtype-limits

2007-11-21 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > If applied, I will commit to address, directly and by engaging others, > the occurrences of such warnings in Wine. I'm not opposed to applying it, but you have to fix the warnings first, as far as possible the default build should not trigger any warni

Re: [msvcrt] short tty reads don't imply EOF

2007-11-21 Thread Alexandre Julliard
"Damjan Jovanovic" <[EMAIL PROTECTED]> writes: > Changelog: > * For ttys, short reads don't mean we're at the end of the file. That's not limited to ttys, other file types can have short reads too. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [6/9] d3d9: add a test for vertex shader input matching

2007-11-21 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > From 44f176ad4fcbc92ea66d8526670a1ec573ffa9f0 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <[EMAIL PROTECTED]> > Date: Mon, 19 Nov 2007 10:53:26 +0100 > Subject: [PATCH] d3d9: add a test for vertex shader input matching This fails with the usual

Re: ntdll: Shared manifests should have a less-strict version check performed when loading them as dependencies.

2007-11-21 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > --- > dlls/ntdll/actctx.c | 56 > +++--- > 1 files changed, 35 insertions(+), 21 deletions(-) Some test cases would be nice... -- Alexandre Julliard [EMAIL PROTECTED]

Re: wineprefixcreate: get xdg-user-dirs environment variables [1/2]

2007-11-21 Thread Alexandre Julliard
"Lei Zhang" <[EMAIL PROTECTED]> writes: > We need to get the "well known" XDG user directories so we can symlink to > them. This should be done inside shell32, not in wineprefixcreate. -- Alexandre Julliard [EMAIL PROTECTED]

Re: TransGaming's dpnet (DirectPlay 8)

2007-11-21 Thread Kai Blin
On Wednesday 21 November 2007 05:42:18 Gavriel State wrote: Hi Gav, > On #winehackers the other day, kblin asked about whether TransGaming had > a Direct Play implementation. The answer is that we have something that > was worked on for a while but never completed. We have had some partial > su