Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread Pavel Troller
> i`ve tracked this down to a watchdog issue. > > whenever i do "cat /dev/watchdog" - my system reboots after ~1 minute. > > i`ve contacted the maintainer of the watchdog subsystem. > > looks like a bug to me. > > thanks > roland > Hi! I think it's not a bug, it's a normal behaviour. The k

Re: kernel32 [1/5]: Export part of UnhandledExceptionHandler as aninternal Wine function.

2007-11-19 Thread Dmitry Timoshkov
"Dan Hipschman" <[EMAIL PROTECTED]> wrote: > This patch exports the part of UnhandledExceptionFilter that sets a page > as either writable or executable in some cases to allow continued execution > as an internal wine function. This is used in the next patch to implement > exception handling in c

Re: server: Change the get_dll_info server request to allow retrievingthe image file name of a process.

2007-11-19 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: > +if (req->exe_module) > +dll = list_head( &process->dlls ) ? > +LIST_ENTRY(list_head( &process->dlls ), struct process_dll, > entry) : NULL; > +else > +dll = find_process_dll( process, req->base

Re: wininet: InternetAttemptConnect() Stub

2007-11-19 Thread Pavel Troller
> Hi Pavel, > > On Nov 19, 2007 6:30 AM, Pavel Troller <[EMAIL PROTECTED]> wrote: > > I have a problem running an offline client for ordering photo prints from > > digital cameras. > > Even it is an "offline" client, it requires the computer to be online. > > It seems that in wine, it feels

Re: bits: Description of patch set (resend 2) (0/26)

2007-11-19 Thread Roy Shea
On Mon, Nov 19, 2007 at 08:31:31PM -0600, James Hawkins wrote: > On Nov 19, 2007 6:19 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > > Howdy, > > > > This is another resend of the BITS patch set. This resend changes > > svnhost to be ANSI based, merges patches 25 and 26 (old numbering), > > and removes

Re: mshtml #6: Change FIXME that is usually invalid to TRACE.

2007-11-19 Thread James Hawkins
On Nov 19, 2007 6:51 PM, Jacek Caban <[EMAIL PROTECTED]> wrote: > --- > dlls/mshtml/navigate.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > How about a warn instead of a trace? That is unless all the correct interfaces are already available, and any other requested interface

Re: bits: Description of patch set (resend 2) (0/26)

2007-11-19 Thread James Hawkins
On Nov 19, 2007 6:19 PM, Roy Shea <[EMAIL PROTECTED]> wrote: > Howdy, > > This is another resend of the BITS patch set. This resend changes > svnhost to be ANSI based, merges patches 25 and 26 (old numbering), > and removes extra headers and linked libraries. > Any particular reason for using ans

Re: Missed Patches

2007-11-19 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Any other pointers? > This interface shouldn't be available in BSCallback. You probably added it because of the FIXME message. I've sent a patch that silences it. In the future you should check if interface is available in Windows before adding them to Wine. Jace

Re: Missed Patches

2007-11-19 Thread Alistair Leslie-Hughes
"Jacek Caban" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Alistair Leslie-Hughes wrote: >> Hi, >> Is there any reason the following patches haven't been applied? >> > [...] > >> mshtml: Provide support for the IInternetProtocol Interface >> > > The patch is obviously wrong.

Re: Missed Patches

2007-11-19 Thread Jacek Caban
Alistair Leslie-Hughes wrote: > Hi, > Is there any reason the following patches haven't been applied? > [...] > mshtml: Provide support for the IInternetProtocol Interface > The patch is obviously wrong. Did you run tests with Gecko installed? It probably won't fail, but you will see so

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread devzero
i`ve tracked this down to a watchdog issue. whenever i do "cat /dev/watchdog" - my system reboots after ~1 minute. i`ve contacted the maintainer of the watchdog subsystem. looks like a bug to me. thanks roland > -Ursprüngliche Nachricht- > Von: "Hans Leidekker" <[EMAIL PROTECTED]> > G

Missed Patches

2007-11-19 Thread Alistair Leslie-Hughes
Hi, Is there any reason the following patches haven't been applied? [1/2] msxml: Implement createTextNode [2/2] msxml: Tests for createTextNode mshtml: Provide support for the IInternetProtocol Interface Best Regards Alistair Leslie-Hughes

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread devzero
checked if app is leaking fd`s, but lsof didn`t tell anything special. after some investigation i came across the following entry in dmesg: iTCO_wdt: Unexpected close, not stopping watchdog seems that wine is triggering something with this - after unloading iTCO_wdt kernel module, the problem

Re: Wrong comparison in ntdll/actctx.c

2007-11-19 Thread nlataill
Hi, Yes, I can see that such 4-level comparisons are already in the actctx.c codebase (probably for a reason ?). Looking at MSDN earlier this evening, I could not find reference to 3rd and 4th entries in comparisons, but I probably skipped the right section in the doc. Do you believe it is worthw

Re: Wrong comparison in ntdll/actctx.c

2007-11-19 Thread Robert Shearman
nlataill wrote: Adding verbosity to actctx.c, it seems that this game is requesting version 8.0.50608.0, which does match major.minor, but not the whole version number (/major.minor.build.revision)/. ... According to MSDN, it seems only major.minor is considered for version matching: - http:/

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread Hans Leidekker
On Monday 19 November 2007 21:39:16 [EMAIL PROTECTED] wrote: > i retried with ordinary account and the crash didn`t happen there. > anyway - should i expect such problems with root ? Well, a reboot is not expected but it can certainly happen. If your app is leaking file descriptors for example, g

Re: recent cedega contributions to wine

2007-11-19 Thread Gavriel State
Stefan Dösinger wrote: >> "TransGaming's developers have been contributing some changes back to Wine >> as well, including in several networking and debugging libraries. " >> >> Just out of curiousity, which patches are these? >> > A wine-patches archive search finds these: > > http://article.

Re: Wrong comparison in ntdll/actctx.c

2007-11-19 Thread Stefan Dösinger
Am Montag, 19. November 2007 21:25:25 schrieb nlataill: > Working on a D3D game, I have found that wine is refusing to load the > following > manifest file (when Windows does not fail). > > I am proposing the following one-liner to ntdll/actctx.c: You can send patches to [EMAIL PROTECTED] Please u

Re: credui: Show a balloon tip in the credential dialog if CREDUI_FLAGS_INCORRECT_PASSWORD was specified.

2007-11-19 Thread Robert Shearman
Juan Lang wrote: > Hi Rob, > > +IDS_INCORRECTPASSWORDTITLE "Logon unsucessful" > > The typo's your own work too, eh? Absolutely! -- Rob Shearman

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread devzero
> Yes, Wine shouldn't be able to do that. You're not running Wine > as root are you? whoops - i did. shame on me :) i retried with ordinary account and the crash didn`t happen there. anyway - should i expect such problems with root ? >Does your system log reveal anything about the crash? no, un

Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal

2007-11-19 Thread Stefan Dösinger
Am Montag, 19. November 2007 21:19:08 schrieb Vijay Kiran Kamuju: > Why not having the functionality of d3dx in wined3d, instead of having > a separate d3dx library called wined3dx? > I like the having all the common functionality of d3drm,d3dx8, d3dx9_* > and d3dxof dlls at one place and for

Wrong comparison in ntdll/actctx.c

2007-11-19 Thread nlataill
Hi, Working on a D3D game, I have found that wine is refusing to load the following manifest file (when Windows does not fail). Adding verbosity to actctx.c, it seems that this game is requesting version 8.0.50608.0, which does match major.minor, but not the whole version numb

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread Hans Leidekker
On Monday 19 November 2007 20:59:46 [EMAIL PROTECTED] wrote: > when scannnig trough drive z:\ , my notebook reboots ! > wasn`t wine a userspace application with no kernel related stuff ? > so it`s weird, that windirstat is crashing my notebook, isn`t it ? Yes, Wine shouldn't be able to do that.

Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal

2007-11-19 Thread Vijay Kiran Kamuju
On 11/19/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Hi, > > It's not really about this patch, but I am curious what the plans about > sharing code between the various d3dx?_* libraries are. I think a big amount > of functionality can be shared among d3dx8.dll, d3dx9_*.dll, and propably > d3dx

Re: Unimplemented function KERNEL32.dll.FindFirstVolumeW

2007-11-19 Thread devzero
Hello Marcus, hello Hans, thanks very much - that was a quick fix ! :) I tried the latest snapshot and now was going able start windirstat. great! i can tell , that it basically works and i`m able to scan a disk. despite some minor quirks like crash of the app when i click trough the cushion

Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal

2007-11-19 Thread Stefan Dösinger
Hi, It's not really about this patch, but I am curious what the plans about sharing code between the various d3dx?_* libraries are. I think a big amount of functionality can be shared among d3dx8.dll, d3dx9_*.dll, and propably d3dxof.dll and d3drm.dll. I think this was discussed in the past, b

Re: credui: Show a balloon tip in the credential dialog if CREDUI_FLAGS_INCORRECT_PASSWORD was specified.

2007-11-19 Thread Juan Lang
Hi Rob, +IDS_INCORRECTPASSWORDTITLE "Logon unsucessful" The typo's your own work too, eh? --Juan

Re: svchost: Added base implementation of svchost (1/27)

2007-11-19 Thread Juan Lang
Hi Roy, > The docs for HeapFree state "If this pointer is NULL, the behavior is > undefined." So in practice the undefined behavior is benign? Yes. There are tests for that, and in fact there's a janitorial project about removing redundant NULL pointer checks before HeapFree. Michael Stefaniuc

Re: svchost: Added base implementation of svchost (1/27)

2007-11-19 Thread Roy Shea
Hello Juan, Thank you for the code review! A quick clarification about HeapFree: > Some judicious use of goto could reduce code for all your error paths. > Remember that HeapFree of a NULL pointer is allowed. The docs for HeapFree state "If this pointer is NULL, the behavior is undefined." So

Re: Removing Windows and Solaris from the Downloads page

2007-11-19 Thread Steven Edwards
On Nov 19, 2007 5:40 AM, Hans Leidekker <[EMAIL PROTECTED]> wrote: > I recall Alexandre saying that he wants the exposure to alternative headers > and import libraries because it brings up bugs in Wine. He also suggested > that the wininet/winsock issue could be solved by making wininet build > aga

Re: wininet: InternetAttemptConnect() Stub

2007-11-19 Thread Juan Lang
Hi Pavel, On Nov 19, 2007 6:30 AM, Pavel Troller <[EMAIL PROTECTED]> wrote: > I have a problem running an offline client for ordering photo prints from > digital cameras. > Even it is an "offline" client, it requires the computer to be online. > It seems that in wine, it feels to be offline,

Re: imagelist test exception?

2007-11-19 Thread Dan Kegel
On Nov 19, 2007 6:58 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > It's a DIB access exception, it's perfectly normal, it's used to trigger > a copy of the DIB bits from the X server. Oh, right, thanks! - Dan

Re: imagelist test exception?

2007-11-19 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > comctl32/tests/imagelist.c seems to throw an exception > during GetDIBits(), but for some reason, the test continues > and succeeds (except in Valgrind, which is why I noticed). > Do other folks also see a seh exception in the +seh log > on this test? > >

Re: imagelist test exception?

2007-11-19 Thread Dan Kegel
On Nov 19, 2007 6:36 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Dan Kegel wrote: > > comctl32/tests/imagelist.c seems to throw an exception > > during GetDIBits(), but for some reason, the test continues > > and succeeds (except in Valgrind, which is why I noticed). > > FWIW I have several except

Re: imagelist test exception?

2007-11-19 Thread Paul Vriens
Dan Kegel wrote: > comctl32/tests/imagelist.c seems to throw an exception > during GetDIBits(), but for some reason, the test continues > and succeeds (except in Valgrind, which is why I noticed). > Do other folks also see a seh exception in the +seh log > on this test? > > I narrowed the test cas

wininet: InternetAttemptConnect() Stub

2007-11-19 Thread Pavel Troller
Hi! I have a problem running an offline client for ordering photo prints from digital cameras. Even it is an "offline" client, it requires the computer to be online. It seems that in wine, it feels to be offline, thus refusing further operation with a dialog saying something like "Internet co

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-11-19 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > I had expected this comment for a different patch of mine. In > dlls/gdi32/enhmetafile.c we are just reading existing records, > so I'm not sure what you have in mind here? The records usually come from an external file, so they have to be validated

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-11-19 Thread Gerald Pfeifer
On Mon, 19 Nov 2007, Alexandre Julliard wrote: >> The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so >> comparing them for >= 0 is a noop which always evaluates to true. >> >> Gerald >> >> ChangeLog: >> Remove four unnecessary comparisions of DWORD variables for >= 0. > Validating the

Re: recent cedega contributions to wine

2007-11-19 Thread Tom Wickline
On Nov 19, 2007 8:36 AM, EA Durbin <[EMAIL PROTECTED]> wrote: > > > > > Date: Mon, 19 Nov 2007 08:14:11 -0500 > > From: [EMAIL PROTECTED] > > To: [EMAIL PROTECTED] > > Subject: Re: recent cedega contributions to wine > > CC: wine-devel@winehq.org > > > > > WhooHoo five patches made it into the Wine

imagelist test exception?

2007-11-19 Thread Dan Kegel
comctl32/tests/imagelist.c seems to throw an exception during GetDIBits(), but for some reason, the test continues and succeeds (except in Valgrind, which is why I noticed). Do other folks also see a seh exception in the +seh log on this test? I narrowed the test case down a bit (see patch). Can a

RE: recent cedega contributions to wine

2007-11-19 Thread EA Durbin
> Date: Mon, 19 Nov 2007 08:14:11 -0500> From: [EMAIL PROTECTED]> To: [EMAIL > PROTECTED]> Subject: Re: recent cedega contributions to wine> CC: > wine-devel@winehq.org> > WhooHoo five patches made it into the Wine tree in > three YEARS!> > Here is a list of patches over the past five years.. B

Re: recent cedega contributions to wine

2007-11-19 Thread Tom Wickline
WhooHoo five patches made it into the Wine tree in three YEARS! Here is a list of patches over the past five years.. But five patches in three years is grounds for a announcement? :D 2007-07-11 Mark Adams <[EMAIL PROTECTED]> * dlls/iphlpapi/iphlpapi_main.c, dlls/iphlpapi/ipstats.c:

Re: recent cedega contributions to wine

2007-11-19 Thread Tom Wickline
On Nov 19, 2007 2:37 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Montag, 19. November 2007 08:13:49 schrieb EA Durbin: > > http://www.cedega.com./devreports/ > > > > The latest Cedega dev report states it plans to include wine's msi > > implementation back into it's code base and they have

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-11-19 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > One of the really uncontested ones, I think. ;-) > > -- Forwarded message -- > From: Gerald Pfeifer <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Date: Thu, 1 Nov 2007 16:10:03 +0100 (CET) > Subject: Remove four useless checks in dlls

Re: Removing Windows and Solaris from the Downloads page

2007-11-19 Thread Hans Leidekker
On Monday 19 November 2007 03:55:20 Steven Edwards wrote: > The headers are not an issue because we use the Wine headers and > import libraries for the dlls. The only place there is a problem is > with wine/programs and the regression tests. They use the native > import libraries. I don't really u