Gerald Pfeifer wrote:
> How do you propose to address the following?
> string.c: In function 'msi_addstring':
> string.c:208: warning: comparison between signed and unsigned
For starters:
diff --git a/configure.ac b/configure.ac
index 3d62f45..c97aa8e 100644
--- a/configure.ac
+++ b/configure.a
Mikołaj Zalewski wrote:
> A problem with this patch is that the user may have an IXMLDOMNode *
> reference to the attribute node being removed. The xmlFreeProp will free
> the xmlnode so accessing the IXMLDOMNode could result in memory
> corruption. Under MSXML it's possible to access such nod
On Do, 2007-11-15 at 08:22 -0800, Roy Shea wrote:
> This adds svchost, proxying, and a stub version of the qmgr.dll
> process. The
> functional code in this patch is boilerplate required to run a DLL as
> a
> service via svchost.
> ---
> dlls/qmgr/Makefile.in |6 ++-
> dlls/qmgr/factory
On Do, 2007-11-15 at 17:37 +0100, Stefan Dösinger wrote:
> +const unsigned char small[] = "small";
> +int ret;
> +memset(dest, 'X', sizeof(dest));
> +ret = p_mbsnbcpy_s(dest, sizeof(dest), small, sizeof(small));
> +ok(ret == 0, "_mbsnbcpy_s: Copying a string into a big enough
>
"Stefan Dösinger" <[EMAIL PROTECTED]> wrote:
> +@ cdecl strcat_s(str str) MSVCRT_strcat_s
...
> +int CDECL MSVCRT_strcat_s( char* dst, MSVCRT_size_t elem, const char* src )
The spec file entry still has wrong number of parameters.
--
Dmitry.
On Do, 2007-11-15 at 08:24 -0800, Roy Shea wrote:
> dlls/qmgr/qmgr.c| 19 ++-
> dlls/qmgr/qmgr.spec |4 +-
> dlls/qmgr/tests/Makefile.in | 17 ++
> dlls/qmgr/tests/qmgr.c | 50
> +++
> 4 files change
On Do, 2007-11-15 at 17:35 +0100, Stefan Dösinger wrote:
> +memset(dest, 'X', sizeof(dest));
> +ret = pstrcpy_s(dest, sizeof(dest), small);
> +ok(ret == 0, "Copying a string into a big enough destination
> returned %d, expected 0\n", ret);
> +ok(dest[0] == 's' && dest[1] == 'm' &&
On Do, 2007-11-15 at 08:21 -0800, Roy Shea wrote:
> +++ b/include/bitsmsg.h
> @@ -0,0 +1,83 @@
> +/*
> + * Return values that may be generated by BITS as described at:
> + * http://msdn2.microsoft.com/en-us/library/aa362823.aspx
We want to remove all links to MSDN from wine (the URL changes
On Do, 2007-11-15 at 08:24 -0800, Roy Shea wrote:
> Implementation of BITS_IClassFactory_CreateInstance ond the support
> function
> BackgroundCopyManagerConstructor.
> ---
> dlls/Makefile.in |5 +
> + qmgrprxy \
> + qmgrprxy/libqmgrprxy.$(IMPLIBEXT) \
This changes ar
On Thu, 15 Nov 2007, James Hawkins wrote:
> I don't see how silencing warnings catches any regression.
With default options older versions of GCC currently issue two warnings
for all of Wine, so any warning regression immediately jumps out for
analysis to see whether it is a real regression. If
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> Good question. It's probably pretty involved; you may have to wait
> for an expert to try it and see what it breaks. Alexandre suggested
> it might not work recently (see
> http://bugs.winehq.org/show_bug.cgi?id=10273#c17 ), but
> perhaps he's being ove
* On Fri, 21 Sep 2007, Stefan [iso-8859-1] D�singer wrote:
> * Am Donnerstag, 20. September 2007 03:49:40 schrieb Carroll Vance:
> > I have tested this with a driver I made and it seemed to
> > work fine.
>
> I don't know much about ntoskrnl.exe, but if you have a test driver, you
> may want to i
On Thu, 15 Nov 2007, James Hawkins wrote:
>> ChangeLog:
>> Fix use of signed versus unsigned variables.
> This change is unnecessarily complicated.
How do you propose to address the following?
string.c: In function 'msi_addstring':
string.c:208: warning: comparison between signed and unsigned
On 11/15/07, Gerald Pfeifer <[EMAIL PROTECTED]> wrote:
> On Thu, 15 Nov 2007, James Hawkins wrote:
> >> ChangeLog:
> >> Fix use of signed versus unsigned variables.
> > This change is unnecessarily complicated.
>
> How do you propose to address the following?
>
> string.c: In function 'msi_addstr
On Thu, Nov 15, 2007 at 01:12:07PM +0100, Chris McKillroy wrote:
> Hello everybody,
>
> I recently run into the following problem:
>
> I tried to use a DLL injection into a process started by a controller
> Process using an external code hooking dll
> (http://www.madshi.net/madCodeHookDescription
> p.s. the mailing list archives seem to be not archiving new messages :-(
Jer restarted mailman and it seems to be fixed now. Presumably a side
effect of the db going nuts yesterday.
cheers,
Jeremy
On Thu, 15 Nov 2007, Alexandre Julliard wrote:
>> CpuUsage and CpuKernelUsage are of type ULONG, so it does not make
>> sense checking whether they are less than 0.
> The checks should most likely done in PerfDataGetProcessorUsage before
> converting to ULONG.
Fair enough. I wasn't sure we want t
Chris McKillroy asked:
> I tried to use a DLL injection ...
> (http://www.madshi.net/madCodeHookDescription.htm)
> Under Solaris10 (wine version 0.9.49) the child process regularly
> crashed... [because] kernel32.dll.so
> always gets loaded to a varying address by the runtime linker
Yep. Known pr
On Nov 15, 2007 2:33 AM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote:
> Since wineserver sequests are sent without an attempt to reduce the size of
> written data (and memset(0) is a part of SERVER_START_REQ macro) I'd assume
> that it's ok to do the same for server APC requests. Otherwise server ca
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> Oh, he'd undoubtedly prefer ignoring to memsetting.
> But he would like it even better if we can
> avoid sending unneeded bytes. Are the extra
> bytes at the end (they ought to be)? If so,
> whatever decides how many bytes to send could
> be just a bit s
On 11/14/07, Gerald Pfeifer <[EMAIL PROTECTED]> wrote:
> Last one for today, promised. ;-)
>
> Gerald
>
> -- Forwarded message --
> From: Gerald Pfeifer <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Date: Sat, 3 Nov 2007 20:02:18 +0100 (CET)
> Subject: dlls/msi/string.c -- fix us
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote:
> Changelog:
> Convert start.exe to Unicode.
Please carefully check buffer sizes passed to Win32 APIs.
--
Dmitry.
"Dan Kegel" <[EMAIL PROTECTED]> wrote:
> It seems that valgrind doesn't like Ubuntu 7.10; I had
> to drop back to my Feisty system to generate good
> valgrind stack dumps. And the tests didn't hang once!
>
> Results for the last two days are at
> http://kegel.com/wine/valgrind/20071112/
> http:/
"Stefan Dösinger" <[EMAIL PROTECTED]> wrote:
> +@ cdecl strcat_s(str str) MSVCRT_strcat_s
...
> +int CDECL MSVCRT_strcat_s( char* dst, size_t elem, const char* src )
> +{
> +unsigned int i, j;
...
> +static int (*pstrcat_s)(char *dst, unsigned int len, const char *src);
This one has the same
"Dan Kegel" <[EMAIL PROTECTED]> wrote:
> On Nov 14, 2007 10:16 PM, Dmitry Timoshkov
>> While looking at the valgrind reports above I noticed that a lot of
>> warnings are triggered in NTDLL_queue_process_apc by the fact that
>> not the whole apc_call_t union is initialized before passing it to
>>
"Stefan Dösinger" <[EMAIL PROTECTED]> wrote:
> +int CDECL _mbsnbcpy_s(unsigned char* dst, MSVCRT_size_t size, const unsigned
> char* src, MSVCRT_size_t n)
> +{
> +unsigned int pos = 0;
Same problem as with strcpy_s patch, and in addition MSVCRT_size_t is used.
Perhaps strcpy_s implementation
"Stefan Dösinger" <[EMAIL PROTECTED]> wrote:
> +int CDECL MSVCRT_strcpy_s( char* dst, size_t elem, const char* src )
> +{
> +unsigned int i;
...
> +for(i = 0; i < elem; i++)
Since 'i' is used to enumerate [0 < elem] and elem has type size_t, 'i' should
have type size_t as well.
> +static
"Uwe Bonnes" <[EMAIL PROTECTED]> wrote:
>Dmitry> Hello, this patch should fix the problem reported in the bug
>Dmitry> 10343. My test which calls SetTimer in an infinite loop shows
>Dmitry> that XP starts to allocate timer ids at 0x7fff and goes
>Dmitry> backwards to 0x101, then re
Gerald Pfeifer <[EMAIL PROTECTED]> writes:
> Another simplifcation I'd like to ping if you don't mind.
>
> -- Forwarded message --
> From: Gerald Pfeifer <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Date: Thu, 1 Nov 2007 16:14:28 +0100 (CET)
> Subject: taskmgr/perfpage.c simpli
In break_thread(), generate_debug_event() seems to
send the entire ExceptionInformation array regardless of how
many entries are used. The smart thing to do
would be to send only the used elements, but I
couldn't figure out how to do that. So here's
a quick fix that just zeroes that array before
On Nov 14, 2007 10:16 PM, Dmitry Timoshkov
> While looking at the valgrind reports above I noticed that a lot of
> warnings are triggered in NTDLL_queue_process_apc by the fact that
> not the whole apc_call_t union is initialized before passing it to
> the server. In contrast SERVER_START_REQ alway
> "Dmitry" == Dmitry Timoshkov <[EMAIL PROTECTED]> writes:
Dmitry> Hello, this patch should fix the problem reported in the bug
Dmitry> 10343. My test which calls SetTimer in an infinite loop shows
Dmitry> that XP starts to allocate timer ids at 0x7fff and goes
Dmitry> backward
A problem with this patch is that the user may have an IXMLDOMNode *
reference to the attribute node being removed. The xmlFreeProp will free
the xmlnode so accessing the IXMLDOMNode could result in memory
corruption. Under MSXML it's possible to access such node and even
reconnect it e.g. to
Hello everybody,
I recently run into the following problem:
I tried to use a DLL injection into a process started by a controller
Process using an external code hooking dll
(http://www.madshi.net/madCodeHookDescription.htm)
to achieve some sort of datalink.
In a windows environment the solution w
On Wednesday 14 November 2007 23:22:00 Jeremy Newman wrote:
> I restarted it. I still have no idea how it gets into this state. The
> logs have not been much help. I think we have exposed a bug in mysql
> itself, as we did not have these issues until we upgraded to ver 5.
>
> On Wed, 2007-11-14 at
On Sunday 11 November 2007 14:56:21 Fred . wrote:
> Applications that run under Wine looks so legacy like Windows 95.
>
> This patch makes the software applications look a bit more modern and
> prettier by changing the colors from the Windows 95-look to the
> "Windows Classic"-look, the one in Wind
On Nov 14, 2007 10:01 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> In break_thread(), generate_debug_event() seems to
> send the entire ExceptionInformation array regardless of how
> many entries are used. The smart thing to do
> would be to send only the used elements, but I
> couldn't figure out
37 matches
Mail list logo
