Re: msxml - Fix Memory Leak

2007-11-02 Thread Vitaliy Margolen
Not really. Now it's an attachment of "application/octet-stream" type. Not plain/text. Try renaming the file to *.patch.txt. Vitaliy. Alistair Leslie-Hughes wrote: > Hi Vitaliy, > >Thanks for the information, I though I had fixed my News client. > > Does this work better? Ill forward t

Re: [PATCH 04/14] inetcomm: Add self-registration code.

2007-11-02 Thread Robert Shearman
Detlef Riekenberg wrote: > On Fr, 2007-11-02 at 13:46 +, Huw Davies wrote: > >> + NULL, >> > > The char 0x0c looks wrong here. > (was already in the Patch from Rob) > > > The Patchset was send twice (xx/14 and xx/18) with the same times. > > Example from Huw (Rob did the same befo

Re: today's valgrind results online

2007-11-02 Thread Stefan Dösinger
Am Freitag, 2. November 2007 22:10:28 schrieb Dan Kegel: > On 11/2/07, Dan Kegel <[EMAIL PROTECTED]> wrote: > > Online at http://kegel.com/wine/valgrind/20071002/ > > I should mention: I'm not planning fixing any of these > myself for now (I'd love to, but I can't afford to type that > much). > I'm

re: USER32: win16 applications should not see long filenames returned from dialog control

2007-11-02 Thread Dan Kegel
Alex wrote: > Legacy Win16 applications display file/directory selection listboxes and > expect to receive a short name from the control >The attached patch attempts to fix this >by converting the about-to-be-returned name to a short name if the expected >windows version is not at least Win95

Re: today's valgrind results online

2007-11-02 Thread Kai Blin
On Friday 02 November 2007 19:59:10 Dan Kegel wrote: > dplayx I'm not sure if this is worth the effort right now. It seems to be leaking some memory, but everybody _using_ dplay with wine right now uses native, anyway. > netapi32 That's my fault, working on it. Cheers, Kai -- Kai Blin World

Re: today's valgrind results online

2007-11-02 Thread Dan Kegel
On 11/2/07, Dan Kegel <[EMAIL PROTECTED]> wrote: > Online at http://kegel.com/wine/valgrind/20071002/ I should mention: I'm not planning fixing any of these myself for now (I'd love to, but I can't afford to type that much). I'm hoping other Wine developers will pitch in to clean the real valgrind

Re: [PATCH 04/14] inetcomm: Add self-registration code.

2007-11-02 Thread Detlef Riekenberg
On Fr, 2007-11-02 at 13:46 +, Huw Davies wrote: > + NULL, The char 0x0c looks wrong here. (was already in the Patch from Rob) The Patchset was send twice (xx/14 and xx/18) with the same times. Example from Huw (Rob did the same before): Subject: [PATCH 17/1

Re: mshtml: Set IE version when installing wine gecko

2007-11-02 Thread Detlef Riekenberg
On Fr, 2007-11-02 at 16:24 +0100, Jacek Caban wrote: > 11,,dxdiagn.dll,1 > 11,,hhctrl.ocx,1 > 11,,hlink.dll,1 > +11,,iexplore.exe,1 This is the wrong directory. In [FakeDllsSection], we use the correct location: 16422,Internet Explorer,iexplore.exe -- By by ... Detlef

today's valgrind results online

2007-11-02 Thread Dan Kegel
Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.) The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status cryp

Re: mshtml: Set IE version when installing wine gecko

2007-11-02 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> >> The idea would be that there should be an easy way to uninstall it, so >> if Gecko is installed the app will try to use that, and if it doesn't >> work we can tell users to uninstall Gecko and let the app install IE >> inste

Re: Generic text printer driver

2007-11-02 Thread Detlef Riekenberg
On Mi, 2007-10-31 at 20:02 +0100, Juan Luis Ramos wrote: > is there anybody working in the generic text printer driver o raw > printer driver? There is some work going in this direction, but that is not in the main tree yet. > I've a problem with a compatible Epson POS printer so, Does the Pri

Re: mshtml: Set IE version when installing wine gecko

2007-11-02 Thread Jacek Caban
Alexandre Julliard wrote: > > The idea would be that there should be an easy way to uninstall it, so > if Gecko is installed the app will try to use that, and if it doesn't > work we can tell users to uninstall Gecko and let the app install IE > instead. Ultimately of course the goal is that they

Re: mshtml: Set IE version when installing wine gecko

2007-11-02 Thread Jacek Caban
Chris Robinson wrote: > Even if you fix all the apps that have a problem with Gecko, native IE still > has rendering differences. And short of reimplementing it ourselves, some > people will have a need for native IE (eg. web developers wanting to see what > their site looks like in IE). There m

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.

2007-11-02 Thread Robert Shearman
Huw Davies wrote: > On Fri, Nov 02, 2007 at 07:15:23AM -0700, Juan Lang wrote: > >> Hi Rob, >> >> +const char szHostName[] = "roblaptop"; /* FIXME */ >> >> Did you mean to leave that in? >> > > Nice. Ok, I've just resent the patchset without the smtp stuff. > Rob can tidy that up and s

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.

2007-11-02 Thread Huw Davies
On Fri, Nov 02, 2007 at 07:15:23AM -0700, Juan Lang wrote: > Hi Rob, > > +const char szHostName[] = "roblaptop"; /* FIXME */ > > Did you mean to leave that in? Nice. Ok, I've just resent the patchset without the smtp stuff. Rob can tidy that up and submit it himself. Thanks, Huw. -- Huw D

Re: Fix type of loop variable in alloc_device().

2007-11-02 Thread Gerald Pfeifer
On Fri, 2 Nov 2007, Vitaliy Margolen wrote: >> We iterate between 0 and and the value of an usigned variable, so we >> should adjust the loop variable accordingly (not the list to silence >> GCC). > >> -int i; >> +unsigned i; > If there is nothing wrong about it, then why do you change it?

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.

2007-11-02 Thread Juan Lang
Hi Rob, +const char szHostName[] = "roblaptop"; /* FIXME */ Did you mean to leave that in? --Juan

Re: [Bug 10266] Numpad keyboard handling is strange, Del keyproducestwo events

2007-11-02 Thread Peter Åstrand
On Fri, 2 Nov 2007, Dmitry Timoshkov wrote: > > It's a good idea to try to have > > ToUnicodeEx work mainly as it does on Windows, but we are miles away from > > reaching this goal. > > What goal are you talking about? The goal of a implementation of ToUnicodeEx that is 100% compatible with Wi

Re: [PATCH 04/18] inetcomm: Add self-registration code.

2007-11-02 Thread Huw Davies
On Fri, Nov 02, 2007 at 01:51:10PM +, Robert Shearman wrote: > Paul Vriens wrote: > > Robert Shearman wrote: > >> --- > > > > +static LONG recursive_delete_key(HKEY key); > > +static LONG recursive_delete_keyA(HKEY base, char const *name); > > +static LONG recursive_delete_keyW(HKEY base, WCHAR

Re: [PATCH 04/18] inetcomm: Add self-registration code.

2007-11-02 Thread Robert Shearman
Paul Vriens wrote: > Robert Shearman wrote: >> --- > > +static LONG recursive_delete_key(HKEY key); > +static LONG recursive_delete_keyA(HKEY base, char const *name); > +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); > > We just got rid of all the self build recursive delete ones.

Re: [PATCH 1/7] advapi32: Implement CredWriteW.

2007-11-02 Thread Robert Shearman
Detlef Riekenberg wrote: > On Di, 2007-10-30 at 12:36 +, Robert Shearman wrote: > >> +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) >> +{ >> +return RegCreateKeyExW(HKEY_CURRENT_USER, >> wszCredentialManagerKey, 0, >> + NULL, REG_OPTION_NON_VOL

Re: msxml - Fix Memory Leak

2007-11-02 Thread Vitaliy Margolen
Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > Fixed memory leak > > > Regards > Alistair Leslie-Hughes > > > begin 666 xmlelem.diff Please attach patches as a plain text. This patch is not an attachment and is unreadable. Vitaliy.

Re: shell32: Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate returned string

2007-11-02 Thread Vitaliy Margolen
Thomas Weidenmueller wrote: > Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate the returned > string. pOleStr in the STRRET structure has to be allocated using > CoTaskMemAlloc(). SHStrDupW uses CoTaskMemAlloc() whereas StrDupW uses > LocalAlloc(). > > - Thomas > --

Re: [PATCH 02/18] inetcomm: Add a framework for connecting to a server and sending/receiving data asynchronously with callbacks being called in the context of the original thread, using window message

2007-11-02 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > +#include "winsock2.h" > +#include "winuser.h" > + > +#undef GetProp > +#undef SendMessage > +#undef SetProp > + > +#include "objbase.h" > +#include "imnxport.h" You forgot to submit the new imnxport.idl. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Fix type of loop variable in alloc_device().

2007-11-02 Thread Vitaliy Margolen
Gerald Pfeifer wrote: > We iterate between 0 and and the value of an usigned variable, so we > should adjust the loop variable accordingly (not the list to silence > GCC). > -int i; > +unsigned i; If there is nothing wrong about it, then why do you change it? If even gcc does not complai

Re: [PATCH 04/18] inetcomm: Add self-registration code.

2007-11-02 Thread Paul Vriens
Robert Shearman wrote: > --- +static LONG recursive_delete_key(HKEY key); +static LONG recursive_delete_keyA(HKEY base, char const *name); +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); We just got rid of all the self build recursive delete ones. Can you use RegDeleteTree[AW]

Re: [Bug 10266] Numpad keyboard handling is strange, Del keyproducestwo events

2007-11-02 Thread Dmitry Timoshkov
"Peter Åstrand" <[EMAIL PROTECTED]> wrote: > > Current behaviour emulates what ToUnicodeEx does under Windows. And some > > apps depend on it. > > We shouldn't forget that the Wine keyboard implementation is a total mess. > The code is full of special cases, makes wrong assumptions about the > pla

Re: [PATCH 1/7] advapi32: Implement CredWriteW.

2007-11-02 Thread Detlef Riekenberg
On Di, 2007-10-30 at 12:36 +, Robert Shearman wrote: > +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) > +{ > +return RegCreateKeyExW(HKEY_CURRENT_USER, > wszCredentialManagerKey, 0, > + NULL, REG_OPTION_NON_VOLATILE, > +

Re: alsa->pulseaudio->alsa directsound hang

2007-11-02 Thread Jan Zerebecki
I didn't test pulseaudio nor looked at your .asoundrc , but there are some non-obvious pitfalls when configuring such stuff in .asoundrc . But the fault may also be that the pulseaudio alsa plugin doesn't fully behave like normal alsa does. Wine is pretty sensitive to such things (even to e.g. non-

Re: [Bug 10266] Numpad keyboard handling is strange, Del keyproduces two events

2007-11-02 Thread Peter Åstrand
On Thu, 1 Nov 2007, Dmitry Timoshkov wrote: > > 1) "Not consistent" > > > > It might be interesting to compare with CapsLock. Shift can cancel > > CapsLock, but also substitute it. This is true on both Windows and Linux. > > Additionally, on Linux, NumLock works the same, ie Shift works in both >

Re: setupapi: Add stub for SetupInstallServicesFromInfSectionW

2007-11-02 Thread Alexandre Julliard
Frank Richter <[EMAIL PROTECTED]> writes: > Unless you ignore the A/W suffix. One could argue that this is more > intuitive as you could locate an entry in the list by searching for the > undecorated name and then look for the one with the appropriate suffix, > which is at most one line away. If y

Re: Valgrind and structs with holes

2007-11-02 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > For instance, the warning > ==3415== Syscall param writev(vector[1]) points to uninitialised byte(s) > ==3415==at 0x40007F2: (within /lib/ld-2.6.1.so) > ==3415==by 0x4412E24: wine_server_call (server.c:244) > ==3415==by 0x43EBA73: server_ioctl_

Re: [Bug 10266] Numpad keyboard handling is strange, Del keyproduces two events

2007-11-02 Thread Peter Åstrand
On Thu, 1 Nov 2007, Dmitry Timoshkov wrote: > > > Besides, I just tested with Wine's notepad and don't see the problem you > > > are reporting. > > > > Which keyboard layout are you using? On my system, Wine selects the > > Swedish keyboard layout. > > I'm using us keyboard layout. That explains