Re: ddraw:d3d tests failing consistently

2007-10-26 Thread H. Verbeet
On 26/10/2007, Francois Gouget <[EMAIL PROTECTED]> wrote: > Parallels is a bit of a special case because it does not just replace > the graphics driver, but the DirectX dlls altogether. However VMware 5.5 > does not do that. > In practice the difference isn't that significant. While replacing the D

wine needs a relatively new version of fontforge?

2007-10-26 Thread Lei Zhang
Hi, Dan K. and I both ran into bug 10103 [1] because the fontforge on our systems is too old. I noticed some of the font tests failed on my system for the same reason. So what is the minimum version of fontforge that will generate correct fonts? Should we add a check for it? - Lei [1] http://bu

Re: makefiles: add a notest target

2007-10-26 Thread Lei Zhang
On 10/26/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Maarten Lankhorst wrote: > > Lei Zhang schreef: > >> This patch adds a notest target to build everything but the dll unit > >> tests and winetest. This cuts down build time by 25%. > >> > > Julliard will never accept such patch. In the hac

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Francois Gouget
On Fri, 26 Oct 2007, Stefan Dösinger wrote: > Am Freitag, 26. Oktober 2007 15:42:18 schrieb Jakob Eriksson: > > Agree 100%. Windows on vmware is still Windows. > No, I do not agree with that. Using that logic, Windows on Parallels would > still be Windows. However, Parallels uses WineD3D as their

Re: makefiles: add a notest target

2007-10-26 Thread Michael Stefaniuc
Maarten Lankhorst wrote: > Lei Zhang schreef: >> This patch adds a notest target to build everything but the dll unit >> tests and winetest. This cuts down build time by 25%. >> > Julliard will never accept such patch. In the hacks.git tree there is a > patch I did that has a configuration time

Re: makefiles: add a notest target

2007-10-26 Thread Maarten Lankhorst
Hi Lei, Lei Zhang schreef: > Hi, > > This patch adds a notest target to build everything but the dll unit > tests and winetest. This cuts down build time by 25%. > Julliard will never accept such patch. In the hacks.git tree there is a patch I did that has a configuration time option for it. It

Re: What if heap errors caused 'make test' to fail?

2007-10-26 Thread Dan Kegel
On 10/26/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > http://bugs.winehq.org/show_bug.cgi?id=10179 > > That's not heap corruption, it's the expected behavior of GlobalHandle > when called with a pointer to a moveable block. Good - then the bug is just that Wine is generating a spurious sc

Re: What if heap errors caused 'make test' to fail?

2007-10-26 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Have a look at > http://bugs.winehq.org/show_bug.cgi?id=10179 > and see if you still think so! That's not heap corruption, it's the expected behavior of GlobalHandle when called with a pointer to a moveable block. -- Alexandre Julliard [EMAIL PROTECTED]

Re: What if heap errors caused 'make test' to fail?

2007-10-26 Thread Dan Kegel
On 10/26/07, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > Did you run them with a -j flag? Nope. Yeah, things happened kind of out of order, no idea why. > It would be less confusing to see it > without it. In either case I will take a look at the winmm/dsound tests > either tomorrow or when I

Re: Misplaced Property Sheet buttons

2007-10-26 Thread Frank Richter
On 26.10.2007 16:52, Peter Åstrand wrote: > This solves the position problem, but instead the Help button disappears. > See screenshot > http://www.cendio.com/~astrand/wine/62-tab-size/patched.png. Any ideas? Hint: check again what WM_WINDOWPOSCHANGED's 'lParam' contains ... -f.r.

Re: user32: Fix a test that now passes in Windows

2007-10-26 Thread Dan Hipschman
Some of what you're saying has validity, but all your criticisms are on very minor points, and I was surprised to see them. I think they're offset by the fact that James is a long-time developer who has a lot of work to do. I'm sure the Wine community appreciates every person who wants to help t

Re: What if heap errors caused 'make test' to fail?

2007-10-26 Thread Maarten Lankhorst
Hi Dan, Dan Kegel schreef: > 25! Here's the output of WINEDEBUG=warn+heap make -k test > piped through grep make.*Error: > > make[2]: *** [alloc.ok] Error 134 > make[2]: *** [pipe.ok] Error 1 > make[2]: *** [systray.ok] Error 6 > make[2]: *** [thread.ok] Error 9 > make[2]: *** [security.ok] Error

Re: Lots of 'make test' failures on Windows

2007-10-26 Thread Jakob Eriksson
Robert Shearman wrote: > > We do. I've got a machine that regularly runs the test on Windows 2003 > on real hardware: > http://test.winehq.org/data/200710241000/2003_rshearman/report That's excellent! > > However, the tests are run by a service rather than manually by me to > reduce the effort nee

Re: my first patch

2007-10-26 Thread Maarten Lankhorst
Hi Vincent, viny schreef: > Can someone tell me if this patch is correct for submitting to > wine-patches. > I have generated this patch with "git format-patch -o out origin" Anything created by git-diff or git-format patch will automatically be inthe proper format. Cheers, Maarten.

Misplaced Property Sheet buttons

2007-10-26 Thread Peter Åstrand
I'm debugging a problem where the standard buttons on a property sheet are misplaced. The application is Magna Cura. The screenshot http://www.cendio.com/~astrand/wine/62-tab-size/unpatched.png demonstrates the problem: The buttons are only partially visible. It turns out that the parent windo

Re: Lots of 'make test' failures on Windows

2007-10-26 Thread Robert Shearman
Jakob Eriksson wrote: > Alexandre Julliard wrote: > >> If we require tests to pass on all Windows versions before getting >> committed it will drastically reduce the number of tests accepted, >> with little benefit. In most cases tests fail on some Windows boxes >> because they are too strict in

Re: Improving http://tests.winehq.org/data/

2007-10-26 Thread Jakob Eriksson
Francois Gouget wrote: > On Fri, 26 Oct 2007, Robert Shearman wrote: > [...] > >> Win9x's rpcrt4 is quite buggy and I don't think it's worth the trouble >> of diagnosing what is happening and trying to work around it, both with >> the crash and the test failures. >> > > Then rpcrt4_test s

Re: my first patch

2007-10-26 Thread Vijay Kiran Kamuju
This looks good, I am not an expert in that area. Send this patch to [EMAIL PROTECTED] Cheers, VJ On 10/26/07, viny <[EMAIL PROTECTED]> wrote: > Can someone tell me if this patch is correct for submitting to wine-patches. > I have generated this patch with "git format-patch -o out origin" > > (re

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Stefan Dösinger
Am Freitag, 26. Oktober 2007 15:42:18 schrieb Jakob Eriksson: > Agree 100%. Windows on vmware is still Windows. No, I do not agree with that. Using that logic, Windows on Parallels would still be Windows. However, Parallels uses WineD3D as their Direct3D driver. Is Windows on Parallels still Wind

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Jakob Eriksson
Francois Gouget wrote: > acceleration that they added in 6.0. So the relevant tests should be > easy to skip, either by detecting lack of any 3D support or in the worst > case by detecting the name of the graphics /sound card. > Agree 100%. Windows on vmware is still Windows. // Jakob

Re: Anything wrong with my patch from 16.10. aboutw32x86andwin40creation?

2007-10-26 Thread Markus Gömmel
> You could do it in GetPrinterDriverDirectory. ??? And if a Windows application simply queries systemdir and adds spool\drivers\w32x86 to copy printer driver files into it (ok, bad design, but I've seen a lot of that stuff in the past), it will still fail... And a native Windows system also co

my first patch

2007-10-26 Thread viny
Can someone tell me if this patch is correct for submitting to wine-patches. I have generated this patch with "git format-patch -o out origin" (related bug : http://bugs.winehq.org/show_bug.cgi?id=9805) >From c5eab13b67e6f24b3518dd77840f260dc101520e Mon Sep 17 00:00:00 2001 From: Vincent Hardy <[

Re: Lots of 'make test' failures on Windows

2007-10-26 Thread Jakob Eriksson
Alexandre Julliard wrote: > If we require tests to pass on all Windows versions before getting > committed it will drastically reduce the number of tests accepted, > with little benefit. In most cases tests fail on some Windows boxes > because they are too strict in the behavior they expect, and th

Re: [1/5] (resend) WineD3D: Enable the draw buffers extension only when used

2007-10-26 Thread Stefan Dösinger
Please ignore this patch. I just saw that macos advertises 4 draw buffers, but only one was used inside wined3d because we weren't using fbo offscreen rendering. Now macos supports the extension, 4 draw buffers but still complains... oh well > Am Freitag, 26. Oktober 2007 12:45:57 schrieb Stefa

Re: bug 9986

2007-10-26 Thread Damjan Jovanovic
On 10/26/07, Reece Dunn <[EMAIL PROTECTED]> wrote: > On 25/10/2007, Juan Lang <[EMAIL PROTECTED]> wrote: > > > Tests would also be useful here as well, so that there is not a > > > regression. > > > > That's good general advice, but hard to implement without a serial > > device to test against, wh

Re: Improving http://tests.winehq.org/data/

2007-10-26 Thread Francois Gouget
On Fri, 26 Oct 2007, Robert Shearman wrote: [...] > Win9x's rpcrt4 is quite buggy and I don't think it's worth the trouble > of diagnosing what is happening and trying to work around it, both with > the crash and the test failures. Then rpcrt4_test should detect this and skip the server test. Ot

Re: bug 9986

2007-10-26 Thread Francois Gouget
On Thu, 25 Oct 2007, Juan Lang wrote: > > Tests would also be useful here as well, so that there is not a regression. > > That's good general advice, but hard to implement without a serial > device to test against, which our test systems won't have. The tests could be set to only run in interact

Re: d3dx8 math implementation + tests: use more "," instead of ";".

2007-10-26 Thread Alexandre Julliard
Lionel Debroux <[EMAIL PROTECTED]> writes: > I noticed several "," in the implementation and tests of D3DX8 math > functions. I added more, since this may help the auto-vectorizer of > some compilers noticing that x86 SIMD could be used. I don't see any reason why that would make the slightest di

Re: Improving http://tests.winehq.org/data/

2007-10-26 Thread Robert Shearman
Huw Davies wrote: > On Fri, Oct 26, 2007 at 12:51:17AM +0200, Francois Gouget wrote: > >> So I had a closer look at the tests that failed to run: >> ... >> * rpcrt4:server crashes and then times out with the message box that >> says: >> This program has performed an illegal operation and

Re: Anything wrong with my patch from 16.10. about w32x86andwin40creation?

2007-10-26 Thread Alexandre Julliard
Markus Gömmel <[EMAIL PROTECTED]> writes: > Hm, so you suggest putting it into WINSPOOL_LoadSystemPrinters()? Cause this > looks like the only function who is definitely called during wine startup, > isn't it? You could do it in GetPrinterDriverDirectory. > So we should include creation of "sp

Re: Improving http://tests.winehq.org/data/

2007-10-26 Thread Francois Gouget
On Thu, 25 Oct 2007, James Hawkins wrote: [...] > I don't think that's fair to long tests, say msi:install. I don't think we have any long-running tests right now (except the 'ftp' tests but that's probably a bug). All the tests that time out do so because they do stuff that pops up a MessageBox

Re: Improving http://tests.winehq.org/data/

2007-10-26 Thread Huw Davies
On Fri, Oct 26, 2007 at 12:51:17AM +0200, Francois Gouget wrote: > So I had a closer look at the tests that failed to run: >... > * rpcrt4:server crashes and then times out with the message box that > says: > This program has performed an illegal operation and will be > shut down. >

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Francois Gouget
On Fri, 26 Oct 2007, Reece Dunn wrote: [...] > This would mean that the tests that are consistently (and predictably) > failing under vmware will not show up on the test failures, so we can > investigate actual failures. Well, as far as I know, except for Direct3D and maybe sound issues, VMware s

Re: Word crash

2007-10-26 Thread Kai Blin
On Friday 26 October 2007 09:28:09 Marco Stornelli wrote: > Hi all, > > I'm using wine 0.9.44-15 for openSuse 10.3 and office 2000. Excel > works fine, powerpnt doesn't start and wine doesn't print nothing in > console about it, and about word, wine prints this: Please don't send emails to wine-bu

Re: user32: Fix a test that now passes in Windows

2007-10-26 Thread Reece Dunn
On 26/10/2007, James Hawkins <[EMAIL PROTECTED]> wrote: > On 10/25/07, Reece Dunn <[EMAIL PROTECTED]> wrote: > > On 25/10/2007, James Hawkins wrote: > > > Hi, > > > > > > Changelog: > > > * Fix a test that now passes in Windows. > > > > Looking at the code, it looks as if they are now passing in Wi

Re: ddraw:d3d tests failing consistently

2007-10-26 Thread Reece Dunn
On 26/10/2007, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Freitag, 26. Oktober 2007 01:22:22 schrieb Reece Dunn: > > Also, I suspect that it would be worth adding vmware in the test > > cases. That is, something like: > > > >ok( ret == 129 /* Windows */ || ret == 133 /* VMware */, ... ); >