Re: msi: make the WriteEnvironmentStrings handling of [~] a bit better

2007-10-17 Thread Mikolaj Zalewski
EA Durbin wrote: > The compiler complains at this line about lstrlenW being passed an > incompatible pointer type > > +else if (lstrlenW(value) >= prefix_len) > > > > should it be lstrlenW(*value) ? > Thanks for noticing it. Mikołaj Zalewski

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Misha Koshelev
On Wed, 2007-10-17 at 17:10 -0700, Nigel Liang wrote: > On 10/17/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > On Wed, 2007-10-17 at 17:10 -0500, Misha Koshelev wrote: > > > > n 10/13/07, Nigel Liang wrote: > > > > > Hi, > > > > > > > > > > Http requests open sockets and forget to close them.

RE: msi: make the WriteEnvironmentStrings handling of [~] a bit better

2007-10-17 Thread EA Durbin
The compiler complains at this line about lstrlenW being passed an incompatible pointer type +else if (lstrlenW(value) >= prefix_len) should it be lstrlenW(*value) ? _ Climb to the top of the charts!  Play Star Shuffle:  the

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Nigel Liang
On 10/17/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > On Wed, 2007-10-17 at 17:10 -0500, Misha Koshelev wrote: > > > n 10/13/07, Nigel Liang wrote: > > > > Hi, > > > > > > > > Http requests open sockets and forget to close them. Left running over > > > > a long > > > > period, the socket file

Priority/severity of test suite hangs

2007-10-17 Thread Dan Kegel
I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. -- Wine for Windows ISVs: http://kegel.com/wine/isv

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Misha Koshelev
On Wed, 2007-10-17 at 17:10 -0500, Misha Koshelev wrote: > > n 10/13/07, Nigel Liang wrote: > > > Hi, > > > > > > Http requests open sockets and forget to close them. Left running over a > > > long > > > period, the socket file descriptor starts getting large. Once it exceeds > > > FD_SETSIZE, th

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Misha Koshelev
> n 10/13/07, Nigel Liang wrote: > > Hi, > > > > Http requests open sockets and forget to close them. Left running over a > > long > > period, the socket file descriptor starts getting large. Once it exceeds > > FD_SETSIZE, the behavior becomes unpredictable and results in funcky > > crashes. >

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Nigel Liang
On 10/13/07, Nigel Liang <[EMAIL PROTECTED]> wrote: > Hi, > > Http requests open sockets and forget to close them. Left running over a long > period, the socket file descriptor starts getting large. Once it exceeds > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > >

wnaspi and DVD Burner

2007-10-17 Thread Stefan Leichter
Hello, i tried to make some progress with Ahead Nero, but now i'm stuck. I found the NeroSDK-1.08.zip and inside the comand line tool NeroAPITest.exe. The source code of NeroAPITest.exe is in the archive too. This makes finding the problems easier. Executing the comand 'wine NeroAPITest.exe --

Re: Wine Stats Malfunctioning

2007-10-17 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: > Web page: > > http://www.winehq.org/site/winapi_stats > > on wine statistics does not work. Yes, winapi_extract failed to parse a file in the last release. I've uploaded a fixed version. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt

2007-10-17 Thread Nigel Liang
On 10/17/07, Frank Richter <[EMAIL PROTECTED]> wrote: > On 17.10.2007 06:49, Nigel Liang wrote: > > Hi, > > > > strchrW assumes a NULL-terminated string. May crash if terminating > > character is > > not found. memchrW is better because you can specify the maximum number of > > bytes to search. >

Re: Possible WIne regression with Warcraft

2007-10-17 Thread Michael Lothian
> Please fix your hosts file while your at it. It might not be this > specific issue, but it's going to cause other problems for certain. What would you recommend?

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt

2007-10-17 Thread Frank Richter
On 17.10.2007 06:49, Nigel Liang wrote: > Hi, > > strchrW assumes a NULL-terminated string. May crash if terminating character > is > not found. memchrW is better because you can specify the maximum number of > bytes to search. On the flipside, memchrW() doesn't stop at a NUL... -f.r.

Wine Stats Malfunctioning

2007-10-17 Thread luis . busquets
Web page: http://www.winehq.org/site/winapi_stats on wine statistics does not work.

Re: widl [1/2]: Improve file cleanup when errors occur

2007-10-17 Thread Alexandre Julliard
Dan Hipschman <[EMAIL PROTECTED]> writes: > @@ -446,10 +441,18 @@ static void rm_tempfile(void) >abort_import(); >if(temp_name) > unlink(temp_name); > - if (header_name) > -unlink(header_name); > - if (client_name) > -unlink(client_name); > - if (server_name) > -unlink(

Re: "make test" failure in gdi32/bitmap.c

2007-10-17 Thread Dmitry Timoshkov
"Francois Gouget" <[EMAIL PROTECTED]> wrote: >> err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=24 >> err:bitmap:DIB_GetBitmapInfo (39): unknown/wrong size for header >> err:bitmap:DIB_GetBitmapInfo (11): unknown/wrong size for header >> err:bitmap:DIB_GetBitmapInfo (13): u

Re: "make test" failure in gdi32/bitmap.c

2007-10-17 Thread Francois Gouget
On Tue, 16 Oct 2007, Dan Kegel wrote: > "make test" fails for me with: > > bitmap.c:1113: Test failed: GetDIBits with 4 bpp DIB selected in DC: > Invalid DIB bits > bitmap.c:1113: Test failed: GetDIBits with 8 bpp DIB selected in DC: > Invalid DIB bits I'm working on the above two. From my testi