Re: Have `make distclean` also remove .i and .s files

2007-10-15 Thread Gerald Pfeifer
On Mon, 15 Oct 2007, Alexandre Julliard wrote: >> After using GCC's -save-temps option to debug something, I noticed >> that `make distclean` fails to actually remove .i and .s files. > It would be, but I don't think we want make clean to remove all > possible output files from all possible tools.

Re: Possible WIne regression with Warcraft

2007-10-15 Thread Michael Lothian
On 15/10/2007, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > > Let me take a wild guess. /etc/hosts resolves your hostname to a loopback > > address, like 127.0.1.1 or somesuch. > > > > If that's the case, please change /etc/hosts to make your hostname resolve > to > > your network card's IP address

Re: ntdll: Fix NtAccessCheck for NULL, but present SACLs and DACLs.

2007-10-15 Thread Robert Shearman
Juan Lang wrote: > Hi Rob, > > -sd.sacl_len = (present ? sacl->AclSize : 0); > +sd.sacl_len = ((present && dacl) ? sacl->AclSize : 0); > > Shouldn't that be ((present && sacl) ? sacl->AclSize : 0); ? Good spot. It wouldn't be the first time I've mixed up dacls and sacls... Thanks,

Re: ntdll: Fix NtAccessCheck for NULL, but present SACLs and DACLs.

2007-10-15 Thread Juan Lang
Hi Rob, -sd.sacl_len = (present ? sacl->AclSize : 0); +sd.sacl_len = ((present && dacl) ? sacl->AclSize : 0); Shouldn't that be ((present && sacl) ? sacl->AclSize : 0); ? --Juan

Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Detlef Riekenberg
On Mo, 2007-10-15 at 12:16 -0400, Dimi Paun wrote: > (And the rather > > non intuitive requirement to 'know' the unpublished > > url http://test.winehq.org/data/ is harsh). > > The plan was to have a home page at: > http://test.winehq.org > that would contain the explanation, p

re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Dan Kegel
>> There is a headless operation mode already, it detects >> if you run it as a service, and skips appropriate tests. > > Perhaps on Windows; I'm focused on Linux. How about wine net start winetest? - Dan

Re: Have `make distclean` also remove .i and .s files

2007-10-15 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > The GNU Coding Conventions (make distclean is a GNU invention as far > as I know) says the following: > > distclean: Delete all files in the current directory (or created by > this makefile) that are created by configuring or building the program. >

Re: First batch of Swedish translation patches

2007-10-15 Thread James Hawkins
On 10/15/07, Daniel Nylander <[EMAIL PROTECTED]> wrote: > > Here is the first batch of Swedish translation patches. > One patch per email. -- James Hawkins

Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Hans Leidekker
I have written attached script to facilitate automated winetest runs. It needs a VirtualBox virtual machine with either Windows or a Wine platform configured to run autorun.inf files. The script downloads the latest winetest binary and puts it in an iso image, along with an autorun file to trigge

Re: Have `make distclean` also remove .i and .s files

2007-10-15 Thread Michael Stefaniuc
Alexandre Julliard wrote: > Gerald Pfeifer <[EMAIL PROTECTED]> writes: > >> After using GCC's -save-temps option to debug something, I noticed >> that `make distclean` fails to actually remove .i and .s files. >> >> This patch fixes it. I hope it's the right place to make this change? > > It wou

Re: Patch for adding Swedish localization

2007-10-15 Thread Maarten Lankhorst
Daniel Nylander schreef: > How do I create a patch per file? There are 28 new files that needs to > be commited and one #include per dll/program to be added. Please help me > out, I'm not a developer If you created a git commit, you can undo it with git reset --mixed origin. Then do the following:

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Maarten Lankhorst skrev: > Hi Daniel, > > You must add localizations for 1 dll/program at a time, that makes it a > lot easier to review. How do I create a patch per file? There are 28 new files that needs to be commited and one #include per dll/program to be added. Please help me out, I'm not a

Re: Have `make distclean` also remove .i and .s files

2007-10-15 Thread Alexandre Julliard
Gerald Pfeifer <[EMAIL PROTECTED]> writes: > After using GCC's -save-temps option to debug something, I noticed > that `make distclean` fails to actually remove .i and .s files. > > This patch fixes it. I hope it's the right place to make this change? It would be, but I don't think we want make

Re: make crosstest - a catastrophic saga

2007-10-15 Thread Hans Leidekker
On Monday 15 October 2007 19:24:27 Pedro Araújo wrote: > I've been consistently failing to 'make crosstest'... I've already tried my > distro's repositories, Hans Leidekker's patches, all to no avail. I wish I You need more patches ;) Wine tests are a fast moving target which means we're nearly a

Bug in dlls/oleaut32/tests/vartype.c?

2007-10-15 Thread Gerald Pfeifer
dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400;/* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, &bstr); + ok(hres == S_OK, "got hres 0x%08lx\n", hres); + if (bstr) + { +todo_wine ok(memcmp(bstr, szZero, sizeof(szZero))

Re: Wine at Systems in Munich

2007-10-15 Thread Rosa Riebl
An mir soll es nicht scheitern! :-) Rosa Dan Kegel schrieb: > Vielen Dank, Peter! > > Rosa: ich freue mich auf naechstes Jahr, hoffentlich kann Wine dabei sein! > - Dan > > On 10/15/07, Peter Gietz <[EMAIL PROTECTED]> wrote: >> Hi Rosa, >> >> upon your request, I asked Open Source projects for

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Gerald Pfeifer
Thanks for all your feedback! On Mon, 15 Oct 2007, Dmitry Timoshkov wrote: > Your fix still won't work for a 64-bit target. You would need to use > ULONG_PTR cast for that. 'if (!HIWORD(lpszStructType))' line also doesn't > look right in the 64-bit case. The latter is left unchanged and I'll lea

Re: Wine at Systems in Munich

2007-10-15 Thread Peter Gietz
Hi Rosa, upon your request, I asked Open Source projects for possible participation at the Open Source booth on Systems 2007. For this year it seems, I couldn't find anyone. But, if I understand correctly Wine may be interested in joining next year, provided there will be a similar booth then.

Re: libs/wine/mmap.c: conditionally provide reserve_area()

2007-10-15 Thread Gerald Pfeifer
On Sun, 14 Oct 2007, Vitaliy Margolen wrote: > In this and all of your patches, please diff from the top of the tree. > The above line should say "+++libs/wine/mmap.c". And it would be even > better if you can use GIT instead of cvs. Thanks for the feedback. I'll certainly try to keep the forme

make crosstest - a catastrophic saga

2007-10-15 Thread Pedro Araújo
Hi all, I've been consistently failing to 'make crosstest'... I've already tried my distro's repositories, Hans Leidekker's patches, all to no avail. I wish I could use the test suite, but I need some custom local tests and therefore I need to be able to build win32 executables. However, I'm stuck

Re: RICHED20: EM_SETTEXTEX must support RTF strings too

2007-10-15 Thread Daniel Remenak
When you fix bugs that are documented in comments, please fix the comments also. At the top of the file: EM_SETTEXTEX 3.0 (no rich text insertion handling, proper style?) And in the case itself /* FIXME: this should support RTF strings too, according to MSDN */ Thanks, Daniel Remenak On 1

Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Dimi Paun
On Mon, 2007-10-15 at 11:18 -0500, Jeremy White wrote: > Perhaps on Windows; I'm focused on Linux. Is there > a way to trigger that when doing a 'wine winetest.exe.so'? Maybe "-c" (console mode, no GUI) -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Jeremy White
> There is a headless operation mode already, it detects > if you run it as a service, and skips appropriate tests. Perhaps on Windows; I'm focused on Linux. Is there a way to trigger that when doing a 'wine winetest.exe.so'? Cheers, Jeremy

Re: Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Dimi Paun
On Mon, 2007-10-15 at 10:48 -0500, Jeremy White wrote: > In my opinion, it needs the following: > > 1. A Wiki page! > > I could not find *any* documentation on this utility. > > For example, I'm still not entirely clear on how to > setup and/or register my build.id so that m

Make test drill, next steps, call for help with Winetest

2007-10-15 Thread Jeremy White
Hi Folks, So I had plan to report on the status of make test, and sound a call to action. That is, one of the best and most fun things we did at Wineconf was to call bullshit on the failure of make test to work reliably. That is, it only runs cleanly on Alexandre's machine, and not even all the

Re: Wine at Systems in Munich

2007-10-15 Thread Dan Kegel
Vielen Dank, Peter! Rosa: ich freue mich auf naechstes Jahr, hoffentlich kann Wine dabei sein! - Dan On 10/15/07, Peter Gietz <[EMAIL PROTECTED]> wrote: > Hi Rosa, > > upon your request, I asked Open Source projects for possible > participation at the Open Source booth on Systems 2007. > > For th

Re: Patch for adding Swedish localization

2007-10-15 Thread Maarten Lankhorst
Hi Daniel, You must add localizations for 1 dll/program at a time, that makes it a lot easier to review. Cheers, Maarten.

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Robert Shearman skrev: > You need to make one patch with both the changes to existing .rc files > and with the new .rc files, otherwise the commit isn't atomic. > > Also, don't gzip a patch unless it is over ~100KB since it makes it much > harder to review. Here is another shot at it. http://ho

Re: Patch for adding Swedish localization

2007-10-15 Thread Robert Shearman
Daniel Nylander wrote: > Robert Shearman skrev: > >> Daniel Nylander wrote: >> >>> Here is the patch to add Swedish localization files to Wine. >>> Sorry, this is my first patch using git and I'm really unsure if I did >>> it correctly. >>> >>> >> You need to use git-add to includ

Re: Patch for adding Swedish localization

2007-10-15 Thread Daniel Nylander
Robert Shearman skrev: > Daniel Nylander wrote: >> Here is the patch to add Swedish localization files to Wine. >> Sorry, this is my first patch using git and I'm really unsure if I did >> it correctly. >> > > You need to use git-add to include the new files in the commit/patch you > sent. Hmm

Re: Patch for adding Swedish localization

2007-10-15 Thread Robert Shearman
Daniel Nylander wrote: > Here is the patch to add Swedish localization files to Wine. > Sorry, this is my first patch using git and I'm really unsure if I did > it correctly. > You need to use git-add to include the new files in the commit/patch you sent. -- Rob Shearman

Re: widl: Generate dlldata files. [resend]

2007-10-15 Thread Robert Shearman
Dan Hipschman wrote: > if (!parse_only && do_header) > write_interface($$); > if (!parse_only && do_idfile) > write_iid($$); > pointer_default = > $1.ol

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Francois Gouget
On Mon, 15 Oct 2007, Robert Shearman wrote: > Gerald Pfeifer wrote: > > } > > if (!HIWORD(lpszStructType)) > > { > > -switch (LOWORD(lpszStructType)) > > +switch ((DWORD)lpszStructType) > > > > You're just passing the problem on to people doing 64-bit builds. You

Re: Possible WIne regression with Warcraft

2007-10-15 Thread Andrey Turkin
> > Let me take a wild guess. /etc/hosts resolves your hostname to a loopback > address, like 127.0.1.1 or somesuch. > > If that's the case, please change /etc/hosts to make your hostname resolve > to > your network card's IP address. > > If that's not the case, please attach a +winsock log to bug

Re: Possible WIne regression with Warcraft

2007-10-15 Thread Kai Blin
On Monday 15 October 2007 02:15:37 Michael Lothian wrote: > I've rolled all the way back to 0.9.43 but I still can't join a Local > Lan game (I don't use battlenet) > > So either the problem is in my setup (GCC 4.2.2 & Glibc 2.6.1) some > random change in the Kernel or perhaps using the git tree ra

Re: Swedish translations

2007-10-15 Thread Robert Shearman
Daniel Nylander wrote: > I have translated a lot of programs and dlls to Swedish. > Would be great if someone could commit this to git. > > http://home.danielnylander.se/translations/wine/wine-sv.tar.gz > > > Please also add the following to the ./tools/wine.desktop > > Name[sv]=Windows-emulatorn W

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Robert Shearman
Gerald Pfeifer wrote: > } > if (!HIWORD(lpszStructType)) > { > -switch (LOWORD(lpszStructType)) > +switch ((DWORD)lpszStructType) > You're just passing the problem on to people doing 64-bit builds. You should use DWORD_PTR or use LOWORD everywhere, like you sugge