Re: Recent BiDi changes

2007-09-25 Thread Shachar Shemesh
Maarten Lankhorst wrote: >> On a related note - I haven't been able to get an answer to that one, >> not even through experimentation. Does anyone know whether Windows' >> Unicode is UTF-16 or UCS-2? Whether it's necessary to handle aggregates >> is crucially important when reordering characters. >

Re: shell32[1/2]: shlview: make the shell view control Unicode (fixesbuf #9767)

2007-09-25 Thread Dmitry Timoshkov
"Mikolaj Zalewski" <[EMAIL PROTECTED]> wrote: > When the control class is Unicode the listview will be sending > LVN_GETDISPINFOW instead of LVN_GETDISPINFOA and filenames with > charactes outside of the ACP will display properly. > I'm changing the type of a define from the include/ directory

Re: comctl32: remove unneeded todo_wine, because test pass

2007-09-25 Thread Dmitry Timoshkov
"Hans Leidekker" <[EMAIL PROTECTED]> wrote: > On Wednesday 26 September 2007 02:11:21 Lei Zhang wrote: > >> I can pick a new coordinate to fix this, but then the new hit test >> will be just as brittle as the current one. Anyone have better ideas >> on how to make these coordinate based tests mor

Re: comctl32: remove unneeded todo_wine, because test pass

2007-09-25 Thread Hans Leidekker
On Wednesday 26 September 2007 02:11:21 Lei Zhang wrote: > I can pick a new coordinate to fix this, but then the new hit test > will be just as brittle as the current one. Anyone have better ideas > on how to make these coordinate based tests more robust? I'd say we need to ship a set of fonts wi

Re: comctl32: remove unneeded todo_wine, because test pass

2007-09-25 Thread Mikołaj Zalewski
> > I can pick a new coordinate to fix this, but then the new hit test > will be just as brittle as the current one. Anyone have better ideas > on how to make these coordinate based tests more robust? > For the toolbar tests I have been sending WM_SETFONT with GetStockObject(SYSTEM_FONT) . It

Re: comctl32: remove unneeded todo_wine, because test pass

2007-09-25 Thread Lei Zhang
On 9/25/07, James Hawkins <[EMAIL PROTECTED]> wrote: > On 9/25/07, Christian Gmeiner <[EMAIL PROTECTED]> wrote: > > I am running make test an a fresh git fetch; git rebase origin and am > > getting this: > > > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > > comctl32_test.exe.

Re: mpr: Changes comparison of dwScope in WNetOpenEnum function

2007-09-25 Thread Juan Lang
> The following condition in _globalEnumeratorAdvance() looks incorrect: > > for (; enumerator->providerIndex < providerTable->numProviders && > !(enumerator->dwScope & providerTable->table > [enumerator->providerIndex].dwEnumScopes); > enumerator->providerIndex++

Re: Wine GSoC 2007 project membership

2007-09-25 Thread Juan Lang
> I did contact Google, and they told me to contact our admin, whichh from the > Google > page appeared to be Dan Kegel, but he never replied to my mail. Ah, right. He's probably the right person, and he reads this list, so hopefully you've got his attention now ;) --Juan

Re: Wine GSoC 2007 project membership

2007-09-25 Thread Alexander Nicolaysen Sørnes
On Wednesday 26 September 2007 00:36:20 Juan Lang wrote: > > I received a passing evaluation in this year's GSoC, but I was not added > > to the Wine project hosting for 2007, does anyone here have the power to > > add me? > > If you mean on the wine wiki, you can edit that yourself, of course. > I

Re: Wine GSoC 2007 project membership

2007-09-25 Thread Juan Lang
> I received a passing evaluation in this year's GSoC, but I was not added to > the Wine project hosting for 2007, does anyone here have the power to add me? If you mean on the wine wiki, you can edit that yourself, of course. If you mean somewhere on Google's SoC site, you'll need to contact the

Re: comctl32: remove unneeded todo_wine, because test pass

2007-09-25 Thread James Hawkins
On 9/25/07, Christian Gmeiner <[EMAIL PROTECTED]> wrote: > I am running make test an a fresh git fetch; git rebase origin and am > getting this: > > ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p > comctl32_test.exe.so monthcal.c && touch monthcal.ok > err:monthcal:MONTHCAL_Window

Wine GSoC 2007 project membership

2007-09-25 Thread Alexander Nicolaysen Sørnes
Hello all, I received a passing evaluation in this year's GSoC, but I was not added to the Wine project hosting for 2007, does anyone here have the power to add me? Alexander N. Sørnes

Re: Recent BiDi changes

2007-09-25 Thread Maarten Lankhorst
Shachar Shemesh schreef: > Alexandre Julliard wrote: > >> Actually the proper place would be libwine along with the rest of the >> Unicode support. >> >> > I've spent the past hour downloading 12% of the git repository, so I'm > unable to look at current Wine code for at least the next 2

Re: Recent BiDi changes

2007-09-25 Thread Alexandre Julliard
Shachar Shemesh <[EMAIL PROTECTED]> writes: > I've spent the past hour downloading 12% of the git repository, so I'm > unable to look at current Wine code for at least the next 24 hours > :-(. You can always browse the code at http://source.winehq.org/git/wine.git >>From memory, libwine contains

Re: Recent BiDi changes

2007-09-25 Thread Shachar Shemesh
Alexandre Julliard wrote: > > Actually the proper place would be libwine along with the rest of the > Unicode support. > I've spent the past hour downloading 12% of the git repository, so I'm unable to look at current Wine code for at least the next 24 hours :-(. >From memory, libwine contains m

Re: Recent BiDi changes

2007-09-25 Thread Shachar Shemesh
Alexandre Julliard wrote: > > Actually the proper place would be libwine along with the rest of the > Unicode support. > I've spent the past hour downloading 12% of the git repository, so I'm unable to look at current Wine code for at least the next 24 hours :-(. >From memory, libwine contains m

Re: Recent BiDi changes

2007-09-25 Thread Alexandre Julliard
Shachar Shemesh <[EMAIL PROTECTED]> writes: > Hi Maarten, > > Can you, please, explain the advantage of creating our own > implementation of the BiDi algorithm over using existing > implementations? I know ICU sucks (especially as far as linkage is > concerned), but there are other implementations

Recent BiDi changes

2007-09-25 Thread Shachar Shemesh
Hi Maarten, Can you, please, explain the advantage of creating our own implementation of the BiDi algorithm over using existing implementations? I know ICU sucks (especially as far as linkage is concerned), but there are other implementations, major among which is fribidi, which are free, are C ba

Re: pdh: add tests for XP variant of api call

2007-09-25 Thread Hans Leidekker
On Tuesday 25 September 2007 14:19:34 Jeff Latimer wrote: > I am happy with that though the tests I added relate to the following > paragraph where it says that XP requires the buffer parameter as well as > the size at all times and testing shows that it returns > PDH_INVALID_ARGUMENT. It also re

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > I added that changes because Microsoft compiler from latest Vista SDK > complains that variables might be used without being initialized. It sounds like that compiler is on crack. I don't think we want to sprinkle assignments all over the place jus

Re: [5/5] winex11: Use an offscreen redirected window for child OpenGL rendering

2007-09-25 Thread Alexandre Julliard
Chris Robinson <[EMAIL PROTECTED]> writes: > With the child being parented to the main window, a BadWindow error sometimes > crops up on XDestroyWindow for the X11 child. I couldn't see why, but > parenting it to the root_window works. Would that be due to using gdi_display > for creating/destr

Re: pdh: add tests for XP variant of api call

2007-09-25 Thread Jeff Latimer
Hans Leidekker wrote: >> From this we should write tests to accept all values. It would seem >> that the wine dll still needs to implement the API accurately, so you >> are saying, code the API correctly but make the tests generic? >> > > Quote from MSDN on PdhLookupPerfNameByIndex: > > PD

Re: [5/5] winex11: Use an offscreen redirected window for child OpenGL rendering

2007-09-25 Thread Chris Robinson
On Tuesday 25 September 2007 04:31:04 am Alexandre Julliard wrote: > Chris Robinson <[EMAIL PROTECTED]> writes: > > +if(w > 0 && h > 0) { > > +XFlush(gdi_display); > > +XCopyArea(gdi_display, physDev->gl_drawable, physDev->drawable, > > + physDev->gc, 0, 0, w, h

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Dmitry Timoshkov
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote: > Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > >> /* posted message */ >> PostMessageA( hwnd, WM_CHAR, dbch[0], 0 ); >> +msg.message = 0xdeadbeef; >> ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", >> msg.

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > /* posted message */ > PostMessageA( hwnd, WM_CHAR, dbch[0], 0 ); > +msg.message = 0xdeadbeef; > ok( !PeekMessageW( &msg, hwnd, 0, 0, PM_REMOVE ), "got message %x\n", > msg.message ); > PostMessageA( hwnd, WM_CHAR, dbch[1], 0

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: > "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > > As the subject of the patch says the tests pass absolutely cleanly for > me. > The failure you see above is a very minor thing in comparison to > current state. > Usually I'm monitoring test.winehq.org/data and trying to fi

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: > Sorry! It falls in my Windows XP SP2 with: > msg.c:3267:expected 0009 - actual 0009 > msg.c:3267:expected 0008 - actual 0008 > msg.c:3267:expected 0281 - actual 0007 > msg.c:3267: Test failed: Child did not switch correctly: the msg 0x0281 > was expec

Re: [5/5] winex11: Use an offscreen redirected window for child OpenGL rendering

2007-09-25 Thread Alexandre Julliard
Chris Robinson <[EMAIL PROTECTED]> writes: > +if(w > 0 && h > 0) { > +XFlush(gdi_display); > +XCopyArea(gdi_display, physDev->gl_drawable, physDev->drawable, > + physDev->gc, 0, 0, w, h, physDev->dc_rect.left, > + physDev->dc_rect.top); Why do

Re: user32: Make message test pass cleanly under XP SP2

2007-09-25 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: > Hello, > > Changelog: > user32: Make message test pass cleanly under XP SP2. > > --- > dlls/user32/tests/msg.c | 142 +- > 1 files changed, 102 insertions(+), 40 deletions(-) > > > > @@ -224,51 +226,53 @@ static const str

Re: widl [2/6]: Fix conformant array test failures

2007-09-25 Thread Alexandre Julliard
Dan Hipschman <[EMAIL PROTECTED]> writes: > This patch gets conformant arrays working in the tests. Currently, only > the address of some conformant arrays are being marshalled, and this wasn't > showing up in the tests because some storage was static. This patch fixes > the problem by writing p

Re: mpr: Changes comparison of dwScope in WNetOpenEnum function

2007-09-25 Thread Konstantin Kondratyuk
Hello, Juan! > Hi Konstantin, > > - providerTable->table[index].dwEnumScopes > & dwScope) > + providerTable->table[index].dwEnumScopes > & WNNC_ENUM_GLOBAL) > > This change looks correct, but it should be changed in the next block as > well: