Re: kernel32: Don't crash accessing an invalid handle in GlobalSize [try3]

2007-09-19 Thread James Hawkins
On 9/20/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "James Hawkins" <[EMAIL PROTECTED]> wrote: > > > This version compares the pointer value to 64000 instead of using a > > try/catch block, as suggested by Alexandre. > > > - if(pintern->Magic==MAGIC_GLOBAL_USED) > > + if(pintern > (

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize [try3]

2007-09-19 Thread Dmitry Timoshkov
"James Hawkins" <[EMAIL PROTECTED]> wrote: > This version compares the pointer value to 64000 instead of using a > try/catch block, as suggested by Alexandre. > - if(pintern->Magic==MAGIC_GLOBAL_USED) > + if(pintern > (PGLOBAL32_INTERN)64000 && > pintern->Magic==MAGIC_GLOBAL_USED) >

Re: Handling New IDLs with widl

2007-09-19 Thread Robert Shearman
Roy wrote: > I'm looking for advice on how to integrate a new idl into wine. > > I'm implementing bits and using the widl compiler on the IDL I wrote. My > current setup places the IDL in include/ with the build system generating a > header file that it posits there. So far, so good. > > I now ne

Handling New IDLs with widl

2007-09-19 Thread Roy
Howdy, I'm looking for advice on how to integrate a new idl into wine. I'm implementing bits and using the widl compiler on the IDL I wrote. My current setup places the IDL in include/ with the build system generating a header file that it posits there. So far, so good. I now need to generate

Re: Minimal Background Intelligent Transfer Service (bits) implementation

2007-09-19 Thread Roy
Howdy, Resubmission of bits skeleton with a DLL_WINE_PREATTACH case added to DllMain. Thanks for the advice! Peace, -Roy On Wed, Sep 19, 2007 at 09:57:45AM +0200, Michael Stefaniuc wrote: > Hello Roy, > > Roy wrote: > > This patch provides a first skeleton version of bits.dll. > thanks for the

Re: wineboot: Pass non-zero timeouts to SendMessageTimeout, otherwise the call won't timeout.

2007-09-19 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > The original code seems to have been designed to not wait at all, but > this got changed by a user32 commit that made a timeout of zero behave > as INFINITE. I don't think so, AFAICT it has always been supposed to wait (except with the SMTO_ABORTIFHUN

Re: wineboot: Pass non-zero timeouts to SendMessageTimeout, otherwise the call won't timeout.

2007-09-19 Thread Robert Shearman
Alexandre Julliard wrote: > Robert Shearman <[EMAIL PROTECTED]> writes: > > >> Set the default for WM_QUERYENDSESSION to be 5s which should be enough >> time for users to respond to any message boxes and WM_ENDSESSION to a >> lower 1s. >> > > If you are going to timeout on the user interact

Re: Alexandre Julliard : wordpad.exe: We can now store binary files in the repository.

2007-09-19 Thread Markus Amsler
So we can also add ttf fonts and get rid of the fontforge dependency? Markus

Re: widl [2/2]: Implement pointer descriptions for complex structures

2007-09-19 Thread Robert Shearman
Dan Hipschman wrote: > On Tue, Sep 18, 2007 at 11:15:26PM +0100, Robert Shearman wrote: > >>> Sorry, I missed your last three patches somehow. My patch not only uses >>> RPC_FC_POINTER instead of RPC_FC_LONG here, but it also implements the >>> pointer description section for complex structures

Re: winsock: Increase amount of iovec's to 32

2007-09-19 Thread Alexandre Julliard
Maarten Lankhorst <[EMAIL PROTECTED]> writes: > I don't know why WS_MSG_MAXIOVLEN is used here, that seems to be a > message identifier rather then the actual size of MAXIOVLEN, so I added > a define for MAXIOVLEN and made it 32. MSG_MAXIOVLEN is not a message identifier, it's really supposed to

Re: include: add a macro to declare critical sections as we declare them in Wine - initialized and with a debug

2007-09-19 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > Would such a patch be accepted? No, debug.h is about the libwine debugging API, critical sections have nothing to do with that. -- Alexandre Julliard [EMAIL PROTECTED]

Re: winex11.drv: When minimizing a top level window move it outside of the visible desktop area

2007-09-19 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > Changelog: > winex11.drv: When minimizing a top level window move it outside of > the visible desktop area. This will break apps that expect to paint their icon window, and probably also break the positioning of the icon title. It also doesn'

Re: winex11.drv[1/4]: fix two bugs in WTInfoA

2007-09-19 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > Two bugs I've found working on previous implentations > From b233532f7adc140c4e36fb2288581fe0ff181935 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <[EMAIL PROTECTED]> > Date: Mon, 17 Sep 2007 11:54:41 -0700 > Subject: [PATCH] w

Re: wineboot: Pass non-zero timeouts to SendMessageTimeout, otherwise the call won't timeout.

2007-09-19 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Set the default for WM_QUERYENDSESSION to be 5s which should be enough > time for users to respond to any message boxes and WM_ENDSESSION to a > lower 1s. If you are going to timeout on the user interaction you need to popup a confirmation dialog of s

Re: Minimal Background Intelligent Transfer Service (bits) implementation

2007-09-19 Thread Michael Stefaniuc
Hello Roy, Roy wrote: > This patch provides a first skeleton version of bits.dll. thanks for the patch but could you please add also a DLL_WINE_PREATTACH case in DllMain()? That way Wine can prefer to load a native bits DLL (if one is available) until the Wine one gets usable. See for example the