Re: msi(1/3): Don't crash if rec is NULL

2007-09-14 Thread James Hawkins
On 9/14/07, Jeremy White <[EMAIL PROTECTED]> wrote: > Your patches also cure the symptom, Juan; thanks. > > I agree with the concerns James expressed, though: I didn't feel that I > understood the whole story. (Heck, I really have *no* clue what I'm > talking about ). > > However, the call to MSI

Re: msi(1/3): Don't crash if rec is NULL

2007-09-14 Thread Jeremy White
Your patches also cure the symptom, Juan; thanks. I agree with the concerns James expressed, though: I didn't feel that I understood the whole story. (Heck, I really have *no* clue what I'm talking about ). However, the call to MSI_FormatMessageW is not an internal call, I think; it looks to me

Re: carbon poker under wine

2007-09-14 Thread Trent Waddington
On 9/13/07, Trent Waddington <[EMAIL PROTECTED]> wrote: > wget > http://fpdownload.macromedia.com/get/flashplayer/current/install_flash_player.exe > ./wine install_flash_player.exe Forget I said that. Grab: http://rtfm.insomnia.org/~qg/Flash9b.ocx and put it in ~/.wine/drive_c/windows/system32

Problem with TCP Option 0x00000008

2007-09-14 Thread Christian Mahnke
Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x0008" after the loading of native rpcltccm.dll. To work a

Re: fnt2fon: janitorial IgnoredReturnValues

2007-09-14 Thread Alexandre Julliard
Lionel_Debroux <[EMAIL PROTECTED]> writes: > * the current input file (fp) is not always closed when exiting; Closing the input on exit is useless. > * the atexit() and signal() calls are placed too late in the program, > and their return values are not checked; Their return value is irrelevant

Re: fnt2fon: janitorial IgnoredReturnValues

2007-09-14 Thread Lionel_Debroux
> > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues". > > This page is outdated, but its content is still valid for fnt2fon, > > which ignores a number of return values. > I don't think that's worth fixing, the warnings are essentially > useless, it just makes the code uglier.

Re: msi(1/3): Don't crash if rec is NULL

2007-09-14 Thread James Hawkins
On 9/14/07, Juan Lang <[EMAIL PROTECTED]> wrote: > > MSI_FormatRecordW is an internal function and we should be crashing if > > rec is NULL. > > Are you sure? This is causing the iTunes installer to crash for a > couple people. Besides, I don't think the code is written with this > assumption in

Re: msi(1/3): Don't crash if rec is NULL

2007-09-14 Thread Juan Lang
> MSI_FormatRecordW is an internal function and we should be crashing if > rec is NULL. Are you sure? This is causing the iTunes installer to crash for a couple people. Besides, I don't think the code is written with this assumption in mind. In deformat_string_internal: static DWORD deformat_s

Re: fnt2fon: janitorial IgnoredReturnValues (1/5)

2007-09-14 Thread Alexandre Julliard
Lionel_Debroux <[EMAIL PROTECTED]> writes: > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues". > This page is outdated, but its content is still valid for fnt2fon, which > ignores a number of return values. I don't think that's worth fixing, the warnings are essentially usele

Re: msi(1/3): Don't crash if rec is NULL

2007-09-14 Thread James Hawkins
On 9/14/07, Juan Lang <[EMAIL PROTECTED]> wrote: > This series of patches is in response to Jeremy's troubles with > iTunes. They may or may not fix the installer for him, but they > prevent potential crashes. > --Juan > MSI_FormatRecordW is an internal function and we should be crashing if rec i

Problem with TCP Option 0x00000008

2007-09-14 Thread Christian Mahnke
Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x0008" after the loading of native rpcltccm.dll. To work arou

Re: winex11.drv/wintab32[1/5]: store categories field-by-field (resend)

2007-09-14 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > There is a problem to have the same prototype and make winex11.drv > call handle only Unicode as some of the WTInfo output are binary data > and some are strings. Should I duplicate the knowledge of which are > which in wintab32? The W->A transla

An enumeration of network resources

2007-09-14 Thread Konstantin Kondratyuk
Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The inform