Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Dmitry Timoshkov
"Vincent Povirk" <[EMAIL PROTECTED]> wrote: Well, I COULD do that if SHCreateDirectoryExW worked the way the Wine API docs claim. It seems to be returning ERROR_ALREADY_EXISTS even when the thing that already exists is a file and not a directory. Then it needs a separate test case and a fix.

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Vincent Povirk
On 9/2/07, Vincent Povirk <[EMAIL PROTECTED]> wrote: > On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > > By checking return value of SHCreateDirectoryExW you can make a shortcut > > in the deciding logic, in both cases: when the function fails you exit > > right away (returning *correct* e

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Vincent Povirk
On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Vincent Povirk" <[EMAIL PROTECTED]> wrote: > > >> Why there is no check for SHCreateDirectoryExW return value? > > The return value of SHCreateDirectoryExW doesn't matter. All that > > matters is whether the directory exists when the functio

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Dmitry Timoshkov
"Vincent Povirk" <[EMAIL PROTECTED]> wrote: Why there is no check for SHCreateDirectoryExW return value? The return value of SHCreateDirectoryExW doesn't matter. All that matters is whether the directory exists when the function returns. It may or may not have existed when the function was call

winhelp, Vector NTI, molecular biologists

2007-09-02 Thread Misha Koshelev
Hi everybody, So as you all know I've been working on various bug fixes throughout wine, with my most significant contributions to date being MSI OLE automation support and implementation of http protocol support in urlmon. This involvement was driven by my initial experiences of getting a key pro

Re: Window decorations missing on Compiz/Debian Etch

2007-09-02 Thread Michael Jung
Hi Maarten, Maarten Lankhorst wrote: Hi Michael, First of all, please do 'reply all' so a copy gets sent to wine-devel too. Oops, sorry. Will do. Second, if the bug only occurs with compiz/beryl it is really likely that it is a compiz/beryl bug., since it's not really a mature window manage

Re: Window decorations missing on Compiz/Debian Etch

2007-09-02 Thread Michael Jung
Hi, L. Rahyen wrote: On Saturday September 1 2007 16:35, Michael Jung wrote: Hi all, since a couple of weeks all wine GUI applications are missing the window manager decorations on my Debian Etch box with the Compiz window manager. Have you tried to report this bug to Compiz developers? It

Re: Window decorations missing on Compiz/Debian Etch

2007-09-02 Thread L. Rahyen
On Saturday September 1 2007 16:35, Michael Jung wrote: > Hi all, > > since a couple of weeks all wine GUI applications are missing the window > manager decorations on my Debian Etch box with the Compiz window > manager. Have you tried to report this bug to Compiz developers? It really see

Re: ddraw: fix cases where desc2.u2.dwMipMapCount is 0.

2007-09-02 Thread David Hedberg
Hi again, I played around a bit with a simple test case, and it seems that my first attempt at a patch was faulty. From what I can see and what the test case says, windows does not allow the creation of these surfaces at all. I've remade the patch to mimic the behaviour of windows, and also added

Re: IDirect3DImpl_EnumDevices only enumerating IID_IDirect3DTnLHalDevice

2007-09-02 Thread Stefan Dösinger
Am Sonntag, 2. September 2007 14:15 schrieb David Hedberg: > While this works as a "fix", it's obviously not a good one. In my > (somewhat limited and at the moment not doublechecked) understanding, > windows "always" returns (at least) two devices, one reporting T&L > capable and one not. So I am

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Vincent Povirk
On 9/2/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > It's better to not use fixed buffer sizes but allocate the buffer dynamically. OK. I avoided that because I didn't want to have to worry about freeing the buffer later when it's only needed in some cases. > If the job must be done only when

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite

2007-09-02 Thread Dmitry Timoshkov
"Vincent Povirk" <[EMAIL PROTECTED]> wrote: HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR path, DWORD flags) { -FIXME("%p %p %s 0x%08x\n", hwnd, modless, debugstr_a(path), flags); -return S_OK; +WCHAR wpath[MAX_PATH]; +MultiByteToWideChar( CP_ACP,

Re: Window decorations missing on Compiz/Debian Etch

2007-09-02 Thread Maarten Lankhorst
Michael Jung schreef: > Hi Maarten, > > Thanks for pointing me to the FAQ. The FAQ entry seems to address > primarily OpenGL related issues, however, which I'm currently not > concerned about that much. Given the fact that the window decorations > used to work just fine before the mentioned patch,

Re: ddraw: fix cases where desc2.u2.dwMipMapCount is 0.

2007-09-02 Thread Stefan Dösinger
Am Sonntag, 2. September 2007 14:16 schrieb David Hedberg: > (Resending mail after subscribing to list) > > Hi, > > This patch fixes a problem visible in Delta Force Land Warrior and > Delta Force Task Force Dagger, where extra_surfaces would sometimes > get a value of -1 and later cause a "near in

IDirect3DImpl_EnumDevices only enumerating IID_IDirect3DTnLHalDevice

2007-09-02 Thread David Hedberg
(Resending mail after subscribing to list) Hi, I've been tracking down the reason for bug 7993 ( http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found it. It appears as if the EnumDevices callback in Delta Force for so

Re: UbiSoft giving away games

2007-09-02 Thread Stefan Dösinger
Am Sonntag, 2. September 2007 06:58 schrieb Michael Lothian: > Hi > > Just thought I'd share this with you all. > > http://www.theinquirer.net/default.aspx?article=42069 > > For those of you that haven't heard > > I know FarCry works with wine I'm not sure about the other 2 but it could > be worth