Re: [2/5] WineD3D: Clear unused channels on R32F and R16F textures on readback

2007-08-29 Thread Stefan Dösinger
Am Mittwoch, 29. August 2007 20:54 schrieb H. Verbeet: > On 29/08/2007, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > Can you even use those formats as render target on any cards? On windows yes, and there are apps that expect it. Some of those new unreal 3 engine based games(Airborne, I think) e

Re: notepad: Add program icon

2007-08-29 Thread Alexander Nicolaysen Sørnes
Tirsdag 28 august 2007 13:30, skrev du : > On 8/27/07, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote: > > notepad: Add program icon > > > > And now for the usual Wine oath: :) > > I swear under pain of treason that the icon is my own work. > > > > .png attached if anyone wants to look at it

Re: try2:patch for sysparams.c

2007-08-29 Thread L. Rahyen
On Wednesday August 29 2007 09:15, Ivan Sinitsin wrote: > Has corrected "logpixels=72" to " logpixels = 96 " and has changed the > indentation > > This patch adds an opportunity for fonts of the menu, statusbar and > messages to increase depending on logpixels. > > > Changelog: > This patch does a

Re: [2/5] WineD3D: Clear unused channels on R32F and R16F textures on readback

2007-08-29 Thread H. Verbeet
On 29/08/2007, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Can you even use those formats as render target on any cards?

Re: [PATCH] Support for animated cursors

2007-08-29 Thread Trent Waddington
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote: > Like Henri already said, you really can't use globals for anih, > ani_frames, and ani_frame_idx. These should be in a structure, and > decodeRIFF should write into that structure, not into globals. The > structure should then be associated with t

Re: [PATCH] Support for animated cursors

2007-08-29 Thread Trent Waddington
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote: > For ease of review, you should send one cumulative patch, rather than > patches that apply on top of one another. (I use separate git trees - > one for development, one for merging - to make this easier.) The > style fixes at least look good thou

Re: [PATCH] Support for animated cursors

2007-08-29 Thread Trent Waddington
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote: > That doesn't make it better, it's not thread-safe. Pass them as > parameters to decodeRIFF. Ahh, I see. Yes, fixed. > I still say a symbolic constant is better, or at the least, a comment. > A test case that shows that it's needed is even bett

Re: [PATCH] Support for animated cursors

2007-08-29 Thread Trent Waddington
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote: > This doesn't belong with this patch. Yes, sorry. > One more random piece of advice: this has gotten enough commentary > that it may very well have entered Alexandre's "ignore for a while" > queue. So if you don't have success with this, wait so

Re: winex11.drv[2/2]: Support GdiAlphaBlend with blendfn.AlphaFormat == 0 (fixes bug #9262)

2007-08-29 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > @@ -1600,6 +1603,16 @@ #endif > for(; y >= y2; y--) { > memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes > + xSrc * 4, > widthSrc * 4); > +if (!(blendfn.AlphaFormat & AC_SRC_ALPHA)) > +

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (3rd try, with testcase, fixes bug #9195)

2007-08-29 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > Is there something wrong with this patch? You should use IntersectClipRect or ExtSelectClipRgn to avoid intermediate copies. Also GetClipRgn doesn't return a region code so checking it against NULLREGION is wrong. -- Alexandre Julliard [EMAIL PRO

Re: patch for sysparam.c

2007-08-29 Thread Paul Vriens
Ivan Sinitsin wrote: This patch adds an opportunity for fonts of the menu, statusbar and messages to increase depending on logpixels. Changelog: This patch does a font for the menu,statusbar and messages dependent from logpixels.

Re: patch for sysparam.c

2007-08-29 Thread Robert Shearman
Ivan Sinitsin wrote: This patch adds an opportunity for fonts of the menu, statusbar and messages to increase depending on logpixels. +size=sizeof(DWORD); +RegOpenKeyExW( HKEY_LOCAL_MACHINE, registry_key, + 0, KEY_QUERY_VALUE, &myhKey ); +if (!RegQueryValueExW( myhKe