Re: [PATCH] Support for animated cursors

2007-08-28 Thread Juan Lang
--- a/dlls/imm32/imm.c +++ b/dlls/imm32/imm.c @@ -1505,7 +1505,8 @@ BOOL WINAPI ImmRegisterWordW( */ BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC) { - FIXME("(%p, %p): stub\n", hWnd, hIMC); +if (hIMC == (HIMC)root_context) +root_context->IMC.hWnd = NULL; This doesn't belong

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Juan Lang
> > Like Henri already said, you really can't use globals for anih, > > ani_frames, and ani_frame_idx. These should be in a structure, and > > decodeRIFF should write into that structure, not into globals. The > > structure should then be associated with the icon. > > They're temps.. I've added a

Re: [PATCH] Support for animated cursors

2007-08-28 Thread H. Verbeet
On 28/08/07, Juan Lang <[EMAIL PROTECTED]> wrote: > This may be obvious to other, but certainly not to me: what does > 0x0003 mean? You need to use symbolic constants here. > It's a version number.

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Juan Lang
> Ok, attached, and fixed an issue with setting delay on the last frame. +static ANIHEADER *anih; +static LPBYTE *ani_frames; +static DWORD ani_frame_idx; + +static void decodeRIFF(LPBYTE bytes, DWORD size) +{ +CK *chunk = (CK*)bytes; +CKSIZE sizeWithPad = chunk->ckSize % 2 ? chunk->ckSize

Re: getting started...

2007-08-28 Thread Dan Kegel
On 8/28/07, Ed Sutter <[EMAIL PROTECTED]> wrote: > My problem there is that I'm stuck with RH9 at the moment, and it appears > that the latest Wine RPM for RH9 is 0.9.2. I see a few bugs already > in bugzilla related to serial com port issues; not quite the same problem > as I am seeing. So I can

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Trent Waddington
I've fixed the style issues indicated. I'm now using Xcursor's animated cursor support. The delay information in the ANI is honored. The changes to struct tagCURSORICONINFO are removed and, instead, I'm appending data after the bitmap info.. so Paint Brush can continue manipulating those bits di

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Trent Waddington
I noticed LoadCursorFromFile() wasn't working, so here's a patch to fix that. And a patch to fix some memory I was leaking. Have tested 150+ animated cursors so far, all appear to display correctly. Trent From 969a78da805d267ac5abc6427e017e4f6e3fec18 Mon Sep 17 00:00:00 2001 From: Trent Waddingt

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Trent Waddington
On 8/28/07, H. Verbeet <[EMAIL PROTECTED]> wrote: > http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344335f485aca6f6b37cfde5099c556f7dbdd73;hb=e69f5034c725353f1d23f7df6a2ce6ef3ad58412#l514 > should be a decent start. heh, making me think this is a well beaten path. > Well,

Re: [PATCH] the function called is cdecl, not WINAPI

2007-08-28 Thread Juan Lang
> Didn't you get a warning during compilation here? Curiously, no. --Juan

Re: [PATCH] Support for animated cursors

2007-08-28 Thread Juan Lang
For ease of review, you should send one cumulative patch, rather than patches that apply on top of one another. (I use separate git trees - one for development, one for merging - to make this easier.) The style fixes at least look good though. --Juan

Re: getting started...

2007-08-28 Thread Paul Chitescu
On Tue, 28 Aug 2007, Ed Sutter wrote: Anyway, if it makes more sense for me to just report problems that I have with uCon when running it on wine, that's fine with me. Bottom line is I will do whatever is most appropriate/helpful/efficient to get it running and that includes doing some wine co

Re: Will ROS and WINE still be steady be synchronized ?

2007-08-28 Thread Dmitry Timoshkov
"theUser BL" <[EMAIL PROTECTED]> wrote: Oh, I have seen, that Ged have been answert at http://www.reactos.org/archives/public/ros-dev/2007-August/009725.html And he write "Wine doesn't use ReactOS code, so it will never be back synched." Why? Because some people at WINE think, that ROS is il

Re: Will ROS and WINE still be steady be synchronized ?

2007-08-28 Thread Alexander Nicolaysen Sørnes
Tirsdag 28 august 2007 15:48, skrev theUser BL: > Hi! > > I have also ask the question in a mail in the ROS-Mailinglist -- until now > there comes now answer. > http://www.reactos.org/archives/public/ros-dev/2007-August/009718.html > > Will ReactOS and WINE still be steady synchronized? > > ROS hav

Re: getting started...

2007-08-28 Thread Roderick Colenbrander
On Tuesday 28 August 2007 16:11, Ed Sutter wrote: > >>Anyway, if it makes more sense for me to just report problems that I have > >>with uCon when running it on wine, that's fine with me. Bottom line is > >>I will do whatever is most appropriate/helpful/efficient to get it > >> running and that in

Re: getting started...

2007-08-28 Thread Ed Sutter
Anyway, if it makes more sense for me to just report problems that I have with uCon when running it on wine, that's fine with me. Bottom line is I will do whatever is most appropriate/helpful/efficient to get it running and that includes doing some wine code if necessary. I also have no proble

RE: Will ROS and WINE still be steady be synchronized ?

2007-08-28 Thread theUser BL
Oh, I have seen, that Ged have been answert at http://www.reactos.org/archives/public/ros-dev/2007-August/009725.html And he write "Wine doesn't use ReactOS code, so it will never be back synched." Why? Because some people at WINE think, that ROS is illegal without any evidence ? Greatings

Will ROS and WINE still be steady be synchronized ?

2007-08-28 Thread theUser BL
Hi! I have also ask the question in a mail in the ROS-Mailinglist -- until now there comes now answer. http://www.reactos.org/archives/public/ros-dev/2007-August/009718.html Will ReactOS and WINE still be steady synchronized? ROS have for example an other Notepad.exe and an other Wordpad.exe

Re: getting started...

2007-08-28 Thread Dan Kegel
On 8/28/07, Ed Sutter <[EMAIL PROTECTED]> wrote: > Maybe I mis-read something out of context... > On http://winehq.org/site/contributing#port_app, under the section > "Porting Your Windows Application to Wine" it suggests this. That's about how to improve Wine, not about getting your app on Linux.

Re: getting started...

2007-08-28 Thread Ed Sutter
Dan, Maybe I mis-read something out of context... On http://winehq.org/site/contributing#port_app, under the section "Porting Your Windows Application to Wine" it suggests this. I wrote uCon (a win32 application) and I would really like it to work with Wine. The majority of it does now. The GUI

Re: notepad: Add program icon

2007-08-28 Thread Pedro Araújo
On 8/27/07, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote: > notepad: Add program icon > > And now for the usual Wine oath: :) > I swear under pain of treason that the icon is my own work. > > .png attached if anyone wants to look at it. It's really not all that pretty. > > Alexander N. Sø

Re: winex11.drv: test for out-of-bound src coordinates in GdiAlphaBlend (fixed, with testcase, fixes bug #7428)

2007-08-28 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > The previous version didn't take into account that dib.dsBmih.biHeight > can be negative. You should check for negative widthSrc/heightSrc too. -- Alexandre Julliard [EMAIL PROTECTED]

Re: msvcrt: tests: some values of _mbctype are dependent on the version of Windows

2007-08-28 Thread Alexandre Julliard
"Mikolaj Zalewski" <[EMAIL PROTECTED]> writes: > @@ -144,10 +144,18 @@ static int result_cp_949_mbctype[] = { 0 > static int result_cp_950_mbctype[] = { 0x0,65, 0x8,1, 0x18,26, 0x8,6, > 0x28,26, 0x8,4, >0x0,2, 0x4,32, 0xc,94, 0,1 }; > > +/* these characters may differ on different Windows

Re: [PATCH] Support for animated cursors

2007-08-28 Thread H. Verbeet
On 28/08/07, Trent Waddington <[EMAIL PROTECTED]> wrote: > On 8/28/07, H. Verbeet <[EMAIL PROTECTED]> wrote: > > You should use the timing and frame sequence info from the .ani. > > Also, Xcursor actually supports proper animated cursors, so it would > > be better to handle the animation in winex11