Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-06 Thread Dmitry Timoshkov
"Hans Leidekker" <[EMAIL PROTECTED]> wrote: +static DWORD map_info_level(DWORD level) +{ +DWORD ret = 0; + +switch (level & QUERY_HEADER_MASK) +{ +case WINHTTP_QUERY_MIME_VERSION: ret = HTTP_QUERY_MIME_VERSION; break; +case WINHTTP_QUERY_CONTENT_TYPE:

FW: [Bug 2520] menu bar problem

2007-08-06 Thread Ann & Jason Edmeades
>Vitaliy >Jason, please don't forget to cc wine-bugs when you reassign the bug. Yeah, sorry... Its late here :-) Out of interest, why don't we fix bugzilla to always enforce that userid (ie if it gets removed, it automatically gets inserted back). I'm sure I'm not the only one who forgets to do i

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-06 Thread Jakob Eriksson
Jacek Caban wrote: > Hans Leidekker wrote: > >> I haven't seen a convincing argument for code duplication yet. >> > > Then why do you want to add hacks instead of proper implementation? > > >> We may >> even be able to achieve 100% by extending wininet a bit. E.g. we could >> add a Wine

Re: Can we please have at least a minimal coding style ?

2007-08-06 Thread Kai Blin
On Monday 06 August 2007 12:52:08 Stephan Rose wrote: > > Easy solution to that. I'm in absolute heaven with this feature... > > Eclipse 3.3 with CDT has an automatic code formatting feature, Ctrl > +Shift+F, my favorite keyboard shortcut now. =) > > May want to load some files into that and run t

Re: [WINE] WIDL regression between 0.9.38 and 0.9.39

2007-08-06 Thread Dan Hipschman
On Mon, Aug 06, 2007 at 04:24:39PM +0200, Herv? Poussineau wrote: > Hi Dan, > > I'm using Wine IDL compiler to compile some .idl files, and I found a > regression in WIDL between 0.9.38 and 0.9.39. > As you are the one who mostly changed WIDL between these releases, I'm > sending you this email ;)

Re: [PATCH] msi: correct buffer overrun in msi_get_deferred_action().

2007-08-06 Thread James Hawkins
On 8/5/07, William Waghorn <[EMAIL PROTECTED]> wrote: > --- > dlls/msi/custom.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c > index 390113e..17f581c 100644 > --- a/dlls/msi/custom.c > +++ b/dlls/msi/custom.c > @@ -153,7 +15

Re: Wine disassembly and reverse engineering rules.

2007-08-06 Thread Jesse Allen
On 8/6/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Montag, 6. August 2007 21:02 schrieb James Hawkins: > > "The reverse engineer is required to ask permission first, however." > > > > ...good luck with that. > Asking is easy :-) > > Does the reverse engineer have to get permission? If he do

Missing library - faultrep.

2007-08-06 Thread Peter Dons Tychsen
Hello. Wine is missing the library "faultrep". The library comes with Windows, and is used by apps for error reporting. Most apps don't really need it (unless something goes wrong), but simply require the DLL to be present. To start with i just wanted to add the DLL to Wine. I tried to submit a

Re: Wine disassembly and reverse engineering rules.

2007-08-06 Thread Stefan Dösinger
Am Montag, 6. August 2007 21:02 schrieb James Hawkins: > "The reverse engineer is required to ask permission first, however." > > ...good luck with that. Asking is easy :-) Does the reverse engineer have to get permission? If he does need the blessing of the creator of the reverse engineered soft

Re: Wine disassembly and reverse engineering rules.

2007-08-06 Thread James Hawkins
On 8/5/07, Jakob Eriksson <[EMAIL PROTECTED]> wrote: > Peter Dons Tychsen wrote: > > By browsing MSDN, i found out that i can accomplish this by using the > > documented function StalkWalk64(), which can examine the call stack. I > > would then introduce this into the test system for DLLs like "use

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-06 Thread Jacek Caban
Hans Leidekker wrote: > I haven't seen a convincing argument for code duplication yet. Then why do you want to add hacks instead of proper implementation? > We may > even be able to achieve 100% by extending wininet a bit. E.g. we could > add a Wine internal INTERNET_OPTION_CALLBACK_WINHTTP if we

Re: [winetest] Show missing tests in single/group results

2007-08-06 Thread Jakob Eriksson
Paul Vriens wrote: > > Comments/remarks etc.. are welcome. It is excellent that you are doing this, the reports are clearer for it. I will try to submit test results regularly. regards, Jakob Eriksson

Re: Direct3D Game test framework

2007-08-06 Thread Stefan Dösinger
Am Montag, 6. August 2007 16:49 schrieb martin pilka: > > Do you have HKCU/Software/Wine/Direct3D/DirectDrawRenderer set to "gdi" > > perhaps? This disables D3D support altogether. You could try with a > > fresh .wine, it should run 3dmark2000 and 2001 out of the box. > > I tried latest WineHq, it

Some details about SHDoDragDrop

2007-08-06 Thread Timo Kunze
Hi, currently Wine's SHDoDragDrop is a stub and the comment states that it probably is equivalent to DoDragDrop. That's not quite true. In one of my programs I passed a NULL drop source accidentally and to my surprise it worked. So SHDoDragDrop creates an IDropSource object for you if you don't pa

Re: [winetest] Show missing tests in single/group results

2007-08-06 Thread Paul Vriens
Jakob Eriksson wrote: Paul Vriens wrote: Comments/remarks etc.. are welcome. It is excellent that you are doing this, the reports are clearer for it. I will try to submit test results regularly. regards, Jakob Eriksson Hi Jakob, I think you ran a few win95 tests yesterday? What was wro

Re: winecfg: values list should be NULL-terminated.

2007-08-06 Thread Paul Chitescu
Great, thanks! Paul On Mon, 6 Aug 2007, Kirill K. Smirnov wrote: This fixes winecfg crash caused by recent winecfg changes.

Re: Direct3D Game test framework

2007-08-06 Thread martin pilka
> Do you have HKCU/Software/Wine/Direct3D/DirectDrawRenderer set to "gdi" > perhaps? This disables D3D support altogether. You could try with a > fresh .wine, it should run 3dmark2000 and 2001 out of the box. I tried latest WineHq, it created ~/.wine directory and installed 3DMark2000 correctly,

Re: wine.inf: Remove RelayFromExclude. It hides the real call traces which makes nearly useless relay logs. [resend]

2007-08-06 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Resend. Anything wrong with this patch? > > After this change went in, it became impossible to see what functions was > being called where and how inside Wine to understand what is happening. If > any one looks at the bugzilla and all of the reported

Re: Can we please have at least a minimal coding style ?

2007-08-06 Thread Stephan Rose
On Mon, 2007-08-06 at 10:37 +0200, Roderick Colenbrander wrote: > > Or even worse (I've seen this in winex11.drv, and it took me quite a > > long time until I understood it - it was part of a larger block with a > > lot these constructs): > > > > if (cond) do_sth(); > > do_sth_else(); > > > >

Re: Can we please have at least a minimal coding style ?

2007-08-06 Thread Roderick Colenbrander
> Or even worse (I've seen this in winex11.drv, and it took me quite a > long time until I understood it - it was part of a larger block with a > lot these constructs): > > if (cond) do_sth(); > do_sth_else(); > I think you are speaking about the opengl code there. There are quite a number o

Re: Can we please have at least a minimal coding style ?

2007-08-06 Thread H. Verbeet
On 06/08/07, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > This type of construct seems popular in the wine source: > > while (isspace(*GL_Extensions)) GL_Extensions++; > Start = GL_Extensions; > Other than the questionable variable naming I see nothing wrong with that construction? > Or even worse