Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value

2007-08-03 Thread Nigel Liang
On 8/3/07, Evan Stade <[EMAIL PROTECTED]> wrote: > On 8/3/07, Nigel Liang <[EMAIL PROTECTED]> wrote: > > diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c > > index 84dd4c8..05f322c 100644 > > --- a/programs/winecfg/winecfg.c > > +++ b/programs/winecfg/winecfg.c > > @@ -468,11 +4

Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value

2007-08-03 Thread Evan Stade
On 8/3/07, Nigel Liang <[EMAIL PROTECTED]> wrote: > diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c > index 84dd4c8..05f322c 100644 > --- a/programs/winecfg/winecfg.c > +++ b/programs/winecfg/winecfg.c > @@ -468,11 +468,15 @@ void set_reg_key(HKEY root, const char * > > wp

Re: user32 - set_active_window uses SendMessage instead ofPostMessage for WM_ACTIVATEAPP messages.

2007-08-03 Thread Dmitry Timoshkov
"Peter Dons Tychsen" <[EMAIL PROTECTED]> wrote: 1) Yes i did testing on Windows-XP. I did it by putting together various examples and by checking with InSendMessage() for all cases. This clearly showed that WM_ACTIVATEAPP was always posted and never sent. Looks like you misunderstood the InSen

Re: Nigel Liang : winecfg: Read/write registry in unicode.

2007-08-03 Thread Nigel Liang
On 8/3/07, James Hawkins <[EMAIL PROTECTED]> wrote: > On 8/3/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > > Module: wine > > Branch: master > > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > > URL: > > http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29ae32a2e

Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.

2007-08-03 Thread Peter Dons Tychsen
Hello again, 1) Yes i did testing on Windows-XP. I did it by putting together various examples and by checking with InSendMessage() for all cases. This clearly showed that WM_ACTIVATEAPP was always posted and never sent. 2) Yes, i tested with the msg.c test-cases. The patch does "break" some test

Re: gdi32: don't print fixme more than once

2007-08-03 Thread Robert Shearman
Evan Stade wrote: diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c index 9e7684b..2b4d03f 100644 --- a/dlls/gdi32/enhmetafile.c +++ b/dlls/gdi32/enhmetafile.c @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord( case EMR_EXTSELECTCLIPRGN: { +static int e

Re: Nigel Liang : winecfg: Read/write registry in unicode.

2007-08-03 Thread James Hawkins
On 8/3/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Module: wine > Branch: master > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29ae32a2e863273fe > > Author: Nigel Liang <[EMAIL PROTECTED]> > Date: T

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes

2007-08-03 Thread Stefan Dösinger
Am Freitag, 3. August 2007 18:18 schrieb H. Verbeet: > You are now executing that code multiple times. + This->baseTexture.states[WINED3DTEXSTA_MIPFILTER] = samplerStates[WINED3DSAMP_MIPFILTER]; + This->baseTexture.states[WINED3DTEXSTA_MINFILTER] = samplerStates[WINED3DSAMP_MINFILTER]; + This->ba

Re: [1/5] D3D9: Deal with failing surface creation

2007-08-03 Thread H. Verbeet
On 03/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > +ok(SUCCEEDED(hr) || hr == D3DERR_INVALIDCALL, > "IDirect3DDevice9_CreateTexture: %s\n", DXGetErrorString9(hr)); Same comment as for yesterday's test (even though that one apparently made it in), I don't think that's a useful test.

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes

2007-08-03 Thread H. Verbeet
You are now executing that code multiple times.

Re: Lostwages : contributing.diff

2007-08-03 Thread Jeremy White
Hi Tom, Thanks for thinking of this; I think James would appreciate it if he wasn't listed by name, though. Otherwise, though, it looks great. Cheers, Jeremy Tom Wickline wrote: > Hello, > > I'm CC: Jeremy White in on this patch, if possible I would like to ask > for his approval on the patch

[Fwd: [winetest] New gather script]

2007-08-03 Thread Paul Vriens
Hi, Forgot to include wine-devel. Original Message Subject: [winetest] New gather script Hi Ferenc, Could you have a look at the new 'gather' script? (you're the original author after all). The new winetest (when committed of course) executable will report when a test is mis

Re: msvcrt40.dll

2007-08-03 Thread Alexandre Julliard
[EMAIL PROTECTED] writes: > Nevertheless, msvcirt.dll is not currently one of the files to be ported, > i.e., dlls/msvcirt does not exist. > My questions are: > 1. Can we add the forward to all the rest of the functions in the > msvcrt40.dll spec file to msvcirt.dll? > 2. Should we first add a win

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-03 Thread Hans Leidekker
On Thursday 02 August 2007, Jacek Caban wrote: > I agree that such a big code duplication is ugly, but that's the > way to go. We may separate the common code to different files in wininet > and keep them in sync with winhttp. This way it shouldn't be too hard to > implement most of the functi