Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.

2007-08-02 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: Hello Wine. On original Windows, the messages WM_ACTIVATEAPP are sent using PostMessage() and not SendMessage() like in the current Wine implementation. I have thoroughly verified that this is the case on Windows-XP (that it uses PostMessage()). This error can lead

[PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.

2007-08-02 Thread Misha Koshelev
> Hi Misha, > > Misha Koshelev wrote: > > This simplifies the code a bit by getting rid of an enum and a > > corresponding variable in the IBinding > > implementation, as we can successfully use the bscf values that are passed > > to report_data to get all > > the information. > > > > Additiona

Re: Patch: VarWeekdayName

2007-08-02 Thread James Hawkins
On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote: > On Fri, 03 Aug 2007 01:43:05 +0200, James Hawkins <[EMAIL PROTECTED]> > wrote: > > > On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote: > >> On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> > >> wrote: > >> > >> >> Thank you. Hop

Re: Patch: VarWeekdayName

2007-08-02 Thread Jiří Paleček
On Fri, 03 Aug 2007 01:43:05 +0200, James Hawkins <[EMAIL PROTECTED]> wrote: On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote: On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> wrote: >> Thank you. Hope it will be better this time. Also, I'll send a test >> if this is OK.

Re: Patch: VarWeekdayName

2007-08-02 Thread James Hawkins
On 8/2/07, Jiří Paleček <[EMAIL PROTECTED]> wrote: > On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> wrote: > > >> Thank you. Hope it will be better this time. Also, I'll send a test > >> if this is OK. > > > > This one looks pretty good to me, but I have one error and a few nits

Re: Patch: VarWeekdayName

2007-08-02 Thread Jiří Paleček
On Thu, 02 Aug 2007 16:06:44 +0200, Juan Lang <[EMAIL PROTECTED]> wrote: Thank you. Hope it will be better this time. Also, I'll send a test if this is OK. This one looks pretty good to me, but I have one error and a few nits to correct: The error: + { +ERR("GetLocaleInfo of 0x%x failed

Re: wine3d3: Check the destination recangle when for FastBlt().

2007-08-02 Thread Peter Dons Tychsen
On Mon, 2007-07-30 at 22:18 +0200, Peter Dons Tychsen wrote: > On Sun, 2007-07-29 at 23:08 +0200, Stefan Dösinger wrote: > > Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: > > > Hello Wine! > > > > > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > > > appli

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Peter Dons Tychsen
On Fri, 2007-08-03 at 01:02 +0200, Peter Dons Tychsen wrote: > On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote: > > Peter Dons Tychsen wrote: > > > On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: > > >> Peter Dons Tychsen wrote: > > >>> On Tue, 2007-07-31 at 06:34 -0600, Vitali

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Peter Dons Tychsen
On Thu, 2007-08-02 at 06:54 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: > >> Peter Dons Tychsen wrote: > >>> On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: > Peter Dons Tychsen wrote: > > On Mon, 2007

Bug introduced in 0.9.42 in printer dialog

2007-08-02 Thread Christian Pradelli
A bug was introduced in version 0.9.42, that makes printer dialogs to not work. When you press Accept button in the printer dialog the I receive the followin error: fixme:commdlg:PRINTDLG_UpdatePrintDlgA No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandA Update printdlg was not successful! Should I

Re: [PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.

2007-08-02 Thread Jacek Caban
Hi Misha, Misha Koshelev wrote: This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding implementation, as we can successfully use the bscf values that are passed to report_data to get all the information. Additionally, the original implementation

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-02 Thread Jacek Caban
Hans Leidekker wrote: We should be able to implement more than 95% of this dll by wrapping/forwarding to wininet. That's better than many other dlls in Wine and we're already seeing regressions in apps trying to use our stub winhttp. And when we'll find an app (I'm sure we will) that uses th

Re: WGL: GetPixelFormat fix for offscreen formats

2007-08-02 Thread Kuba Ober
On Thursday 02 August 2007, Tomas Carnecky wrote: > from the patch: > > return physDev->current_pf; > + TRACE("(%p): returns %d\n", physDev, physDev->current_pf); > } > > What's the purpose of that TRACE() ? Copy/paste bug? Cheers, Kuba

Re: WGL: GetPixelFormat fix for offscreen formats

2007-08-02 Thread Tomas Carnecky
from the patch: return physDev->current_pf; + TRACE("(%p): returns %d\n", physDev, physDev->current_pf); } What's the purpose of that TRACE() ? tom

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-02 Thread Hans Leidekker
On Thursday 02 August 2007 20:19:52 Robert Shearman wrote: > We shouldn't be implementing winhttp on top of wininet as there are > functions such as WinHttpSetCredentials > (http://msdn2.microsoft.com/en-us/library/Aa384112.aspx) that can't be > implemented on top of wininet functions. Why not

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.

2007-08-02 Thread Robert Shearman
Hans Leidekker wrote: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet. We shouldn't be implementing winhttp on top of wininet as there are functions such as WinHttpSetCredentials (http://msdn2.microsoft.com/en-us/library/Aa384112.aspx) that can't be implemented

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Kuba Ober
> Is there a formal process for reviewing an arguably incompetent > bugzilla staffer? Obviously it wouldn't be to submit their name as a > bug. But is there any defined administrative layer that concerns > itself with people on that level who are dragging on the project? >

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Kuba Ober
On Thursday 02 August 2007, Chris Morgan wrote: > > Rewriting: > > > > We can conclude that VM was distracted first by the mention of the > > ies4lin and second by attempts to attribute the problem to ies4lin, and > > that, because of these distractions, he was unable to assess properly the > > iss

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Alex Waite
Chris Morgan wrote: On 8/2/07, Kuba Ober <[EMAIL PROTECTED]> wrote: On Wednesday 01 August 2007, Vitaliy Margolen wrote: Whit Blauvelt wrote: Hi, Is there a formal process for reviewing an arguably incompetent bugzilla staffer? Obviously it wouldn't be to submit their name as a bug. But is th

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported

2007-08-02 Thread Stefan Dösinger
Am Donnerstag, 2. August 2007 13:57 schrieb H. Verbeet: > On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > > If the return value is irrelevant though, what's the point of the test? > > > > I want to catch all the possible return values from windows drivers, even > > if it's just for docu

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Chris Morgan
> Rewriting: > > We can conclude that VM was distracted first by the mention of the ies4lin and > second by attempts to attribute the problem to ies4lin, and that, because of > these distractions, he was unable to assess properly the issue at hand. One > also concludes that VM over-relied on the fe

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Chris Morgan
On 8/2/07, Kuba Ober <[EMAIL PROTECTED]> wrote: > On Wednesday 01 August 2007, Vitaliy Margolen wrote: > > Whit Blauvelt wrote: > > > Hi, > > > > > > Is there a formal process for reviewing an arguably incompetent bugzilla > > > staffer? Obviously it wouldn't be to submit their name as a bug. But i

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Kuba Ober
> We can conclude that VM was distracted first by the mention of the ies4lin > and second by attempts to attribute the problem to ies4lin, and that, > because of these distractions, he was unable to assess properly the issue > at hand. One also concludes that VM over-relied on the features of the >

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Kuba Ober
> > > Is there a formal process for reviewing an arguably incompetent > > > bugzilla staffer? > > To spare everyone time and to skip directly to an entertainment see bug > > 9147: http://bugs.winehq.org/show_bug.cgi?id=9147 > I agree with Whit. Most of your writing in that bug report would be in

Re: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread Kuba Ober
On Wednesday 01 August 2007, Vitaliy Margolen wrote: > Whit Blauvelt wrote: > > Hi, > > > > Is there a formal process for reviewing an arguably incompetent bugzilla > > staffer? Obviously it wouldn't be to submit their name as a bug. But is > > there any defined administrative layer that concerns i

Re: Patch: VarWeekdayName

2007-08-02 Thread Juan Lang
> Thank you. Hope it will be better this time. Also, I'll send a test > if this is OK. This one looks pretty good to me, but I have one error and a few nits to correct: The error: + { +ERR("GetLocaleInfo of 0x%x failed in 2nd stage?!\n", localeValue); +SysFreeString(*pbstrOut); You shou

RE: Is there a process for reviewing a bugzilla staffer?

2007-08-02 Thread EA Durbin
I don't think we need to be rude and poke fun at new wine users by pointing out their mistakes to everyone. He may someday prove to be a valuable asset to the project, or may be driven off from contributing altogether because a dev/admin had to point out his errors for "entertainment" purposes.

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Christoph Frick
On Thu, Aug 02, 2007 at 06:54:12AM -0600, Vitaliy Margolen wrote: > >OK, so how do i force my system to use the other implementation (so i > >can test it) ? > >I have a Logitech WingMan Extreme (old version). > Just (re)move /dev/input/js*. Or in dinput change device name to point to > non-existe

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-08-02 Thread Vitaliy Margolen
Peter Dons Tychsen wrote: On Tue, 2007-07-31 at 20:05 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Tue, 2007-07-31 at 06:34 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 17:43 -0600,

Re: Direct3D Game test framework

2007-08-02 Thread Stefan Dösinger
> To make this useful, we need to solve 'DirectX detection failed' bug, so we > can run real tests nightly. Could you send me ~/.wine directory you are > using with latest WineHq? Do you have HKCU/Software/Wine/Direct3D/DirectDrawRenderer set to "gdi" perhaps? This disables D3D support altogether.

Re: Direct3D Game test framework

2007-08-02 Thread martin pilka
Hello Stefan! > It is without CxTest and without VNC. I do have HW acceleration and OpenGL > (GLX) enabled. Attached is output of xdpyinfo. > > I am going to try whether 3DMark2001 works. 3DMark2001 behaves the same way. Note this is long lasting bug, I remember on WineConf 2006 I was able to r

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported

2007-08-02 Thread H. Verbeet
On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: >+ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, That doesn't do what you want it to do. If the return value is irrelevant though, what's the point of the test?

Re: [5/5] D3D9: Check for volume texture support before running the volume test

2007-08-02 Thread Stefan Dösinger
Am Donnerstag, 2. August 2007 13:53 schrieb H. Verbeet: > On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > +if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { > > That doesn't check for volume textures. oops again... :-|

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported

2007-08-02 Thread H. Verbeet
On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > If the return value is irrelevant though, what's the point of the test? > I want to catch all the possible return values from windows drivers, even if > it's just for documentation purposes. That doesn't seem very useful if there are no ac

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported

2007-08-02 Thread Stefan Dösinger
Am Donnerstag, 2. August 2007 13:41 schrieb H. Verbeet: > On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > >+ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, > > That doesn't do what you want it to do. oops... > If the return value is irrelevant though, what's the poi

Re: [5/5] D3D9: Check for volume texture support before running the volume test

2007-08-02 Thread H. Verbeet
On 02/08/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > +if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { That doesn't check for volume textures.

dwarf2_parse_udt_type Unhandled Tag type 0x16

2007-08-02 Thread Robert Reif
I get tons of these sometimes when a program crashes: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x16 at ctx(0x34ec70,L"kernel32"), for debug_info(abbrev:0x17ab04,symt:0xe24ee4) which makes debugging difficult.

re: OT: Everyone at minnesota ok?

2007-08-02 Thread Dan Kegel
I checked with Jeremy six hours ago and he said he hadn't heard of any of his folks being involved, whew. I've driven over that bridge a lot myself, and my father in law drove over it an hour before the collapse. There's a video of the collapse at http://edition.cnn.com/2007/US/08/02/bridge.colla

Re: mshtml #2: Make get_typeinfo thread safe.

2007-08-02 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > } > + > +tl = InterlockedExchangePointer((void**)&typelib, tl); > + > +if(tl) > +ITypeLib_Release(tl); That's not thread-safe. You need to use InterlockedCompareExchangePointer. -- Alexandre Julliard [EMAIL PROTECTED

OT: Everyone at minnesota ok?

2007-08-02 Thread Shachar Shemesh
For those who have not head, there was a lethal bridge collapse and there are several casualties. Codeweavers is located near there. Just wanted to make sure everyone is ok. Shachar

msvcrt40.dll

2007-08-02 Thread luis . busquets
Dear all, In relation to the file msvcrt40.dll File Version 5.1.2600.2180 Product Version 5.1.2600.2180 This file has been transformed and forwards all of its calls to either msvcrt.dll or msvcirt.dll The forwards to msvcrt.dll are set in the current wine msvcr40.spec but the rest of the function