Re: [Resend PATCH 2/2] gdi32: Do not fill in the color tableiflpvBits is NULL

2007-07-13 Thread Dmitry Timoshkov
"Jeremy White" <[EMAIL PROTECTED]> wrote: p.s. While I'm coming clean, *another* failure on my part was to fail to credit Huw; this is mostly his insight. I provided the clue, and the hopeless failure to get a clean patch in :-/. Since you are going to resend the patch anyway please add a mis

Re: programs/winefontcfg: Add winefontcfg (try 3)

2007-07-13 Thread Dan Kegel
Nigel wrote: Is there a way you can get the path to the currently running instance instead of hardcoding it? Then it would work even if winefontcfg isn't on the PATH. +GetFullPathNameW(exename, MAXSTRLEN, szFullPathName, NULL); That just prepends the current directory onto the given filen

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Jan Zerebecki
The usual disclaimer, IANAL, yadda yadda. On Fri, Jul 13, 2007 at 10:55:38PM +0200, Stefan Dösinger wrote: > Hypothetial: > Assumed ddraw.dll was signed by Microsoft. Now we have an app that checks for > this signature, and refuses to run otherwise. This app is not part of wine, > and it is not

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Kai Blin
On Friday 13 July 2007 18:23:32 Michael Stefaniuc wrote: > Ian Macfarlane wrote: > > - Samba has decided to become GPL3+ only, as they want the added > > > > protections provided by the license. WINE and Samba seem like projects > > that may potentially wish to share code (a very quick search bri

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Stefan Dösinger
Am Freitag, 13. Juli 2007 17:22 schrieb Kai Blin: > What specifically are we waiting for? Until the GPLv3 is tested in court? > Until someone TiVolizes Wine? Christmas? Some possible TiVolization of wine I have brought up on #winehackers with third party signatures: Hypothetial: Assumed ddraw.dll

RE: [Resend PATCH 2/2] gdi32: Do not fill in the color table iflpvBits is NULL

2007-07-13 Thread Jeremy White
> The patch mixes tabs and spaces. Also, in general, I don't think we > should include text from MSDN. *blush*. Teach me to edit this on a test machine, without my .vimrc... I'll tweak the comment, but I felt it was important to motivate the if statement; I don't feel that it's obvious from the

Re: unsuspected success in tests/monthcal?

2007-07-13 Thread Lei Zhang
Committish 7495d changed the rendering of the calendar. Just by chance, the coordinates used in the hit test now lands on a spot that passed the hit test. On 7/13/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: Marcus Meissner wrote: > For some days I now get unexpected successes in > dlls/comc

Re: [Resend PATCH 2/2] gdi32: Do not fill in the color table if lpvBits is NULL

2007-07-13 Thread H. Verbeet
On 13/07/07, Jeremy White <[EMAIL PROTECTED]> wrote: --- dlls/gdi32/dib.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) The patch mixes tabs and spaces. Also, in general, I don't think we should include text from MSDN.

Re: [msi/tests] Remove the whole directory after the test

2007-07-13 Thread Paul Vriens
James Hawkins wrote: On 7/13/07, Paul Vriens <[EMAIL PROTECTED]> wrote: Hi, RemoveDirectory only removes empty directories. Changelog Remove the whole directory after the test No, this is wrong. The line above, CreateDirectory("msitest\\msitest", NULL); is what needs to be removed.

Re: programs/net: Add russian resources

2007-07-13 Thread Dmitry Timoshkov
"Konstantin Kondratyuk" <[EMAIL PROTECTED]> wrote: Changelog: add russian resources in programs/net Did you test this translation? You are using KOI8-R which won't work properly in russian resources. -- Dmitry.

Re: winedump: Cast-qual warnings fix

2007-07-13 Thread Andrew Talbot
David Laight wrote: > And I'm not sure that the compiler is required to treat the two > fields of the union as being the same data item. > Certainly if the fields of the union are 'void *' and 'intptr_t' > you can't assume that a value written to one field of the union > can be immediately read fr

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Tomas Kuliavas
>> Code licensed under BSD is not compatible with GPLv2. They can't include >> GPLv2 code in codebase licensed under BSD. So there is no difference >> between GPLv2 and GPLv3 for BSD people. > > BSDv2 is compatible with all versions of the GPL. Very little code is > left floating around under the o

Re: [msi/tests] Remove the whole directory after the test

2007-07-13 Thread James Hawkins
On 7/13/07, Paul Vriens <[EMAIL PROTECTED]> wrote: Hi, RemoveDirectory only removes empty directories. Changelog Remove the whole directory after the test No, this is wrong. The line above, CreateDirectory("msitest\\msitest", NULL); is what needs to be removed. -- James Hawkins

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Steven Edwards
On 7/13/07, Tomas Kuliavas <[EMAIL PROTECTED]> wrote: Code licensed under BSD is not compatible with GPLv2. They can't include GPLv2 code in codebase licensed under BSD. So there is no difference between GPLv2 and GPLv3 for BSD people. BSDv2 is compatible with all versions of the GPL. Very litt

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Michael Stefaniuc
Ian Macfarlane wrote: > - Samba has decided to become GPL3+ only, as they want the added protections provided by the license. WINE and Samba seem like projects that may potentially wish to share code (a very quick search brings up articles like this http://www.winehq.org/?issue=272), and if WINE

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Steven Edwards
On 7/13/07, Ian Macfarlane <[EMAIL PROTECTED]> wrote: I've been meaning to ask about this since (L)GPL3 was released. I'd also like to weigh in on my reasons for liking the (L)GPLv3. The termination clause is clarified and a grace period added for compliance. As it stands right now, if someone

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Tomas Kuliavas
>> The GPL3 has no track record so far, and it's too political and >> controversial for my liking. Let's wait a while before making the >> decision. > > Many groups are exceedingly worried about parts of GPL3. > Not only commercial companies who may not have been obeying the > general spirit of the

Re: programs/winefontcfg: Add winefontcfg (try 3)

2007-07-13 Thread Dan Kegel
All in all the app looks like it's coming along nicely. I apologize for catching so few problems in each pass, but we'll get there. Is there a way you can get the path to the currently running instance instead of hardcoding it? Then it would work even if winefontcfg isn't on the PATH. +stati

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-13 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: If a message is marked as optional it can be skipped without causing the test to fail. Thank you. I did not know about it. It will help me. Here are the failures I see in http://test.winehq.org/data/200707121000/2003_W2K3-S

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-13 Thread Anatoly Lyutin
Dmitry Timoshkov пишет: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thanks. I have viewed this. It was failed on "0x00ae" messages. I could no

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-13 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: Can you send me output when you run my test on XP? It will be nice. You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thank

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Ian Macfarlane
I've been meaning to ask about this since (L)GPL3 was released. The version 3 of the (L)GPL license has numerous benefits: - It's much more legally sound in the rest of the world (IMO one of the most important factors about the new license) - numerous reasons for this e.g. referencing WIPO rathe

Re: winedump: Cast-qual warnings fix

2007-07-13 Thread David Laight
On Fri, Jul 13, 2007 at 12:29:36PM +0200, Alexandre Julliard wrote: > Andrew Talbot <[EMAIL PROTECTED]> writes: > > > + const char *iter, *base_type, *catch_unsigned; > > + union > > + { > > + const char*constant; > > + char *nonconst; > > + } type_str; > > That's not b

Re: Should Wine move to LGPL 3?

2007-07-13 Thread David Laight
On Fri, Jul 13, 2007 at 01:18:41PM +0200, Damjan Jovanovic wrote: > > The GPL3 has no track record so far, and it's too political and > controversial for my liking. Let's wait a while before making the > decision. Many groups are exceedingly worried about parts of GPL3. Not only commercial compan

Re: unsuspected success in tests/monthcal?

2007-07-13 Thread Michael Stefaniuc
Marcus Meissner wrote: For some days I now get unexpected successes in dlls/comctl32/tests/monthcal.c. ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so monthcal.c && touch monthcal.ok err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp= lp=

unsuspected success in tests/monthcal?

2007-07-13 Thread Marcus Meissner
Hi, For some days I now get unexpected successes in dlls/comctl32/tests/monthcal.c. ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so monthcal.c && touch monthcal.ok err:monthcal:MONTHCAL_WindowProc unknown msg 2006 wp= lp= err:monthca

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Kai Blin
On Friday 13 July 2007 13:18:41 Damjan Jovanovic wrote: > On 7/13/07, Tom Wickline <[EMAIL PROTECTED]> wrote: > > Why shouldn't Wine move? > > LGPL3 = GPL3 + additional permissions: > "This version of the GNU Lesser General Public License incorporates > the terms and conditions of version 3 of the

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-13 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: I have asked that I can not understand why in test expected and obtained message does not coincide and test does not fail. Ex.: msg.c:3285:expected 0008 - actual 0008 msg.c:3285:expected 0281 - actual 0007 msg.c:3285:expected 0281 - actual 0007 msg.c:

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-13 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: You can find the results of the test run under XP here: http://test.winehq.org/data/200707121000/xp_XP-PRO-IE7/user32:msg.txt I get the same failures. Thanks. I have viewed this. It was failed on "0x00ae" messages. I could not find description of thi

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Tim Schmidt
On 7/13/07, Victor <[EMAIL PROTECTED]> wrote: Also Wine isn't just a library. (LGPL) Nor is the LGPL a license exclusively for libraries. --tim

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Victor
On Friday 13 July 2007 15:01:26 Tom Wickline wrote: > Why shouldn't Wine move? IMHO: Before changing license, there must be a really good reason to do that - for example, if application won't survive without doing so. And before change, license must be reread at least one hundred times - just to

Re: SUBLANG Rules

2007-07-13 Thread Mikołaj Zalewski
I think the best thing is for Wine to support things like LC_ALL="nn nb" LANG="nn nb" because even though we provide a Nynorsk translation, most programs will only be available in Bokmål. It seems that Vista supports many user preferred languages and many system fallback languages so it s

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Damjan Jovanovic
On 7/13/07, Tom Wickline <[EMAIL PROTECTED]> wrote: On 7/13/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Tom Wickline wrote: > > I was wondering if there are any plans in place for Wine to move to > > the newly revised LGPL 3 licence before the release of 1.0? > > > > http://www.gnu.org/lic

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Tom Wickline
On 7/13/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: Tom Wickline wrote: > I was wondering if there are any plans in place for Wine to move to > the newly revised LGPL 3 licence before the release of 1.0? > > http://www.gnu.org/licenses/lgpl.html Why should Wine move? Why shouldn't Wine move

Re: winedump: Cast-qual warnings fix

2007-07-13 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > + const char *iter, *base_type, *catch_unsigned; > + union > + { > + const char*constant; > + char *nonconst; > + } type_str; That's not better than simply casting const away, it's just hiding the problem from the compiler. -

Re: programs/winefontcfg: Add winefontcfg (try 3)

2007-07-13 Thread Paul Vriens
Nigel Liang wrote: Hi, Some changes suggested by Dan. Changelist: - Initialize non-static local arrays at runtime or make them static - Use CompareStringW to do case-insensitive comparison - Initialize some static variables before use and clear them after - Rename a global variable - Move some

Re: Should Wine move to LGPL 3?

2007-07-13 Thread Michael Stefaniuc
Tom Wickline wrote: I was wondering if there are any plans in place for Wine to move to the newly revised LGPL 3 licence before the release of 1.0? http://www.gnu.org/licenses/lgpl.html Why should Wine move? bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Net

Re: Proposal to phase out *winehq.com email addresses

2007-07-13 Thread Stefan Dösinger
Am Freitag, 13. Juli 2007 10:44 schrieb Robert Shearman: > Stefan Dösinger wrote: > > OK with me. The dual address thing is also confusing for everyone who > > sets up his own filters in the mailer, mostly to sort out mails into > > different folders. > > You should sort on the List-Id header inste

Re: Proposal to phase out *winehq.com email addresses

2007-07-13 Thread Robert Shearman
Stefan Dösinger wrote: Am Donnerstag, 12. Juli 2007 23:39 schrieb Duane Clark: Due to the rather large amount of spam sent to the *winehq.com email addresses (as opposed to *winehq.org), I would like to phase them out. I will state up front that this proposal benefits only me or any future mo