Re: programs/winefontcfg: Add winefontcfg

2007-07-11 Thread Dan Kegel
On 7/11/07, Nigel Liang (梁乃強) <[EMAIL PROTECTED]> wrote: Sent in try 2: http://www.winehq.org/pipermail/wine-patches/2007-July/041356.html Not all the locals in FontLinkListBoxWndProc really need to be static. (e.g. 'dst') Those that really need to be static should probably be initialized to

Re: programs/winefontcfg: Add winefontcfg

2007-07-11 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to put them in the .c file if they're not used by multipl

ANNOUNCE: Wine/Mono Regression Test Suite

2007-07-11 Thread Matt Jones
Hi Everyone - I'm working on getting mono to run happily under wine, thus opening wine (& linux) up to a much larger range of .NET applications. Unfortunately, mono-under-wine fails in rather cryptic ways at the moment, so I've found that running the mono regression test suite has given me a bett

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-11 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: /* test for switch maximized MDI children */ +ShowWindow(mdi_client, SW_SHOW); trace("creating maximized visible MDI child window 1(Switch test)\n"); mdi_child = CreateWindowExA(WS_EX_MDICHILD, "MDI_child_class

Re: shlwapi: Use publicly defined structure DATABLOCK_HEADER instead of redefining it locally

2007-07-11 Thread James Hawkins
On 7/11/07, Thomas Weidenmueller <[EMAIL PROTECTED]> wrote: Update the datablock list code to use the DATABLOCK_HEADER structure defined in shlobj.h rather than re-defining it locally. - Thomas You forgot the patch. -- James Hawkins

Re: winex11.drv: send proper file path for drag and drop

2007-07-11 Thread Lei Zhang
On 7/11/07, Damjan Jovanovic <[EMAIL PROTECTED]> wrote: On 7/11/07, Lei Zhang <[EMAIL PROTECTED]> wrote: > Hi, > > Drag and drop currently sends the file path as "\path\to\file" which > does not work properly for some applications. This patch converts the > file path to a proper Windows file path

Performance testing experiences

2007-07-11 Thread Stefan Dösinger
Hi, In the past days I've been actively hacking on automated performance testing. I have test scripts for Half Life 2, 3Dmark2000 and 3dmark2001 and a small z buffer test app. I am playing around with UT2004 and I want to take a look at plain old unreal tornament. I have the tests running on my

re: programs/winefontcfg: Add winefontcfg

2007-07-11 Thread Dan Kegel
I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to put them in the .c file if they're not used by multiple files.

Re: Make visible mdi client window before as Switch Maximized MDI Children test will be activated. [try2]

2007-07-11 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: /* test for switch maximized MDI children */ +ShowWindow(mdi_client, SW_SHOW); trace("creating maximized visible MDI child window 1(Switch test)\n"); mdi_child = CreateWindowExA(WS_EX_MDICHILD, "MDI_child_class", "MDI child",

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Anatoly Lyutin
Alexandre Julliard wrote: Anatoly Lyutin <[EMAIL PROTECTED]> writes: This test only shows correct work GetShortPathNameW with latin and non Latin charsets. The Cyrillic locale is chosen only as locale with non Latin symbols. Since you are testing the Unicode function, why would non-La

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Anatoly Lyutin
Alexandre Julliard wrote: Anatoly Lyutin <[EMAIL PROTECTED]> writes: +if ( GetThreadLocale() == CyrLCID ) +{ +/* Create directory with Cyrillic long name */ +helper_GetShortPathNameW( pathRL ); + +/* Create directory with Cyrillic short name */ +helpe

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Anatoly Lyutin
Alexandre Julliard wrote: Anatoly Lyutin <[EMAIL PROTECTED]> writes: Only that this code conversion will be correct. Although I understand that it is for Unicode does not matter. It is only additional test. Yes but it's useless. Please get rid of the Russian chars and try to write a

Re: bug triaging

2007-07-11 Thread Jan Zerebecki
On Mon, Jul 09, 2007 at 06:00:37PM -0700, Austin English wrote: > I too, lack the permissions to triage bugs. But I'll leave that > for the devs to decide. I don't know you so I'll wait a bit more... > I just have quite a bit of spare time to debug, along with a > few machines to do the testing.

Re: msi: Add tests for adding properties with a transform during an install

2007-07-11 Thread Paul Vriens
James Hawkins wrote: Hi, Changelog: * Add tests for adding properties with a transform during an install. dlls/msi/tests/install.c | 235 ++ include/msiquery.h |5 + 2 files changed, 240 insertions(+), 0 deletions(-) -

Re: bug triaging

2007-07-11 Thread Jan Zerebecki
On Mon, Jul 09, 2007 at 01:53:41PM -0700, Scott Ritchie wrote: > Don't got permission to do that. At least, not since last I checked. > > Speaking of which, I'd like bugzilla permissions to be a triager. Done. Jan

Re: [Resubmit]: Added wrapper dll for ct-api(CardTerminal API)

2007-07-11 Thread Alexandre Julliard
"Christian Eggers" <[EMAIL PROTECTED]> writes: > +#ifndef SONAMES_LIBCTAPI > +#define SONAMES_LIBCTAPI > "libctapi.so","libctapi-cyberjack.so.1","libct.so","libctdeuti.so.5" > +#endif There should be a registry key to specify the library to load instead of a hardcoded list. If the key is not set

Re: Direct3D Game test framework

2007-07-11 Thread Dan Kegel
Martin wrote: YAWT looks interesting Thanks! If you need any changes in it, ask Lei (or ask me to ask Lei). I also had a look to AutoHotKey, and its language seems to solve some of the problems we have with CxTest scripts (double click, better support for menus, better conditioning). It is

Re: configure complains about liblcms not being there

2007-07-11 Thread Paul Vriens
Hans Leidekker wrote: On Wednesday 11 July 2007, Alexandre Julliard wrote: It's the first time I actually looked deeper into configure.ac/configure so bear with me. This part look suspicious in configure.ac: 832 WINE_NOTICE_IF([test "$ac_cv_lib_lcms_cmsOpenProfileFromFile" = "yes"],[liblcms d

Re: configure complains about liblcms not being there

2007-07-11 Thread Hans Leidekker
On Wednesday 11 July 2007, Alexandre Julliard wrote: > > It's the first time I actually looked deeper into configure.ac/configure so > > bear > > with me. This part look suspicious in configure.ac: > > > > 832 WINE_NOTICE_IF([test "$ac_cv_lib_lcms_cmsOpenProfileFromFile" = > > "yes"],[liblcms de

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Alexandre Julliard
Anatoly Lyutin <[EMAIL PROTECTED]> writes: > Only that this code conversion will be correct. Although I understand > that it is for Unicode does not matter. It is only additional test. Yes but it's useless. Please get rid of the Russian chars and try to write a more meaningful test that works in

Re: [1/10] gdiplus: moved two helpers to gdiplus.c

2007-07-11 Thread Alexandre Julliard
"Evan Stade" <[EMAIL PROTECTED]> writes: > +inline INT roundr(REAL x) > +{ > +return (INT) floorf(x + 0.5); > +} > + > +inline REAL deg2rad(REAL degrees) > +{ > +return M_PI * degrees / 180.0; > +} If you want them to be inlined they should be defined in the header file. -- Alexandre Ju

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Alexandre Julliard
Anatoly Lyutin <[EMAIL PROTECTED]> writes: > This test only shows correct work GetShortPathNameW with latin and non > Latin charsets. The Cyrillic locale is chosen only as locale with non > Latin symbols. Since you are testing the Unicode function, why would non-Latin make any difference? Again,

Re: configure complains about liblcms not being there

2007-07-11 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > It's the first time I actually looked deeper into configure.ac/configure so > bear > with me. This part look suspicious in configure.ac: > > 832 WINE_NOTICE_IF([test "$ac_cv_lib_lcms_cmsOpenProfileFromFile" = > "yes"],[liblcms development files not found

Re: kernel32:tests:path.c Add test for GetShortPathNameW [try3]

2007-07-11 Thread Alexandre Julliard
Anatoly Lyutin <[EMAIL PROTECTED]> writes: > +if ( GetThreadLocale() == CyrLCID ) > +{ > +/* Create directory with Cyrillic long name */ > +helper_GetShortPathNameW( pathRL ); > + > +/* Create directory with Cyrillic short name */ > +helper_GetShortPathName

Re: kernel: use VirtualAlloc in GlobalAlloc16 to make such memory executable

2007-07-11 Thread Alexandre Julliard
Mikołaj Zalewski <[EMAIL PROTECTED]> writes: > This patch is not enough to run Win16 programs on NX protected > systems as there is also some code placed in the UMB by > winedos/himem.c. I have a patch that makes the DOS area executable > (see bug #8744) but I will have to look if that's what Win

Re: winex11.drv: send proper file path for drag and drop

2007-07-11 Thread Damjan Jovanovic
On 7/11/07, Lei Zhang <[EMAIL PROTECTED]> wrote: Hi, Drag and drop currently sends the file path as "\path\to\file" which does not work properly for some applications. This patch converts the file path to a proper Windows file path, i.e. z:\path\to\file. I'm not sure we should even be trying

Fw: shell32: implementation of SheGetDirA/W and SheChangeDirA/W

2007-07-11 Thread Martin Fuchs
Hi, any hint why this patch was not yet applied? Regards, Martin On 13.05.2007 19:04:25 Martin Fuchs wrote: Changelog: implement SheGetDirA/W and SheChangeDirA/W in shell32 This functions are needed for the good old winfile.exe of NT4. Index: dlls/shell32/shlfileop.c =