On 6/23/07, James Hawkins <[EMAIL PROTECTED]> wrote:
On 6/23/07, Andrew Talbot <[EMAIL PROTECTED]> wrote:
> This patch should fix Coverity bug CID-562.
>
> -- Andy.
> ---
> Changelog:
> msi: Fix use of uninitialized variable (Coverity).
>
> diff -urN a/dlls/msi/action.c b/dlls/msi/action.c
> --
On 6/23/07, James Hawkins <[EMAIL PROTECTED]> wrote:
Or how about adding some magic to the ML where any reply to wine-bugs
gets added as a comment to the bug report? Web programming isn't my
specialty, so I don't know if this if feasible or possible, but it
seems like the best solution to the pr
On 6/23/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
"Damjan Jovanovic" <[EMAIL PROTECTED]> writes:
> With FindFirstChangeNotification() and FindNextChangeNotification()
> you don't even have to poll, and those are implemented on wineserver
> using inotify, so it's very efficient.
Except i
On 6/23/07, Adam Petaccia <[EMAIL PROTECTED]> wrote:
If there are any SkyOS developers lurking about, I know some people
that developed a SkyOS to win32 wrapper that allowed you to run some
simple SkyGI apps on Windows. It might be a good place to start if you
want to take a look at what primitiv
James Hawkins wrote:
>
> Please don't check env for NULL; RegCloseKey will just fail harmlessly
> if env is NULL. We spent a lot of time removing such checks.
>
OK, I shall re-post my first effort as "Try 3".
--
Andy.
On 6/23/07, Andrew Talbot <[EMAIL PROTECTED]> wrote:
This patch should fix Coverity bug CID-562.
-- Andy.
---
Changelog:
msi: Fix use of uninitialized variable (Coverity).
diff -urN a/dlls/msi/action.c b/dlls/msi/action.c
--- a/dlls/msi/action.c 2007-06-18 17:52:27.0 +0100
+++ b/dlls/
On 6/22/07, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote:
Lørdag 23 juni 2007 01:13, skrev Tom Spear:
> Just curious how trivial it would be to add a note to the bugzilla
> mail template saying to post replies to comments in the bug?
>
> Something like the following:
>
>
>
> A bug you ar
On Fri, 2007-06-22 at 22:56 -0400, Tom Wickline wrote:
> Hello All,
>
> Looks as if SkyOS will soon support Wine!
But I don't think it supports the graphical aspects of wine, just
command line and the infrastructure, if I recall correctly.
> Internals
> - Many kernel updates like LDT support (re
On 6/21/07, Ben Hodgetts (Enverex) <[EMAIL PROTECTED]> wrote:
I've done some heavy modifications and additions to the Wiki FAQ and
it's now the "YOU MUST READ THIS NOW!" document pointed to by the
#winehq IRC channel so I agree. It's also impossible to edit the old FAQ
easily anyway. Some users h
Paul Vriens wrote:
> Wouldn't it be easier to set env to NULL when declaring it and do a:
>
> if (env) RegCloseKey(env);
>
> Cheers,
>
> Paul.
Indeed it would! I shall submit a vastly simplified retry, accordingly. :)
--
Thanks,
Andy.
Andrew Talbot wrote:
This patch should fix Coverity bug CID-562. Additionally, I have pinpointed
another suspected use-before-initialization bug, for future consideration.
-- Andy.
---
Changelog:
msi: Fix use of uninitialized variable (Coverity).
Wouldn't it be easier to set env to NULL w
Tom Spear wrote:
> At the risk of looking like an idiot, I'll take a stab at this.. If
> you RegCloseKey on env, and it is not initialized, then RegCloseKey
> will generate ERROR_INVALID_HANDLE, so I personally think that
> something like the first approach would be the better one to go with.
> e
"Damjan Jovanovic" <[EMAIL PROTECTED]> writes:
> With FindFirstChangeNotification() and FindNextChangeNotification()
> you don't even have to poll, and those are implemented on wineserver
> using inotify, so it's very efficient.
Except it doesn't work on many platforms, so it can't be the standar
13 matches
Mail list logo