Re: wine menus

2007-06-21 Thread Tom Spear
I actually did some testing behind .lnk functionality (unscientific testing, that is) with wine a few months ago. Xorg actually fully supports Windows' .lnk files with 2 minor annoyances.. The .lnk files could theoretically be used as the links in the menus if these 2 annoyances could be fixed (

wine menus

2007-06-21 Thread Damjan Jovanovic
Hi At the moment, wine builds fd.o menus by calling winemenubuilder and wineshelllink when shell32's IPersistFile_fnSave is invoked. This both misses menus copied directly into the menu directory without calling IPersistFile_fnSave, and provides no way to remove the menus when the app is uninstal

gdiplus: graphics tests [try2]

2007-06-21 Thread Misha Koshelev
> Am Freitag, 15. Juni 2007 22:02 schrieb Jan Zerebecki: > > On Fri, Jun 15, 2007 at 01:36:09PM +0200, Alexandre Julliard wrote: > > > "Evan Stade" writes: > > > > +static const INT drawline_bmp1[192] = > > > > +{0x,0x,0x,0x,0x,0x,0xf > > > >fff,

Re: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.

2007-06-21 Thread Misha Koshelev
On Thu, 2007-06-21 at 16:11 +0200, Alexandre Julliard wrote: > Misha Koshelev <[EMAIL PROTECTED]> writes: > > > This sends proper position information to the GDI driver when we are > > emulating these functions. > > I don't think I agree with this one. If the driver needs to update the > positio

re: [1/2] oleaut32: add PNG loading [try2]

2007-06-21 Thread Dan Kegel
Alexandre wrote: How can I improve this patch such that it will be accepted? The biggest problem is that the libpng versioning scheme is broken, so we can't find the proper soname. This will need some more configure magic. Looking at http://www.libpng.org/pub/png/libpng.html and http://www.l

Re: Making the wiki FAQ live

2007-06-21 Thread Ben Hodgetts (Enverex)
I've done some heavy modifications and additions to the Wiki FAQ and it's now the "YOU MUST READ THIS NOW!" document pointed to by the #winehq IRC channel so I agree. It's also impossible to edit the old FAQ easily anyway. Some users have been confused though finding two FAQs on the site, so th

Re: PATCH - implement LockWorkStation using xdg-screensaver on Linux

2007-06-21 Thread Detlef Riekenberg
On Di, 2007-06-19 at 22:55 +0200, Alexandre Julliard wrote: > No, it should lock the virtual desktop (with a fancy screensaver and > all ;-). That stuff really belongs in explorer though, not in > wineboot. Yes Please. I already punched Stefan for this, but without Success (He is to Busy ..) I

Making the wiki FAQ live

2007-06-21 Thread Scott Ritchie
So, about a month ago we discussed the idea of replacing the documentation FAQ with one based in the wiki. Nothing was done, but the general consensus seemed to be to wait and see if the wiki approach worked out better. Since that time, the Wiki FAQ has been updated by 7 people other than myself.

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Domagoj Babic
Hi, On 6/21/07, Tom Spear <[EMAIL PROTECTED]> wrote: This is true, many applications are written to work around bugs in windows. If we fix these bugs, then the apps dont have anything to work around, and therefore they do unexpected things The software development process is soo broken.

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Tom Spear
On 6/21/07, James Hawkins <[EMAIL PROTECTED]> wrote: > On 6/21/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > > The problem with NULL pointer dereferences is that those may be valid. > > If a function crashes in Windows on a NULL pointer dereference Wine > > should/has do the same. > > Why?

Coverity status

2007-06-21 Thread Paul Vriens
Hi, I've been in contact with Coverity. People currently listed as Wine contacts are: - Jan Zerebecki - Paul Vriens The main page is changed so it reflects the new scan site http://scan2.coverity.com:7479 and there has just been a new run! Coverity is very busy setting up some proper commun

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread James Hawkins
On 6/21/07, Domagoj Babic <[EMAIL PROTECTED]> wrote: Hi, On 6/21/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > The problem with NULL pointer dereferences is that those may be valid. > If a function crashes in Windows on a NULL pointer dereference Wine > should/has do the same. Why? Sever

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Domagoj Babic
Hi, On 6/21/07, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: The problem with NULL pointer dereferences is that those may be valid. If a function crashes in Windows on a NULL pointer dereference Wine should/has do the same. Why? Wine is meant to run software "written for windows". I doubt that

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Michael Stefaniuc
Dan Kegel wrote: On 6/20/07, Paul Vriens <[EMAIL PROTECTED]> wrote: Marcus also mentions a second site for Wine : http://scan2.coverity.com:7479/ instead of http://scan.coverity.com:7479/. The result are till the end of May, That's recent enough to be able to compare with Calypso, though. It

Re: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.

2007-06-21 Thread Alexandre Julliard
"Koshelev, Misha Vladislavo" <[EMAIL PROTECTED]> writes: > I will have to investigate this further on native then (I'll look > into making a fake driver that implements Arc and MoveTo but not > ArcTo, call ArcTo on that driver and see what happens). > > I don't know whether this is a valid case,

RE: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.

2007-06-21 Thread Koshelev, Misha Vladislavo
I will have to investigate this further on native then (I'll look into making a fake driver that implements Arc and MoveTo but not ArcTo, call ArcTo on that driver and see what happens). I don't know whether this is a valid case, but what I'm thinking of is a pre-Win2000 GDI driver (have to do

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Dan Kegel
On 6/20/07, Paul Vriens <[EMAIL PROTECTED]> wrote: Marcus also mentions a second site for Wine : http://scan2.coverity.com:7479/ instead of http://scan.coverity.com:7479/. The result are till the end of May, That's recent enough to be able to compare with Calypso, though. It will be interestin

Re: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.

2007-06-21 Thread Alexandre Julliard
Misha Koshelev <[EMAIL PROTECTED]> writes: > This sends proper position information to the GDI driver when we are > emulating these functions. I don't think I agree with this one. If the driver needs to update the position then it should implement ArcTo etc. since it may need to distinguish that

Re: winmm: Specify the arguments of the function in the function pointer

2007-06-21 Thread Alexandre Julliard
Michael Stefaniuc <[EMAIL PROTECTED]> writes: > @@ -114,10 +114,10 @@ static BOOLMMDRV_GetDescription32(const char* > fname, char* buf, int buflen) > DWORDdw; > BOOL ret = FALSE; > UINT u; > -FARPROC pGetFileVersionInfoSizeA; > -FARPROC pGetFileVersionInfoA

Re: [1/2] oleaut32: add PNG loading [try2]

2007-06-21 Thread Alexandre Julliard
"Evan Stade" <[EMAIL PROTECTED]> writes: > How can I improve this patch such that it will be accepted? The biggest problem is that the libpng versioning scheme is broken, so we can't find the proper soname. This will need some more configure magic. -- Alexandre Julliard [EMAIL PROTECTED]

Re: shell32: Make SHGetDesktopFolder use a cached instance of IShellFolder

2007-06-21 Thread Alexandre Julliard
Dmitry Timoshkov <[EMAIL PROTECTED]> writes: > +sf = LocalAlloc( LMEM_ZEROINIT, sizeof (IGenericSFImpl) ); > +if (!sf) > +return E_OUTOFMEMORY; > + > +if (InterlockedCompareExchangePointer((void *)&cached_sf, sf, NULL) > != NULL) > +LocalFree( sf );

Re: msi [1/6]: Add support for remote handles

2007-06-21 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > @@ -215,18 +282,28 @@ UINT WINAPI MsiCloseHandle(MSIHANDLE han > > EnterCriticalSection( &MSI_handle_cs ); > > -info = msihandle2msiinfo(handle, 0); > -if( !info ) > -goto out; > - > -if( info->magic != MSIHANDLE_MAGIC ) >

ntdll: Constify some variables (1 of 2)

2007-06-21 Thread Andrew Talbot
Please ignore this patch. Thanks, -- Andy.

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Paul Vriens
Marcus Meissner wrote: On Thu, Jun 21, 2007 at 08:40:12AM +0200, Paul Vriens wrote: Dan Kegel wrote: Say, whatever happened to Coverity's scans of Wine? I just logged in to the Wine results at http://scan.coverity.com, and the last scan seems to have been last July. Did they set up a new, pri

Re: NULL ptr dereferences found with Calysto static checker

2007-06-21 Thread Marcus Meissner
On Thu, Jun 21, 2007 at 08:40:12AM +0200, Paul Vriens wrote: > Dan Kegel wrote: > >Say, whatever happened to Coverity's scans of Wine? I just logged > >in to the Wine results at http://scan.coverity.com, and the last > >scan seems to have been last July. Did they set up a new, private > >site for