Re: NULL ptr dereferences found with Calysto static checker

2007-06-20 Thread Paul Vriens
Dan Kegel wrote: Say, whatever happened to Coverity's scans of Wine? I just logged in to the Wine results at http://scan.coverity.com, and the last scan seems to have been last July. Did they set up a new, private site for us? Paul V., do you know? - Dan HI Dan, No I'm sorry. I saw an email

Re: NULL ptr dereferences found with Calysto static checker

2007-06-20 Thread Domagoj Babic
Hi, On 6/20/07, Jan Zerebecki <[EMAIL PROTECTED]> wrote: The web page is a bit sparse, so does calysto offer anything special e.g. anything that distinguishes it from coverity? Yes, it's a different technology - no pattern matching at all. Is it free software? Probably it will be free for

Re: [kernel32][tests] Add test for GetShortPathNameW

2007-06-20 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: static DWORD (WINAPI *pGetLongPathNameA)(LPCSTR,LPSTR,DWORD); static DWORD (WINAPI *pGetLongPathNameW)(LPWSTR,LPWSTR,DWORD); +static DWORD (WINAPI *pGetShortPathNameW)(LPWSTR,LPWSTR,DWORD); I don't see where pGetShortPathNameW is initialized. I ha

Re: NULL ptr dereferences found with Calysto static checker

2007-06-20 Thread Jan Zerebecki
The web page is a bit sparse, so does calysto offer anything special e.g. anything that distinguishes it from coverity? Is it free software? On Wed, Jun 20, 2007 at 03:05:33PM -0700, Dan Kegel wrote: > Domagoj wrote: > >http://www.cs.ubc.ca/~babic/index_calysto_community.htm > >2) if the condition

Re: [kernel32][tests] Add test for GetShortPathNameW

2007-06-20 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: + WCHAR PROG_FILES_DIR[MAX_PATH]; Looks like that this variable is not used anywhere. Yeah, It is a garbage. static DWORD (WINAPI *pGetLongPathNameA)(LPCSTR,LPSTR,DWORD); static DWORD (WINAPI *pGetLongPathNameW)(LPWSTR,

re: NULL ptr dereferences found with Calysto static checker

2007-06-20 Thread Dan Kegel
Domagoj wrote: I've ran my static checker Calysto on Wine v0.9.35 and got 78 bug reports:... If you are interested in the reports, please: 1) read http://www.cs.ubc.ca/~babic/index_calysto_community.htm 2) if the conditions are acceptable, let me know where to send the reports. The conditions l

Re: [1/2] oleaut32: add PNG loading [try2]

2007-06-20 Thread Evan Stade
On 6/19/07, Evan Stade <[EMAIL PROTECTED]> wrote: Hi, Try2: This time the rowsize is correctly aligned (on 4-byte boundaries) and palette-mode PNGs are allowed as well as RGB-mode PNGs. Changelog: *added support to decode some PNG files *added check for png.h / dynamic loading of libpng.so co

Re: [kernel32][tests] Add test for GetShortPathNameW

2007-06-20 Thread Detlef Riekenberg
On Di, 2007-06-19 at 13:18 +0400, Anatoly Lyutin wrote: > +{ > +SetLastError(0xdeadbeef); > +length = pGetShortPathNameW(NULL,NULL,0); > +if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > +{ > +skip("GetShortPathNameW is not implemented\n"); > +return;

NULL ptr dereferences found with Calysto static checker

2007-06-20 Thread Domagoj Babic
Hi, I've ran my static checker Calysto on Wine v0.9.35 and got 78 bug reports: makedep: 1 sfnt2fnt: 4 winebuild: 6 winedump: 2 winegcc: 5 libwine: 60 If you are interested in the reports, please: 1) read http://www.cs.ubc.ca/~babic/index_calysto_community.htm 2) if the conditions are acceptable

Re: On stuttering audio in quartz/DirectShow

2007-06-20 Thread Chris Robinson
On Wednesday 20 June 2007 11:11:29 am Alex Villací­s Lasso wrote: > In particular, I see the following two things about sync sources: > 1) I see no effort on part of filtergraph.c to add a sync source when > simply asked to render a file Right. What's supposed to happen is that the filter graph is

On stuttering audio in quartz/DirectShow

2007-06-20 Thread Alex Villací­s Lasso
Upon checking the source code of dlls/quartz I found out about the method SetSyncSource defined in the IBaseFilter interface: dsoundrender.c:static HRESULT WINAPI DSoundRender_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filesource.c:static HRESULT WINAPI AsyncReader_SetSyncSourc

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.

2007-06-20 Thread Misha Koshelev
On Wed, 2007-06-20 at 12:09 +0200, Alexandre Julliard wrote: > Misha Koshelev <[EMAIL PROTECTED]> writes: > > > +if (!PATH_IsPathOpen(dc->path)) > > { > > -angle = atan2( > > -((yend-ycenter)/height), > > -((xend-xcenter)/width)); > > -

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.

2007-06-20 Thread Misha Koshelev
On Wed, 2007-06-20 at 12:09 +0200, Alexandre Julliard wrote: > Misha Koshelev <[EMAIL PROTECTED]> writes: > > > +if (!PATH_IsPathOpen(dc->path)) > > { > > -angle = atan2( > > -((yend-ycenter)/height), > > -((xend-xcenter)/width)); > > -

Re: OpenFile16 and similar functions

2007-06-20 Thread Detlef Riekenberg
On Mi, 2007-06-20 at 06:36 -0700, Dan Kegel wrote: > On 6/20/07, Jakob Eriksson <[EMAIL PROTECTED]> wrote: > > Are not the tests still EXE-s called by winetest? Then the current > > winetest will work OK. > > Except that winetest.h might not compile in 16 bit mode, > and our build system doesn't h

Re: OpenFile16 and similar functions

2007-06-20 Thread Dan Kegel
On 6/20/07, Jakob Eriksson <[EMAIL PROTECTED]> wrote: Are not the tests still EXE-s called by winetest? Then the current winetest will work OK. Except that winetest.h might not compile in 16 bit mode, and our build system doesn't handle 16 bit binaries, and gcc/ld can't build 16 bit NE executab

Re: OpenFile16 and similar functions

2007-06-20 Thread Anssi Hannula
Dan Kegel wrote: On 6/19/07, Dan Kegel <[EMAIL PROTECTED]> wrote: Unfortuately, Wine doesn't currently run these win16 apps properly; they hang with err:ntdll:RtlpWaitForCriticalSection section 0x7b91f300 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000c, retrying (60 sec)

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.

2007-06-20 Thread Alexandre Julliard
Misha Koshelev <[EMAIL PROTECTED]> writes: > +if (!PATH_IsPathOpen(dc->path)) > { > -angle = atan2( > -((yend-ycenter)/height), > -((xend-xcenter)/width)); > -MoveToEx(hdc, GDI_ROUND(xcenter+(cos(angle)*xradius)), > -

RE: PATCH - implement LockWorkStation using xdg-screensaver on Linux

2007-06-20 Thread Rolf Kalbermatter
Steven Edwards [mailto:[EMAIL PROTECTED] wrote: >On 6/19/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> No, it should lock the virtual desktop (with a fancy screensaver and >> all ;-). That stuff really belongs in explorer though, not in >> wineboot. > >Don't tempt me =) If I recall Scr's