Re: [3/5] widl: Add tests for encapsulated unions

2007-06-14 Thread Dan Hipschman
On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > > This adds a test for encapsulated unions, but it crashes wine. The exact Hmm, now that I reread this, I think I said this wrong. The test does crash wine, but I wrote my patch so that it doesn't run on wine. So, doing "make che

Re: Uninstaller

2007-06-14 Thread Misha Koshelev
> On 6/14/07, Misha Koshelev wrote: > > Actually that brings up a good point, does anything ever get written to > > Software\Microsoft\Windows\CurrentVersion in HKEY_CURRENT_USER in windows? > > I have no such > > key on my (rather plain) XP install, and from what I can tell wine MSI > > never

Re: Uninstaller

2007-06-14 Thread Tom Spear
On 6/14/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: Actually that brings up a good point, does anything ever get written to Software\Microsoft\Windows\CurrentVersion in HKEY_CURRENT_USER in windows? I have no such key on my (rather plain) XP install, and from what I can tell wine MSI never wr

Re: Uninstaller

2007-06-14 Thread Misha Koshelev
On Thu, 2007-06-14 at 10:50 -0400, Chris Morgan wrote: > On 6/14/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > First of all, of course I am not Alexandre. > > > > But I have to say I think I agree with James on this, with regards to > > submitting just one patch with the correct spacing. I can

Liberation

2007-06-14 Thread Louis. Lenders
Hi, this is mainly a follow up to the thread here http://www.winehq.org/pipermail/wine-devel/2007-May/057092.html , to give it a new boost Question is, are there any plans to include Liberation fonts in wine? I gave it a good testing last two weeks, that is, i converted the fonts with Hans'

Re: include/uxtheme.h : enum THEMESIZE

2007-06-14 Thread Michael Stefaniuc
Nicolas (dyalog.com) wrote: according to MSDN, include/uxtheme.h should define an "enum THEMESIZE", which is typedefed to "THEME_SIZE", rather than typedef the enum {} to "THEMESIZE" as it is currently. http://msdn2.microsoft.com/en-us/library/ms649970.aspx note that dlls/uxtheme/draw.c uses thi

Re: Uninstaller

2007-06-14 Thread Chris Morgan
Also, there are no changes to tests that show that the uninstaller changes are adding/correcting behavior so it matches windows. Unit tests would make the change more compelling. Chris On 6/14/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: First of all, of course I am not Alexandre. But I hav

Re: user32: improve cut/copy/paste behavior of password edit boxes

2007-06-14 Thread Lei Zhang
On 6/14/07, Vitaly Lipatov <[EMAIL PROTECTED]> wrote: В сообщении от 14 июня 2007 Lei Zhang написал(a): > Hi, > > This patch prevents cutting/copying text from edit boxes with the > ES_PASSWORD style. It also corrects the paste behavior of password Why we need prevent it? > edit boxes when the c

Re: Juan Lang : comdlg32: Initialize file dialog controls before creating dialog.

2007-06-14 Thread Lei Zhang
On 6/13/07, Juan Lang <[EMAIL PROTECTED]> wrote: > With this patch, the bottom of file dialogs are cut off such that the > file type dropdown and the cancel button can barely be seen. In which apps? I just looked at notepad and it looks fine to me. Also, this does correct a crash, so I'm prett

Re: [3/5] WineD3D: Present does not clear the depth stencil

2007-06-14 Thread H. Verbeet
On 14/06/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > It sounds a bit questionable to have different behaviour depending on > the debug channel. My idea is that such a clear is not needed, but costly, and I left it there for debugging. Microsoft says that the debug runtime does that too. We d

Re: [3/5] WineD3D: Present does not clear the depth stencil

2007-06-14 Thread Stefan Dösinger
> It sounds a bit questionable to have different behaviour depending on > the debug channel. My idea is that such a clear is not needed, but costly, and I left it there for debugging. Microsoft says that the debug runtime does that too. We don't have a debug runtime, but our debug channels are cl

Re: [3/5] WineD3D: Present does not clear the depth stencil

2007-06-14 Thread H. Verbeet
On 14/06/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: The patch removes the clearing from Present, except for the DISCARD swap effect if the d3d trace channel is on. It sounds a bit questionable to have different behaviour depending on the debug channel.

Re: user32: improve cut/copy/paste behavior of password edit boxes

2007-06-14 Thread Vitaly Lipatov
В сообщении от 14 июня 2007 Lei Zhang написал(a): > Hi, > > This patch prevents cutting/copying text from edit boxes with the > ES_PASSWORD style. It also corrects the paste behavior of password Why we need prevent it? > edit boxes when the clipboard is empty. -- Vitaly Lipatov, ALT Linux Team