Dmitry Timoshkov wrote:
"Paul Vriens" <[EMAIL PROTECTED]> wrote:
ret = CryptSIPRetrieveSubjectGuid(tempfileW, NULL, &subject);
ok ( !ret, "Expected CryptSIPRetrieveSubjectGuid to fail\n");
ok ( GetLastError() == ERROR_FILE_INVALID ||
+ GetLastError() == ERROR_INVALID_PARAMET
First of all, of course I am not Alexandre.
But I have to say I think I agree with James on this, with regards to
submitting just one patch with the correct spacing. I can see how seeing
one patch without any spacing changes keeps the diff very simple (I am
assuming this is why you submitted your
"James Hawkins" <[EMAIL PROTECTED]> wrote:
+while (*cptr && (*cptr == '=' || *cptr == '+' ||
+ *cptr == '-' || *cptr == '!' || *cptr == '*'))
+{
+switch (*cptr)
+{
+case '=':
+*flags |= ENV_ACT_SETALWAYS;
+break;
+case '+'
> With this patch, the bottom of file dialogs are cut off such that the
> file type dropdown and the cancel button can barely be seen.
In which apps? I just looked at notepad and it looks fine to me.
Also, this does correct a crash, so I'm pretty sure it's (mostly) correct.
--Juan
"Paul Vriens" <[EMAIL PROTECTED]> wrote:
ret = CryptSIPRetrieveSubjectGuid(tempfileW, NULL, &subject);
ok ( !ret, "Expected CryptSIPRetrieveSubjectGuid to fail\n");
ok ( GetLastError() == ERROR_FILE_INVALID ||
+ GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ ||
"Ivan Sinitsin" <[EMAIL PROTECTED]> wrote:
+ static const WCHAR sFont[] = {'M','i','c','r','o','s','o','f','t','
','S','a','n','s',' ','S','e','r','i','f','\0'};
+ HDC hdc = GetDC(0);
...
+if( RegQueryValueEx( hKey, reg_font_facename, NULL, &type,
+ (LPBYTE
It's been a while since I brought anything up on this, so I figured
I'd ask what was wrong with the last set of patches I sent.. The
patches are at [1] and [2], the discussion generated by them are at
[3], [4], [5], and [6]...
Summary, I did everything I was told in private by a developer (who
i
On 6/13/07, Evan Stade <[EMAIL PROTECTED]> wrote:
Hi,
changelog:
*implemented GdipDrawImage
dlls/gdiplus/gdiplus.spec |2 +-
dlls/gdiplus/graphics.c | 28
include/gdiplusflat.h |1 +
3 files changed, 30 insertions(+), 1 deletions(-)
-Evan Stade
> +res = RegQueryValueExW(env, name, NULL, &type, NULL, &size);
> +if (res != ERROR_FILE_NOT_FOUND || (res == ERROR_SUCCESS && type !=
> REG_SZ))
> +goto done;
Hate to point this out but isn't this the exact same error I made in my first
(and second)
patch from last night? I think
Hi Juan,
With this patch, the bottom of file dialogs are cut off such that the
file type dropdown and the cancel button can barely be seen.
- Lei
On 6/7/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
Module: wine
Branch: master
Commit: 13f18ee7593364a2a685fed2bdfa814431906f0c
URL:
http:
On Tue, 2007-06-12 at 23:22 -0700, James Hawkins wrote:
> On 6/12/07, Misha Koshelev <[EMAIL PROTECTED]> wrote:
> > This is necessary (bug not sufficient, see my comment in the bug report
> > that I am about
> > to post) to fix bug 8678.
> >
> > It is also clearly correct, as checking the type "re
On Wednesday 13 June 2007 16:13:21 Paul Vriens wrote:
> ok ( GetLastError() == ERROR_FILE_INVALID ||
> + GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ ||
> GetLastError() == S_OK /* Win98 */,
> "Expected ERROR_FILE_INVALID or S_OK, got 0x%08x\n",
> GetLastErr
http://www.winehq.org/pipermail/wine-patches/2007-June/040336.html
The third version I sent out (yes I know, I was quite sleepy) _is_ correct
though.
And that particular call _will_ return ERROR_SUCCESS and _not_ ERROR_MORE_DATA,
see:
http://msdn2.microsoft.com/en-us/library/ms724911.aspx
Spe
It turns out bug 5309 affects Picasa; a Chinese user
complained that menus were terribly slow. The
patch Aric committed here:
http://www.winehq.org/pipermail/wine-cvs/2006-October/027272.html
seems to have helped. I'm wondering, though, whether
this points up a problem in how linux distros conf
"Hans Leidekker" <[EMAIL PROTECTED]> wrote:
These tests pass on XP and on Wine with Dimitry's patch applied.
I can also confirm that the patch fixes bug 8674.
-Hans
Changelog
Add some tests for BITMAPINFOHEADER biSize checks.
Please add DeleteObject calls to delete a DIB section after each
> Maybe I forgot to explain. My test application was run with
> WINEDLLOVERRIDES=quartz=n in order to use the native quartz.dll . With
> this, audio does not stutter. The explanation about the DirectDraw
> implementation in Wine being based on top of GDI does not explain how
> native quartz manage
"Evan Stade" <[EMAIL PROTECTED]> writes:
> Sorry, to clarify: this series of patches is a resend of the last
> without the tests, and with some new patches.
When resending patches you have to first rebase them on the current
tip.
--
Alexandre Julliard
[EMAIL PROTECTED]
"Evan Stade" <[EMAIL PROTECTED]> writes:
> In the native GDI+ passing uninitialized garbage to GdipDeletePen is
> not harmful.
That doesn't make the code correct. If you really want to pass garbage
you have to do that explicitly with something like 0xdeadbeef; passing
an uninitialized value to an
18 matches
Mail list logo
