Re: msi: Do not use type value if call to RegQueryValueEx failed.

2007-06-12 Thread James Hawkins
On 6/12/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: This is necessary (bug not sufficient, see my comment in the bug report that I am about to post) to fix bug 8678. It is also clearly correct, as checking the type "returned" by RegQueryValueEx when it fails makes no sense. size = 0;

Re: advapi32: Allow setting CRYPT_VERIFYCONTEXT and CRYPT_NEWKEYSET in CryptAcquireContext

2007-06-12 Thread Mounir IDRASSI
Hi Maarten, You should not modify advapi32 to accommodate this behavior but rsaenh instead. The acceptance of this flags combination is specific to the Microsoft RSA CSP implementation and other vendors don't support it (I tested it with four third party CSPs). Moreover, your patch will clearly int

Re: [SPAM] Re: Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw

2007-06-12 Thread Chris Robinson
On Tuesday 12 June 2007 04:36:52 pm Alex Villací­s Lasso wrote: > The explanation about the DirectDraw > implementation in Wine being based on top of GDI does not explain how > native quartz manages to play smoothly while builtin quartz stutters > *when both are run under Wine*. Because built-in q

Re: [SPAM] Re: Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw

2007-06-12 Thread Alex Villací­s Lasso
Stefan Dösinger escribió: Hi, I am now thinking about rewriting the video rendering with DirectDraw. It seems that native quartz.dll uses DirectDraw, not GDI, to display video frames into the output window. DirectDraw sounds like the right way to implement quartz video output, but perfo

Re: Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw

2007-06-12 Thread H. Verbeet
On 13/06/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Obviously, if you can use Direct3D, and Direct3D uses OpenGL, you could use OpenGL directly, which saves you a not really cheap layer and gets you more control over opengl. The advantage of using Direct3D would be that an Overlay path and a

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods

2007-06-12 Thread H. Verbeet
On 13/06/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > +FIXME("ID3D10Device interface is not binary compatible to windows > > yet\n"); > > Actually, a void * is binary compatible with IDGXIAdapter * But the IDirect3D10Device interface isn't yet, thats why I suggested such a fixme for the

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods

2007-06-12 Thread Stefan Dösinger
> > +FIXME("ID3D10Device interface is not binary compatible to windows > > yet\n"); > > Actually, a void * is binary compatible with IDGXIAdapter * But the IDirect3D10Device interface isn't yet, thats why I suggested such a fixme for the start.

Re: Allow GL_ONE on WINED3DRS_EDGEANTIALIAS dstBlend value (try 2)

2007-06-12 Thread H. Verbeet
On 13/06/07, Kovács András <[EMAIL PROTECTED]> wrote: Hi, Allow GL_ONE on WINED3DRS_EDGEANTIALIAS' dstBlend value. This fixes Pirates Of Caribbean At The Worlds End blending problem. ( black square behind linght sources) -- I think I wasn't very clear wrt what I said on IRC / wrote in my earli

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods

2007-06-12 Thread Stefan Dösinger
Am Mittwoch, 13. Juni 2007 00:17 schrieb Kovács András: > [7/7] Add ID3D10Device interface and implement it's IUnknown methods >+object->lpVtbl = &D3D10Device_Vtbl; >+object->ref = 0; Spotted by KittyCat on irc. The ref should be 1. Either set it to 1, or call ID3D10Device_AddRef(*Device)

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods

2007-06-12 Thread H. Verbeet
On 13/06/07, Kovács András <[EMAIL PROTECTED]> wrote: +TRACE("Adapter %p, Driver Type %d, Software Module handle %p, Flags %08x, SDKVersion %d, Device %p\n", + Adapter, DriverType, Software, Flags, SDKVersion, Device); I think the DriverType should be traces as string there (ie, us

Re: Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw

2007-06-12 Thread Stefan Dösinger
Hi, > I am now thinking > about rewriting the video rendering with DirectDraw. It seems that > native quartz.dll uses DirectDraw, not GDI, to display video frames into > the output window. DirectDraw sounds like the right way to implement quartz video output, but performance wise I am concerned ab

Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw

2007-06-12 Thread Alex Villací­s Lasso
From a time till now, I am using a test application in Visual Basic in order to test progress in quartz. The code for the application (along with a precompiled EXE) can be found at the following address: http://www.palosanto.com/~a_villacis/WMediaTest.tar.bz2 One of the things I dislike about

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.

2007-06-12 Thread Misha Koshelev
On Tue, 2007-06-12 at 21:09 +0200, Detlef Riekenberg wrote: > On Mo, 2007-06-11 at 23:29 -0500, Misha Koshelev wrote: > > + * - On installation problems, a MessageBox is displayed and there > > does not seem to be a way to turn this off. > > > A CBT-Hook (HCBT_CREATEWND) might help > > > Yes,

Re: [GDI+ implementation: 1/8] GdipDrawLineI

2007-06-12 Thread Evan Stade
On 6/12/07, Evan Stade <[EMAIL PROTECTED]> wrote: Hi, Changelog: *implemented GdipDrawLineI dlls/gdiplus/gdiplus.spec |2 +- dlls/gdiplus/graphics.c | 16 2 files changed, 17 insertions(+), 1 deletions(-) -Evan Stade Sorry, to clarify: this series of patches is a

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 23:29 -0500, Misha Koshelev wrote: > + * - On installation problems, a MessageBox is displayed and there > does not seem to be a way to turn this off. A CBT-Hook (HCBT_CREATEWND) might help -- By by ... Detlef

Re: [GDI+: 3/10] graphics implementation

2007-06-12 Thread Alexandre Julliard
Detlef Riekenberg <[EMAIL PROTECTED]> writes: > Have you checked, that the native dll does the same? > (WINEDEBUG="+snoop,+relay") There's no reason to look at what calls native makes, that's an internal implementation detail that we don't want to know about. -- Alexandre Julliard [EMAIL PROTEC

Re: [GDI+: 3/10] graphics implementation

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 11:54 -0700, Evan Stade wrote: > + > +*graphics = (GpGraphics*) HeapAlloc(GetProcessHeap(), > HEAP_ZERO_MEMORY, > +sizeof(GpGraphics)); Have you checked, that the native dll does the same? (WINEDEBUG="+snoop,+relay") Your implementation of GdipCreatePen1 is usi

Re: [GDI+: 3/10] graphics implementation

2007-06-12 Thread James Hawkins
On 6/12/07, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: On Mo, 2007-06-11 at 11:54 -0700, Evan Stade wrote: > +GpStatus WINGDIPAPI GdipCreateFromHDC(HDC hdc, GpGraphics **graphics) > +{ > +if(hdc == NULL) > +return OutOfMemory; > + > +if(graphics == NULL) > +return Invali

Re: [GDI+: 6/10] GdipDrawLineI test

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 12:00 -0700, Evan Stade wrote: > > Changelog: > *Added framework for pixel-by-pixel comparison in tests > *added GdipDrawLineI test > > dlls/gdiplus/tests/graphics.c | 164 > + > 1 files changed, 164 insertions(+), 0 deletions(-) > >

Re: [GDI+: 3/10] graphics implementation

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 11:54 -0700, Evan Stade wrote: > +GpStatus WINGDIPAPI GdipCreateFromHDC(HDC hdc, GpGraphics **graphics) > +{ > +if(hdc == NULL) > +return OutOfMemory; > + > +if(graphics == NULL) > +return InvalidParameter; > + > +*graphics = (GpGraphics*) HeapAlloc(

Re: Add new dll mscat32

2007-06-12 Thread James Hawkins
On 6/11/07, Vijay Kiran Kamuju <[EMAIL PROTECTED]> wrote: Hi, I havent tested by putting a stubbed dll, but i have tested it with the native one. Well, after I have written the stubbed dll, will test again. As I have to check which function it actually uses. First of all, please bottom-post o

Re: [GDI+: 2/10] first pen test

2007-06-12 Thread Evan Stade
On 6/12/07, Detlef Riekenberg <[EMAIL PROTECTED]> wrote: On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote: > + > +status = GdipCreatePen1((ARGB)0x00ff, 10.0f, UnitPixel, > &pen); > + > +todo_wine > +expect(GdiplusNotInitialized, status); > + > +GdipDeletePen(pen); > +}

Re: widl: Add a missing assignment to current_structure before calling write_embedded_types.

2007-06-12 Thread Dan Hipschman
On Tue, Jun 12, 2007 at 10:29:24AM +0100, Robert Shearman wrote: > error("structure size for %s exceeds %d bytes by %d bytes\n", >name, USHRT_MAX, total_size - USHRT_MAX); > > +current_structure = type; > has_pointers = write_embedded_types(file, NULL, type, name

Re: [GDI+: 2/10] first pen test

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote: > + > +status = GdipCreatePen1((ARGB)0x00ff, 10.0f, UnitPixel, > &pen); > + > +todo_wine > +expect(GdiplusNotInitialized, status); > + > +GdipDeletePen(pen); > +} Is pen set to NULL, when GdipCreatePen1 failed? This ist n

Re: [GDI+: 3/5] added graphics implementation and tests

2007-06-12 Thread Evan Stade
On 6/10/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Evan Stade" <[EMAIL PROTECTED]> wrote: > > >> Any reason why are you creating a new pen in GdipDrawRectangleI, and while using > >> an existing one in GdipDrawLineI? > >> > >> -- > >> Dmitry. > >> > > > > Yes, the reason for that is the p

Re: [GDI+: 1/10] first pen implementation

2007-06-12 Thread Detlef Riekenberg
On Mo, 2007-06-11 at 11:51 -0700, Evan Stade wrote: > +GpStatus WINGDIPAPI GdipCreatePen1(ARGB color, FLOAT width, GpUnit > unit, > +GpPen **pen) > +{ > +LOGBRUSH lb; > +GpPen *gp_pen; > + > +gp_pen = (GpPen*) GdipAlloc(sizeof(GpPen)); > +if(!pen)return OutOfMemory; > + > +

Re: Allow GL_ONE on WINED3DRS_EDGEANTIALIAS dstBlend value

2007-06-12 Thread H. Verbeet
On 12/06/07, Kovács András <[EMAIL PROTECTED]> wrote: Hi, Allow GL_ONE on WINED3DRS_EDGEANTIALIAS' dstBlend value. This fixes Pirates Of Caribbean At The Worlds End blending problem. ( black square behind linght sources) -- I'm not sure we should be changing srcBlend/dstBlend in the first place

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.

2007-06-12 Thread Misha Koshelev
On Mon, 2007-06-11 at 23:10 -0700, James Hawkins wrote: > On 6/11/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > Changes from previous version in patch 1: > > * Comments to explain why this conformance test cannot be quite standard - > > see Notes comment @ beginning > > * Try A function first

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.

2007-06-12 Thread Misha Koshelev
On Mon, 2007-06-11 at 23:10 -0700, James Hawkins wrote: > This would still be clearer and more efficient if you set up a > function pointer at the beginning of the tests, and just use that > function for the rest of the tests. You make a helper function that > tests which version (A or W) works, a

Can we start/stop services in conformance tests?

2007-06-12 Thread Misha Koshelev
Just wondering. It seems like I can avoid message boxes easily by using a CHT hook, but the Beep() that this particular message box uses can only be disabled with the ControlService/StartService combo. Can I use this in a non-service conformance test, or is it too much to assume that the person run

Re: [PATCH try2 1/3] setupapi/tests: Add rudimentary tests for InstallHinfSectionA/W.

2007-06-12 Thread Misha Koshelev
On Mon, 2007-06-11 at 23:10 -0700, James Hawkins wrote: > On 6/11/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > Changes from previous version in patch 1: > > * Comments to explain why this conformance test cannot be quite standard - > > see Notes comment @ beginning > > * Try A function first

Re: Alexandre Julliard : winecfg: Fix potential null pointer access ( spotted by Yaroslav Skorokhodov).

2007-06-12 Thread Alexandre Julliard
Vitaly Lipatov <[EMAIL PROTECTED]> writes: > В сообщении от 12 июня 2007 Alexandre Julliard написал(a): > ... >> @@ -107,7 +107,7 @@ static void update_comboboxes(HWND dialog) >> winver = get_reg_key(config_key, keypath(""), "Version", ""); > What wrong with call get_reg_key (,,,NULL) ? Why w

Re: Alexandre Julliard : winecfg: Fix potential null pointer access ( spotted by Yaroslav Skorokhodov).

2007-06-12 Thread Vitaly Lipatov
В сообщении от 12 июня 2007 Alexandre Julliard написал(a): ... > @@ -107,7 +107,7 @@ static void update_comboboxes(HWND dialog) > winver = get_reg_key(config_key, keypath(""), "Version", ""); What wrong with call get_reg_key (,,,NULL) ? Why we need winver as NULL pointer and as empty string?

Re: [GDI+: 4/10] graphics test

2007-06-12 Thread Alexandre Julliard
"Evan Stade" <[EMAIL PROTECTED]> writes: > +wndClass.lpszClassName = TEXT(ClassName); > + > +if(!RegisterClassA(&wndClass)) return FALSE; This is broken, TEXT() doesn't work on a variable name, and it's useless since you call the A function anyway. Please don't use any of the ugly TCHAR

Re: Add new dll mscat32

2007-06-12 Thread Vijay Kiran Kamuju
Hi, There seems to be already a patch available. http://www.winehq.org/pipermail/wine-devel/2006-April/047232.html I would like to know from author, if this will work with latest version of wine Can anyone test windows media player installation with this patch? Thanks, VJ On 6/12/07, Vijay Kira