FYI: SHELL_ArgifyW and unquoted %1, non-native behavior

2007-06-07 Thread Misha Koshelev
Sorry if I am just filling your inboxes, but I thought I'd at least throw this out there before I forget about it. When I was making my ShellExecute DDE conformance tests to get Vector NTI associated files to open correctly (using DDE and without the fake "%1" that wine was adding to all shell/?/c

Re: shell32: conformance tests for unicode filenames and fix a bug forfile deletion (try 2)

2007-06-07 Thread Dmitry Timoshkov
"Nigel Liang" <[EMAIL PROTECTED]> wrote: +static const WCHAR UNICODE_PATH[] = {'c',':','\\','w',0x00ef,0x00f1,0x00eb, +'t',0x00e8,'s','t','\0','\0'}; /* "c:\winetest" */ The name above is definitely not "c:\winetest", also if you need a double termination '\0' state it specifically. +sta

Re: ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath

2007-06-07 Thread Ulrich Czekalla
Silly me that's what I get for copying and pasting what was already there. Attached is a revised patch. Thanks, /Ulrich On Fri, Jun 08, 2007 at 01:11:03AM +0900, Dmitry Timoshkov wrote: > "Ulrich Czekalla" <[EMAIL PROTECTED]> wrote: > > >-WCHAR word[MAX_PATH]; > >-int i=0,j,tabIndex=0;

Re: Could somebody run the wininet/ftp tests on Wine?

2007-06-07 Thread Paul Vriens
Detlef Riekenberg wrote: On Do, 2007-06-07 at 08:53 +0200, Paul Vriens wrote: Hi, Some time ago I added some ftp-tests. After I've seen a lot of wininet patches I just tried (current GIT) to run the ftp tests again on Wine. This time I get some failure (or actually successes): [EMAIL PROTECTE

Re: Could somebody run the wininet/ftp tests on Wine?

2007-06-07 Thread Detlef Riekenberg
On Do, 2007-06-07 at 08:53 +0200, Paul Vriens wrote: > Hi, > > Some time ago I added some ftp-tests. After I've seen a lot of wininet > patches I > just tried (current GIT) to run the ftp tests again on Wine. > > This time I get some failure (or actually successes): > > [EMAIL PROTECTED] tests]

Re: cmd:Ru:Update Russian translation.[try2][fixed]

2007-06-07 Thread Anatoly Lyutin
Kirill K. Smirnov wrote: Hi All!=) Thank you very much for discussions!It has helped me to make this patch better. + WCMD_YES, "Д" + WCMD_NO, "Н" Answers to "Yes/No" question should not be translated, should they? "All" too. I think that should translate this answers because in some

Re: ole32: Remove stack-based string buffer inFileMonikerImpl_DecomposePath

2007-06-07 Thread Dmitry Timoshkov
"Ulrich Czekalla" <[EMAIL PROTECTED]> wrote: -WCHAR word[MAX_PATH]; -int i=0,j,tabIndex=0; +LPOLESTR word; +int i=0,j,tabIndex=0, ret=0; LPOLESTR *strgtable ; int len=lstrlenW(str); TRACE("%s, %p\n", debugstr_w(str), *stringTable); -strgtable =CoTaskMemAlloc(le

Re: cmd:Ru:Update Russian translation.[try2][fixed]

2007-06-07 Thread Kirill K. Smirnov
> >> + WCMD_YES, "Д" > >> + WCMD_NO, "Н" > > > > Answers to "Yes/No" question should not be translated, should they? "All" > > too. > > I think that should translate this answers because in some languages > such as Norwegian,German and Korean it was translated. > I really doesn`t understand why i

Re: wininet: Make the passive mode response check case insensitive.

2007-06-07 Thread Hans Leidekker
On Thursday 07 June 2007, Francois Gouget wrote: > - if (strncmp(p, "Entering Passive Mode", 21)) > + if (strncasecmp(p, "Entering Passive Mode", 21)) > > You should not be using str*casecmp() in Wine (because it's a Unix > function, and because it uses the wrong locale). Try

Re: wininet: Make the passive mode response check case insensitive.

2007-06-07 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > You should not be using str*casecmp() in Wine (because it's a Unix > function, and because it uses the wrong locale). Try CompareString() > instead. Actually both would be wrong in this case, the comparison should really be done in the C locale. But

Re: avifil32: remove 'recursive registry key delete' function

2007-06-07 Thread Detlef Riekenberg
On Do, 2007-06-07 at 00:00 +0200, Stefan Leichter wrote: Replacing recursive_delete_key with RegDeleteTree is not the same. As Example: > - res = recursive_delete_keyA(HKEY_CLASSES_ROOT, > list->progid); > + res = RegDeleteTreeA(HKEY_CLASSES_ROOT, list->progid); >

Re: wininet: Make the passive mode response check case insensitive.

2007-06-07 Thread Francois Gouget
On Wed, 6 Jun 2007, Hans Leidekker wrote: [...] > Changelog > Make the passive mode response check case insensitive. --- a/dlls/wininet/ftp.c +++ b/dlls/wininet/ftp.c [...] - if (strncmp(p, "Entering Passive Mode", 21)) + if (strncasecmp(p, "Entering Passive Mode", 21)) You

Re: wined3d [1/5]: Add GL_EXT_texture_sRGB constants and corresponding CheckDeviceFormat query

2007-06-07 Thread Stefan Dösinger
Am Donnerstag, 7. Juni 2007 02:19 schrieb Phil Costin: > Stefan Dösinger wrote: > > Am Donnerstag, 7. Juni 2007 01:03 schrieb Phil Costin: > >> Adds necessary GL constants and allows the application to query whether > >> a particular texture format is compatible with sample-time texture > >> linear

Re: cmd:Ru:Update Russian translation.[try2][fixed]

2007-06-07 Thread L. Rahyen
On Thursday June 7 2007 07:01, Kirill K. Smirnov wrote: > Prase "Файл, ассоциированный с расширением %s, отсутствует" is invalid. > File never is associated with extension. Program is associated. And not > "File" is absent, but "File association" I agree with you here then, original phras

Re: cmd:Ru:Update Russian translation.[try2][fixed]

2007-06-07 Thread Kirill K. Smirnov
> I think original phrase "Файл, ассоциированный с > расширением %s,отсутствует\n" is better (but there is a typo in it - > missing space after second ","). And word "ассоциированный" do sounds like > Russian (and has frequent use in books and speech), and I like it more than > less familiar