Re: crypt32: implement CryptSIPLoad (try 5)

2007-05-31 Thread Paul Vriens
On 6/1/07, Juan Lang <[EMAIL PROTECTED]> wrote: Answering my own question, I see that the previous try introduced compiler warnings. Fixed. ChangeLog: implement CryptSIPLoad --Juan Hi Juan, This patch still uses the non-native behavior. Is there a consensus on this? I guess we are the only

Re: Bug triage, or spam?

2007-05-31 Thread Jan Zerebecki
I'm not sure there is a agreement what some things here mean. The following is my understanding of things, please correct me or state differing understanding: triage bugs: Make sure the bug is properly filed, has enough information and possibly uncover the cause (e.g. regression testing, finding w

Re: wine.inf: Create fake dll for iexplore.exe.

2007-05-31 Thread Vitaliy Margolen
Louis. Lenders wrote: >> wine.inf: Create fake dll for >iexplore.exe. >Vitaliy Margolen >> wine-patches at kievinfo.com > >Thu May 24 08:50:10 CDT 2007 >> Some older programs check if IE is installed looking for c:\Program >> Files\Internet Explorer\iexplore.exe > --- > > Hi

Re: FPS tool for wine

2007-05-31 Thread Tom Wickline
On 5/21/07, Lei Zhang <[EMAIL PROTECTED]> wrote: Right, for instance Tom Wickline ran 3dmark2000 and posted the results here: http://wiki.winehq.org/BenchMark-0.9.33 There is also some scores here. http://wiki.winehq.org/BenchMark-0.9.6 http://wiki.winehq.org/BenchMark-0.9.35 My laptop has

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, Jesse Allen <[EMAIL PROTECTED]> wrote: Bug triage is a good idea so that stuff like this gets cleaned up. I'm not sure what everyone wants though. I guess you can figure that out :P See, my opinion of what triage is isnt the same as everyone else's.. Either way, I'll just leave reso

Re: Bug triage, or spam?

2007-05-31 Thread Jesse Allen
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 5/31/07, Jesse Allen <[EMAIL PROTECTED]> wrote: > Remember that this is only my opinion. Other people handle things a > little different. It is probably true that the two recent bugs you > mentioned I would have closed, but it was only resolved.

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, Jesse Allen <[EMAIL PROTECTED]> wrote: Remember that this is only my opinion. Other people handle things a little different. It is probably true that the two recent bugs you mentioned I would have closed, but it was only resolved. It's just how it was handled. If you want to close bug

Re: Bug triage, or spam?

2007-05-31 Thread Jesse Allen
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 5/31/07, Jesse Allen <[EMAIL PROTECTED]> wrote: > Tom, > > This is how I finalize bugs: > > * When a bugs has decisively been fixed, by a merged patch, with test > cases, or reported by user been fixed, then I close it. If it's > decisively "not

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, Jesse Allen <[EMAIL PROTECTED]> wrote: Tom, This is how I finalize bugs: * When a bugs has decisively been fixed, by a merged patch, with test cases, or reported by user been fixed, then I close it. If it's decisively "not a wine bug" close invalid. * When a bug is rumored to be fix

Re: Bug triage, or spam?

2007-05-31 Thread Jesse Allen
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: It's a problem to me, it may not be a problem to you, but that doesn't make it an invalid point. Marcus and Dan have both said to keep going, I'm sure others here (I'm not trying to speak for anyone, so someone else feel free to correct me if I a

Re: [d3drm/tests] d3drm is removed from Windows Vista

2007-05-31 Thread Tom Wickline
On 5/11/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > I suppose that implies that any application using d3drm won't work on > Vista? Yes, I think ms stated that clearly somewhen. No idea why they removed it since it just wraps to directdraw, and native d3drm works on wine(apart of a whole lo

Re: Whitespace changes in an indentation patch, is it acceptable?

2007-05-31 Thread Dan Hipschman
On Thu, May 31, 2007 at 02:23:59PM -0500, Tom Spear wrote: > I recall a few years back (2003?) There was a discussion about > removing extra whitespace at the end of lines, and someone came up > with a bash/sed script to look thru the entire wine tree, strip > trailing whitespace, and then somehow

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, James Hawkins <[EMAIL PROTECTED]> wrote: > Obviously someone that commits patches to the upstream bugzilla tree > agrees with me, because otherwise, there either wouldnt be a resolved > option, OR there would be a close option on the bugs that are in any > state of open, which is some

Re: Bug triage, or spam?

2007-05-31 Thread James Hawkins
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 5/31/07, James Hawkins <[EMAIL PROTECTED]> wrote: > I do read through all of your bug emails, which is exactly the > problem, because I don't trust that you make the right decision on > every bug, and in some cases I've had to go back and correc

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, James Hawkins <[EMAIL PROTECTED]> wrote: I do read through all of your bug emails, which is exactly the problem, because I don't trust that you make the right decision on every bug, and in some cases I've had to go back and correct it. That is the issue. It has been a small number

Re: Whitespace changes in an indentation patch, is it acceptable?

2007-05-31 Thread Tom Spear
On 5/31/07, Dan Kegel <[EMAIL PROTECTED]> wrote: Now that you've fixed a couple bugs in your uninstall patch, I think you should post the very simplest form of it possible, without any other change mixed in. In this case, I think that means you should do the whitespace changes in a second patch.

Re: Bug triage, or spam?

2007-05-31 Thread James Hawkins
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 5/31/07, James Hawkins <[EMAIL PROTECTED]> wrote: > Marking bugs as closed has nothing to do with bug triage. Triaging > bugs would be a really helpful thing, but mass-closing bugs does > nothing but give subscribers a whole lot of emails to de

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, James Hawkins <[EMAIL PROTECTED]> wrote: Marking bugs as closed has nothing to do with bug triage. Triaging bugs would be a really helpful thing, but mass-closing bugs does nothing but give subscribers a whole lot of emails to delete. We don't keep track of stats like other projects

Re: GDI+: headers and one test

2007-05-31 Thread Chris Robinson
On Thursday 31 May 2007 06:59:09 am Francois Gouget wrote: > --- /dev/null > +++ b/include/GdiplusTypes.h > [...] > +typedef enum { > [...] > +} Status; > > Hmm, this is not the same as the PSDK. The PSDK only defines 'enum > Status { ... }' which, in theory, should only allow one to use 'enum > St

re: Whitespace changes in an indentation patch, is it acceptable?

2007-05-31 Thread Dan Kegel
Tom wrote: Hi all, just curious, in my work on uninstaller, I am writing my patches to where when indentation is changed, due to adding a for loop, it is done in a separate patch file. I was wondering if it is acceptable to make whitespace changes to other parts of the file in that same patch.

Re: Bug triage, or spam?

2007-05-31 Thread James Hawkins
On 5/31/07, Tom Spear <[EMAIL PROTECTED]> wrote: Hi all, I just have a quick question.. I got a message from someone last night asking me to stop closing bugs because I'm spamming the list, however I also received a message from someone a couple of nights ago thanking me for doing bug triage.. W

Re: Bug triage, or spam?

2007-05-31 Thread Marcus Meissner
On Thu, May 31, 2007 at 10:04:00AM -0500, Tom Spear wrote: > On 5/31/07, Ben Hodgetts <[EMAIL PROTECTED]> wrote: > >Can someone explain to me the point of closing bugs please? If it's > >resolved one way or another then surely that's enough? Just seems like a > >waste of effort to be honest. > > W

Re: Bug triage, or spam?

2007-05-31 Thread Tom Spear
On 5/31/07, Ben Hodgetts <[EMAIL PROTECTED]> wrote: Can someone explain to me the point of closing bugs please? If it's resolved one way or another then surely that's enough? Just seems like a waste of effort to be honest. Well, I can tell you this about it, it's supposed to work like this: -

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

2007-05-31 Thread Jacek Caban
Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> Yes, that's my plan, but I'm not sure why it's important for this patch. >> Currently Wine downloads always the same Gecko version that was never >> updated, so this check should work with current Wine. It will change >>

Re:wine.inf: Create fake dll for iexplore.exe.

2007-05-31 Thread Louis. Lenders
>wine.inf: Create fake dll for >iexplore.exe. >Vitaliy Margolen >wine-patches at kievinfo.com >Thu May 24 08:50:10 CDT 2007 >Some older programs check if IE is installed looking for c:\Program >Files\Internet Explorer\iexplore.exe --- tools/wine.inf |1 + 1 files changed

Re: Bug triage, or spam?

2007-05-31 Thread Ben Hodgetts
Can someone explain to me the point of closing bugs please? If it's resolved one way or another then surely that's enough? Just seems like a waste of effort to be honest. Ben H. Tom Spear wrote: > Hi all, I just have a quick question.. > > I got a message from someone last night asking me to stop

Whitespace changes in an indentation patch, is it acceptable?

2007-05-31 Thread Tom Spear
Hi all, just curious, in my work on uninstaller, I am writing my patches to where when indentation is changed, due to adding a for loop, it is done in a separate patch file. I was wondering if it is acceptable to make whitespace changes to other parts of the file in that same patch.. For example

Re: GDI+: headers and one test

2007-05-31 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Hmm, this is not the same as the PSDK. The PSDK only defines 'enum > Status { ... }' which, in theory, should only allow one to use 'enum > Status' and not 'Status'. Yet the PSDK headers seem to make use of > 'Status'. This might be different in C++

Re: GDI+: headers and one test

2007-05-31 Thread Francois Gouget
On Tue, 29 May 2007, Evan Stade wrote: [...] > include/Gdiplus.h| 10 + > include/GdiplusEnums.h | 39 ++ > include/GdiplusFlat.h| 23 ++ > include/GdiplusGpStubs.h | 10 + > include/GdiplusInit.h| 26 ++

Bug triage, or spam?

2007-05-31 Thread Tom Spear
Hi all, I just have a quick question.. I got a message from someone last night asking me to stop closing bugs because I'm spamming the list, however I also received a message from someone a couple of nights ago thanking me for doing bug triage.. Which is it, and if it is both, then what draws the

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

2007-05-31 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > Yes, that's my plan, but I'm not sure why it's important for this patch. > Currently Wine downloads always the same Gecko version that was never > updated, so this check should work with current Wine. It will change > once we will switch to the new version