Re: winefile/explorer hardcoded? HKEY_CLASSES_ROOT\Folder\shell\open\command ignored

2007-05-30 Thread Jan Zerebecki
On Mon, Apr 09, 2007 at 05:26:22AM +0200, RusH wrote: > Winefile seems to be hardcoded when it comes to opening folders. No > matter what I do it always pops up. I tried deleting > HKEY_CLASSES_ROOT\Folder and nothing changed. How do you test this? For me using start on directories gives access de

Re: (try 2) ws2_32: getsockname should fail for unbound sockets

2007-05-30 Thread Dmitry Timoshkov
"Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: +case AF_INET6: +{ +static const struct sockaddr_in6 emptyAddr; +const struct sockaddr_in6 *in6 = (struct sockaddr_in6*) uaddr; +return in6->sin6_port || memcmp(&in6->sin6_addr, &emptyAddr.sin6_add

Re: headers, two tests

2007-05-30 Thread Dmitry Timoshkov
This time it's just the nit picks, I see no serious problems. "Evan Stade" <[EMAIL PROTECTED]> wrote: +void WINGDIPAPI GdipFree(void* ptr) +{ +if(ptr) +HeapFree(GetProcessHeap(), 0, ptr); +} There is no need to check a pointer for NULL before HeapFree call, there is even a janitor

Looking for Dev to help with BSD Port

2007-05-30 Thread Kris Moore
Hey all! We're looking for a Wine dev to assist us with some porting issues over to PC-BSD / FreeBSD. We've recently begun to embrace making packages with wine embedded, making the process of loading windows programs a snap. The end user only needs to double-click, insert their CD, and click

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

2007-05-30 Thread Jacek Caban
Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) >> if(res != ERROR_SUCCESS || type != REG_SZ) >> return FALSE; >> >> -if(TRACE_ON(mshtml)) >> -check_version(gre_path); >>

Re: crypt32: implement CryptSIPLoad (resend)

2007-05-30 Thread Paul Vriens
On 5/30/07, Juan Lang <[EMAIL PROTECTED]> wrote: Hi Paul, > Please correct me if I'm wrong but aren't you filling pSipDispatch > with the function pointers of the given dll (as indicated by the GUID) > instead of the function pointers of crypt32 (as the tests show it > should)? I am. I couldn'

Re: Pretty Build System (Take 3)

2007-05-30 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of

Re: Pretty Build System (Take 3)

2007-05-30 Thread Robert Shearman
Tom Spear wrote: On 5/29/07, Robert Shearman <[EMAIL PROTECTED]> wrote: Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements

Re: Ownerdraw listview font patch...

2007-05-30 Thread Dimi Paun
On Wed, May 30, 2007 08:47, Markus Gömmel wrote: > Before sending this to wine.patches, I wanted to ask if anyone here can tell > me if the above is ok or total bullshit. Looks good to me. I wonder if we shouldn't set other things as well, but this would require testing to figure out. -- Dimi P

Re: Implement the WriteEnvironmentStrings standard action

2007-05-30 Thread James Hawkins
On 5/29/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: "James Hawkins" <[EMAIL PROTECTED]> wrote: > +HKEY env, root = HKEY_CURRENT_USER; ... > +if (flags & ENV_MOD_MACHINE) > +root = HKEY_LOCAL_MACHINE; It looks like root is not used. Oops. Thanks for catching that, I'll re

Re: Pretty Build System (Take 3)

2007-05-30 Thread Tom Spear
On 5/29/07, Robert Shearman <[EMAIL PROTECTED]> wrote: Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of not reducing p

Ownerdraw listview font patch...

2007-05-30 Thread Markus Gömmel
Hi, one of our windows application is using an OWNERDRAW_FIXED listview. With the current version of Wine I mentioned that when the listview is loosing its focus, the selected item will be repainted in a wrong front (System 12 instead of my MS Shell Dlg 11)... after the focus comes back, the i

Re: Call for Ubuntu-wine admin

2007-05-30 Thread Tomas Zijdemans
Scott Richie has filled the position, since he is the one doing most wine related work in Ubuntu. Thanks for showing interest! I'm looking forward to making Wine rock in Ubuntu! [EMAIL PROTECTED] wrote: If someone is interested in leading the Ubuntu-wine team, please contact me.

Re: crypt32: implement CryptSIPLoad (resend)

2007-05-30 Thread Juan Lang
Hi Paul, > Please correct me if I'm wrong but aren't you filling pSipDispatch > with the function pointers of the given dll (as indicated by the GUID) > instead of the function pointers of crypt32 (as the tests show it > should)? I am. I couldn't find any reason that the behavior needs to be tha

Re: crypt32: implement CryptSIPLoad (resend)

2007-05-30 Thread Paul Vriens
On 5/30/07, Juan Lang <[EMAIL PROTECTED]> wrote: Hi, I fixed the test failures - anything wrong with it this time? ChangeLog: implement CryptSIPLoad Thanks, --Juan Hi Juan, Please correct me if I'm wrong but aren't you filling pSipDispatch with the function pointers of the given dll (as indi

Re: hhctrl.ocx: Parse HTML entities in the table of contents.

2007-05-30 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > +p++; > +if ((*p == 'X') || (*p == 'x')) > +{ > +/* hexadecimal entity */ > +while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') > || > + (*p >= 'A' && *

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.

2007-05-30 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) > if(res != ERROR_SUCCESS || type != REG_SZ) > return FALSE; > > -if(TRACE_ON(mshtml)) > -check_version(gre_path); > +/* We may consider message box here

Re: [ws2_32] getsockname should fail on unbound socket

2007-05-30 Thread Kai Blin
On Wednesday 30 May 2007 07:56:31 Damjan Jovanovic wrote: > +case AF_INET: { > +const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > +return in->sin_port != 0; > +} Talking to Alexandre about this in IRC, he wanted me to check for all-null returns,

Re: Fedora Packages

2007-05-30 Thread Andreas Bierfert
On Sat, 5 May 2007 12:05:01 +0200 Andreas Bierfert <[EMAIL PROTECTED]> wrote: > Hi, > > here is some news/status update on the fedora packages: And again a small update interesting for RHEL/Centos 4 users: All dependencies that where needed to build wine for EPEL 4 have been met and I just pushe