Re: [PATCH 3/6] CMD.EXE: Handle command line as Unicode

2007-05-15 Thread Dmitry Timoshkov
"Jason Edmeades" <[EMAIL PROTECTED]> wrote: int main (int argc, char *argv[]) { + LPWSTR *argvW = NULL; + int args; + WCHAR *cmdW = NULL; If you will start using wmain() instead of main() you get unicode args for free, and that will help to avoid changing the command line parsing code

Direct X 10 game demo

2007-05-15 Thread EA Durbin
The lost planet demo utilizing Direct X 10 is out, for those of you interested in developing/testing Direct X 10. http://www.fileshack.com/file.x/10513/Lost+Planet:+Extreme+Condition+Demo+-+DirectX10 _ Make every IM count. Download

Re: winscard stub dll

2007-05-15 Thread Francois Gouget
Hi, Mounir IDRASSI wrote: Hi, Apart from Alexandre comment, I don't see any other possible changes. Here's a new version of the patch that removes the casts as suggested by Alexandre. -- Francois Gouget [EMAIL PROTECTED] commit 86fd1bdb35906c5601ff9b44ac2cbd6c35cdfbd9 Author: Francois Goug

Re: [PATCH 1/6] msi: automation: Condense a few loops.

2007-05-15 Thread Misha Koshelev
On Tue, 2007-05-15 at 16:35 -0500, James Hawkins wrote: > On 5/15/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > > --- > > dlls/msi/automation.c | 30 -- > > 1 files changed, 12 insertions(+), 18 deletions(-) > > > > --- a/dlls/msi/automation.c > > +++ b/dlls/msi/a

ntoskrnl.exe: Initial stub version with forwards to existing functions.

2007-05-15 Thread EA Durbin
Nice! : ) _ PC Magazine’s 2007 editors’ choice for best Web mail—award-winning Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migration_HM_mini_pcmag_0507

Re: wined3d: Add hardware cursor support.

2007-05-15 Thread Stefan Dösinger
Am Dienstag 15 Mai 2007 00:40 schrieb Andrew Riedi: > Ok, I think the patch is finally ready to go in. I applied what Stefan > wanted me to apply. > > changelog: wined3d: Add hardware cursor support. Looks ok to me pgpy8Fs7R5xkA.pgp Description: PGP signature

Re: [PATCH 2/6] msi/tests: automation: Remove unnecessary if (SUCCEEDED(hr)) statements.

2007-05-15 Thread Jacek Caban
Hi Misha, While you are at it, it's worth to directly compare the result to S_OK in tests instead of using SUCCEEDED macro as it's a more strict test. Jacek

Re: [PATCH 1/6] msi: automation: Condense a few loops.

2007-05-15 Thread James Hawkins
On 5/15/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: --- dlls/msi/automation.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) --- a/dlls/msi/automation.c +++ b/dlls/msi/automation.c @@ -580,16 +580,13 @@ static HRESULT WINAPI RecordImpl_Invoke(

Re: winscard stub dll

2007-05-15 Thread Mounir IDRASSI
Hi, Apart from Alexandre comment, I don't see any other possible changes. So, if the first patch containing the API headers is OK, I can submit the winscard stub patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Francois Gouget <[EM

Re: wininet: Add support for SSPI authentication for HTTP.

2007-05-15 Thread Juan Lang
Hi Rob, +static UINT HTTP_DecodeBase64(LPCWSTR base64, LPSTR bin); Do we really have to keep proliferating base64 implementations? Could you not implement CryptStringToBinaryW instead? Should be mostly a copy-paste job.. --Juan ___

Re: wininet: Add support for SSPI authentication for HTTP.

2007-05-15 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > +if (strncmpiW(pszAuthValue, szBasic, > sizeof(szBasic)/sizeof(szBasic[0])-1)) > +{ When using strncmp you need to also check that you reached the end of the first string. > +/* compare against last character to be set to avoid a

Re: winscard stub dll

2007-05-15 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > But then on a 64bit system an __int64 should be the same as a long so > maybe it's ok anyway. Yes, __int64 is a long on Win64. > The only issue that could happen is if we try to compile Wine's dlls > on a 64bit Windows system using Visual C++. Isn't

Re: winscard stub dll

2007-05-15 Thread Francois Gouget
Alexandre Julliard wrote: Francois Gouget <[EMAIL PROTECTED]> writes: * I would really have liked to get rid of the (unsigneg int) casts, but as the handle types are ULONG_PTRs it seems like it won't be possible. That's quite annoying. If anyone has suggestions... ULONG_PTRs are longs, they

Re: How works pGetAsyncKeyState?

2007-05-15 Thread Rafał Miłecki
2007/5/14, James Liggett <[EMAIL PROTECTED]>: On Mon, 2007-05-14 at 20:12 +0200, Rafał Miłecki wrote: > I can not find anywhere code writing any value to "pGetAsyncKeyState" > nor function that is executed when "pGetAsyncKeyState" is called. What you're looking at here is a function pointer to t

Re: crypt32(5/5): Implement CryptSIPLoad

2007-05-15 Thread Alexandre Julliard
Juan Lang <[EMAIL PROTECTED]> writes: > +static struct list providers; > +CRITICAL_SECTION providers_cs; > + > +void crypt_sip_init(void) > +{ > +InitializeCriticalSection(&providers_cs); > +list_init(&providers); > +providers_cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": > provide

Re: winscard stub dll

2007-05-15 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > * I would really have liked to get rid of the (unsigneg int) casts, but > as the handle types are ULONG_PTRs it seems like it won't be possible. > That's quite annoying. If anyone has suggestions... ULONG_PTRs are longs, they should be printed with

winscard stub dll

2007-05-15 Thread Francois Gouget
As I was working on the winscard headers, I also did small tweaks on the winscard stub implementation. I admit it's mostly whitespace changes: * removed unneeded #includes. They should be added back when the implementation actually requires them. * use LPCBYTE like in the headers instead of 'c

Re: mentoring

2007-05-15 Thread Stefan Dösinger
Am Dienstag 15 Mai 2007 02:33 schrieb Ivan Gyurdiev: > > What Stefan says about discussing patches > > is true--it helps if there's not a lot of debate around a patch. > > This quote should go down in the history of open source :) > I hope the word you're looking for is "controversy". Yes, "contro

Re: mentoring

2007-05-15 Thread Chris Howe
Can I just chime in here as a newbie Wine developer working on his first patch and say that I find this kind of discussion invaluable? I've lurked on wine-devel for a while and tried to gauge the answers to these questions before, and personally bothered some of the devs with a few questions that

Re: CMD.EXE patchset 1->6

2007-05-15 Thread Robert Shearman
Ann & Jason Edmeades wrote: Apologies if this set arrives multiple times - I sent it all on Friday, and the mailing list only shows 1,2 and 4. I sent then again tonight separately, and immediately 3 went missing... FYI I had this problem before the last hardware upgrade on winehq, and it appea