Sorry for jumping in, but I have some comments as well.
Dan, CopyFileA does not leaks a string (note BOOL flags). Instead first
call use static TEB-based buffer so this is OK, given that recursion is
impossible in this case.
Kevin, you are setting file size before copy starts. I'm not sure
Wind
"Vitaly Budovski" <[EMAIL PROTECTED]> wrote:
Both floats and integers have their share of problems. Since the square
root operation has been removed, we are dealing with much larger
numbers, potentially larger than can fit into unsigned int without
looping back around. This is why I think keepin
Jesse Allen wrote:
On 5/7/07, Duane Clark <[EMAIL PROTECTED]> wrote:
Dmitry Timoshkov wrote:
> "Vitaly Budovski" <[EMAIL PROTECTED]> wrote:
>
>>> Now that you got rid of sqrt calls usage of float numbers internally
>>> doesn't look justified (to me) anymore.
>>>
>> Only because in this instance
Hi, thank you very much for your help.
I am implementing Installer::RegistryValue for MSI OLE automation and I need a
way to tell apart
a VT_EMPTY and a VT_I4 type variant with a value of 0 as these have two
different behaviors for this
function under Windows XP. I have not figured out a way to
Rolf Kalbermatter [mailto:[EMAIL PROTECTED]
>+GetServiceDisplayName(SCManager, service_name, NULL, buffer_size);
>+if(!buffer_size)
>+{
>
>Apart from GetServiceDisplayName() currently not being implemented in Wine,
this won't work!
>*buffer_size won't be allocated by the function but h
On 5/7/07, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
"James Hawkins" <[EMAIL PROTECTED]> writes:
> I have a patch ready to go that fixes a problem with the media
> switching code in msi. According to tests and msdn, the presence of a
> required media (usually a CD or DVD) is confirmed using
"Kirill K. Smirnov" <[EMAIL PROTECTED]> wrote:
+/* Try to set invalid CP */
+ok(!SetConsoleCP(0), "Shouldn't succeed\n");
+ok(GetLastError()==ERROR_INVALID_PARAMETER, "GetLastError: expecting %u got %u\n", ERROR_INVALID_PARAMETER,
GetLastError());
+ok(!SetConsoleOutputCP(0), "S
Nice to see somebody filling in the gaps like this.
A few nits based on a superficial reading:
CopyFileA leaks a string. (I know, it did before your change, too.)
copy_file_open_dest's interface comment has the wrong name.
+for(i = 0; i < sizeof(flags) / sizeof(flags[0]); i++)
+{
+
Hey, that's only an hour away, maybe I / Lei / Nigel can drop by.
But what's the "itchy /etc/hosts bug"? Is that
http://bugs.winehq.org/show_bug.cgi?id=7929 ?
- Dan
On Mo, 2007-05-07 at 18:29 +0200, Mounir IDRASSI wrote:
> Thanks for your reply. I'm rewriting the patches and sending them back.
>
> Mounir IDRASSI
> IDRIX - Cryptography and IT Security Experts
> http://www.idrix.fr
>
> Detlef Riekenberg wrote:
> > I have no Idea about the code, but the missing
On 5/7/07, Christian Gmeiner <[EMAIL PROTECTED]> wrote:
Add support for DllCanUnloadNow and eliminates a FIXME
You need to add (Un)LockModule calls to all the objects in ddraw. See
[1] et al.
[1] http://www.winehq.org/pipermail/wine-cvs/2005-January/013741.html
--
James Hawkins
Hello, again.
Two months ago I posted a message
http://www.winehq.org/pipermail/wine-devel/2007-March/054710.html to
this list.
Now I'm using wine-0.9.36, but the serial port problem is still the
same. After port initialization (19200,8N1-it's OK I think) no data is
received from serial devi
On 5/7/07, Duane Clark <[EMAIL PROTECTED]> wrote:
Dmitry Timoshkov wrote:
> "Vitaly Budovski" <[EMAIL PROTECTED]> wrote:
>
>>> Now that you got rid of sqrt calls usage of float numbers internally
>>> doesn't look justified (to me) anymore.
>>>
>> Only because in this instance it is used with inte
Tim Schwartz [EMAIL PROTECTED] wrote:
diff --git a/programs/net/net.c b/programs/net/net.c index f77c820..ef08250
100644
--- a/programs/net/net.c
+++ b/programs/net/net.c
@@ -18,15 +18,66 @@
#include
#include
+#include
+
+int net_service(char *operation, char *service_name) {
+SC_HANDLE
Dmitry Timoshkov wrote:
"Vitaly Budovski" <[EMAIL PROTECTED]> wrote:
Now that you got rid of sqrt calls usage of float numbers internally
doesn't look justified (to me) anymore.
Only because in this instance it is used with integer data. It doesn't
need to be limited to just integer values. B
Hi,
I will see whether I have time this week to check this on
winecoreaudio.drv.
Emmanuel
Le 6 mai 07 à 13:37, Dmitry Timoshkov a écrit :
"Emmanuel Maillard" <[EMAIL PROTECTED]> wrote:
Changelog :
- inital Mixer support on Mac OS X
- find all lines and initialize controls
Could you ple
On 5/7/07, Bryan Haskins <[EMAIL PROTECTED]> wrote:
Oi, If only I could go =[
I would like to point out to any players who would go there "on the behald
of the wine project" wink wink nudge nudge, that they generally give away
some sick in game prizes! If you go and arent a player, you could eas
Markus Amsler a écrit :
Thanks to Eric for the idea.
---
dlls/dbghelp/dbghelp_private.h |3 +-
dlls/dbghelp/storage.c | 47
++-
2 files changed, 18 insertions(+), 32 deletions(-)
Markus, could you try what gives starting the bucket array size a
Oi, If only I could go =[
I would like to point out to any players who would go there "on the behald
of the wine project" wink wink nudge nudge, that they generally give away
some sick in game prizes! If you go and arent a player, you could easily
sell the codes they give out (at least last time)
On 07/05/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
Needed to handle them properly there
What exactly was the problem?
Sorry for the OT, but I thought this might be of your interest, considering
some of the Blizzard game developers will attend:
http://www.blizzard.com/press/070412.shtml
Maybe someone in California feels like dropping by to do some lobbying about
that itchy /etc/hosts bug? :-)
--
Robert Milla
On 5/7/07, Pavel Troller <[EMAIL PROTECTED]> wrote:
Hi Tom,
there is the installer file.
With regards, Pavel Troller
Hi Pavel,
I looked into the file. It is a 7-zip compressed Nullsoft installer.
What that means is that if you decide to file a bug on bugzilla
(highly recommended), ma
On 5/7/07, Vitaliy Margolen <[EMAIL PROTECTED]> wrote:
Pavel Troller wrote:
>>> it chokes on SECDRV.SYS).
That is all you need to see to know this is SafeDisk.
(for anybody who would like to
try this too, the game itself has to be patched by nocd crack
first, otherwise
it chokes on SECDRV.S
> Pavel Troller wrote:
> >>> it chokes on SECDRV.SYS).
>
> That is all you need to see to know this is SafeDisk.
>
> Vitaliy.
>
Hi Vitaliy,
sorry but you are wrong.
If you want to judge the others, please be so kind and read at least
the sentence in which your keyword appears. I'm quoting m
On 5/7/07, Bernard Ladenthin <[EMAIL PROTECTED]> wrote:
Hello,
sorry about the patch before, it was the false one.
This one is the right.
Your first patch was already committed, so you might want to send in
another patch fixing the mistake.
--
James Hawkins
Pavel Troller wrote:
>>> it chokes on SECDRV.SYS).
That is all you need to see to know this is SafeDisk.
Vitaliy.
Hi Tom!
> On 5/7/07, Pavel Troller <[EMAIL PROTECTED]> wrote:
> >Dear Vitaliy,
> > I'm very sorry for my total stupidity, ignorance and maybe even debility,
> >but I can't find nothing common between Bug# 219 and my question.
> > The PhysX installer doesn't check for any *ICE components present
I'll take you advice from now and I apologize for any annoyance caused
by my previous emails.
I would also thank all the people who took time to review our patches
and sent me their comments/remarks.
Regards,
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Vitaliy
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Am Wed, 25 Apr 2007 17:44:57 +0200
schrieb Stefan Munz <[EMAIL PROTECTED]>:
> Hi,
>
> finally we got a Wine booth at Linuxtag 2007 in Berlin. Everybody who
> wants to participate is welcome. I have to order exhibitor passes, so
> anyone you want
No, that adds more pollution to the place which should not have it.
Please send all patches to [EMAIL PROTECTED] If you think that
all of your patches need work, then don't send them at all. Do this
extra work. And when you have a patch that _you_ think is as good as it
can be, send it to [EMAIL PR
yes but I prefer sending patches first to the devel list for comments.
Once no major issue is raised, I send it to the patches list. I think
this helps prevent polluting the patches list.
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Stefan Dösinger wrote:
> Hi,
Thanks for your reply. I'm rewriting the patches and sending them back.
Mounir IDRASSI
IDRIX - Cryptography and IT Security Experts
http://www.idrix.fr
Detlef Riekenberg wrote:
> I have no Idea about the code, but the missing defines should
> be a seperate patch.
>
> Your idention looks broken.
>
Hi,
Patches should go to [EMAIL PROTECTED] :-)
pgpiFsHZzRqcO.pgp
Description: PGP signature
On Sa, 2007-05-05 at 19:16 +0200, Mounir IDRASSI wrote:
> --- a/include/wincrypt.h
> +++ b/include/wincrypt.h
> +/* Values returned by CryptGetProvParam of PP_KEYSTORAGE */
> +#define CRYPT_SEC_DESCR 0x0001
> +#define CRYPT_PSTORE0x0002
> +#define CRYPT_UI_PROMPT
On Mo, 2007-05-07 at 08:28 +0200, Damjan Jovanovic wrote:
> * Moved explorer.exe to the windows directory, because that's where
> some apps expect to find it.
You should also modify GetDesktopWindow in "dlls/user32/win.c":
GetSystemDirecoryW => GetWindowsDirectoryW
--
By by ... Detlef
"Tim Schwartz" <[EMAIL PROTECTED]> wrote:
+int net_service(char *operation, char *service_name)
Please add 'static' since it isn't used outside of this .c file.
+{
+SC_HANDLE SCManager, serviceHandle;
+int result = 0;
+unsigned int *buffer_size = NULL;
+char *service_display_
On Mo, 2007-04-30 at 00:58 +0200, Mounir IDRASSI wrote:
> +#define SCARD_S_SUCCESS0x
> +#define SCARD_F_INTERNAL_ERROR 0x8011 /**< An internal
> consistency check failed. */
> +#define SCARD_E_CANCELLED 0x8012 /**< The
> a
On Mo, 2007-05-07 at 05:46 +0200, Markus Amsler wrote:
> +/* Don't even try to resize memory. Memory gain would be
> minimal
> + but speed hit significant with big vecotrs. *
I have no Idea about the code, but found this Typo:
vecotrs => vectors
--
By by ... Detle
Hi all,
We have noticed that our first patch for winscard containing only the
headers have not been applied yet. Is this a normal delay? Is there any
pending issues? Should we send the remaining list of patches to complete
the winscard implementation?
Any comments/remarks are welcomed.
Cheers,
Mou
"James Hawkins" <[EMAIL PROTECTED]> writes:
> I have a patch ready to go that fixes a problem with the media
> switching code in msi. According to tests and msdn, the presence of a
> required media (usually a CD or DVD) is confirmed using only the
> volume name listed in the Media table of the ms
Hi,
We have found a critical bug in rsaenh dll. This bug prevents
CryptAcquireContext from correctly loading the key associated with the
container from the registry, and thus CryptGetUserKey become unusable.
This bug is located in the internal function read_key_container.
Attached with this email i
On 5/7/07, Pavel Troller <[EMAIL PROTECTED]> wrote:
Dear Vitaliy,
I'm very sorry for my total stupidity, ignorance and maybe even debility,
but I can't find nothing common between Bug# 219 and my question.
The PhysX installer doesn't check for any *ICE components present in the
system, doesn'
> -ok(info->dwKeySpec == AT_SIGNATURE,
> +ok(info->dwKeySpec == (AT_SIGNATURE|AT_KEYEXCHANGE),
> "Expected AT_SIGNATURE, got %d\n", info->dwKeySpec);
It could be a good idea to correct the error text "Expected AT_SIGNATURE"
Hi,
In the tests of the crypt32 dll, a test was written in a way that
accommodates the bug we have corrected previously in the patch for
rsaenh dll. The attached small patch corrects the value expected from
this test to be consistent with the correct output.
Cheers,
Mounir IDRASSI
IDRIX - Cryptog
Dear Vitaliy,
I'm very sorry for my total stupidity, ignorance and maybe even debility,
but I can't find nothing common between Bug# 219 and my question.
The PhysX installer doesn't check for any *ICE components present in the
system, doesn't output any strings to wine console, which are descri
I'm not so sure why are you reporting a long long long known problem
with Safedisk here, on the mailing list? See the bug 219 and add your
comments there.
Pavel Troller wrote:
> Hi!
> I was trying to install the Joint Task Force game, which was packaged as
> a bonus with my new graphics card. Th
В сообщении от 30 апреля 2007 16:26 вы написали:
> Hi,
> A week ago I've sent a patch which fixes console input/output codepages
> handling.
> http://www.winehq.org/pipermail/wine-patches/2007-April/038429.html
> It is still not applied, so please, explain, what is wrong with it? It even
> fixes
On Mon, May 07, 2007 at 12:31:02PM +0200, Mikołaj Zalewski wrote:
> I'm trying to write a tests for invalid cbSize in Shell_NotifyIcon.
> The behaviour under Windows XP is to assume in such a case that the size
> is NOTIFYICONDATA_V1_SIZE. AFAIK Shell_NotifyIcon doesn't provide a way
> to read
On 5/7/07, Mikołaj Zalewski <[EMAIL PROTECTED]> wrote:
I'm trying to write a tests for invalid cbSize in Shell_NotifyIcon.
The behaviour under Windows XP is to assume in such a case that the size
is NOTIFYICONDATA_V1_SIZE. AFAIK Shell_NotifyIcon doesn't provide a way
to read icon data to check
I'm trying to write a tests for invalid cbSize in Shell_NotifyIcon.
The behaviour under Windows XP is to assume in such a case that the size
is NOTIFYICONDATA_V1_SIZE. AFAIK Shell_NotifyIcon doesn't provide a way
to read icon data to check that the data introduced after Win95 is not
modified.
"Tim Schwartz" <[EMAIL PROTECTED]> wrote:
#include
#include
+#include
+
+int net_service(char *operation, char *service_name);
It's better to properly arrange the code to avoid forward declarations.
+int net_service(char *operation, char *service_name)
+{
+SC_HANDLE SCManager, service
51 matches
Mail list logo
