Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/25/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: Now, I am writing tests for this. Windows crashes if I pass NULL pointer to these function. Crash can be easily avoided in wine. Should we crash too? And how the windows crash can be caught? Or just I should not write such test-case?

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
Now, I am writing tests for this. Windows crashes if I pass NULL pointer to these function. Crash can be easily avoided in wine. Should we crash too? And how the windows crash can be caught? Or just I should not write such test-case? Thanks, -- Kirill

Using A- instead of W-calls in tests

2007-04-24 Thread Paul Vriens
Hi, There are several tests where we use W-calls where we could use A-calls to accomplish the same test goal. Most of the time this means some of these will fail on Win9x or WinME as they are not by default Unicode enabled. Do we need write our tests with A-calls ? For Wine this doesn't matter i

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/25/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: > > > > For containing backshash. Yes, comment must be better. > > A comment that states you're looking for a backslash is superfluous; > the code makes that obvious. A better comment would be 'check for > filename only' or something along

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF

2007-04-24 Thread Ivan Gyurdiev
> Stefan Dösinger wrote: You're returning a size_t here, which does not match the WINED3DERR_OUTOFVIDEOMEMORY returned on the HeapAlloc (granted, that's probably incorrect behavior by d3d9, but at least the return types should be consistent). Does that mean we'll be removing the other two ve

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
> > > > For containing backshash. Yes, comment must be better. > > A comment that states you're looking for a backslash is superfluous; > the code makes that obvious. A better comment would be 'check for > filename only' or something along those lines. Maybe, 'MSDN claims that if filename contains

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/25/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: > On 4/24/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: > > Hi, > > I've sent the patch: > > http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html > > about a week ago and it has not been applied. Please, explain, what is

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
> On 4/24/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: > > Hi, > > I've sent the patch: > > http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html > > about a week ago and it has not been applied. Please, explain, what is > > wrong with it? > > You haven't sent in any tests for t

FillGLCaps foreign context question

2007-04-24 Thread Jesse Allen
Jan, In a patch from Nov 23, you changed FillGLCaps to return false when we get a foreign context. This causes SW Battlefront to crash while loading sometime after calling IWineD3DImpl_GetAdapterIdentifier, at least on my system. IWineD3DImpl_GetAdapterIdentifier calls FillGLCaps, and when it get

Re: [Try 4] Check HKCU for uninstall entries

2007-04-24 Thread James Hawkins
On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: All previous patches are obsoleted by this one. Instead of just checking HKLM for uninstall entries, check HKCU as well. + if (!entries) +entries = HeapAlloc(GetProcessHeap(), 0, sizeof(uninst_entry)); You're still mixing tab

Re: Problems with Ubuntu packages

2007-04-24 Thread Mirek
This is strange, I tried it today (24.04.2007). I am using this repository: ## WineHQ - Ubuntu 7.04 "Feisty Fawn" deb http://wine.budgetdedicated.com/apt feisty main deb-src http://wine.budgetdedicated.com/apt feisty main Package 0.9.35~winehq0~ubuntu~7.04-1 Mirek Vitaliy Margolen napsal(a):

Re: Problems with Ubuntu packages

2007-04-24 Thread Vitaliy Margolen
Mirek wrote: > Hi, I am using Ubuntu FF, and I have some fullsreen issues. In Ubuntu > universe is wine 0.9.33 compiled with xrandr support, but on winehq site > is repository with wine 0.9.35 compiled without xrandr support. Can > someone fix this? I have several fullscreen issues with packages fr

Re: [3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF

2007-04-24 Thread H. Verbeet
On 24/04/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: How do you intend for this to be used? In particular, how should this work with eg. IDirect3DVertexDeclaration9::GetDeclaration or IDirect3DDevice8::GetVertexShaderDeclaration?

Re: [Try 3] [programs/uninstaller] Check HKCU for uninstall entries

2007-04-24 Thread Tom Spear
On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote: On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: > This patch makes the wine uninstaller check HKCU for uninstall entries > in addition to HKLM. > +const int numrootkeys = 2; +static const DWORD maxSubkeyNameLen = 255; const variables should

Re: winealsa: Improved handling of SysEx MIDI messages

2007-04-24 Thread Christian Costa
Seems fine. Michał Wiernowolski a écrit : This patch puts together pieces of SysEx messages until End-of-Exclusive (F7) arrives or the buffer gets filled. This improves current behavior (giving up on all multi-buffer sysex msgs), fixing partially bug #6788. ---

Re: Disabled Wine PostScript Driver?

2007-04-24 Thread Detlef Riekenberg
On Mo, 2007-04-23 at 13:51 -0300, Alisson Gomes wrote: > I need print tickets, bill. The software (VB 6) send file for printer > in generic text. The clean way is the use of a different Printer-Driver, but wine has only the Postscript-Driver "wineps.drv". After a quick view, there is no way in win

Re: [Try 3] [programs/uninstaller] Check HKCU for uninstall entries

2007-04-24 Thread James Hawkins
On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: This patch makes the wine uninstaller check HKCU for uninstall entries in addition to HKLM. +const int numrootkeys = 2; +static const DWORD maxSubkeyNameLen = 255; const variables should be all uppercase to differentiate them from non-const var

Re: schannel: Tests for Sp[Lsa,User]ModeInitialize and GetInfo

2007-04-24 Thread James Hawkins
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote: +#if 0 +/* NULL parameters: All 3 crash as of Windows XP */ +status = pSpLsaModeInitialize(0x1, NULL, &pTables, &cTables); +status = pSpLsaModeInitialize(0x1, &Version, NULL, &cTables); +status = pSpLsaModeInitialize(

Re: schannel: Implement SpUserModeInitialize

2007-04-24 Thread James Hawkins
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote: On 24/04/07, James Hawkins <[EMAIL PROTECTED]> wrote: > On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote: > > On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote: > > > > > > > > > > +if (LsaVersion != 0x1) > > > > What is 0x1? If

NONE folder ???

2007-04-24 Thread Tom Spear
While looking thru my ~/.wine/drive_c and my home directory today, I noticed that there is a folder called NONE that was created after I redid my wine install from the ground up last night. Looking thru it, there is a subfolder called var/cache/fontconfig and in that folder is a bunch of files th

Re: Should we handle this?

2007-04-24 Thread Tom Spear
On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: > On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: > > While testing my uninstaller patch, I ran into the issue that was a > > problem in Win95, where the uninstaller did not handle deletion of > > i

Re: Should we handle this?

2007-04-24 Thread Tom Spear
On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: > While testing my uninstaller patch, I ran into the issue that was a > problem in Win95, where the uninstaller did not handle deletion of > it's uninstall registry key. What I did was install a pro

Re: Should we handle this?

2007-04-24 Thread Tom Spear
On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: While testing my uninstaller patch, I ran into the issue that was a problem in Win95, where the uninstaller did not handle deletion of it's uninstall registry key. What I did was install a program that I new put it's registry key under HKLM. Then

Re: schannel: Implement SpUserModeInitialize

2007-04-24 Thread James Hawkins
On 4/24/07, James Hawkins <[EMAIL PROTECTED]> wrote: On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote: > > +if (LsaVersion != 0x1) What is 0x1? If it's not defined in the SDK, then please use a #define to clarify what it means. Also, it would be nice to have some tests for the

Re: schannel: Implement SpUserModeInitialize

2007-04-24 Thread James Hawkins
On 4/24/07, Yuval Fledel <[EMAIL PROTECTED]> wrote: +if (LsaVersion != 0x1) What is 0x1? If it's not defined in the SDK, then please use a #define to clarify what it means. -- James Hawkins

RE: ADVAPI32: Make service_start_process return the pid to the caller

2007-04-24 Thread Rolf Kalbermatter
James Hawkins [mailto:[EMAIL PROTECTED] wrote: > >On 4/24/07, Rolf Kalbermatter <[EMAIL PROTECTED]> wrote: >> Changelog >> dlls/advapi32/service.c >>- Make service_start_process return the pid to the caller >> > >-/* FIXME: Put the pid into the service struct */ >+if (ppid) *p

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/24/07, Kirill K. Smirnov <[EMAIL PROTECTED]> wrote: Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? You haven't sent in any tests for this function. Is the

[try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? Thanks -- Kirill

Re: Typo fix

2007-04-24 Thread Lei Zhang
The attachment for that email is 0 bytes. Please resend. While you're at it, would you mind spellchecking the entire file and fixing any other spelling errors? - Lei On 4/24/07, Tom Spear <[EMAIL PROTECTED]> wrote: Just curious. I sent a patch to wine-patches last week to fix a typo in a trace

Re: patch for msi.dll (action.c and custom.c)

2007-04-24 Thread James Hawkins
On 4/24/07, Ivan Sinitsin <[EMAIL PROTECTED]> wrote: The patch fix the problem with wrong source path when you install *.msi (for example FineReader 8.0). Changelog: This patch fix problem with wrong source path. This is wrong. Please read msdn about custom action type 17. The source dll fo

Should we handle this?

2007-04-24 Thread Tom Spear
While testing my uninstaller patch, I ran into the issue that was a problem in Win95, where the uninstaller did not handle deletion of it's uninstall registry key. What I did was install a program that I new put it's registry key under HKLM. Then I copied that key to HKCU. Then I installed a pro

Typo fix

2007-04-24 Thread Tom Spear
Just curious. I sent a patch to wine-patches last week to fix a typo in a trace for regedit, but it was not committed. Should I go ahead and resend it? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.

D3DRM: Thanks a lot, Wine people

2007-04-24 Thread David . Adam
Hello, my first "real" patches for wine were accepted. I would to thank all wine people for their kindness, and their help to make these patche accepted. Now I can play Motocross Madness 2 out the box :D :D :D Specially, I would like to thanks Vijay for his help to start the implementati

Problems with Ubuntu packages

2007-04-24 Thread Mirek
Hi, I am using Ubuntu FF, and I have some fullsreen issues. In Ubuntu universe is wine 0.9.33 compiled with xrandr support, but on winehq site is repository with wine 0.9.35 compiled without xrandr support. Can someone fix this? I have several fullscreen issues with packages from winehq, but no

Fwd: Status of Wine in (K)Ubuntu

2007-04-24 Thread Vijay Kiran Kamuju
Hi Jonathan Riddell has sent me a reply regarding the wine status in Ubuntu. I am also putting that message below. I have nominated Scott Ritchie as maintainer for wine in Ubuntu. I think we need to put up a proposal for wine for Ubuntu. Any Ideas, guys. Thanks, VJ -- Forwarded message

Re: localui: add Polish translation

2007-04-24 Thread Mikołaj Zalewski
+#include "ui_Pl.rc" You missed the translated File, but it would be nice, when you wait a week please: I have a Patch for AddPortUI, that add more strings and a Dialog and the Patchs grow whith more translations. I forgot the git add. But then I won't resend it but I'll wait for

SambaXP 2007 Report, Day 1

2007-04-24 Thread Kai Blin
Hi folks, this will be the first installment of my SambaXP 2007 report. SambaXP started on monday with a tutorial from Jerry Carter, which was interesting but not really related to Wine. However, in the evening I finally managed to grab hold of Steve French to talk about implementing a remote