Re: ole32: Void functions should not return a value

2007-04-12 Thread Andrew Talbot
James Hawkins wrote: > Read Andrew's last sentence. Technically no return is needed, but it > can be added for aesthetics. > Thanks, James (and everyone). If the patch gets rejected, I shall resubmit it with added returns. -- Andy.

Re: locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Dmitry Timoshkov
"Ann & Jason Edmeades" <[EMAIL PROTECTED]> wrote: >What your test app is doing? It probably needs a test under Windows to >see in which encoding (ANSI/OEM) a not unicode app should receive input >via a pipe. Sorry, just realized I had not addressed your last comment - Can you expand on this sam

Re: [2/2] wined3d: Remove usesFog flag from IWineD3DVertexShaderImpl

2007-04-12 Thread Ivan Gyurdiev
Stefan Dösinger wrote: Honestly I do not really agree with getter methods like this inside WineD3D. Yes, they do hide the implementation details, namely how the flag is stored. Yes, they do encapsulate data, like the Object Oriented Programming model says. But honestly, how much use is it to do

Re: ole32: Void functions should not return a value

2007-04-12 Thread James Hawkins
On 4/12/07, Brian Gerst <[EMAIL PROTECTED]> wrote: Andrew Talbot wrote: > Robert Shearman wrote: > >> Andrew Talbot wrote: >>> diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c >>> --- a/dlls/ole32/rpc.c 2007-03-28 12:43:32.0 +0100 >>> +++ b/dlls/ole32/rpc.c 2007-04-12 20:20:48.

Re: ole32: Void functions should not return a value

2007-04-12 Thread Brian Gerst
Andrew Talbot wrote: > Robert Shearman wrote: > >> Andrew Talbot wrote: >>> diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c >>> --- a/dlls/ole32/rpc.c 2007-03-28 12:43:32.0 +0100 >>> +++ b/dlls/ole32/rpc.c 2007-04-12 20:20:48.0 +0100 >>> @@ -1352,7 +1352,7 @@ >>> T

locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Kirill K. Smirnov
Just some thoughts in hope they would help: There is special utility called 'mode' in Windows. I can select output locale: mode con cp prepare ... mode con cp select ... I think it would solve many problems if similiar tool will be implemented in wine. [bug #8022 comment #7] -- Kirill

RE: locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Ann & Jason Edmeades
>What your test app is doing? It probably needs a test under Windows to >see in which encoding (ANSI/OEM) a not unicode app should receive input >via a pipe. Sorry, just realized I had not addressed your last comment - Can you expand on this sample test please and I'll do some experimenting. How d

Re: ole32: Void functions should not return a value

2007-04-12 Thread Andrew Talbot
Robert Shearman wrote: > Andrew Talbot wrote: >> diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c >> --- a/dlls/ole32/rpc.c 2007-03-28 12:43:32.0 +0100 >> +++ b/dlls/ole32/rpc.c 2007-04-12 20:20:48.0 +0100 >> @@ -1352,7 +1352,7 @@ >> TRACE("ipid = %s, iMethod = %d\n

Re: ole32: Void functions should not return a value

2007-04-12 Thread Robert Shearman
Andrew Talbot wrote: diff -urN a/dlls/ole32/rpc.c b/dlls/ole32/rpc.c --- a/dlls/ole32/rpc.c 2007-03-28 12:43:32.0 +0100 +++ b/dlls/ole32/rpc.c 2007-04-12 20:20:48.0 +0100 @@ -1352,7 +1352,7 @@ TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg->ProcNum); pa

Re: [5/5] D3D9: Add a test for the converted vertex decl

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 16:59 schrieb Ivan Gyurdiev: > Looks good, but this comment is misleading - s/"second"/"first". > > +/* The contents should correspond to the second conversion */ > +VDECL_CHECK(compare_elements(result_decl1, test_elements1)); > > Also, I thought when Henri was t

Re: mshtml #1: Change TRACE to FIXME in stubs.

2007-04-12 Thread Michael Stefaniuc
Jacek Caban wrote: > > --- > dlls/mshtml/htmlbody.c | 70 > > 1 files changed, 35 insertions(+), 35 deletions(-) > > > > > diff --git a/dlls/mshtml/htmlbody.c b/dlls/msht

RE: locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Ann & Jason Edmeades
>>> Apparently you need to use appropriate console output APIs directly (that >>> take into account the console input/output code page) instead of using >>> MSVCRT APIs. >>> >> Unfortunately just using the wide console function will only help the >> output to the screen, but as my test program sh

Re: [2/2] wined3d: Remove usesFog flag from IWineD3DVertexShaderImpl

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 19:49 schrieb Fabian Bieler: > Remove the usesFog flag and replace it with a 'method' as suggested by Ivan > Gyurdiev. So I'm ready to start yet another design flamewar here :-) Honestly I do not really agree with getter methods like this inside WineD3D. Yes, they do h

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 17:01 schrieb Tom Wickline: > On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > I guess some hl2 timedemos may be good too > > Was this what you had in mind? : > http://www.hocbench.com/hl2.html I don't think we need anything that complex really. I think just a

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 16:57 schrieb Tom Wickline: > On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > > Nvidia SDK D3D Demos? > > > Nvidia SDK OpenGL Demos? > > > > I don't think SDK demos are good performance benchmarks for overall > > performance. They can find bottlenecks, but not

Re: rpcrt4: Implement RpcMgmtWaitServerListen

2007-04-12 Thread Dan Hipschman
On Thu, Apr 12, 2007 at 11:47:05AM +0100, Robert Shearman wrote: > Dan Hipschman wrote: > >@@ -94,7 +95,8 @@ struct connection_ops { > > RpcConnection *(*alloc)(void); > > RPC_STATUS (*open_connection_client)(RpcConnection *conn); > > RPC_STATUS (*handoff)(RpcConnection *old_conn, RpcConnecti

Re: wined3d: Mark vertex shader 3.0 as foggy shaders if they write out the fog coord

2007-04-12 Thread H. Verbeet
On 12/04/07, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: I'm not sure what needs to be done instead, since it all looks so broken... - I would say this type of analysis about shader usage needs to go into pass 1 (baseshader), since it is backend independent. It's kind of vertex-shader specific, but

Re: wined3d: Mark vertex shader 3.0 as foggy shaders if they write out the fog coord

2007-04-12 Thread Ivan Gyurdiev
Here is how this was meant to work at some point [ since I see all kinds of incorrect things being done ]: Entry point Code generation == Pixelshader Baseshader --- ARB backend Vertexshader ---

Re: wined3d: Mark vertex shader 3.0 as foggy shaders if they write out the fog coord

2007-04-12 Thread Ivan Gyurdiev
Fabian Bieler wrote: Vertex shaders are marked as 'foggy shaders' in wined3d if they write out the fog coord. Previously this was not done for vertex shaders 3.0. This patch corrects this problem. Please don't do that - the design is flawed enough as it is (GLSL being invoked from vertexshad

Re: Add Windows Vista option to winecfg

2007-04-12 Thread H. Verbeet
On 12/04/07, H. Verbeet <[EMAIL PROTECTED]> wrote: On 12/04/07, Kovács András <[EMAIL PROTECTED]> wrote: > This patch is needed, because DirectX 10 is Vindows Vista only feature. > You'll need to change more than that, eg. see my attachment to bug 7558. Note that I only guessed the values used in

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Tom Wickline
On 4/12/07, Tom Wickline <[EMAIL PROTECTED]> wrote: Performance Mark 5.0 Lets kick in 6.1 as well. http://wiki.winehq.org/BenchMark-0.9.6?action=AttachFile&do=get&target=PerformanceTest6.1.png -- Tom Wickline Respectable computing - Linux/FOSS

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Jesse Allen
On 4/11/07, Felix Nawothnig <[EMAIL PROTECTED]> wrote: Okay, I've spent the last days looking into this matter and I'd like to suggest a way to get it started. So. This is the plan: Now I see the emails. I found it in the gmail trash. I don't know why it was there. Anyway yesterday was a long

Re: Add Windows Vista option to winecfg

2007-04-12 Thread H. Verbeet
On 12/04/07, Kovács András <[EMAIL PROTECTED]> wrote: This patch is needed, because DirectX 10 is Vindows Vista only feature. You'll need to change more than that, eg. see my attachment to bug 7558. Note that I only guessed the values used in that patch, to make the dx sdk installer happy. They

Re: Removal of unused audio drivers

2007-04-12 Thread Jakob Eriksson
Marcus Meissner wrote: Hi Maarten, I'm using esd actively. There are some audiocard drivers OSS provide and ALSA don't. I haven't used NAS at all and the winecfg delay annoys me too. Regards Vit What has esound (esd) to do with OSS? If you have soundcard only OSS supports, you cant

Re: Questions about using native vs implementing our own

2007-04-12 Thread Tom Spear
Well the patch definitely works, so if it hasn't been submitted, please do so. There are still crashes in random spots, but that is documented on Paul's wiki page. Tom On 4/11/07, Tom Spear <[EMAIL PROTECTED]> wrote: I just tried the patch is it fails, but I copied and pasted the code into the

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Tom Wickline
On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: I guess some hl2 timedemos may be good too Was this what you had in mind? : http://www.hocbench.com/hl2.html -- Tom Wickline Respectable computing - Linux/FOSS

Re: [5/5] D3D9: Add a test for the converted vertex decl

2007-04-12 Thread Ivan Gyurdiev
Looks good, but this comment is misleading - s/"second"/"first". +/* The contents should correspond to the second conversion */ +VDECL_CHECK(compare_elements(result_decl1, test_elements1)); Also, I thought when Henri was testing this that the object kept changing between sequential Get(

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Tom Wickline
On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Nvidia SDK D3D Demos? > Nvidia SDK OpenGL Demos? I don't think SDK demos are good performance benchmarks for overall performance. They can find bottlenecks, but not predict how good something is for games. They could show which features wo

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Stefan Dösinger
> Nvidia SDK D3D Demos? > Nvidia SDK OpenGL Demos? I don't think SDK demos are good performance benchmarks for overall performance. They can find bottlenecks, but not predict how good something is for games. They could show which features work in Wine / Cedega, but I think that would be unfair

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 16:22 schrieb Tom Wickline: > On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > > But I agree with Henri that a Direct3D performance comparison will be > > much more interesting. > > Well were all three in agreement, I believe a well rounded benchmark > review is

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Mirek
Tom Wickline napsal(a): On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: But I agree with Henri that a Direct3D performance comparison will be much more interesting. Well were all three in agreement, I believe a well rounded benchmark review is in order ;) Some test software: Disk

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Tom Wickline
On 4/12/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote: But I agree with Henri that a Direct3D performance comparison will be much more interesting. Well were all three in agreement, I believe a well rounded benchmark review is in order ;) Some test software: Disk I/O Memory: Performance Mar

Re: Windows dll as Linux Shared Object

2007-04-12 Thread Stefan Dösinger
Am Donnerstag 12 April 2007 15:57 schrieb Phil Lodwick: > > What is the problem with running the whole app as a winelib app? > > You don't save any resources by having the application outside > > since you still have wine running, and you have the IPC overhead. > > I want to provide a library other

RE: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Rolf Kalbermatter
Felix Nawothnig [mailto:[EMAIL PROTECTED] >Okay, I've spent the last days looking into this matter and I'd like to >suggest a way to get it started. So. This is the plan: > >1. In winex11.drv: > >-INT X11DRV_LockDIBSection(X11DRV_PDEVICE *physDev, INT req, BOOL lossy) >+HBITMAP X11DRV_LockDIBSect

RE: Windows dll as Linux Shared Object

2007-04-12 Thread Phil Lodwick
> What is the problem with running the whole app as a winelib app? > You don't save any resources by having the application outside > since you still have wine running, and you have the IPC overhead. I want to provide a library other developers can use without having them worry about the intric

Re: Add Windows Vista option to winecfg

2007-04-12 Thread Frank Richter
On 12.04.2007 15:25, Felix Nawothnig wrote: > Kovács András wrote: >> This patch is needed, because DirectX 10 is Vindows Vista only feature. > > Nothing wrong with adding Vista to the list but how is this needed? You > don't want to disallow usage of dx10 unless Vista is selected, do you? Apps m

Re: Add Windows Vista option to winecfg

2007-04-12 Thread Felix Nawothnig
Kovács András wrote: This patch is needed, because DirectX 10 is Vindows Vista only feature. Nothing wrong with adding Vista to the list but how is this needed? You don't want to disallow usage of dx10 unless Vista is selected, do you? Felix

Re: Removal of unused audio drivers

2007-04-12 Thread Tomas Kuliavas
>> why do you compile the drivers in - or why do have the files around for >> them? my audio dialog just shows oss and alsa; the others get dropped at >> compile time. also there might be other platforms that have to use those >> audio drivers - why drop something that works? > I was just proposing

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Felix Nawothnig
Alexandre Julliard wrote: 2. Export LockDIBSection/Unlock to gdi32. Adding more exports is not nice but there really is no way around that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. In my code the call to LockDIBSection serves two p

Re: locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Dmitry Timoshkov
"Jason Edmeades" <[EMAIL PROTECTED]> wrote: Apparently you need to use appropriate console output APIs directly (that take into account the console input/output code page) instead of using MSVCRT APIs. Unfortunately just using the wide console function will only help the output to the screen

Re: Removal of unused audio drivers

2007-04-12 Thread Maarten Lankhorst
Christoph Frick schreef: > why do you compile the drivers in - or why do have the files around for > them? my audio dialog just shows oss and alsa; the others get dropped at > compile time. also there might be other platforms that have to use those > audio drivers - why drop something that works? I

Re: Removal of unused audio drivers

2007-04-12 Thread Damjan Jovanovic
On 4/12/07, Vit Hrachovy <[EMAIL PROTECTED]> wrote: Maarten Lankhorst wrote: > There are 5 different audio drivers for linux, I think this is a bit > overkill, so I propose to remove the esd and nas drivers, I don't think > anyone uses esd, especially that since for that task alsa can be used > n

Re: Removal of unused audio drivers

2007-04-12 Thread Vit Hrachovy
On Thu, Apr 12, 2007 at 01:54:17PM +0200, Marcus Meissner wrote: > On Thu, Apr 12, 2007 at 01:01:43PM +0200, Vit Hrachovy wrote: > > I'm using esd actively. There are some audiocard drivers OSS provide and > > ALSA don't. > > > > I haven't used NAS at all and the winecfg delay annoys me too. > >

Re: Removal of unused audio drivers

2007-04-12 Thread Christoph Frick
On Thu, Apr 12, 2007 at 10:02:31AM +0200, Maarten Lankhorst wrote: > There are 5 different audio drivers for linux, I think this is a bit > overkill, so I propose to remove the esd and nas drivers, I don't think > anyone uses esd, especially that since for that task alsa can be used > now since dm

Re: Removal of unused audio drivers

2007-04-12 Thread Marcus Meissner
On Thu, Apr 12, 2007 at 01:01:43PM +0200, Vit Hrachovy wrote: > Maarten Lankhorst wrote: > >There are 5 different audio drivers for linux, I think this is a bit > >overkill, so I propose to remove the esd and nas drivers, I don't think > >anyone uses esd, especially that since for that task alsa ca

Re: Removal of unused audio drivers

2007-04-12 Thread Francois Gouget
On Thu, 12 Apr 2007, Maarten Lankhorst wrote: [...] > I'm not sure what nas is for, but it seems to be 'network audio system', > I haven't seen any use for it, except that it causes a 30 seconds > slowdown at showing 'audio' tab in winecfg. I don't think anyone uses it. > > For esd I think it's be

Re: Removal of unused audio drivers

2007-04-12 Thread Vit Hrachovy
Maarten Lankhorst wrote: There are 5 different audio drivers for linux, I think this is a bit overkill, so I propose to remove the esd and nas drivers, I don't think anyone uses esd, especially that since for that task alsa can be used now since dmix addon. I'm not sure what nas is for, but it s

Re: rpcrt4: Implement RpcMgmtWaitServerListen

2007-04-12 Thread Robert Shearman
Dan Hipschman wrote: @@ -94,7 +95,8 @@ struct connection_ops { RpcConnection *(*alloc)(void); RPC_STATUS (*open_connection_client)(RpcConnection *conn); RPC_STATUS (*handoff)(RpcConnection *old_conn, RpcConnection *new_conn); - int (*read)(RpcConnection *conn, void *buffer, unsigned int

Re: How come individual applications can't be put on a virtual desktop in winecfg?

2007-04-12 Thread Alexandre Julliard
Scott Ritchie <[EMAIL PROTECTED]> writes: > When Wine detects that it's about to launch an app with special > configurations set in winecfg, why can't it launch a new desktop as > though we were calling an entirely new Wine instance? Because usually when an app launches another one it expects to

Re: Patches / a proposal for the mystic DIB engine

2007-04-12 Thread Alexandre Julliard
Felix Nawothnig <[EMAIL PROTECTED]> writes: > 2. Export LockDIBSection/Unlock to gdi32. > >Adding more exports is not nice but there really is no way around >that, right? No, LockDIBSection is a driver internal detail, gdi32 has no business knowing about this. > 3. Move dc->funcs to dc->

Re: locales, unicode and ansi with msvcrt (bug 8022)

2007-04-12 Thread Jason Edmeades
Dmitry Timoshkov wrote: "Ann & Jason Edmeades" <[EMAIL PROTECTED]> wrote: Bug 8022 (http://bugs.winehq.org/show_bug.cgi?id=8022) has highlighted something interesting which has me puzzled... Basically lets take xcopy as an example command line application. It issues messages to the screen us

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread Stefan Dösinger
> Tbh, I don't think an OpenGL performance comparison is particularly > interesting in the first place. Though the interesting thing is that I did my own native Linux vs native MacOS vs Wine benchmarks with glExcess a few days ago. I got pretty much the opposite result. Granted, my benchmarking c

Re: Wine vs. Cedega in Benchmarks

2007-04-12 Thread H. Verbeet
On 12/04/07, Tom Wickline <[EMAIL PROTECTED]> wrote: Those guys ran 5 game test and Wine's performance is clearly superior to that of Cedega on benchmarks where Wine was run, they give no details of the Wine configuration, So I can only presume it's a default setup. And since there *trying* to pa

Removal of unused audio drivers

2007-04-12 Thread Maarten Lankhorst
There are 5 different audio drivers for linux, I think this is a bit overkill, so I propose to remove the esd and nas drivers, I don't think anyone uses esd, especially that since for that task alsa can be used now since dmix addon. I'm not sure what nas is for, but it seems to be 'network audio s