Re: Why double translation on keydown?

2007-04-05 Thread Dmitry Timoshkov
"Shachar Shemesh" <[EMAIL PROTECTED]> wrote: X11DRV_ToUnicodeEx is a backend of the Win32 API ToUnicodeEx and it takes a virtual key code. I.e. ToUnicodeEx takes a predefined input and should return data very closely resembling what Windows does. Ok, then maybe we should have TranslateMessage n

Re: Why double translation on keydown?

2007-04-05 Thread Shachar Shemesh
Dmitry Timoshkov wrote: > X11DRV_ToUnicodeEx is a backend of the Win32 API ToUnicodeEx and it takes > a virtual key code. I.e. ToUnicodeEx takes a predefined input and should > return data very closely resembling what Windows does. Ok, then maybe we should have TranslateMessage not call that, and u

Using signals to turn logging on and off

2007-04-05 Thread Dan Kegel
I tried the patch in the wiki to control logging with f12, but it wasn't quite satisfying, because only one process has the keyboard, so you can only turn one process' logging on and off. This isn't so great if the process you're interested in never has the keyboard. (Like com servers started up

Re: notepad: Use the more explicitly UNICODE character type.

2007-04-05 Thread Byeong-Sik Jeon
Dmitry Timoshkov wrote: > "Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: > > > Changelog: > >Use the more explicitly UNICODE character type. > > Then you have to simultaneously explicitly start using unicode Win32 APIs. Yes. I agree. > I'd suggest you to start with the application that presuma

Re: notepad: Use the more explicitly UNICODE character type.

2007-04-05 Thread Dmitry Timoshkov
"Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: Changelog: Use the more explicitly UNICODE character type. Then you have to simultaneously explicitly start using unicode Win32 APIs. I'd suggest you to start with the application that presumably doesn't work properly in multibyte locales and wh

Re: Why double translation on keydown?

2007-04-05 Thread Dmitry Timoshkov
"Shachar Shemesh" <[EMAIL PROTECTED]> wrote: This process seems, to me, overly long and inefficient. It requires building fairly complex lookup tables for both vkey and Windows keycode. I fail to see what is gained. Why not use the following process instead: * An X11 event arrives * Use t

Re: Changing debug channels on the fly

2007-04-05 Thread Stefan Dösinger
Am Freitag 06 April 2007 01:33 schrieb Dan Kegel: > It looks like programs/taskmgr/taskmgr used to let > you edit debug channels for any process, but now > that function seems broken; when I right-click > on a process and select 'edit debug channels', > I get column headers > Debug Channel Fixm

Changing debug channels on the fly

2007-04-05 Thread Dan Kegel
It looks like programs/taskmgr/taskmgr used to let you edit debug channels for any process, but now that function seems broken; when I right-click on a process and select 'edit debug channels', I get column headers Debug Channel Fixme Err Warn Trace but nothing under them. Is this supposed

Re: [2/2] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride

2007-04-05 Thread H. Verbeet
On 05/04/07, H. Verbeet <[EMAIL PROTECTED]> wrote: On 05/04/07, Fabian Bieler <[EMAIL PROTECTED]> wrote: > > > From b369a9384beb831dfae6460418d861f30a9cef3e Mon Sep 17 00:00:00 2001 > From: Fabian Bieler <[EMAIL PROTECTED]> > Date: Thu, 5 Apr 2007 21:52:44 +0200 > Subject: [PATCH] wined3d: Use GL

Re: [2/2] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride

2007-04-05 Thread H. Verbeet
On 05/04/07, Fabian Bieler <[EMAIL PROTECTED]> wrote: From b369a9384beb831dfae6460418d861f30a9cef3e Mon Sep 17 00:00:00 2001 From: Fabian Bieler <[EMAIL PROTECTED]> Date: Thu, 5 Apr 2007 21:52:44 +0200 Subject: [PATCH] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltO

Re: notepad: Fix the wrong '&' operator use.

2007-04-05 Thread Byeong-Sik Jeon
Felix Nawothnig wrote: > Byeong-Sik Jeon wrote: > > FormatMessage( > > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > > NULL, error, 0, > > -(LPTSTR) &lpMsgBuf, 0, NULL); > > +lpMsgBuf, 0, NULL); > > This patch is wrong. Wh

Re: notepad: Fix the wrong '&' operator use.

2007-04-05 Thread Felix Nawothnig
Byeong-Sik Jeon wrote: FormatMessage( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, NULL, error, 0, -(LPTSTR) &lpMsgBuf, 0, NULL); +lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used For

Why double translation on keydown?

2007-04-05 Thread Shachar Shemesh
Hi all, The current code for keyboard translation goes something like this, if I understood it correctly: * An X11 event arrives with the physical keycode for the key pressed. * Said code is translated into a VKey based on the current keyboard (fair enough) * Keycode is translat

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is returning a number that is too small > > ==> No. Currently Wi

Re: Fedora packages, where are they?

2007-04-05 Thread Andreas Bierfert
On Thu, 5 Apr 2007 08:01:01 + (UTC) Louis Lenders <[EMAIL PROTECTED]> wrote: > Hi, the link on the wine-page to get the Fedora- wine packages points to > "nowhere". Could this be fixed? Furthermore, anyone know where i can get the > wine-rpm for Fedora? Sorry that I am a bit behind with the

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Robert Shearman wrote: > Byeong-Sik Jeon wrote: > > Hi, > > > > MS-Windows's RegQueryKeyInfo function test result: > > > > 1. MSDN means TCHARS when it says 'character' for this function. > > ==> No. > > 2. why RegQueryInfoKey is returning a number that is too small > > ==> No. Currently Wi

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Bill Medland wrote: > I confess that I have not tested this. I think it is sufficiently > counterintuitive that it would be useful if you could submit a test that > would demonstrate it, e.g. put a non-SBCS string into the registry in > Unicode, query and get it back out, demonstrating that the si

Re: Fedora packages, where are they?

2007-04-05 Thread Marcus Meissner
On Thu, Apr 05, 2007 at 08:01:01AM +, Louis Lenders wrote: > Hi, the link on the wine-page to get the Fedora- wine packages points to > "nowhere". Could this be fixed? Furthermore, anyone know where i can get the > wine-rpm for Fedora? It is in their Extras RPMs. Additionally in my buildservi

Re: comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)

2007-04-05 Thread Mikołaj Zalewski
Since it clearly sounds like a CopyImage bug it would be more appropriate to fix CopyImage instead, Microsoft may do that at some point as well. I was a bit affraid that even Windows Vista has this bug so there might be apps depending on it. However it would be strange for some app to depen

Re: string comparison functions

2007-04-05 Thread Dmitry Timoshkov
"Tomas Kuliavas" <[EMAIL PROTECTED]> wrote: What rules are used when Wine libraries compare Unicode strings? I need to know when ascii characters can match their approximate Unicode equivalents. For example: 'U+1D49 MODIFIER LETTER SMALL E' matches 'U+0065 LATIN SMALL LETTER E' on Wine. WideCh

Re: Random X errors caused by recent cursor patch?

2007-04-05 Thread Tom Spear
On 4/5/07, John Smith <[EMAIL PROTECTED]> wrote: This patch seemed to fix this (or atleast hide it from being as reproducible as it was). Hide it from being as reproducible? Are you still able to reproduce it at all, now? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU.

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Bill Medland
On Thu, 2007-05-04 at 12:03 +0900, Byeong-Sik Jeon wrote: > Hi, > > MS-Windows's RegQueryKeyInfo function test result: > > 1. MSDN means TCHARS when it says 'character' for this function. > ==> No. > 2. why RegQueryInfoKey is returning a number that is too small > ==> No. Currently Wine's

string comparison functions

2007-04-05 Thread Tomas Kuliavas
Hi, Sorry for cross posting. I've already asked same question on wine-users list and only reply redirected me to devel list. What rules are used when Wine libraries compare Unicode strings? I need to know when ascii characters can match their approximate Unicode equivalents. For example: 'U+1D49

Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Peter Beutner
Alexandre Julliard schrieb: > "Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > >> "Peter Beutner" <[EMAIL PROTECTED]> wrote: >>> @@ -148,6 +148,10 @@ LPWSTR WINAPI GetEnvironmentStringsW(void) >>> */ >>> BOOL WINAPI FreeEnvironmentStringsA( LPSTR ptr ) >>> { >>> +/* broken app passes ptr it g

Re: comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)

2007-04-05 Thread Dmitry Timoshkov
"Mikolaj Zalewski" <[EMAIL PROTECTED]> wrote: If the DDB format is RGB565, CopyImage uses an RGB555 intermediate DIB that leads to data loses. This may change the COLOR_BTNFACE pixels slightly and they won't be recognized as transparent anymore. As this bug is also present under Windows, I hav

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Byeong-Sik Jeon
Alexandre Julliard wrote: > Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > > > another soultion: > > * we can change the "IDS_NEWKEY, IDS_NEWVALUE" of resource file. > > * define the UNICODE > > but these sulution don't fix the regedit's bug. just bug hide... > > What we should do for regedit,

Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Peter Beutner" <[EMAIL PROTECTED]> wrote: >> @@ -148,6 +148,10 @@ LPWSTR WINAPI GetEnvironmentStringsW(void) >> */ >> BOOL WINAPI FreeEnvironmentStringsA( LPSTR ptr ) >> { >> +/* broken app passes ptr it got from GetEnvironmentStringsW */ >> +

Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Dmitry Timoshkov
"Peter Beutner" <[EMAIL PROTECTED]> wrote: Probably an exception handler should be added inside of RtlFreeHeap instead. hm, i vaguely remember reading here that it was prefered not to cover up crashes produced by passing invalid pointers, unless absolutely necessary. If the crash is caused by

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Robert Shearman
Byeong-Sik Jeon wrote: Hi, MS-Windows's RegQueryKeyInfo function test result: 1. MSDN means TCHARS when it says 'character' for this function. ==> No. 2. why RegQueryInfoKey is returning a number that is too small ==> No. Currently Wine's RegQueryInfoKey set the right values. Sorry

Re: Random X errors caused by recent cursor patch?

2007-04-05 Thread John Smith
I was able to reproduce the badpixmap bug on peachtree 2006 right after picking a company from the "open company" dialog. This patch seemed to fix this (or atleast hide it from being as reproducible as it was). I had some trouble applying it to current gitwine, but I typed it in manually and it

Fedora packages, where are they?

2007-04-05 Thread Louis Lenders
Hi, the link on the wine-page to get the Fedora- wine packages points to "nowhere". Could this be fixed? Furthermore, anyone know where i can get the wine-rpm for Fedora?

Re: [msi OLE automation] Re: msi patches info pls

2007-04-05 Thread Alexandre Julliard
Misha Koshelev <[EMAIL PROTECTED]> writes: > As one is looking at the oleview output of the native IDL file, one > starts a blank document and begins to make the wine IDL file. One > defines all the appropriate interfaces, etc. using the UUID's, names, > etc. from the native interface. All the fun

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-05 Thread Alexandre Julliard
Byeong-Sik Jeon <[EMAIL PROTECTED]> writes: > another soultion: > * we can change the "IDS_NEWKEY, IDS_NEWVALUE" of resource file. > * define the UNICODE > but these sulution don't fix the regedit's bug. just bug hide... What we should do for regedit, and actually for all our programs, is to

Re: wined3d: Fix GLSL cnd instruction

2007-04-05 Thread H. Verbeet
On 05/04/07, Fabian Bieler <[EMAIL PROTECTED]> wrote: According to MSDN the cnd instruction should translate: dst = src0 > 0.5 ? src1 : src2; This matches the ARB implementation in wined3d and fixes the borders in civ4. Note: On nvidia hardware this patch breaks the outro of Half-Life 2 with dx