Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Hi, MS-Windows's RegQueryKeyInfo function test result: 1. MSDN means TCHARS when it says 'character' for this function. ==> No. 2. why RegQueryInfoKey is returning a number that is too small ==> No. Currently Wine's RegQueryInfoKey set the right values. Thank you.

Re: [AppDB] Use objectMakeLink()/Url() in more places

2007-04-04 Thread Jan Zerebecki
On Tue, Apr 03, 2007 at 12:59:21AM -0500, Marty Schmidt wrote: > I can not open the attachment on this message It looks fine from skimming it: http://article.gmane.org/gmane.comp.emulators.wine.patches/35452 Or look at the raw message and copy&paste attached diff: http://article.gmane.org/gmane.co

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Byeong-Sik Jeon wrote: > Bill Medland wrote: > > On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > > > Without UNICODE, sizeof(TCHAR) == 1. This is no effect. CJK multibyte > > > character is 2 byte size. > > > > > Yes, but you are getting confused by the term 'character'. It is being

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > > Without UNICODE, sizeof(TCHAR) == 1. This is no effect. CJK multibyte > > character is 2 byte size. > > > Yes, but you are getting confused by the term 'character'. It is being > used in two different senses. Yo

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Bill Medland
On Thu, 2007-05-04 at 06:17 +0900, Byeong-Sik Jeon wrote: > Bill Medland wrote: > > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > > Hi, > > > > > > Currently regedit is not defined "UNICODE". > > > > > > The point are "max_val_name_len", "valName", "valNameLen". > > > Not max_val_

Re: [msi OLE automation] Re: msi patches info pls

2007-04-04 Thread Misha Koshelev
On Tue, 2007-04-03 at 16:54 +0100, Robert Shearman wrote: > Misha Koshelev wrote: > > On Fri, 2007-03-09 at 17:27 +0100, Alexandre Julliard wrote: > > > >> Sorry for the lack of response, I'm currently waiting for our lawyers > >> to determine if it's ok to use code based on an oleview dump of a

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not max_val_size, valSize. > > > > RegQueryInfoKey set the "max_val_name_len" to the

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Bill Medland wrote: > On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > > Hi, > > > > Currently regedit is not defined "UNICODE". > > > > The point are "max_val_name_len", "valName", "valNameLen". > > Not max_val_size, valSize. > > > > RegQueryInfoKey set the "max_val_name_len" to the

Re: winspool: Add a test for DeviceCapabilities, fix some bugs found

2007-04-04 Thread Detlef Riekenberg
On Mi, 2007-04-04 at 11:06 +0900, Dmitry Timoshkov wrote: > "Detlef Riekenberg" <[EMAIL PROTECTED]> wrote: > > >> +hComdlg32 = LoadLibrary("comdlg32.dll"); > >> +assert(hComdlg32); > >> +pPrintDlg = GetProcAddress(hComdlg32, "PrintDlgA"); > >> +assert(pPrintDlg); > > > > Why are yo

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Bill Medland
On Thu, 2007-05-04 at 02:18 +0900, Byeong-Sik Jeon wrote: > Hi, > > Currently regedit is not defined "UNICODE". > > The point are "max_val_name_len", "valName", "valNameLen". > Not max_val_size, valSize. > > RegQueryInfoKey set the "max_val_name_len" to the size of the longest > value name, in c

Re: [PATCH] kernel32: return copy of environment block inGetEnvironmentStringsW

2007-04-04 Thread Peter Beutner
Dmitry Timoshkov schrieb: > "Peter Beutner" <[EMAIL PROTECTED]> wrote: > >> Make behaviour consistent with GetEnvironmentStringsA. >> Prevents crash for confused applications which first call >> GetEnvironmentStringsW and then want to free it with >> FreeEnvironmentStringsA. > > This patch is wro

Re: [AppDB] Use objectMakeLink()/Url() in more places

2007-04-04 Thread Marty Schmidt
I can not open the attachment on this message - Original Message - From: "Alexander Nicolaysen Sørnes" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]>; "Chris Morgan" <[EMAIL PROTECTED]> Sent: Sunday, April 01, 2007 4:38 PM Subject: [AppDB] Use objectMakeLink()/Url() in more places Use obj

Re: [winmm/winearts] Kill off winearts

2007-04-04 Thread Chris Morgan
On 4/4/07, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: As far as I can tell, it has been disabled for at least 4 months, and I didn't hear anyone about it, so it seems like a good idea to remove winearts, if anybody feels like reviving it, it would be easy to do so by reversing this commit, b

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Byeong-Sik Jeon
Hi, Currently regedit is not defined "UNICODE". The point are "max_val_name_len", "valName", "valNameLen". Not max_val_size, valSize. RegQueryInfoKey set the "max_val_name_len" to the size of the longest value name, in characters. This value is not required byte size. N character string: ==> w

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.

2007-04-04 Thread Detlef Riekenberg
On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > +/* convert from WCHAR size to maximum required TCHAR size */ > +max_val_name_len *= sizeof(WCHAR) / sizeof(TCHAR); > + > valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * > sizeof(TCHAR)); > valBuf = HeapAll

Re: RegDeleteTreeA [2nd]

2007-04-04 Thread Paul Vriens
On 4/3/07, Stefan Leichter <[EMAIL PROTECTED]> wrote: Am Tuesday 03 April 2007 07:25 schrieb Paul Vriens: > On 4/2/07, Stefan Leichter <[EMAIL PROTECTED]> wrote: > > ChangeLog > > -- > > add some tests for RegDeleteTreeA > > Hi Stefan, > > You're patch wasn't against latest GI

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs

2007-04-04 Thread Felix Nawothnig
Stefan Dösinger wrote: Some of them should technically be ERRs because we tell the application that we do not support those features, so they should never be used. Application bugs shouldn't trigger ERRs, Wine bugs should. Felix.

Re: [1/2] wined3d: Downgrade some ERRs to FIXMEs

2007-04-04 Thread Stefan Dösinger
Am Dienstag 03 April 2007 23:38 schrieb Felix Nawothnig: > --- > dlls/wined3d/state.c | 24 > 1 files changed, 12 insertions(+), 12 deletions(-) Some of them should technically be ERRs because we tell the application that we do not support those features, so they shou