Re: [PATCH] ntdll: remove one exception test

2007-03-31 Thread Dmitry Timoshkov
"Peter Beutner" <[EMAIL PROTECTED]> wrote: -ok( (context->Dr6 & 0xf) == 0, "B0...3 flags in Dr6 shouldn't be set\n"); +/* depending on the win version the B0 bit is already set here as well */ + Please leave an original line of code in place, just enclose it in the comment.

Re: [PATCH] kernel32: return copy of environment block inGetEnvironmentStringsW

2007-03-31 Thread Dmitry Timoshkov
"Peter Beutner" <[EMAIL PROTECTED]> wrote: Make behaviour consistent with GetEnvironmentStringsA. Prevents crash for confused applications which first call GetEnvironmentStringsW and then want to free it with FreeEnvironmentStringsA. This patch is wrong: http://blogs.msdn.com/matt_pietrek/arc

Re: extracting info from a minidump via winedbg

2007-03-31 Thread Dmitry Timoshkov
"Dennis Schridde" <[EMAIL PROTECTED]> wrote: > I actually meant > winedump dump -x debug -G warzone2100.exe Still does not work... "Only one file can be treated at once" 'winedump dump -j debug -G warzone2100.exe' should work. -- Dmitry.

Anyone else want to be a SoC mentor?

2007-03-31 Thread Dan Kegel
Hey folks, it looks like we might need a few more mentors; anyone else interested? - Dan

Re: extracting info from a minidump via winedbg

2007-03-31 Thread Dennis Schridde
Am Samstag, 31. März 2007 schrieb Eric Pouech: > >> what does 'winedbg -x debug -g warzone2100.exe' give ? > > > > Usage information... > > > > winedbg has neither a -x nor a -g parameter. > > winedump has a -x parameter (which takes no option) and a -G parameter. > > It complains about not being a

Re: extracting info from a minidump via winedbg

2007-03-31 Thread Eric Pouech
Dennis Schridde a écrit : Am Freitag, 30. März 2007 schrieb Eric Pouech: 2007/3/29, Dennis Schridde <[EMAIL PROTECTED]>: Am Donnerstag, 29. März 2007 schrieb Eric Pouech: Dennis Schridde a écrit : Hello Wine users! I've got a minidump from a ("real") Windows user of o

Re: Submitting AppDB test results broken?

2007-03-31 Thread Alexander Nicolaysen Sørnes
Lørdag 31 mars 2007 14:42, skrev Markus: > Hi, > > I just noticed that submitting test data to AppDB does not work. After > submitting, the result page shows several e-mails sent but also an error > "No test id defined!". The test data does not show up in the result list > either. In addition, the

Submitting AppDB test results broken?

2007-03-31 Thread Markus
Hi, I just noticed that submitting test data to AppDB does not work. After submitting, the result page shows several e-mails sent but also an error "No test id defined!". The test data does not show up in the result list either. In addition, the .34 release is not available for selection yet. R

Re: request to look into this bug

2007-03-31 Thread Damjan Jovanovic
On 3/30/07, Louis. Lenders <[EMAIL PROTECTED]> wrote: Hi, while working through the test reports in the appdb, i saw users submitting crashes with applications , all similar to bug 7380, so i decided to take it here. The applications that crash are *WinMerge (newest version) *BookWorms Adven

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Stefan Dösinger
Am Samstag 31 März 2007 13:05 schrieb Nathan Williams: > Hmm, ok it seems I'm going to have to put some more time and thought > into this patch before I try again! > > Thanks for all your help, I'll see what I can work out. > Do you know of any games that create power of 2 surfaces, so any > change

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Nathan Williams
Hmm, ok it seems I'm going to have to put some more time and thought into this patch before I try again! Thanks for all your help, I'll see what I can work out. Do you know of any games that create power of 2 surfaces, so any changes I make, I can test them against? Or should I just fire up wind

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Stefan Dösinger
Am Samstag 31 März 2007 11:56 schrieb Nathan Williams: > > This->Flags |= SFLAG_NONPOW2 This also isn't correct in that case :-) This will set the NONPOW2 flag unconditionally, even for surfaces which have power of 2 sizes. If there is a surface which has non power of 2 sizes, and the non power

DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Nathan Williams
Sorry about the last patch, I slipped up on my bitwise operators. This should be correct to my intentions at least! (I forgot to hit reply all, agh, i should probably power off my computer now :P ) On 3/31/07, Chris Bandy <[EMAIL PROTECTED]> wrote: Stefan Dösinger wrote: >> @@ -3194,6 +3193,

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Chris Bandy
Stefan Dösinger wrote: @@ -3194,6 +3193,7 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) { } else { /* No oversize, gl rect is the full texture size */ This->Flags &= ~SFLAG_OVERSIZE; +This->Flags &= SFLAG_NONPOW2;

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Nathan Williams
Actually I needed to set that flag, otherwise other code further on fails, using the incorrect height. And now that I look at it, all my bitwise operator knowledge is coming back from university, that should have been a bitwise or! so: This->Flags |= SFLAG_NONPOW2; I'll fix it and resend an upda

Re: [PATCH 1/1] wined3d: Make 8bpp a valid depth in EnumAdapterModes

2007-03-31 Thread Stefan Dösinger
> You'll probably need to wait for Stefan or Henri to respond to figure out > what to do. Though, it appears DDraw can be patched to do a second > enumeration loop with WINED3DFORMAT_P8 if the first was with > WINED3DFMT_UNKNOWN.. whether or not this is acceptable, I'm not sure, but > it's an idea

Re: DirectDrawRenderer - opengl non power of 2 windows

2007-03-31 Thread Stefan Dösinger
> @@ -3194,6 +3193,7 @@ static HRESULT WINAPI IWineD3DSurfaceImpl_PrivateSetup(IWineD3DSurface *iface) { > } else { > /* No oversize, gl rect is the full texture size */ > This->Flags &= ~SFLAG_OVERSIZE; > +This->Flags &= SFLAG_NONPOW2; This is not correct. This rem

Re: Excluding a Windows version from the tests

2007-03-31 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > It turns out we had a lof of failures with this test on win98. It looks like > win98 doesn't assign a new handle when the same registry key is opened. This > means that the close test close the main handle and we thus have an issue in > the > first test a