Re: winegcc: sign-compare fixes

2007-02-08 Thread [EMAIL PROTECTED]
> > memmove(&arr->base[i], &arr->base[i + 1], > (arr->size - i - 1) * > > sizeof(arr->base[0])); > > arr->size--; > > } > > If the element size could be greater than one byte, > the multiplication > here should be checked for overflow (actually, this > is more necessary > when the array is crea

Re: comctl32: datetime: initial tests for date and time picker

2007-02-08 Thread Mike McCormack
Kanit Therdsteerasukdi wrote: I'm a student at UCLA taking CS130: Software Engineering. For CS130, we are writing conformance tests for Common Controls (comctl32). I will be working on the Date and Time Picker. Attached is an initial test, testing the getters and setters. Looks like good w

Re: DirectDrawRenderer=opengl - screen size changeable for final rendering?

2007-02-08 Thread Stefan Dösinger
> thats the point. i dont know how wine handles the ddraw-over-opengl > scenario. i just had very blury graphics in JA2. nothing to wonder > about as i assume at least one quad is drawn with the image as texture. > so the filtering kicks in and voila we have bad image quality. No, I think opengl dd

Re: [2] wineshelllink: Keep using the slash as path separator.

2007-02-08 Thread Vitaliy Margolen
Hans Leidekker wrote: > On Thursday 08 February 2007 16:38:07 Vitaliy Margolen wrote: > >> And creates invalid menu entries. Did you test this patch with >> multi-level menu structure? When I tried your patch it created all menu >> entries in the top level menu, with the name like: > > Strange, I

Re: [2] wineshelllink: Keep using the slash as path separator.

2007-02-08 Thread Hans Leidekker
On Thursday 08 February 2007 16:38:07 Vitaliy Margolen wrote: > And creates invalid menu entries. Did you test this patch with > multi-level menu structure? When I tried your patch it created all menu > entries in the top level menu, with the name like: Strange, I tested the patch extensively bef

RE: Helping a user migrate an odbc app to Wine

2007-02-08 Thread Rolf Kalbermatter
Boaz Harrosh [mailto:[EMAIL PROTECTED] wrote: >This is totally not true and it is right there in documentation. (User guide) Ok! I stand corrected. Sorry. >All you do is install mdac downloadable from Microsoft.com, or any MS product >like Office. Than run odbcad32.exe to set your DSNs. I had e

Re: Bugzilla: Adding a 'patch' keyword

2007-02-08 Thread Jeremy Newman
Since nobody else jumped on this, I went ahead and added a "patch" keyword. On Mon, 2007-02-05 at 19:48 +0100, Francois Gouget wrote: > On Tue, 30 Jan 2007, Francois Gouget wrote: > [...] > > But it would be nice if there was an easy way to find bugs that have a > > patch, even, and maybe especia

Re: Getting Fallout 2 to work well

2007-02-08 Thread Joonas Koivunen
2007/2/5, Mitchell Mebane <[EMAIL PROTECTED]>: Stefan Dösinger wrote: Am Freitag 02 Februar 2007 08:34 schrieb Joonas Koivunen: Profiling with oprofile (GDI session) shows that most of the time is used in the game (I suppose it's the "anon" from wine-preload), next most time consuming is win

IE Dev Toolbar now compatible!

2007-02-08 Thread Darryl Dixon
Hi All, Just a brief to let you know that it looks like Microsoft is finally taking compatability seriously ;) - the new Beta 3 version of the IE Developers Toolbar (http://www.microsoft.com/downloads/details.aspx?FamilyID=e59c3964-672d-4511-bb3e-2d5e1db91038&displaylang=en) improves on the prev

Re: Helping a user migrate an odbc app to Wine

2007-02-08 Thread Boaz Harrosh
On 2/8/07, Rolf Kalbermatter <[EMAIL PROTECTED]> wrote: Ouch, I wouldn't see how this could work. Running the Microsoft drivers together with the whole Microsoft ODBC manager under Wine too would probably be the only way to get that working. But I think it is safe to assume that that would requir

winealsa commit d2f29311caa8041bd992a3867d71d6311c7ff8fa

2007-02-08 Thread Marcus Meissner
Hi Marten, Your commit: http://source.winehq.org/git/wine.git/?a=commit;h=d2f29311caa8041bd992a3867d71d6311c7ff8fa Has some regressions on Coverity. Namely Coverity complains that "areas" is used uninitializied. And yes it is: static DWORD CALLBACK DBSB_MMAPLoop(LPVOID data) {

Re: DirectDrawRenderer=opengl - screen size changeable for final rendering?

2007-02-08 Thread Christoph Frick
On Thu, Feb 08, 2007 at 07:01:04PM +0100, Stefan Dösinger wrote: > DirectDraw games access the screen directly by using coordinates from > 0, 0 to with, height. If wine makes the surface bigger the rendering > will just end up in a corner. The best thing we can do is to scale it, > but that is wha

Re: RedHat rpms

2007-02-08 Thread Lei Zhang
I build RPMs for RHEL 3, give them a try: http://linux.ucla.edu/~leiz/software/wine/rpms.php On 2/8/07, Bill Medland <[EMAIL PROTECTED]> wrote: Just checking I'm looking to see if there are rpms being built for Red Hate Enterprise Linux 3 these days. I see that the Red Hat rpms nowadays are fo

Re: How to find rendering code

2007-02-08 Thread Stefan Dösinger
Am Mittwoch 07 Februar 2007 00:14 schrieb Markus: > Hi, > > I am new to Wine development and wanted to ask on the list, whether someone > could point me to the correct place where the code for issues 3 and 4 in > http://bugs.winehq.org/show_bug.cgi?id=7273 might be located. It looks like > the solu

Re: DirectDrawRenderer=opengl - screen size changeable for final rendering?

2007-02-08 Thread Stefan Dösinger
Am Dienstag 06 Februar 2007 14:13 schrieb Christoph Frick: > hiho > > what i ever wondered but never dared to ask: > > i tried recently the said key with jagged alliance 2. as the game has > quite a low resolution 640 or 800 it would be nice to allow higher > resolutions when rendering ddraw with o

Re: Getting Fallout 2 to work well

2007-02-08 Thread Stefan Dösinger
Am Montag 05 Februar 2007 17:19 schrieb Mitchell Mebane: > How much work would this be? I know nothing about Windows or X11 > programming, but is it something that I might be able to study up on and > propose for a Summer of Code project? It was suggested as a SOC project last year, but nobody show

RedHat rpms

2007-02-08 Thread Bill Medland
Just checking I'm looking to see if there are rpms being built for Red Hate Enterprise Linux 3 these days. I see that the Red Hat rpms nowadays are for fc. but they aren't suitable for RHEL3 The download page says that the RedHat/Fedora area is for RedAht 8,9 and fedora, but I don't see any RedHa

Re: winegcc: sign-compare fixes

2007-02-08 Thread Joris Huizer
--- "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > On 2/7/07, Joris Huizer <[EMAIL PROTECTED]> > wrote: > > I believe this one causes problems -- please do > not commit yet > > > > Joris Huizer <[EMAIL PROTECTED]> wrote: > > > > > > Need Mail bonding? > > Go to

Re: [2] wineshelllink: Keep using the slash as path separator.

2007-02-08 Thread Vitaliy Margolen
Hans Leidekker wrote: > Fixes incorrect handling of paths with dashes. > And creates invalid menu entries. Did you test this patch with multi-level menu structure? When I tried your patch it created all menu entries in the top level menu, with the name like: wine-Programs-Ubi Soft-IL-2 Sturmovik D

Re: [GDI32] Fix for GetTextExtentExPointW() and ExtTextOutW() - Fixes Bug 50

2007-02-08 Thread John Smith
Hey Pedro, Was there supposed to be an attachment on your last message? I didn't see one. Regards, John Klehm On 2/8/07, Pedro Araujo Chaves Jr. <[EMAIL PROTECTED]> wrote: Attached is my proposed patch for Bug #50; the test case was attached in my previous message. -- Patch description: This

RasError.h? Where is this or does it not exist?

2007-02-08 Thread John Smith
Hey all, I cannot find the raserror.h file. I have tried looking around the wine directories to no avail. A find ./wine -name raserror.h -type f -print turns up nothing. Am I looking in the wrong spot or in the wrong way? I really want to think that the file isn't there but I can't rule out th

Re: advapi32: sign-compare fixes

2007-02-08 Thread Francois Gouget
On Wed, 7 Feb 2007, Vitaliy Margolen wrote: [...] > This isn't correct either. lstrlenW() also returns INT and you > can't just cast it to (unsigned). Unsigned what? int/long/dword? In C, 'unsigned' is synonymous with 'unsigned int'. So it's unambiguous. -- Francois Gouget <[EMAIL PROTECTED]>

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-08 Thread Marcus Meissner
On Tue, Feb 06, 2007 at 07:20:40PM +0100, Felix Nawothnig wrote: > Marcus Meissner wrote: > >>>- if(nRelPos>=0) { /* if this or preceding row */ > >>>+ if(nRelPos<=0) { /* if this or preceding row */ > >>> while(nRelPos<=0) { > >>Shouldn't that become a "do { ... } while()" then? > >No, since t

RE: Helping a user migrate an odbc app to Wine

2007-02-08 Thread Rolf Kalbermatter
Dan Kegel [mailto:[EMAIL PROTECTED] wrote: >Can somebody help this (german-speaking) fellow: >http://www.unixboard.de/vb3/showthread.php?t=26943 > >He says his company's internal application requires you to >input a DSN when installing it, and he doesn't know how to >come up with a DSN under Wine.

Re: ole32: Remove casts

2007-02-08 Thread Mike McCormack
Robert Shearman wrote: Ref counts can be assumed to be between 0 and MAXLONG, so the fact that LONG is signed isn't important. NO. The DCOM spec says that STDOBJREF::cPublicRefs is unsigned, therefore the ref counts can be assumed to be up to MAXULONG. Therefore, this change is incorrect an