Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-05 Thread James Hawkins
On 2/6/07, James Hawkins <[EMAIL PROTECTED]> wrote: On 2/5/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: > This is an update, a little less hacky thanks to advice from Dmitry > Timoshkov. This fixes bug #6992. The installer for Vector NTI 10 was > getting to the > point where it was trying to lau

Re: msi: InstallPackage check for UI level must not disregard flags (updated)

2007-02-05 Thread James Hawkins
On 2/5/07, Misha Koshelev <[EMAIL PROTECTED]> wrote: This is an update, a little less hacky thanks to advice from Dmitry Timoshkov. This fixes bug #6992. The installer for Vector NTI 10 was getting to the point where it was trying to launch the .msi files that do the actual install, but was quitt

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread Jan Zerebecki
On Mon, Feb 05, 2007 at 11:15:15PM -0600, John Smith wrote: > Is the GPL w/ library exception compatible with LGPL? Seems like they could > be similair. If so we could utilize the gnu PKCS7 code. Does any one know? IANAL but AFAIK, Yes, GPL w/ library exception like on http://www.gnu.org/softwa

Re: user32: WM_SETFONT on button doesn't repaint directly

2007-02-05 Thread Dmitry Timoshkov
"Clinton Stimpson" <[EMAIL PROTECTED]> wrote: This patch fixes WM_SETFONT on a button to not paint directly. Instead, it calls InvalidateRect. A test is included that demonstrates that no paint events come out of sending a WM_SETFONT. Thanks, Clinton Stimpson ChangeLog: Setting font on

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread [EMAIL PROTECTED]
On 2/5/07, John Smith <[EMAIL PROTECTED]> wrote: Yeah, I can no longer find them on MSDN. Laying the blame on MS all I can say is "nice!". On 2/5/07, Tom Wickline <[EMAIL PROTECTED]> wrote: > On 2/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > That would change the critical

Re: msi patch: Is this too hacky?

2007-02-05 Thread Misha Koshelev
That seems like a good way to do it. I sent an updated patch to wine-patches. Misha On Tue, 2007-02-06 at 12:15 +0800, Dmitry Timoshkov wrote: > "Misha Koshelev" <[EMAIL PROTECTED]> wrote: > > > Hi, I submitted the following patch to wine-patches but was thinking > > about it some more. The prob

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread John Smith
Is the GPL w/ library exception compatible with LGPL? Seems like they could be similair. If so we could utilize the gnu PKCS7 code. Does any one know? John On 2/5/07, Trent Waddington <[EMAIL PROTECTED]> wrote: On 2/6/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > Please break your patch

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread John Smith
Yeah, I can no longer find them on MSDN. On 2/5/07, Tom Wickline <[EMAIL PROTECTED]> wrote: On 2/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > That would change the critical path... how do you put that requirement > on a Gantt chart? Have a list of requirements that DNF depends on? :

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread Tom Wickline
On 2/5/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: That would change the critical path... how do you put that requirement on a Gantt chart? Have a list of requirements that DNF depends on? :D Tom :)

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread Trent Waddington
On 2/6/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: Please break your patch into logical pieces per dll and submit them separately. There is no need to patch ChangeLog, just provide a comment what your patch is doing. Ok. Seperate patches are attached, comment at the top of each. Thanks,

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread Dmitry Timoshkov
"Trent Waddington" <[EMAIL PROTECTED]> wrote: These changes make the Carbon Poker (www.carbonpoker.com) client work. Please break your patch into logical pieces per dll and submit them separately. There is no need to patch ChangeLog, just provide a comment what your patch is doing. -- Dmitry.

Re: [PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread Trent Waddington
On 2/6/07, Trent Waddington <[EMAIL PROTECTED]> wrote: These changes make the Carbon Poker (www.carbonpoker.com) client work. Run the Carbon Poker installer; then Run c:/windows/system32/Macromed/Flash/GetFlash.exe; then Run c:/windows/CarbonPoker/Poker.exe That should be c:/Program Files/Carb

Re: msvcrt: implement _mbbtype according to MSDN

2007-02-05 Thread Dmitry Timoshkov
"Juan Lang" <[EMAIL PROTECTED]> wrote: /* + * _mbbtype(MSVCRT.@) + */ +int CDECL _mbbtype(unsigned char c, int type) +{ +if (type == 1) +{ +if ((c >= 0x20 && c <= 0x7e) || (c >= 0xa1 && c <= 0xdf)) +r

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread [EMAIL PROTECTED]
On 2/5/07, Kai Blin <[EMAIL PROTECTED]> wrote: On Monday 05 February 2007 23:26, Jeremy White wrote: > So we can ask, once again: when will 1.0 ship!?!?! [...] > p.s. I think Wine will go 1.0 in the same year that is the > year of Linux on the Desktop . Oooh, can we make "Duke Nukem Forever ru

Re: msi patch: Is this too hacky?

2007-02-05 Thread Dmitry Timoshkov
"Misha Koshelev" <[EMAIL PROTECTED]> wrote: Hi, I submitted the following patch to wine-patches but was thinking about it some more. The problem is that you have the following UI levels and flags: INSTALLUILEVEL_NOCHANGE = 0, INSTALLUILEVEL_DEFAULT = 1, INSTALLUILEVEL_NONE = 2, INSTA

Re: Window focus testing

2007-02-05 Thread Dmitry Timoshkov
"Duane Clark" <[EMAIL PROTECTED]> wrote: Is it possible to do window focus testing in Wine conformance tests? Or does the windows not being mapped mean that this testing cannot be done? Or maybe I am doing something completely wrong; which is likely ;) Have a look at dlls/user32/tests/win.c,t

[PATCH] make CarbonPoker (previously Poker.com) client work.

2007-02-05 Thread Trent Waddington
These changes make the Carbon Poker (www.carbonpoker.com) client work. Run the Carbon Poker installer; then Run c:/windows/system32/Macromed/Flash/GetFlash.exe; then Run c:/windows/CarbonPoker/Poker.exe Screenshot: http://rtfm.insomnia.org/~qg/CarbonPoker-Ubuntu-wine.png If someone would like t

Re: Dead links

2007-02-05 Thread Tom Wickline
Hello, It's kind of bad when you intend on fixing broken URLs and then send one :) I have that page linked on my wiki page (and have since fixed) and was in a hurry and sent the old broke link. If all goes as planed I should have some free time starting next week to work on this. Cheers, Tom

msi patch: Is this too hacky?

2007-02-05 Thread Misha Koshelev
Hi, I submitted the following patch to wine-patches but was thinking about it some more. The problem is that you have the following UI levels and flags: INSTALLUILEVEL_NOCHANGE = 0, INSTALLUILEVEL_DEFAULT = 1, INSTALLUILEVEL_NONE = 2, INSTALLUILEVEL_BASIC = 3, INSTALLUILEVEL_RED

Re: Donation for your work on Direct 3D

2007-02-05 Thread Tom Wickline
On 2/1/07, H. Verbeet <[EMAIL PROTECTED]> wrote: > Send it to the Wine Party Fund, I'd say. Here is the link: http://www.winehq.org/site/contributing#wpf Cheers, Tom Henri

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread Kai Blin
On Monday 05 February 2007 23:26, Jeremy White wrote: > So we can ask, once again: when will 1.0 ship!?!?! [...] > p.s. I think Wine will go 1.0 in the same year that is the > year of Linux on the Desktop . Oooh, can we make "Duke Nukem Forever runs" a 1.0 release requirement? Then we could bun

Window focus testing

2007-02-05 Thread Duane Clark
Is it possible to do window focus testing in Wine conformance tests? Or does the windows not being mapped mean that this testing cannot be done? Or maybe I am doing something completely wrong; which is likely ;) I am specifically trying to test window focus in this bug: http://bugs.winehq.org/s

Re: It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread John Smith
You mean once wine 1.0 is shipped that will bring about the year of linux on the desktop. =) On 2/5/07, Jeremy White <[EMAIL PROTECTED]> wrote: So we can ask, once again: when will 1.0 ship!?!?! I'd invite anyone with an interest in attending to subscribe to the Wineconf mailing list: http

It's that time again - time to start thinking about WineConf 2007!

2007-02-05 Thread Jeremy White
So we can ask, once again: when will 1.0 ship!?!?! I'd invite anyone with an interest in attending to subscribe to the Wineconf mailing list: http://www.winehq.org/mailman/listinfo/wineconf I think an approach that makes sense is for us to discuss options as to where to hold it this year on t

Re: [try3]: user32/tests: add tests for WM_SETICON - what's wrong?

2007-02-05 Thread Kirill K. Smirnov
Hi, I've asked before: What's wrong with them? Maybe, unnecessary PeekMessage in tests??? http://www.winehq.org/pipermail/wine-patches/2007-January/035044.html http://www.winehq.org/pipermail/wine-patches/2007-January/035043.html Please, answer! Do not ignore! -- Kirill

Re: [Bug 6689] Created links do not reflect WINEPREFIX used

2007-02-05 Thread Lei Zhang
On 1/29/07, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote: Mandag 29 januar 2007 20:58, skrev Kuba Ober: > On Monday 29 January 2007 12:50, Tomas Carnecky wrote: > > Lei Zhang wrote: > > > Setting the Exec= line in a .desktop file to: WINEPREFIX=foo wine bar > > > worked in KDE. In Gnome,

Re: [PATCH] coverity: CID35: fixed wrong condition

2007-02-05 Thread Felix Nawothnig
Marcus Meissner wrote: - if(nRelPos>=0) { /* if this or preceding row */ + if(nRelPos<=0) { /* if this or preceding row */ while(nRelPos<=0) { Shouldn't that become a "do { ... } while()" then?

Re: [msvcrt] properly align struct _stati64's st_size

2007-02-05 Thread Damjan Jovanovic
On 2/5/07, Damjan Jovanovic <[EMAIL PROTECTED]> wrote: On 2/3/07, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: > > > In wine's struct _stati64, st_size has an offset of 20 bytes from the > > beginning of the struct, unlike mingw's and Window's 24. Th

Re: Synchronize code page 20127 table with Windows one

2007-02-05 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > That's not really possible due to a confusing license accompanying the > unicode.org > mappings, and a policy (until at least now) to not patch unicode.org provided > data. > Otherwise we have to patch the unicode collation table (I had a patch fo

Re: Bugzilla: Adding a 'patch' keyword

2007-02-05 Thread Francois Gouget
On Tue, 30 Jan 2007, Francois Gouget wrote: [...] > But it would be nice if there was an easy way to find bugs that have a > patch, even, and maybe especially, if it is incorrect. This would make > it easier for interested parties to survey what potential fixes are > languishing in Bugzilla and

Re: help in debugging

2007-02-05 Thread Ioannis Nousias
forgot to mention that I've added a bug report for this few weeks ago: http://bugs.winehq.org/show_bug.cgi?id=7227 and an entry in wine's Application Database: http://appdb.winehq.org/appview.php?iAppId=2922 regards Ioannis Damjan Jovanovic wrote: On 2/5/07, Ioannis Nousias <[EMAIL PROTECTED]

Re: Getting Fallout 2 to work well

2007-02-05 Thread Mitchell Mebane
Stefan Dösinger wrote: Am Freitag 02 Februar 2007 08:34 schrieb Joonas Koivunen: Profiling with oprofile (GDI session) shows that most of the time is used in the game (I suppose it's the "anon" from wine-preload), next most time consuming is winex11 drivers X11DRV_DIB_SetImageBits which seems

Re: help in debugging

2007-02-05 Thread Ioannis Nousias
Kuba Ober wrote: The application installs but with some error: "C:\Program Files\Fma\sframeword\helper\BramusICQ.dll Unable to register the DLL/OCX: LoadLibrary failed; code 126 Module not found." Can you try typing $ regsvr32 BramusICQ.dll manually? You'll have to do it from the direct

Re: comctl32 kibitzers wanted

2007-02-05 Thread Dimi Paun
On Mon, February 5, 2007 03:16, Dan Kegel wrote: > I and Lei Zhang, with some help from James Hawkins, > are leading a group of 13 UCLA students who are > writing conformance tests for comctl32. Brilliant! > Each student picked one control, and is now busily writing > getter/setter tests. In th

Re: help in debugging

2007-02-05 Thread Kuba Ober
> >> The application installs but with some error: > >> "C:\Program Files\Fma\sframeword\helper\BramusICQ.dll > >> Unable to register the DLL/OCX: LoadLibrary failed; code 126 > >> Module not found." > > > > Can you try typing > > $ regsvr32 BramusICQ.dll > > manually? You'll have to do it from the

Re: shell32: shlfileop tests: avoid buffer overflows for paths

2007-02-05 Thread Mikołaj Zalewski
@@ -329,8 +329,8 @@ static void test_delete(void) static void test_rename(void) { SHFILEOPSTRUCTA shfo, shfo2; -CHAR from[MAX_PATH]; -CHAR to[MAX_PATH]; +CHAR from[5*MAX_PATH]; +CHAR to[5*MAX_PATH]; DWORD retval; shfo.hwnd = NULL; This is really hacky. If th

Re: help in debugging

2007-02-05 Thread Ioannis Nousias
Damjan Jovanovic wrote: On 2/5/07, Ioannis Nousias <[EMAIL PROTECTED]> wrote: Hello Wine developers, I've decided to see what causes floAt's Mobile Agent[1] to fail with wine I checked the wine developers' cheatsheet to help me debug the application, but I'm lost. The application installs b

Re: help in debugging

2007-02-05 Thread Damjan Jovanovic
On 2/5/07, Ioannis Nousias <[EMAIL PROTECTED]> wrote: Hello Wine developers, I've decided to see what causes floAt's Mobile Agent[1] to fail with wine I checked the wine developers' cheatsheet to help me debug the application, but I'm lost. The application installs but with some error: "C:\Pro

help in debugging

2007-02-05 Thread Ioannis Nousias
Hello Wine developers, I've decided to see what causes floAt's Mobile Agent[1] to fail with wine I checked the wine developers' cheatsheet to help me debug the application, but I'm lost. The application installs but with some error: "C:\Program Files\Fma\sframeword\helper\BramusICQ.dll Unable

Re: shell32: shlfileop tests: avoid buffer overflows for paths

2007-02-05 Thread James Hawkins
On 2/4/07, Mikołaj Zalewski <[EMAIL PROTECTED]> wrote: These buffers can contain multiple paths and set_curr_dir_path can make the paths long resulting in a buffer overflow. From 36e05f3140e57bad2af790c56073799d23f7ef60 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <[EMAIL PRO

comctl32 kibitzers wanted

2007-02-05 Thread Dan Kegel
I and Lei Zhang, with some help from James Hawkins, are leading a group of 13 UCLA students who are writing conformance tests for comctl32. Each student picked one control, and is now busily writing getter/setter tests. In the coming few weeks we'll also try more interesting tests, like verifying