Re: Is anyone monitoring Transgaming's changes to the LGPL files?

2007-01-25 Thread Scott Ritchie
On Thu, 2007-01-25 at 19:38 -0500, Gavriel State wrote: > Hi Scott, > > We mostly haven't made many significant changes to the LGPL DLLs that > we've been picking up, other than modifications to allow them to build > within our somewhat different build environment. > > One place where we have

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

2007-01-25 Thread Mike McCormack
Scott Ritchie wrote: The simplest thing to do is for someone to just track the code they release and diff it against our own stuff, and note if anything new and interesting (eg an implementation of a function) comes up. Then send in a patch if it seems like it could help us too. But, is anyon

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

2007-01-25 Thread Gavriel State
Hi Scott, We mostly haven't made many significant changes to the LGPL DLLs that we've been picking up, other than modifications to allow them to build within our somewhat different build environment. One place where we have made changes recently was to the iphlpapi DLL, and we recently submi

Re: Is anyone monitoring Transgaming's changes to the LGPL files?

2007-01-25 Thread Gavriel State
Hi Scott, We mostly haven't made many significant changes to the LGPL DLLs that we've been picking up, other than modifications to allow them to build within our somewhat different build environment. One place where we have made changes recently was to the iphlpapi DLL, and we recently submi

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Alexandre Julliard
Stefan Leichter <[EMAIL PROTECTED]> writes: > Checking the _unix_build_ i find the missing stdole2.tlb in > ./dlls/stdole2.tlb > and ./include/stdole2.tlb. When doing the cross compile the one in the > include directory not generated. It is generated just fine for me. Make sure you don't have

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Stefan Leichter
Am Thursday 25 January 2007 13:08 schrieb Alexandre Julliard: > Stefan Leichter <[EMAIL PROTECTED]> writes: > > What parameters do i need to pass to configure for this case. If i do > > it like Paul Millar descripted it > > > > ../wine-git/configure --host=i586-mingw32msvc \ > > -with-wine-tools=..

Is anyone monitoring Transgaming's changes to the LGPL files?

2007-01-25 Thread Scott Ritchie
I don't know when it started, but Transgaming has been using LGPL chunks of Wine for quite some time. As they're required to, they've released the source for these files, along with whatever changes they've made. However, they're not required to tell us what they did, to send us patches, or to ev

Re: scroll window fix

2007-01-25 Thread Peter Oberndorfer
On Thursday 25 January 2007 18:56, Aric Stewart wrote: > finds the case where the scrolling amount exceeds the window but still falls > within the clipping rect. This generates an additional update region > that needs > to be invalidated. > includes a test Hi, I can't argue about the correctness o

Re: Patch to make X11DRV_GetAsyncKeyState work for TacOps

2007-01-25 Thread Martin Cracauer
Mike McCormack wrote on Thu, Jan 25, 2007 at 06:42:25PM +0900: > > Martin Cracauer wrote: > > >The game "TacOps" (a standalone 2D wargame, not to be mixed up with > >the Unreal mod "Tac Ops") uses home-grown scrollbars. They have > >autorepeat, that means holding the mouse button on the "down"

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

2007-01-25 Thread Anatoly Lyutin
Dmitry Timoshkov wrote: "Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 - 1.8 +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 - @@ -35,6 +35,9 @@ #include "winerror.h" #include "winnls.h" +#include "locale.h" +#include "tables_CP12

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

2007-01-25 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: I'd suggest to test specific strings instead of auto-generated tables. Since microsoft apparently uses their own unicode tables that differ from unicode.org ones that's almost impossible to get the exactly same behaviour among Wine and Windows. Unfort

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Alexandre Julliard
Stefan Leichter <[EMAIL PROTECTED]> writes: > What parameters do i need to pass to configure for this case. If i do > it like Paul Millar descripted it > > ../wine-git/configure --host=i586-mingw32msvc \ > -with-wine-tools=../wine-build That should work. Make sure you don't have a tmarshal.h in t

Re: Failing regression tests, how to solve?

2007-01-25 Thread Alexandre Julliard
Louis Lenders <[EMAIL PROTECTED]> writes: > Maybe it's due to renaming of gdi32 directory, but how can i solve this? > Regression testing is really impossible this way :( Remove all traces of libgdi32.def in your tree and rebuild. -- Alexandre Julliard [EMAIL PROTECTED]

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Paul Vriens
Stefan Leichter wrote: Alexandre Julliard schrieb: Stefan Leichter <[EMAIL PROTECTED]> writes: The problem is related to the fact that i'm doing out of tree builds. Therefore i have three directories: 1. wine-git : the source tree 2. wine-build : the normal build (unix) 3. wine-mingw : the cr

Failing regression tests, how to solve?

2007-01-25 Thread Louis Lenders
Hi, regression testing back to for example wine-0.9.22 all fails for me with link errors: palette.o: In function `X11DRV_PALETTE_ToPhysical': /sda3/wine-git/dlls/winex11.drv/palette.c:828: undefined reference to `GDI_GetObjPtr' /sda3/wine-git/dlls/winex11.drv/palette.c:848: undefined reference to `

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Stefan Leichter
Alexandre Julliard schrieb: Stefan Leichter <[EMAIL PROTECTED]> writes: The problem is related to the fact that i'm doing out of tree builds. Therefore i have three directories: 1. wine-git : the source tree 2. wine-build : the normal build (unix) 3. wine-mingw : the cross compile build If y

Re: cabinet: Fix overrun of static array (Coverity)

2007-01-25 Thread Alexandre Julliard
Andrew Talbot <[EMAIL PROTECTED]> writes: > This patch is aimed at fixing Coverity CID-297. The existing code writes > 52 values to a 51-value array. The patch code only writes the first 51. > > Please let me know what is wrong with this patch. It may well be correct, but I think both the old and

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Alexandre Julliard
Stefan Leichter <[EMAIL PROTECTED]> writes: > The problem is related to the fact that i'm doing out of tree builds. > Therefore i have three directories: > 1. wine-git : the source tree > 2. wine-build : the normal build (unix) > 3. wine-mingw : the cross compile build If you are doing a cross-c

Re: [try 4] slist support (2/2) slist declarations and functions

2007-01-25 Thread Mike McCormack
Damjan Jovanovic wrote: diff -ur a/include/winbase.h b/include/winbase.h --- a/include/winbase.h 2007-01-12 20:59:52.0 +0200 +++ b/include/winbase.h 2007-01-24 20:42:35.0 +0200 I would recommend you at least split the modifications to winbase into a separate patch, as they ar

Re: Patch to make X11DRV_GetAsyncKeyState work for TacOps

2007-01-25 Thread Mike McCormack
Martin Cracauer wrote: The game "TacOps" (a standalone 2D wargame, not to be mixed up with the Unreal mod "Tac Ops") uses home-grown scrollbars. They have autorepeat, that means holding the mouse button on the "down" or "up" icons will continue to scroll until you release the button. Without

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

2007-01-25 Thread Mike McCormack
Anatoly Lyutin wrote: Changelog: Add test for CompareStringA for non latin symbols. Hmm. + if (0) test_sorting_non_latin(); Adding a test that won't run... +/* If you want to get the source code of the program generating a file, + * please write to me on [EMAIL PROTECTED] + * Automatic

Re: make crosstest broken (tmarshal)

2007-01-25 Thread Michal Okresa
On Thursday 25 January 2007 07:51, Paul Vriens wrote: > as far as I can see it's not the fact that tmarshal.h is not there. It's > the fact it's not build, as the .idl files are there (on a clean Wine it's > not in the tests directory as well). On a 'normal' Wine-tree you will see > it being built:

Re: winex11.drv: Copy the GL extensions string because it may be freed.

2007-01-25 Thread Roderick Colenbrander
> On Wednesday 24 January 2007 21:51, Ken Thomases wrote: > > +WineGLInfo.glExtensions = strdup((const char *) > pglGetString(GL_EXTENSIONS)); > > Shouldn't this be free'd somewhere? What about the other strings? > The problem with this string is that it depends on the presence of a