Re: Tests for NtCreateMailslotFile

2007-01-24 Thread Jeff L
Vitaliy Margolen wrote: Jeff Latimer wrote: This is the first of some tests for NtCreateMailslotFile. I have included them in kernel32/tests as I thought it better that the Mailslot tests be collocated. Why do you need to test NtCreateMailslotFile directly? Why can't you use CreateMai

Re: Tests for NtCreateMailslotFile

2007-01-24 Thread Vitaliy Margolen
Jeff Latimer wrote: > This is the first of some tests for NtCreateMailslotFile. I have > included them in kernel32/tests as I thought it better that the Mailslot > tests be collocated. Why do you need to test NtCreateMailslotFile directly? Why can't you use CreateMailslot instead? Vitaliy.

Re: make crosstest broken (tmarshal)

2007-01-24 Thread Paul Vriens
Stefan Leichter wrote: Hello, the tmarshal tests broke cross compiling. Compiling fails for me with i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-

Re: cmdlg32: update Russian translation

2007-01-24 Thread Dmitry Timoshkov
"Vitaly Lipatov" <[EMAIL PROTECTED]> wrote: Changes: Done Russian translation PD32_NO_DEVICES translation is missing a comma after 'Проверьте'. IDS_COLOR_MAROON translation has a spelling error. -- Dmitry.

Re: [kernel32][tests][locale] Add test for CompareStringA for non latin symbols

2007-01-24 Thread Dmitry Timoshkov
"Anatoly Lyutin" <[EMAIL PROTECTED]> wrote: --- dlls/kernel32/tests/locale.c 5 Jan 2007 19:37:02 - 1.8 +++ dlls/kernel32/tests/locale.c 24 Jan 2007 14:15:14 - @@ -35,6 +35,9 @@ #include "winerror.h" #include "winnls.h" +#include "locale.h" +#include "tables_CP1251.h" I'd suggest to te

Re: winex11.drv: Copy the GL extensions string because it may be freed.

2007-01-24 Thread Chris Robinson
On Wednesday 24 January 2007 21:51, Ken Thomases wrote: > +WineGLInfo.glExtensions = strdup((const char *) pglGetString(GL_EXTENSIONS)); Shouldn't this be free'd somewhere? What about the other strings?

Patch to make X11DRV_GetAsyncKeyState work for TacOps

2007-01-24 Thread Martin Cracauer
The appended patch against the CVS version fixes one issue for me. The game "TacOps" (a standalone 2D wargame, not to be mixed up with the Unreal mod "Tac Ops") uses home-grown scrollbars. They have autorepeat, that means holding the mouse button on the "down" or "up" icons will continue to scrol

make crosstest broken (tmarshal)

2007-01-24 Thread Stefan Leichter
Hello, the tmarshal tests broke cross compiling. Compiling fails for me with i586-mingw32msvc-gcc -c -I../../../../wine-git/dlls/oleaut32/tests -I. -I../../../../wine-git/include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strin

Re: riched20: Don't create undos in ME_StreamIn

2007-01-24 Thread Alexandre Julliard
"Matt Finnicum" <[EMAIL PROTECTED]> writes: > This fixes bug 7148 - a regression caused by one of my older patches. > This restores the old code that prevented ME_StreamIn from erroneously > creating undos. > > Changelog: > riched20: Don't create undos in ME_StreamIn It breaks the tests: ../../.

Re: add support for slists

2007-01-24 Thread Tomas Carnecky
Dmitry Timoshkov wrote: > And one more... > > "Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: > >> +__int64 interlocked_cmpxchg64( __int64 **dest, __int64 *xchg, __int64 >> *compare ) >> +{ >> +_lwp_mutex_lock( &interlocked_mutex ); >> +if (memcmp(*dest, compare, 8) == 0) >> +memcpy

Re: add support for slists

2007-01-24 Thread Dmitry Timoshkov
And one more... "Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: +__int64 interlocked_cmpxchg64( __int64 **dest, __int64 *xchg, __int64 *compare ) +{ +_lwp_mutex_lock( &interlocked_mutex ); +if (memcmp(*dest, compare, 8) == 0) +memcpy(*dest, xchg, 8); +else +memcpy(com

Re: add support for slists

2007-01-24 Thread Dmitry Timoshkov
And some other problems with the patch: "Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: --- a/include/winbase.h 2007-01-09 17:42:47.0 +0200 +++ b/include/winbase.h 2007-01-24 09:50:04.0 +0200 @@ -2343,6 +2343,14 @@ #endif /* __i386__ && __GNUC__ && __WINESRC__ && !_NTSYSTEM_ *

Re: add support for slists

2007-01-24 Thread Dmitry Timoshkov
"Damjan Jovanovic" <[EMAIL PROTECTED]> wrote: +kernel32 = LoadLibraryA("KERNEL32.DLL"); All the kernel32 tests are already implicitly linked to kernel32.dll, therefore GetModuleHandle("kernel32.dll") is perfectly enough and is guaranteed to succeed. +if (kernel32 == NULL) +{ +