Re: d3d9: Add a render target test

H. Verbeet wrote: On 20/12/06, H. Verbeet <[EMAIL PROTECTED]> wrote: This time as part of the device.c test. Changelog: - Add a render target test Use the attached patch instead, the previous version doesn't apply. This test really belongs in stateblock.c, along with every other set <--> g

Re: kernel32 console bug?

Eric Pouech wrote: if you move the test() call a couple of lines below, when the console is actually created, it should work. for the actual program to run, you should use wineconsole. A+ 2006/12/20, Robert Reif <[EMAIL PROTECTED] >: I get an error when runnin

Re: usp10: impelment ScriptStringGetLogicalWidths

Quoting Alexandre Julliard <[EMAIL PROTECTED]>: > Clinton Stimpson <[EMAIL PROTECTED]> writes: > > > This patch implements ScriptStringGetLogicalWidths. > > Update usp10.spec so it isn't a stub anymore. > > Also added a test for this function. > > The test fails for me: > > ../../../tools/runtest

Re: setupapi: Use GetSystemDirectory() rather than hardcoding 'system32'.

Francois Gouget <[EMAIL PROTECTED]> writes: > @@ -87,13 +87,13 @@ static HINF search_for_inf(LPCVOID InfSpec, DWORD > SearchControl) > HINF hInf = INVALID_HANDLE_VALUE; > WCHAR inf_path[MAX_PATH]; > > +static const WCHAR bslashW[] = {'\\',0}; > static const WCHAR infW[] = {'\

Re: usp10: impelment ScriptStringGetLogicalWidths

Clinton Stimpson <[EMAIL PROTECTED]> writes: > The test passed on my machine. > I double checked with the native usp10.dll, and it gives the same failure. > Perhaps it is my machine? I guess I'll change the test to expect the value > the > native usp10.dll gives, and it'll pass on yours, and liv

Re: gdi32: Improve the fontconfig filtering hack so that Mac suitcase fonts get through.

On Wed, 2006-12-20 at 17:59 +, Huw Davies wrote: > On Wed, Dec 20, 2006 at 06:37:22PM +0100, Paul Vriens wrote: > > On Tue, 2006-12-19 at 21:21 +, Huw Davies wrote: > > > +if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) > > > AddFontFileToList(file, NULL, ADDFONT_E

Re: gdi32: Improve the fontconfig filtering hack so that Mac suitcase fonts get through.

On Wed, Dec 20, 2006 at 06:37:22PM +0100, Paul Vriens wrote: > On Tue, 2006-12-19 at 21:21 +, Huw Davies wrote: > > +if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) > > AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); > Hi, > > this patch was committed but I don

Re: gdi32: Improve the fontconfig filtering hack so that Mac suitcase fonts get through.

On Tue, 2006-12-19 at 21:21 +, Huw Davies wrote: > +if(strcasecmp(ext, "pfa") && strcasecmp(ext, "pfb")) > AddFontFileToList(file, NULL, ADDFONT_EXTERNAL_FONT); Hi, this patch was committed but I don't think this 'if' statement is correct as it will never be entered. No c

Re: [dinput] regression c17e06d5c0e456d3052a1b6de688956f87c59d3e: No need to copy default constant format. Use already defined static instead

Christoph Frick wrote: > The old code copied the default constant format and applied > caclulate_ids on it. So the dwTypes where set with proper > MAKEINSTANCE(...) calls. So an app, that requested later its own data > format with SetDataFormat using the data from EnumObjects. After the > change no

Re: usp10: impelment ScriptStringGetLogicalWidths

Clinton Stimpson <[EMAIL PROTECTED]> writes: > This patch implements ScriptStringGetLogicalWidths. > Update usp10.spec so it isn't a stub anymore. > Also added a test for this function. The test fails for me: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.

Re: kernel32: suppress an unneeded warning (try 3)

Juan Lang <[EMAIL PROTECTED]> writes: > This time I added a test. It wouldn't have failed before, it would merely > produce a useless fixme. This suppresses that fixme by removing comments > before checking whether the read string overflows the buffer. > > ChangeLog: remove comments from string

Re: ws2_32: ws_sockaddr_u2ws should zero the WS_sockaddr before using it.

On Wednesday 20 December 2006 13:37, Francois Gouget wrote: > On Wed, 20 Dec 2006, Kai Blin wrote: > > @@ -946,6 +946,9 @@ static int ws_sockaddr_u2ws(const struct > { > int res; > > +/* Zero the ws_sockaddr structure before using */ > +memset(wsaddr, 0, *wsaddrlen); > > Are you sure

Re: kernel32 console bug?

Eric Pouech wrote: if you move the test() call a couple of lines below, when the console is actually created, it should work. for the actual program to run, you should use wineconsole. A+ 2006/12/20, Robert Reif <[EMAIL PROTECTED] >: I get an error when runnin

Re: ws2_32: ws_sockaddr_u2ws should zero the WS_sockaddr before using it.

On Wed, 20 Dec 2006, Kai Blin wrote: @@ -946,6 +946,9 @@ static int ws_sockaddr_u2ws(const struct { int res; +/* Zero the ws_sockaddr structure before using */ +memset(wsaddr, 0, *wsaddrlen); Are you sure this is needed in ws_sockaddr_u2ws() or should it rather be done by getsock

Re: [5/5] d3d9: Add a render target test

"H. Verbeet" <[EMAIL PROTECTED]> writes: > Test if the stuff I just sent works. > > Changelog: > - Add a render target test > --- > > dlls/d3d9/tests/Makefile.in|1 > dlls/d3d9/tests/rendertarget.c | 156 > Could you please merge the test into

[dinput] regression c17e06d5c0e456d3052a1b6de688956f87c59d3e: No need to copy default constant format. Use already defined static instead

hiho with that patch: commit c17e06d5c0e456d3052a1b6de688956f87c59d3e Author: Vitaliy Margolen <[EMAIL PROTECTED]> Date: Sun Dec 10 14:15:08 2006 -0700 dinput: No need to copy default constant format. Use already defined static instead. :100644 100644 c5a35a1... 369c26d... M dlls/dinput

Re: kernel32 console bug?

if you move the test() call a couple of lines below, when the console is actually created, it should work. for the actual program to run, you should use wineconsole. A+ 2006/12/20, Robert Reif <[EMAIL PROTECTED]>: I get an error when running a windows console program on wine. It appears that