Re: usp10: fix tests to allow atomic patches for new implementation

2006-12-14 Thread James Hawkins
On 12/15/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Here's a patch to make unimplemented functions return E_NOTIMPL instead of S_OK. Even dependent functions already return E_NOTIMPL. Also fixing tests to check that the return value is S_OK before testing the 'out' parameters. This fi

Re: [5/5] usp10: remote todo_wine

2006-12-14 Thread James Hawkins
On 12/15/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Ok. There are 4 functions that have to be implemented at the same time in order to not break any tests, because of how the tests were written. A few days ago, I sent a single patch that implemented those 4 functions, including an update of

Re: Removed as super maintainer

2006-12-14 Thread Tony Lambregts
Edward Savage wrote: > All of the maintainers for EVE Online > (http://appdb.winehq.org/appview.php?iVersionId=6278) have been removed. > Their back. We have restored all the supermaintainers now. If we have missed anyone somehow we would like to know. -- Tony Lambregts

Re: [5/5] usp10: remote todo_wine

2006-12-14 Thread James Hawkins
On 12/14/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Part 5 of 5. Remove many todo_wine's from the tests, now that the functions are implemented. You have to remove the todo_wine's in the same patch that fixes the tests, or the tests will fail for at least one commit. Patches have to

Re: usp10: implement ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX

2006-12-14 Thread Vijay Kiran Kamuju
Hi, It may be because you need to split it into smaller individual patches. Its rather a one big patch. Cheers, VJ On 12/14/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Can I get some feedback on this patch? It appears to have been rejected. Thanks, Clinton Clinton Stimpson wrote:

Re: usp10: implement ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX

2006-12-14 Thread Stefan Dösinger
Am Donnerstag 14 Dezember 2006 15:58 schrieb Clinton Stimpson: > Hi, > > Can I get some feedback on this patch? > It appears to have been rejected. I don't know about the details of usp10, but from the topic of your mail I think you should send 4 patches, one for each function. pgp4pwx8XvVj4.pgp

Re: usp10: implement ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX

2006-12-14 Thread Clinton Stimpson
Hi, Can I get some feedback on this patch? It appears to have been rejected. Thanks, Clinton Clinton Stimpson wrote: This patch implements ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX. Also, many todo_wine's are removed. Thanks, Clinto

oleaut32: bypass conversion to string in R4/R8 -> DECIMAL conversion (RESEND)

2006-12-14 Thread Alex Villací­s Lasso
Alex Villací­s Lasso escribió: Alexandre Julliard escribió: Alex Villací­s Lasso <[EMAIL PROTECTED]> writes: This patch added the setlocale(LC_ALL, "") line to dlls/kernel32/locale.c . The oleaut32 tests for vartype.c have been failing since that time on non-English locales. I see now that

Re: mshtml #5: Set default print template in exec_print.

2006-12-14 Thread Frank Richter
On 14.12.2006 09:10, Jacek Caban wrote: >> Could it be you forgot to submit the .rc file changes for these new >> strings? >> > .rc changes are in an other patch: > http://www.winehq.org/pipermail/wine-patches/2006-December/033782.html Ah sorry, didn't notice. -f.r. signature.asc Descriptio

Re: msxml.dll: nextNode and reset functions

2006-12-14 Thread Huw Davies
On Thu, Dec 14, 2006 at 11:41:25AM +0100, Colin Pitrat wrote: > Change Log: > Add an iterator to _xmlnodemap struct > Implement nextNode function that give nodes one by one > Implement resetNode that reset the iterator > > It's my first patch, so please tell me if something is wr

Re: [1/2] tests: Add skip_wine, a standard way to skip tests that would cause Wine to crash.

2006-12-14 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > I see some advantages though: > * the code exists rather than not being written in the first place > * it is compiled, which is better than putting it inside an '#if 0' > * 'skip_wine' clearly indicates that the test needs to be fixed in >Wine,

Re: [1/2] tests: Add skip_wine, a standard way to skip tests that would cause Wine to crash.

2006-12-14 Thread Francois Gouget
On Thu, 14 Dec 2006, Alexandre Julliard wrote: [...] > It's not really better with skip_wine; since the test will never be > run on Wine it's useless for regression testing, and we won't even > notice when the bug gets fixed. I see some advantages though: * the code exists rather than not being w

Re: Add ddrawex dll

2006-12-14 Thread Alexandre Julliard
Ulrich Czekalla <[EMAIL PROTECTED]> writes: > diff --git a/dlls/dxguid/dxguid.c b/dlls/dxguid/dxguid.c > index c2c102f..7ea8d17 100644 > --- a/dlls/dxguid/dxguid.c > +++ b/dlls/dxguid/dxguid.c > @@ -44,3 +44,4 @@ > #include "ddrawi.h" > #include "dxfile.h" > #include "d3drm.h" > +#include "ddra

Re: [1/2] tests: Add skip_wine, a standard way to skip tests that would cause Wine to crash.

2006-12-14 Thread Alexandre Julliard
Francois Gouget <[EMAIL PROTECTED]> writes: > Currently there is no standard way of adding a test that works on > Windows but is known to cause Wine to crash. For instance this is > the case for bug 6827: > > Bug 6827: The SimSig installer crashes > http://bugs.winehq.org/show_bug.cgi?id=6827 >

Re: Removed as super maintainer

2006-12-14 Thread Edward Savage
All of the maintainers for EVE Online ( http://appdb.winehq.org/appview.php?iVersionId=6278) have been removed. On 12/14/06, Tony Lambregts <[EMAIL PROTECTED]> wrote: Aaron Slunt wrote: > So do we have to reapply now, or can you just readd me as > supermaintainer to half-life sound selector? My

Re: mshtml #5: Set default print template in exec_print.

2006-12-14 Thread Jacek Caban
Frank Richter wrote: On 14.12.2006 00:21, Jacek Caban wrote: --- a/dlls/mshtml/resource.h +++ b/dlls/mshtml/resource.h @@ -28,6 +28,9 @@ #define IDS_MESSAGE_BOX_TITLE 2213 +#define IDS_PRINT_HEADER_TEMPLATE 8403 +#define IDS_PRINT_FOOTER_TEMPLATE 8404 + Could it be you forgot