Re: msi 2: Remove redundant NULL checks before x_Release

2006-12-01 Thread Mike McCormack
James Hawkins wrote: Changelog: * Remove redundant NULL checks before x_Release. obj->Release() will read the vtable pointer from the object, and that will crash if obj is NULL, so these checks are needed. The following code will crash: IUnknown *obj = NULL; IUnknown_Release(obj); You c

Wined3d State management again

2006-12-01 Thread Stefan Dösinger
Hi, I've done some more work on my state management, and I uploaded an updated patch to http://stud4.tuwien.ac.at/~e0526822/wined3d-statemgmt-2.tar.bz2 . Ok, so what's updated: * Pixel shaders: Should work now * GLSL shaders: Working too. Henris shader backend stuff is integrated in a messy way.

Re: Concerning the separate OpenAL32.dll thunk patch and OpenALwinmm driver patch

2006-12-01 Thread Nick Burns
From: Alexandre Julliard <[EMAIL PROTECTED]> To: "Nick Burns" <[EMAIL PROTECTED]> CC: wine-devel@winehq.org Subject: Re: Concerning the separate OpenAL32.dll thunk patch and OpenALwinmm driver patch Date: Fri, 01 Dec 2006 13:49:52 +0100 "Nick Burns" <[EMAIL PROTECTED]> writes: > Again -- for t

Re: Concerning the separate OpenAL32.dll thunk patch andOpenALwinmm driver patch

2006-12-01 Thread Nick Burns
Sorry I should have reiterated more clearly... Yes you can dl jack -- but it has never worked correctly for me...(I could try Jack again -- it has been a while) esd -- but it too did not work so well (very laggy sound) liboss -- but i dont think that the alpha version compiles under os

Re: Video problems with FC6

2006-12-01 Thread Andreas Bierfert
On Fri, 01 Dec 2006 09:13:31 -0500 gslink <[EMAIL PROTECTED]> wrote: > There is currently a bug in FC6 that affects Wine. If, with any Nvidia > driver from any source, a program attempts to use accelerated video and > the attached monitor uses digital feed the program will often crash the > us

Re: [PATCH 1/9] dinput: Move acquired flag to the base device class.

2006-12-01 Thread Vitaliy Margolen
Peter Oberndorfer wrote: > On Friday 01 December 2006 07:23, Vitaliy Margolen wrote: >> >> --- >> dlls/dinput/device.c | 28 >> dlls/dinput/device_private.h |3 +++ >> dlls/dinput/joystick_linux.c | 23 --- >> dlls/dinput/keyboard.c

Re: Concerning the separate OpenAL32.dll thunk patch and OpenALwinmm driver patch

2006-12-01 Thread Pierre d'Herbemont
On 1 déc. 06, at 00:54, Nick Burns wrote: Again -- for the sound drivers -- Mac OSX has ONE sound driver ONE I would like to have a choice. In fact there is at least two working sound driver: you can also use the Jack driver on Mac OS X if you've downloaded [1] at compile time which by th

Video problems with FC6

2006-12-01 Thread gslink
There is currently a bug in FC6 that affects Wine. If, with any Nvidia driver from any source, a program attempts to use accelerated video and the attached monitor uses digital feed the program will often crash the user session. This has been reported and is not a problem in Wine but a good m

Re: user32: Factorize graphics driver's WindowCreate and ShowWindowin user32.

2006-12-01 Thread Pierre d'Herbemont
On 1 déc. 06, at 08:38, Dmitry Timoshkov wrote: The problem is that for top level windows we need to route ShowWindow actions to a Window Manager/Host Windowing System, so that actions like minimize/maximize/restore would be properly handled. We don't do this at the moment, but we need to. ok

Re: oleaut32: add VarBstrCmp binary comparison for LCID==0

2006-12-01 Thread Dmitry Timoshkov
"Charles Blacklock" <[EMAIL PROTECTED]> wrote: Cool, the attached patch does this now. Is this any better? Yes (although I'd personally move local variables under the "if (lcid == 0)" case), please send it to wine-patches. -- Dmitry.

Re: Concerning the separate OpenAL32.dll thunk patch and OpenALwinmm driver patch

2006-12-01 Thread Alexandre Julliard
"Nick Burns" <[EMAIL PROTECTED]> writes: > Again -- for the sound drivers -- Mac OSX has ONE sound driver ONE > I would like to have a choice. Why? What does it do that you cannot do with the CoreAudio driver? > Yes my wineopenal patch is not perfect (based on broken code does not > help) -- I

Re: [PATCH 1/9] dinput: Move acquired flag to the base device class.

2006-12-01 Thread Peter Oberndorfer
On Friday 01 December 2006 07:23, Vitaliy Margolen wrote: > Sorry ignore my previous patches. I didn't send them in the proper order. > > --- > dlls/dinput/device.c | 28 > dlls/dinput/device_private.h |3 +++ > dlls/dinput/joystick_linux.c | 23 ++

Re: oleaut32: add VarBstrCmp binary comparison for LCID==0

2006-12-01 Thread Dmitry Timoshkov
"Charles Blacklock" <[EMAIL PROTECTED]> wrote: +if (lcid == 0) +{ + ret = memcmp(pbstrLeft, pbstrRight, min(SysStringByteLen(pbstrLeft), SysStringByteLen(pbstrRight))); + if (ret < 0) +return VARCMP_LT; + if (ret > 0) +return VARCMP_GT; + if (SysStrin