Re: ntdll: Add a stub implementation for RtlDllShutdownInProgress.

2006-11-02 Thread Mike McCormack
Robert Shearman wrote: +NTSTATUS WINAPI RtlDllShutdownInProgress(void) For undocumented functions like this, you should add a test case. That's unreasonable. A stub isn't meant to work correctly, just stop an application from crashing. What will a test case prove? Mike

Re: winex11.drv: Bug#6501. XIM problem with XInitThreads().

2006-11-02 Thread Dmitry Timoshkov
"Byeong-Sik Jeon" <[EMAIL PROTECTED]> wrote: http://www.winehq.org/pipermail/wine-cvs/2006-October/026680.html winex11.drv: Give XInitThreads another chance. --- dlls/winex11.drv/x11drv_main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/winex11.drv/x11drv_m

winex11.drv: Bug#6501. XIM problem with XInitThreads().

2006-11-02 Thread Byeong-Sik Jeon
http://www.winehq.org/pipermail/wine-cvs/2006-October/026680.html > winex11.drv: Give XInitThreads another chance. > > --- > > dlls/winex11.drv/x11drv_main.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_m

Re: winhlp32 implementation

2006-11-02 Thread Frank Richter
On 02.11.2006 22:04, Eric Pouech wrote: > Kirill K. Smirnov wrote: > >> Eric, >> there is a mess in winhelp and winhlp32 in "Context" and "Topic" concept: >> what winhelp calls "topic", winhlp32 calls "context", and what winhelp >> calls "Context" winhlp32 calls "Topic without CNT section". >> S

Re: winhlp32 implementation

2006-11-02 Thread Frank Richter
On 02.11.2006 22:04, Eric Pouech wrote: > Kirill K. Smirnov wrote: > >> Eric, >> there is a mess in winhelp and winhlp32 in "Context" and "Topic" concept: >> what winhelp calls "topic", winhlp32 calls "context", and what winhelp >> calls "Context" winhlp32 calls "Topic without CNT section". >> S

Re: Patch for opengl32.dll.so

2006-11-02 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Hi, I think that the patch which I just sent titled 'X11DRV: opengl init fix' should fix the issues. The patch makes sure that opengl is initialized when x11drv wgl functions are called. Regards, Roderick Your patch works OK for me. It fixes the crash when lauc

Re: Patch for opengl32.dll.so

2006-11-02 Thread Roderick Colenbrander
> Roderick Colenbrander wrote: > >> Roderick Colenbrander wrote : > >> > On 11/1/06, Bertrand Coconnier <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > The last release of Wine 0.9.24 contains an error in the code of > > > opengl32.dll.so >

Re: winhlp32 implementation

2006-11-02 Thread Eric Pouech
Kirill K. Smirnov wrote: Eric, there is a mess in winhelp and winhlp32 in "Context" and "Topic" concept: what winhelp calls "topic", winhlp32 calls "context", and what winhelp calls "Context" winhlp32 calls "Topic without CNT section". So, the buttons are messed too. I suspect there are oth

Re: comctl32: Don't free user32 objects with a gdi32 function in imagelist test.

2006-11-02 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Use DestroyIcon for releasing the resources associated with created icons. That's probably correct, but it causes the test to fail: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so imagelist.c && touch imagelist.

Re: Patch for opengl32.dll.so

2006-11-02 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Compared to 0.9.23 I changed the way wglGetIntegerv is loaded before it was directly loaded using GetProcAddress from winex11.drv now it is still loaded from winex11.drv but then using wglGetProcAddress from gdi32. At wine startup (I'm not sure at which stage but

Re: Patch for opengl32.dll.so

2006-11-02 Thread Christoph Frick
On Thu, Nov 02, 2006 at 02:25:33PM +0100, Roderick Colenbrander wrote: > Hmm, if that is indeed the case this patch could work for them. The > whole issue is new for me, I'll see what I can do about it. Right now > there's some GLX code in opengl32 which creates an opengl context. I > was planning

Re: ntdll: Add a stub implementation for RtlDllShutdownInProgress.

2006-11-02 Thread Robert Shearman
Mike McCormack wrote: +NTSTATUS WINAPI RtlDllShutdownInProgress(void) +{ +FIXME("\n"); +return STATUS_SUCCESS; +} For undocumented functions like this, you should add a test case. -- Rob Shearman

Re: Patch for opengl32.dll.so

2006-11-02 Thread Roderick Colenbrander
> Roderick Colenbrander wrote: > >> Roderick Colenbrander wrote : > >> > On 11/1/06, Bertrand Coconnier <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > The last release of Wine 0.9.24 contains an error in the code of > > > opengl32.dll.so >

Re: Patch for opengl32.dll.so

2006-11-02 Thread Nick Law
Roderick Colenbrander wrote: Roderick Colenbrander wrote : On 11/1/06, Bertrand Coconnier <[EMAIL PROTECTED]> wrote: Hi, The last release of Wine 0.9.24 contains an error in the code of opengl32.dll.so under X11 : Wine tries to get the address of "wglGetInte

Re: Patch for opengl32.dll.so

2006-11-02 Thread Roderick Colenbrander
> Roderick Colenbrander wrote : > >> On 11/1/06, Bertrand Coconnier <[EMAIL PROTECTED]> wrote: > >>> Hi, > >>> > >>> The last release of Wine 0.9.24 contains an error in the code of > >> opengl32.dll.so > >>> under X11 : Wine tries to get the address of "wglGetIntegerv" (line > 608 > >> of > >>> dl