Re: wined3d base GLX requirement

2006-09-27 Thread Stefan Dösinger
Hi, > Why should someone have to install glx to run Wine if they don't care > about using wined3d, or if they do need to use wined3d they don't care > about using glx? Well, glx is a base requirement for getting OpenGL set up, which we need for d3d functionality. So wined3d without glx does not ma

Re: Linklint results for winehq

2006-09-27 Thread Tom Wickline
On 9/28/06, Tom Wickline <[EMAIL PROTECTED]> wrote: Hello, I ran our linklint script on winehq and here's the results. I will try and fix as many errors as possible over the next couple weeks. Tom --- Processing ... writing files to linklint wrote 25 txt files wrote 23 html files wrote index

Linklint results for winehq

2006-09-27 Thread Tom Wickline
Hello, I ran our linklint script on winehq and here's the results. I will try and fix as many errors as possible over the next couple weeks. Tom --- Processing ... writing files to linklint wrote 25 txt files wrote 23 html files wrote index file index.html found 1 default index found 476 c

Re: wined3d base GLX requirement

2006-09-27 Thread James Hawkins
On 9/27/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: James Hawkins wrote: > On 9/27/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >> The current base GLX requirement for wined3d seems to be v1.3. >> It won't compile otherwise... I wrote a patch for pbuffers, which adds >> proper extension support

Re: wined3d base GLX requirement

2006-09-27 Thread Ivan Gyurdiev
James Hawkins wrote: On 9/27/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: The current base GLX requirement for wined3d seems to be v1.3. It won't compile otherwise... I wrote a patch for pbuffers, which adds proper extension support for SGIX_PBUFFER and SGIX_FBCONFIG, but: - even with the patch

Re: wined3d base GLX requirement

2006-09-27 Thread James Hawkins
On 9/27/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: The current base GLX requirement for wined3d seems to be v1.3. It won't compile otherwise... I wrote a patch for pbuffers, which adds proper extension support for SGIX_PBUFFER and SGIX_FBCONFIG, but: - even with the patch there's additional of

wined3d base GLX requirement

2006-09-27 Thread Ivan Gyurdiev
The current base GLX requirement for wined3d seems to be v1.3. It won't compile otherwise... I wrote a patch for pbuffers, which adds proper extension support for SGIX_PBUFFER and SGIX_FBCONFIG, but: - even with the patch there's additional offenders in directx.c that prevent a compile with gl

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Vitaliy Margolen
Ge van Geldorp wrote: >> From: Mike McCormack [mailto:[EMAIL PROTECTED] >> >> Seems like that is a system that doesn't scale well at all, >> as it requires Alexandre to specifically respond to each and >> every patch. > > No, it doesn't require that. It requires *someone* to respond, that could

Re: [PATCH] Also show 24bit modes as supported, but still handle them like 32bit later

2006-09-27 Thread Vitaliy Margolen
Christoph Frick wrote: > hi > > would someone please comment on that patch? this is a nearly unchanged > version of my previous attempt - but this time against current git. > > -static const unsigned int depths[] = {8, 16, 32}; > +static const unsigned int depths[] = {8, 16, 32, 24}; > +static

Re: Problem with NtReadVirtualMemory and wine server connection

2006-09-27 Thread Vitaliy Margolen
Juan Lang wrote: >> 1. allocate a temporary buffer in NtReadVirtualMemory, read server >> answer to this buffer, and then inside a try / catch block copy to >> application memory > > This would be my preference, for two reasons: > 1. This would allow the test to pass, that is, we could successfull

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Troy Rollo
On Thursday 28 September 2006 05:49, Mike McCormack wrote: > Seems like that is a system that doesn't scale well at all, as it > requires Alexandre to specifically respond to each and every patch. He still has to take an action to review each patch now, and presumably some action to remove it fr

RE: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Ge van Geldorp
> From: Mike McCormack [mailto:[EMAIL PROTECTED] > > Seems like that is a system that doesn't scale well at all, > as it requires Alexandre to specifically respond to each and > every patch. No, it doesn't require that. It requires *someone* to respond, that could be a fellow developer on wine

Re: How hard is Uniscribe's ScriptLayout() to implement?

2006-09-27 Thread Dan Kegel
On 9/27/06, Hans Leidekker <[EMAIL PROTECTED]> wrote: On Wednesday 27 September 2006 21:42, Dan Kegel wrote: > Have you tried submitting your stub? Not yet, does it work for you too? Yup, seems to! > Got a URL for that? http://live.gnome.org/Boston2006/TextLayout Interesting. - Dan

Re: Appdb as application regression finder

2006-09-27 Thread James Hawkins
On 9/27/06, Tom Spear <[EMAIL PROTECTED]> wrote: On 9/27/06, James Hawkins <[EMAIL PROTECTED]> wrote: > We've run into this before with the Warhammer 40k installer. When we > find that the downloadable trial version works, but the cd installer > doesn't, we take off the download keyword. Adding

Re: Appdb as application regression finder

2006-09-27 Thread Tom Spear
On 9/27/06, James Hawkins <[EMAIL PROTECTED]> wrote: We've run into this before with the Warhammer 40k installer.  When wefind that the downloadable trial version works, but the cd installerdoesn't, we take off the download keyword.  Adding more than one typeof download keyword will add too much no

Re: Route WGL font code through gdi32.dll

2006-09-27 Thread Huw Davies
On Wed, Sep 27, 2006 at 11:34:35PM +0200, Roderick Colenbrander wrote: > Hi, > > This patch routes the WGL font code through gdi32.dll. The patch depends on > the other routing patch which routed the WGL context code through gdi32.dll. > --- dlls/opengl32/opengl32.spec 2006-09-25 23:15:35.0

Re: Appdb as application regression finder

2006-09-27 Thread James Hawkins
On 9/27/06, Tom Spear <[EMAIL PROTECTED]> wrote: On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: > On 9/27/06, Tom Spear <[EMAIL PROTECTED]> wrote: > > On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: > > > Also, I'd like to see us add a checkbox which is the equivalent of > > > the 'download'

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread James Hawkins
On 9/27/06, Mike McCormack <[EMAIL PROTECTED]> wrote: Responding to each and every patch seems like it would be a waste of Alexandre's time. We should encourage more people to participate in the patch review process, so that we have more reviewers and a more scalable process. +1 -- James Ha

Re: LOSTWAGES: Instructions for getting additional modules

2006-09-27 Thread Tom Wickline
On 9/27/06, Mike McCormack <[EMAIL PROTECTED]> wrote: It would be nice to move the remaining modules to Git too, IMO. And you can do all future web site matince IMO! Tom Mike

Re: Appdb as application regression finder

2006-09-27 Thread Tom Spear
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: On 9/27/06, Tom Spear <[EMAIL PROTECTED]> wrote:> On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote:> > Also, I'd like to see us add a checkbox which is the equivalent of > > the 'download' keyword.  That would let people who want to work> > on problem

Re: LOSTWAGES: Instructions for getting additional modules

2006-09-27 Thread Mike McCormack
Detlef Riekenberg wrote: When switching the Instructions for the Wine tree from cvs to git, the Instructions for the additional modules (docs, lostwages, ...) got lost. They're still available at the old link: http://www.winehq.org/site/cvs It would be nice to move the remaining modules to G

Re: How hard is Uniscribe's ScriptLayout() to implement?

2006-09-27 Thread Hans Leidekker
On Wednesday 27 September 2006 21:42, Dan Kegel wrote: > Have you tried submitting your stub? Not yet, does it work for you too? > Got a URL for that? http://live.gnome.org/Boston2006/TextLayout -Hans

Re: How hard is Uniscribe's ScriptLayout() to implement?

2006-09-27 Thread Dan Kegel
On 9/27/06, Hans Leidekker <[EMAIL PROTECTED]> wrote: > usp10.ScriptLayout() isn't implemented. > How hard would it be to fix this? As long as you don't use RTL scripts (such as Arabic, Farsi, Hebrew) a stub like the one I attached to the bug should do the job nicely. This goes for most of unisc

Re: Appdb as application regression finder

2006-09-27 Thread Dan Kegel
On 9/27/06, Tom Spear <[EMAIL PROTECTED]> wrote: On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: > Also, I'd like to see us add a checkbox which is the equivalent of > the 'download' keyword. That would let people who want to work > on problems find ones that don't require purchasing software.

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Mike McCormack
Ge van Geldorp wrote: It would make sure the author always receives some kind of feedback (either from the bot, other developers or yourself) and would make sure patches don't get lost (patches are automatically entered into the system and only leave the system when the author withdraws them or

Re: Appdb as application regression finder

2006-09-27 Thread Tom Spear
On 9/27/06, Chris Morgan <[EMAIL PROTECTED]> wrote: On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote:> The appdb has a "browse by ratings" page, e.g. you can> see all apps that have at least one Gold-rated version at > http://appdb.winehq.org/browse_by_rating.php?sRating=Gold>> This can serve as a k

Re: Appdb as application regression finder

2006-09-27 Thread Tom Spear
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: Also, I'd like to see us add a checkbox which is the equivalent ofthe 'download' keyword.  That would let people who want to workon problems find ones that don't require purchasing software.- Dan One thing that might make this a little more helpful (

Re: oleaut32 2/2: [RESEND] Conformance test for varformat:VarWeekdayName

2006-09-27 Thread Benjamin Arai
I looked up the code pages for English and Russian. Obviously, I get "Monday" for English but for Russian the same day is "ïîíåäåëüíèê". I don't see how this can me made locale dependent. I would have to make a table for each of the locales to test them. LOCALE_INVARIANT flag is not implemented

Re: How hard is Uniscribe's ScriptLayout() to implement?

2006-09-27 Thread Hans Leidekker
> usp10.ScriptLayout() isn't implemented. > How hard would it be to fix this? As long as you don't use RTL scripts (such as Arabic, Farsi, Hebrew) a stub like the one I attached to the bug should do the job nicely. This goes for most of uniscribe. A full implementation that handles RTL scripts a

Re: Problem with NtReadVirtualMemory and wine server connection

2006-09-27 Thread Juan Lang
Hi Peter, I'm guessing the fact that no one has replied means that no one has a strong opinion, or no one feels qualified to answer, or that AJ would prefer to see a patch first. I'll give my opinion in the hope of stimulating discussion, as I think it's important. > 1. allocate a temporary buffe

Re: oleaut32 2/2: [RESEND] Conformance test for varformat:VarWeekdayName

2006-09-27 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Alexandre wrote: >> How will this test work in non-English locales? > > How about if it calls SetThreadLocale(LOCALE_INVARIANT)? It's probably better to really make the test locale-dependent, so that the behavior gets tested in different locales. Of cours

Re: start.exe: Implement /D option, add new wine specific feature allowing to specify the shell operation name (resend)

2006-09-27 Thread James Hawkins
On 9/27/06, Paul Chitescu <[EMAIL PROTECTED]> wrote: On Tue, 26 Sep 2006, James Hawkins wrote: > [...] > Only submit one fix per patch. Please read the WineHQ patch > guidelines: http://winehq.org/site/sending_patches Well, I will, but i hate to have patches depend one on another. > > Why are

Re: Appdb as application regression finder

2006-09-27 Thread Chris Morgan
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: On 9/27/06, Chris Morgan <[EMAIL PROTECTED]> wrote: > When test results were added Tony and myself talked about all kinds of > interesting ways we could farm information from those results. > [suggestion for two particular kinds of searches] I'd l

Re: localspl: [1/3] Build the Importlib

2006-09-27 Thread Alexandre Julliard
Detlef Riekenberg <[EMAIL PROTECTED]> writes: > We need the importlib for the tests It doesn't seem that we should have an importlib, there isn't one in the SDK either. The tests can always use GetProcAddress. -- Alexandre Julliard [EMAIL PROTECTED]

re: oleaut32 2/2: [RESEND] Conformance test for varformat:VarWeekdayName

2006-09-27 Thread Dan Kegel
Alexandre wrote: How will this test work in non-English locales? How about if it calls SetThreadLocale(LOCALE_INVARIANT)?

Re: [PATCH] Also show 24bit modes as supported, but still handle them like 32bit later

2006-09-27 Thread Stefan Dösinger
Hi, > would someone please comment on that patch? this is a nearly unchanged > version of my previous attempt - but this time against current git. Not so sure about it. I am afraid I do not completely understand the color depth issue, but it appears to me that a patch like that rather hides the p

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Dmitry Timoshkov
"Thomas Weidenmueller" <[EMAIL PROTECTED]> wrote: It's also defined as "unsigned long" in the PSDK headers, not ULONG/unsigned LONG. The problem is that 'long' is 32-bit in Win64 while in 64-bit Linux it's 64-bit. -- Dmitry.

Re: oleaut32 2/2: [RESEND] Conformance test for varformat:VarWeekdayName

2006-09-27 Thread Alexandre Julliard
"Benjamin Arai" <[EMAIL PROTECTED]> writes: > +void test_VarWeekdayName(void) > +{ > +WCHAR day_LongFormat[][10] = > +{ > +{'S','u','n','d','a','y',0}, > +{'M','o','n','d','a','y',0}, > +{'T','u','e','s','d','a','y',0}, > +{'W','e','d','n','e','s','d','a','y

Re: clusapi: Implements stub dll for clusapi

2006-09-27 Thread Alexandre Julliard
"Benjamin Arai" <[EMAIL PROTECTED]> writes: > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=6265 > > The application for bug 6265 checks if clusapi.dll exists and attempts > to call clusapi:GetNodeClusterState from it. This patch adds a stub > implementation for the DLL clusapi and GetNodeClus

Re: wintrust.h: add missing defines

2006-09-27 Thread Juan Lang
> these ones you've added are already in Whoops. I was just trying to clean out my tree, and didn't pay close enough attention. Thanks. --Juan __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.co

How hard is Uniscribe's ScriptLayout() to implement?

2006-09-27 Thread Dan Kegel
See http://bugs.winehq.org/show_bug.cgi?id=5772 Quicktime 6.5.x, Eclipse 3.2, Word XP, and other apps crash because usp10.ScriptLayout() isn't implemented. How hard would it be to fix this? - Dan

Re: Appdb as application regression finder

2006-09-27 Thread Dan Kegel
On 9/27/06, Chris Morgan <[EMAIL PROTECTED]> wrote: When test results were added Tony and myself talked about all kinds of interesting ways we could farm information from those results. [suggestion for two particular kinds of searches] I'd like to see a more general search function rather than

Re: H. Verbeet : wined3d: Add support for native NPOT textures.

2006-09-27 Thread Frank Richter
On 27.09.2006 10:46, Alexandre Julliard wrote: > @@ -765,6 +768,12 @@ #undef USE_GL_FUNC > > gl_info->max_sampler_stages = max(gl_info->max_samplers, > gl_info->max_texture_stages); > > +/* We can only use NP2_NATIVE when the hardware supports it. */ > +if (wined3d_settings.nonpow

Re: Appdb as application regression finder

2006-09-27 Thread Chris Morgan
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote: The appdb has a "browse by ratings" page, e.g. you can see all apps that have at least one Gold-rated version at http://appdb.winehq.org/browse_by_rating.php?sRating=Gold This can serve as a kind of poor man's application regression finder; look a

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Thomas Weidenmueller
Dmitry Timoshkov wrote: > Then it should be changed to 'ULONG' or 'unsigned LONG' for compatibility > with Win64. It's also defined as "unsigned long" in the PSDK headers, not ULONG/unsigned LONG. - Thomas

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Michael Stefaniuc
Thomas Weidenmueller wrote: > The parameter of RpcMgmtSetServerStackSize needs to be unsigned long, > not unsigned int. Won't work on Win64. long is 32bits on Win32 and Win64. On Linux64 long is 64bits. bye michael >

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Dmitry Timoshkov
"Thomas Weidenmueller" <[EMAIL PROTECTED]> wrote: The parameter of RpcMgmtSetServerStackSize needs to be unsigned long, not unsigned int. Then it should be changed to 'ULONG' or 'unsigned LONG' for compatibility with Win64. -- Dmitry.

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Ge van Geldorp
> From: Alexandre Julliard <[EMAIL PROTECTED]> > > If you expect > anything to happen, you'll need to make much more concrete > suggestions, and provide examples to make us understand how > what you are suggesting would work in practice Fair enough. Some disclaimers upfront: I'm basically thin

Re: [PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-09-27 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(&test, 0xA5, sizeof(test)); full_file_path_name_in_a_CWD(filename_, expected, FALSE); + SetLastError(0xfaceabee); Please use a usual value we all agreed to use: 0xdeadbeef. It makes sense

Re: [rpcrt4] Fix RpcMgmtSetServerStackSize prototype

2006-09-27 Thread Paul Vriens
On Wed, 2006-09-27 at 14:40 +0200, Thomas Weidenmueller wrote: >FIXME("(0x%x): stub\n", ThreadStackSize); Shouldn't that be (0x%lx) then ? Cheers, Paul.

Re: Coverity coverage of Wine

2006-09-27 Thread Paul Vriens
On Tue, 2006-09-12 at 11:25 +0200, Paul Vriens wrote: > On Tue, 2006-09-12 at 11:15 +0200, Detlef Riekenberg wrote: > > On Di, 2006-09-12 at 08:51 +0200, Paul Vriens wrote: > > > > > the latest run (with report) on the Coverity site seems to be from July > > > 21st. > > > > > Does anybody know m

Re: WineD3D: glBlend* fixes

2006-09-27 Thread Roland Scheidegger
Roderick Colenbrander wrote: On windows the opengl32.dll exports glBlendColor by default and as opengl32.dll is opengl 1.1 I thought that it was a core function. So you say that it is backed by GL_ARB_imaging. The problem is that basicly only Nvidia advertises it and the other drivers don't. Th

Appdb as application regression finder

2006-09-27 Thread Dan Kegel
The appdb has a "browse by ratings" page, e.g. you can see all apps that have at least one Gold-rated version at http://appdb.winehq.org/browse_by_rating.php?sRating=Gold This can serve as a kind of poor man's application regression finder; look at each app on that page, and look for apps whose l

Re: start.exe: Implement /D option, add new wine specific feature allowing to specify the shell operation name (resend)

2006-09-27 Thread Paul Chitescu
On Tue, 26 Sep 2006, James Hawkins wrote: > [...] > Only submit one fix per patch. Please read the WineHQ patch > guidelines: http://winehq.org/site/sending_patches Well, I will, but i hate to have patches depend one on another. > > Why are you adding a new switch? This isn't provided by nativ

Re: some wineconference pictures

2006-09-27 Thread Francois Gouget
On Sun, 24 Sep 2006, Marcus Meissner wrote: > Hi, > > Some Wine conference pictures from David and myself: > http://gallery.kuschelt.net/main.php?g2_view=core.ShowItem&g2_itemId=100617 Here are mine: http://fgouget.free.fr/tmp/200609-WineConf/ -- Francois Gouget <[EMAIL PROTECTED]>

Re: Governance revisited

2006-09-27 Thread Robert Lunnon
On Tuesday 26 September 2006 22:09, Alexandre Julliard wrote: > Robert Lunnon <[EMAIL PROTECTED]> writes: > > Well thats at least a reasoned response, even if I don't agree with the > > reasoning. But again you simply miss the point. I don't care that > > Alexandre doesn't move my patches (because

Re: wintrust.h: add missing defines

2006-09-27 Thread Paul Vriens
On Tue, 2006-09-26 at 22:08 -0700, Juan Lang wrote: > #define WTD_UI_ALL1 > #define WTD_UI_NONE 2 > @@ -115,6 +118,42 @@ > DWORD dwUIContext; > } WINTRUST_DATA, *PWINTRUST_DATA; > > +#define WTD_UI_ALL1 > +#define WTD_UI_NONE 2 > +#define WTD_UI_NOBAD

Re: WineD3D: glBlend* fixes

2006-09-27 Thread H. Verbeet
On 27/09/06, Chris Robinson <[EMAIL PROTECTED]> wrote: On Wednesday 27 September 2006 00:51, you wrote: > Also, I've yet to see a driver that doesn't report the > extension while supporting the functionality in the core. Isn't that the problem you're running into that spawned this discussion? Wi

Re: WineD3D: glBlend* fixes

2006-09-27 Thread Chris Robinson
On Wednesday 27 September 2006 00:51, you wrote: > Also, I've yet to see a driver that doesn't report the > extension while supporting the functionality in the core. Isn't that the problem you're running into that spawned this discussion? With certain drivers not reporting an extension for glBlen

Re: WineD3D: glBlend* fixes

2006-09-27 Thread H. Verbeet
On 27/09/06, Chris Robinson <[EMAIL PROTECTED]> wrote: In the case of WineD3D, it should have an OGL version -> D3D version map. So if, say, OGL 2.0 is functionaly equivilant to D3D 9, then it'd report D3D 9 right off the bat for OGL 2.0 drivers; if added extensions can make it functionally equiv

Re: shlwapi: Resupply array sizes stripped by function interface

2006-09-27 Thread Mikołaj Zalewski
I am now inclined to think - and in line with what you say - that it would be safer and more efficient to modify FillNumberFmt() to take two more arguments and pass the buffer sizes in as well, i.e., in effect, its declaration should be: static void FillNumberFmt(NUMBERFMTW *fmt, LPWSTR decimal