Re: Setupapi [0/6] : ReactOS setupapi patches

2006-09-09 Thread Evil Jay
EA Durbin wrote: >> Still one week, and I got absolutly no reaction about my patches. >> Is something wrong with them? >> >> Hervé >> >> >> > > > If I recall you got alot of reaction to your patches about > implementing ReactOS code and they wouldn't be included as ReactOS has > some potentially di

RE: Setupapi [0/6] : ReactOS setupapi patches

2006-09-09 Thread EA Durbin
Still one week, and I got absolutly no reaction about my patches. Is something wrong with them? Hervé If I recall you got alot of reaction to your patches about implementing ReactOS code and they wouldn't be included as ReactOS has some potentially dirty code.

RE: Setupapi [0/6] : ReactOS setupapi patches

2006-09-09 Thread Hervé Poussineau
Hi, > As setupapi merge from ReactOS has been a recurrent demand > [1], I'm doing this set of patches. > > [...] > > The goal of this set of patches is to set a solid ground to > implement lots of missing functions in setupapi. > I've tried to cut them in smallest possible parts. > Additionnaly

Re: shell32[1/2]: document the shell32 "mini-COM" functions

2006-09-09 Thread Mikołaj Zalewski
Maybe you've seen it already, but this blog post talks about the various allocators: http://blogs.msdn.com/oldnewthing/archive/2004/07/05/173226.aspx -f.r. Yes, that's where I learned about it (a link to it is included in the documentation of SHLoadOLE) Mikolaj

Re: Socket resets randomly

2006-09-09 Thread Alexandre Julliard
Michael Stefaniuc <[EMAIL PROTECTED]> writes: > find -name '*.[ch]' | xargs grep 'SetLastError( *0 *)' | wc -l > 117 > > Time for a new Janitorial mini task? No, SetLastError(0) is fine. -- Alexandre Julliard [EMAIL PROTECTED]

Re: Socket resets randomly

2006-09-09 Thread Michael Stefaniuc
James Hawkins wrote: > On 9/8/06, Ryan Miller <[EMAIL PROTECTED]> wrote: >> +/* In Windows, if setsockopt succeeds, GetLastError() always >> returns zero. >> + The native wininet.dll expects this behavior, and does not always >> + check the return value of setsockopt() first.*/ >> +

Re: shell32[1/2]: document the shell32 "mini-COM" functions

2006-09-09 Thread Frank Richter
On 08.09.2006 21:11, Mikołaj Zalewski wrote: > This patch adds the explanation why many shell32 functions are similar > to ole32 ones - something I've been wondering for some time. It is not > copied from MSDN. Maybe you've seen it already, but this blog post talks about the various allocators: ht

Re: GetTextMetrics returns wrong First/Last char index for Symbol fonts

2006-09-09 Thread Dmitry Timoshkov
"Jie Zhu" <[EMAIL PROTECTED]> wrote: +ptmA->tmFirstChar = ptmA->tmBreakChar - 2; +if (ptmW->tmCharSet == SYMBOL_CHARSET) +{ +ptmA->tmLastChar = ptmW->tmLastChar > 0x0F0FF ? 0x0FF : ptmW->tmLastChar & 0x0FF; +} +else +{ +ptmA->tmLastChar = ptmW->tmLastChar

Re: Symbol demangling and the games crashing

2006-09-09 Thread Stefan Dösinger
Am Freitag 08 September 2006 19:38 schrieb Vijay Kiran Kamuju: > Hi, > > In the bug reports I have seen that we are facing problems with symbol > demangling of '_R' operators and 'Y' datatypes. > > err:msvcrt:symbol_demangle Unknown operator: _R > and > err:msvcrt:demangle_datatype Unknown type Y >

Re: Socket resets randomly

2006-09-09 Thread James Hawkins
On 9/8/06, Ryan Miller <[EMAIL PROTECTED]> wrote: Index: ChangeLog === RCS file: /home/wine/wine/ChangeLog,v retrieving revision 1.120 diff -u -r1.120 ChangeLog --- ChangeLog 24 Aug 2006 14:43:25 - 1.120 +++ ChangeLog 8