[UPDATE 2] RFC: XEmbed System Tray Patches

2006-08-12 Thread James Liggett
Attached is the second update of the XEmbed systray patches. Changes in this version: 1. On the advice of Juan Lang, I only acquire the wine tsx11 lock when actually making X calls, and not while initializing data. 2. Added the ability to detect if we have an XEmbed systray so that we can selecti

Re: reasons for not accepting the patch

2006-08-12 Thread Vijay Kiran Kamuju
I think she developed the code while working for the company, unlike me. ;) Then I think she should be doing as you have suggested. Thank you for ur suggestions, Vijay On 8/12/06, Dan Kegel <[EMAIL PROTECTED]> wrote: 2006/8/12, Vijay Kiran Kamuju <[EMAIL PROTECTED]>: > [Why wasn't the patch >

Re: winmm: prevent NULL dereference in MCI_Close

2006-08-12 Thread Jan Zerebecki
On Sat, Aug 12, 2006 at 08:27:24AM +0200, Eric Pouech wrote: > do you have a specific program that depends on this case ? Yes, I forgot to mention in last mail, that it fixes a crash in Pacmania 2 ( http://appdb.winehq.org/appview.php?iVersionId=5473 ). I already talked to AJ about this patch on

Missing subtitle in WWN 307

2006-08-12 Thread Francois Gouget
Hi, It's not a big issue but I have noticed that in WWN 311 the article about 'Microsoft WGA & Wine' does not have a subject: http://www.winehq.org/?issue=311#Microsoft%20WGA%20&%20Wine Currently it reads: ++-+ |Microsoft WGA & Wine

Re: Wide-string Functions: Double Casting

2006-08-12 Thread Andrew Talbot
Once qualifications are give, how hard it is to take them away, again! Of course, if one were realising these small inline functions literally as inline code, one would not add a const qualification for a few lines, only to take it away again (with great difficulty). Thus, one would not write:

Re: reasons for not accepting the patch

2006-08-12 Thread Dan Kegel
2006/8/12, Vijay Kiran Kamuju <[EMAIL PROTECTED]>: [Why wasn't the patch http://www.winehq.org/pipermail/wine-patches/2006-July/029145.html accepted?] I looked at this a couple days ago, and sent this to the patches' author to encourage him to repost it: -- snip --- 1. The patch is missing th

Re: ddraw fix for incorrect return value from wined3d take 3.

2006-08-12 Thread Roderick Colenbrander
Hi, One small comment regarding your patch make sure that you use the same indentation as the rest of the ddraw code. The ddraw code seems to use 4 spaces for a tab and I think your editor is configured to use tabs. Regards, Roderick Colenbrander > The new test cases crashes under wine but not