Re: Wide-string Functions: Double Casting

2006-08-11 Thread Eric Pouech
David Laight wrote: On Tue, Aug 08, 2006 at 09:27:23PM +0200, Eric Pouech wrote: what I don't like is that in order to plug a hole (casting from const foo* to foo*), we create a bigger hole by allowing to cast from const foo* to bar* (and the compiler will not give any warning) if we want t

Re: winmm: prevent NULL dereference in MCI_Close

2006-08-11 Thread Eric Pouech
Jan Zerebecki wrote: If this patch is rejected from inclusion, please tell me why, as I would have to ask anyway. From: Jan Zerebecki <[EMAIL PROTECTED]> Jan, do you have a specific program that depends on this case ?

Re: wininet: Support http_proxy environment variable

2006-08-11 Thread Francois Gouget
On Fri, 11 Aug 2006, Augusto Arcoverde da Rocha wrote: [...] > But, I have read in somewhere a reply from Alexander about avoiding > environment variables. However, I can't find this message again. Maybe you are thinking about the one in which he argues against introducing new obsucure Wine-speci

Re: [UPDATE] RFC: XEmbed System Tray Patches

2006-08-11 Thread Alexandre Julliard
James Liggett <[EMAIL PROTECTED]> writes: > That was the original plan, but I had some concerns about whether or not > Alexandre would take this or not. When Rob Shearman tried to get these > in last year, Alexandre asked him why it was necessary. At the time Rob > said that without that call, the

Re: Wine and Photoshop in news

2006-08-11 Thread Vijay Kiran Kamuju
Well I tried installing PhotoShop CS2 using 0.9.19. It is not getting installed, we still got msi bugs. On 8/11/06, Scott Ritchie <[EMAIL PROTECTED]> wrote: On Thu, 2006-08-03 at 18:10 -0700, Scott Ritchie wrote: > I'm going to CC the author of the article here, as it looks like he's > using my

Re: Wine and Photoshop in news

2006-08-11 Thread Scott Ritchie
On Thu, 2006-08-03 at 18:10 -0700, Scott Ritchie wrote: > I'm going to CC the author of the article here, as it looks like he's > using my packages. > > On Tue, 2006-08-01 at 11:58 -0700, Dan Kegel wrote: > > On 8/1/06, Jaap Stolk <[EMAIL PROTECTED]> wrote: > > > On 8/1/06, Vijay Kiran Kamuju <[EM

Re: [UPDATE] RFC: XEmbed System Tray Patches

2006-08-11 Thread James Liggett
On Fri, 2006-08-11 at 09:02 -0700, Juan Lang wrote: > +wine_tsx11_lock(); > +/* set XEMBED protocol data on the window */ > +info[0] = 0; /* protocol version */ > +info[1] = 1; /* mapped = true */ > +XChangeProperty( display, data->whole_window, > +

Re: [wintrust.h] Added some missing struct variables

2006-08-11 Thread Paul Vriens
On Fri, 2006-08-11 at 16:40 +0200, Paul Vriens wrote: > Hi, > > our struct was missing some variables. > > Changelog > Added some missing struct variables > > Cheers, > > Paul > --- > include/wintrust.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/w

Re: kernel32: redirect GetNativeSystemInfo to GetSystemInfo

2006-08-11 Thread Alexandre Julliard
Robert Reif <[EMAIL PROTECTED]> writes: > --- dlls/kernel/kernel32.spec 21 Jun 2006 13:03:23 - 1.175 > +++ dlls/kernel/kernel32.spec 11 Aug 2006 01:51:02 - > @@ -546,7 +546,7 @@ > @ stdcall GetNamedPipeHandleStateA(long ptr ptr ptr ptr str long) > @ stdcall GetNamedPipeHandleStateW(

Re: wininet: Support http_proxy environment variable

2006-08-11 Thread Augusto Arcoverde da Rocha
On 8/11/06, Francois Gouget <[EMAIL PROTECTED]> wrote: On Thu, 10 Aug 2006, Augusto Arcoverde da Rocha wrote: [...] > Yes, it's supported but isn't a standart and has no guaranties to > exists on all architectures as Alexander said in a reply in this list $http_proxy and $ftp_proxy may not be ve

Re: [UPDATE] RFC: XEmbed System Tray Patches

2006-08-11 Thread Juan Lang
Hi James, thanks for taking this up. I'd like to have nice docked system tray icons, too. Some small nits on your patches: +wine_tsx11_lock(); +/* set XEMBED protocol data on the window */ +info[0] = 0; /* protocol version */ +info[1] = 1; /* mapped = true */ +

[wintrust.h] Added some missing struct variables

2006-08-11 Thread Paul Vriens
Hi, our struct was missing some variables. Changelog Added some missing struct variables Cheers, Paul --- include/wintrust.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/wintrust.h b/include/wintrust.h index d490ac9..0230dee 100644 --- a/include/wintrust.

Re: wininet: Support http_proxy environment variable

2006-08-11 Thread Francois Gouget
On Thu, 10 Aug 2006, Augusto Arcoverde da Rocha wrote: [...] > Yes, it's supported but isn't a standart and has no guaranties to > exists on all architectures as Alexander said in a reply in this list $http_proxy and $ftp_proxy may not be very well documented but they are defacto standards and as

Re: winhelp: fix LZ77 decompressor patch: what's wrong?

2006-08-11 Thread Dan Kegel
2006/8/11, HolyLich <[EMAIL PROTECTED]>: > Why not use memmove() instead? Heh, this problem was discussed before http://www.winehq.org/pipermail/wine-devel/2006-August/050133.html, http://www.winehq.org/pipermail/wine-devel/2006-August/050139.html http://www.winehq.org/pipermail/wine-devel/2006

Re: winhelp: fix LZ77 decompressor patch: what's wrong?

2006-08-11 Thread Alexandre Julliard
HolyLich <[EMAIL PROTECTED]> writes: > I've sent patch several times, but it has not been applied. > Patch is reasonable, MIME type is OK. > patch -p0 < mbox works ;-) (as recommended at > http://winehq.org/site/docs/winedev-guide/style-notes) > Please, tell what I must do to this patch to be app

Re: winhelp: fix LZ77 decompressor patch: what's wrong?

2006-08-11 Thread HolyLich
В сообщении от Friday 11 August 2006 17:17 вы написали: > 2006/8/11, HolyLich <[EMAIL PROTECTED]>: > > I've sent patch several times, but it has not been applied. > > Why not use memmove() instead? > Heh, this problem was discussed before http://www.winehq.org/pipermail/wine-devel/2006-August/0

Re: Rooms for Wineconf - Please act now

2006-08-11 Thread Dan Kegel
2006/8/11, Michael Stefaniuc <[EMAIL PROTECTED]>: I thought the version control system debate is over now that we have git and everybody is happy with it. Heh. No, now we can have angry discussions about why git mysteriously fails, and is too hard to use... Also everybody knows that vim is b

Re: winhelp: fix LZ77 decompressor patch: what's wrong?

2006-08-11 Thread Dan Kegel
2006/8/11, HolyLich <[EMAIL PROTECTED]>: I've sent patch several times, but it has not been applied. Why not use memmove() instead?

Re: wldap32: Write-strings warning fix

2006-08-11 Thread Andrew Talbot
Hans Leidekker wrote: > On Friday 11 August 2006 00:58, Andrew Talbot wrote: > >> -INT CDECL ber_printf(BerElement*,PCHAR,...); >> +INT CDECL ber_printf(BerElement*,LPCSTR,...); > > This is an API defined by Microsoft, we can't change > its prototype. > > -Hans Thanks, Hans. They surprised me

winhelp: fix LZ77 decompressor patch: what's wrong?

2006-08-11 Thread HolyLich
Hi, I've sent patch several times, but it has not been applied. Patch is reasonable, MIME type is OK. patch -p0 < mbox works ;-) (as recommended at http://winehq.org/site/docs/winedev-guide/style-notes) Please, tell what I must do to this patch to be applied? Thanks a lot -- HolyLich Subject:

Re: Rooms for Wineconf - Please act now

2006-08-11 Thread Michael Stefaniuc
Steven Edwards wrote: > On 8/10/06, Jeremy White <[EMAIL PROTECTED]> wrote: > >> However, we will unabashedly be focusing on things that >> only a developer could love. So the 'developers focus' >> comment is meant as a cautionary (boring, geeks talking >> incessently about obscure and hard to f

Re: patch feedback?

2006-08-11 Thread Alexandre Julliard
Damjan Jovanovic <[EMAIL PROTECTED]> writes: > +classKey = SetupDiOpenClassRegKeyExW(&guid, KEY_ALL_ACCESS, > + DIOCR_INSTALLER, NULL, NULL); > +/* wine does incorrectly return FALSE, so ... */ > +ok(classKey != FALSE && classKey

patch feedback?

2006-08-11 Thread Damjan Jovanovic
Hi I've tried submitting a patch to wine-patches 3 times now in the past 3 weeks, and not only has it not been applied, but I never even got any feedback. Please tell me what I am doing wrong. The latest patch is below. Thank you Damjan --- Damjan Jovanovic <[EMAIL PROTECTED]> wrote: > Date:

Re: segfaults with last selection repaint patch in riched20

2006-08-11 Thread Phil Krylov
Hi Krzysztof, On 11/08/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: What are the circumstances? Is it after some delete/insert operation, or just after document load? Well I have not traced the whole sequence of calls to richedit, but from the display I can suppose the following. I am doin

Re: segfaults with last selection repaint patch in riched20

2006-08-11 Thread Krzysztof Foltman
Phil Krylov wrote: I was getting a segfault in ME_MarkForPainting() after that patch (BTW great work), Owww... I really hoped to avoid bugs in THAT :) and started looking through the code. One thing I found was obviously a typo which can be easily fixed (BTW I don't know for sure but I'd als

Re: wldap32: Write-strings warning fix

2006-08-11 Thread Hans Leidekker
On Friday 11 August 2006 00:58, Andrew Talbot wrote: > -INT CDECL ber_printf(BerElement*,PCHAR,...); > +INT CDECL ber_printf(BerElement*,LPCSTR,...); This is an API defined by Microsoft, we can't change its prototype. -Hans