Re: msi: Write-strings warnings fix

2006-08-04 Thread Dmitry Timoshkov
"Mike McCormack" <[EMAIL PROTECTED]> wrote: Andrew Talbot wrote: MSI{Get|Set}FeatureState(), MSI{Get|Set}ComponentState() and MSI{Get|Set}Property() have appropriate const string arguments in the SDK. Which version of the Windows SDK is that? -UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hIns

Re: msi: Write-strings warnings fix

2006-08-04 Thread Mike McCormack
Andrew Talbot wrote: MSI{Get|Set}FeatureState(), MSI{Get|Set}ComponentState() and MSI{Get|Set}Property() have appropriate const string arguments in the SDK. Which version of the Windows SDK is that? -UINT WINAPI MsiGetFeatureStateA(MSIHANDLE hInstall, LPSTR szFeature, +UINT WINAPI MsiGetFea

Re: Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-04 Thread Dan Kegel
On 8/4/06, Thomas Kho <[EMAIL PROTECTED]> wrote: > > Tommy's APC version of his > > VirtualAllocEx / CreateRemoteThread patch > > seems to be safe (since APCs only run a points where threads > > in well-written programs are not holding locks), > > Unfortunately there's no such guarantee, kernel A

Re: wine.inf: Windows 9x and Windows NT store the time zone data in different places.

2006-08-04 Thread Vitaliy Margolen
Friday, August 4, 2006, 9:47:38 AM, Francois Gouget wrote: > So duplicate it so programs find it no matter where they look. > Note: > Another option would be to have a [Timezones9x] section that would set > this data in the alternate location. But we would still need to > duplicate all the data

Re: Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-04 Thread Thomas Kho
On 8/4/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: "Dan Kegel" <[EMAIL PROTECTED]> writes: > Tommy's APC version of his > VirtualAllocEx / CreateRemoteThread patch > seems to be safe (since APCs only run a points where threads > in well-written programs are not holding locks), Unfortunate

Re: Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-04 Thread Dan Kegel
On 8/4/06, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Tommy's APC version of his > VirtualAllocEx / CreateRemoteThread patch > seems to be safe (since APCs only run a points where threads > in well-written programs are not holding locks), Unfortunately there's no such guarantee, kernel APCs

Re: Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-04 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > Tommy's APC version of his > VirtualAllocEx / CreateRemoteThread patch > seems to be safe (since APCs only run a points where threads > in well-written programs are not holding locks), Unfortunately there's no such guarantee, kernel APCs will run on every

Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-04 Thread Dan Kegel
Tommy's APC version of his VirtualAllocEx / CreateRemoteThread patch seems to be safe (since APCs only run a points where threads in well-written programs are not holding locks), is complete enough to make many apps happy, and is probably the best that can be done without a service thread or a rea

[PATCH] Re: tools/winemaker prints unexpected output

2006-08-04 Thread Colin Pitrat
Hi, it seems like the open function failed, but the error code wasn't checked, resulting in a wrong filehandle. I think I would correct it this way (see attached patch). Regards, Colin Pitrat (Bull Services Telco) Bull, Architect of an Open World (TM) Tél : +33 (0) 1 30 80 72 93 www.bull.co

[ws2_32] connect doesn't generate FD_CONNECT event in non-blocking mode

2006-08-04 Thread Tijl Coosemans
dlls/ws2_32/tests/sock.c:event_client:597: /* Prepare event notification for connect, makes socket nonblocking */ event = WSACreateEvent (); WSAEventSelect ( mem->s, event, FD_CONNECT ); tmp = connect ( mem->s, (struct sockaddr*) &mem->addr, sizeof ( mem->addr ) ); if ( tmp != 0 && ( err = WSA

tools/winemaker prints unexpected output

2006-08-04 Thread Saulius Krasuckas
Now I am running it on a latest GIT tree this way: $ tools/winapi/msvcmaker --no-wine .: searching for /^Makefile.in$/ And after a while it appends this string to the end of last line: readline() on closed filehandle IN at tools/winapi/msvcmaker line 134. Maybe it doesn't indicate any harm,

Re: VNC and worms

2006-08-04 Thread Saulius Krasuckas
* On Thu, 3 Aug 2006, Krzysztof Foltman wrote: > Can anyone figure out how to fix this display artifact that's very > frequent when using Wine through VNC servers ... > http://foltman.com/worms.png I guess this can be related to 2 bugreports: [2] http://bugs.winehq.org/show_bug.cgi?id=3571 [3

Re: advapi32: Add more SID tests

2006-08-04 Thread Robert Reif
Robert Reif wrote: Adds more SID tests. Fixes some Windows failures by checking version first. Add some more info on failed tests. Removes Windows version check. diff -p -u -r1.34 security.c --- dlls/advapi32/tests/security.c 31 Jul 2006 09:33:04 - 1.34 +++ dlls/advapi32/tests/s

Re: advapi32: Add more SID tests

2006-08-04 Thread Alexandre Julliard
Robert Reif <[EMAIL PROTECTED]> writes: > ConvertStringSidToSid is supported on NT and later but the particular > type of two character sid that I am testing is only avaliable on XP > and later. Yes, but the right way is to call it and check if it works. On Wine the Windows version can report any

Re: user [1/2]: Add a test for CreateWindowEx

2006-08-04 Thread Alexandre Julliard
Dan Hipschman <[EMAIL PROTECTED]> writes: > @@ -137,8 +137,10 @@ static void test_parent_owner(void) > trace( "main window %p main2 %p desktop %p child %p\n", hwndMain, > hwndMain2, desktop, child ); > > /* child without parent, should fail */ > +SetLastError(ERROR_SUCCESS); >

Re: advapi32: Add more SID tests

2006-08-04 Thread Robert Reif
Alexandre Julliard wrote: Robert Reif <[EMAIL PROTECTED]> writes: Adds more SID tests. Fixes some Windows failures by checking version first. You shouldn't check the Windows version, you should check the features themselves. ConvertStringSidToSid is supported on NT and later but

Re: advapi32: Add more SID tests

2006-08-04 Thread Alexandre Julliard
Robert Reif <[EMAIL PROTECTED]> writes: > Adds more SID tests. > Fixes some Windows failures by checking version first. You shouldn't check the Windows version, you should check the features themselves. -- Alexandre Julliard [EMAIL PROTECTED]

Re: urlmon: Delay-load cabinet.dll as native urlmon doesn't import it.

2006-08-04 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > +if (!hCabinet) return HRESULT_FROM_WIN32(GetLastError()); > +pExtract = GetProcAddress(hCabinet, "Extract"); > +if (!pExtract) return HRESULT_FROM_WIN32(GetLastError()); > + > +hr = pExtract(dest, szCabName); > +FreeLibrary(hCabine

Re: msi: The input buffer length is the number of characters excluding the NULL terminator, so fix an off by one error [RESEND]

2006-08-04 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > Is there anything wrong with this patch? Yes, the length does include the terminating null. That's what the rest of the function expects, and AFAICT it's what the callers expect too (and it's the standard behavior of API functions that take a buffer l

Re: wine's fullscreen code has no effect on metacity

2006-08-04 Thread Dmitry Timoshkov
"Dmitry Timoshkov" <[EMAIL PROTECTED]> wrote: "Havoc Pennington" <[EMAIL PROTECTED]> wrote: You could try patching metacity with either of the fixes mentioned here (or some other fix) and verify that they work for wine: http://bugzilla.gnome.org/show_bug.cgi?id=346927 They are both basically