Re: SetLastError in CreateWindowEx

2006-07-07 Thread James Hawkins
On 7/7/06, Dan Hipschman <[EMAIL PROTECTED]> wrote: I noticed that sometimes when CreateWindowEx fails and the app tries to display a helpful error message, you get something like "Couldn't create window: Success." These are the error codes that XP sets for the given failures. ChangeLog: * Corr

Re: msi: appsearch

2006-07-07 Thread Juan Lang
Just add an entry to wine.inf for the dll it's failing on, and the existing code should find it and do the version checks. --Juan - Original Message From: Aric Stewart <[EMAIL PROTECTED]> To: Juan Lang <[EMAIL PROTECTED]> Cc: wine-devel@winehq.org Sent: Wednesday, July 5, 2006 10:43:23 A

Re: ole32: Get the threading model value for inproc classes and output a fixme if we should create it in an apartment of another type.

2006-07-07 Thread Jacek Caban
Robert Shearman wrote: Jacek, I have a patch that fixes the crash by validating the conditions on entry to CoGetClassObject (attached). However, this test still fails: err:ole:CoGetClassObject apartment not initialised url.c:768:http test... url.c:424: Test failed: unexpexted code 34 fixme:w

Re: DDraw: Split up the ddraw refcount

2006-07-07 Thread Alexandre Julliard
Stefan Dösinger <[EMAIL PROTECTED]> writes: > +if(ref == 0) InterlockedDecrement(&This->numIfaces); > > -/* This is for the dll cleanup code in DllMain() */ > -if(!This->DoNotDestroy) > -IDirectDrawImpl_Destroy(This); > -} > +/* Checks the refcount before

Issue with French Canadian Keyboard Under SLED 10

2006-07-07 Thread Michael Lessard
Hi everybody ! We still have an issue with wine 0.9.16 and french canadian keyboard accent, we use locale fr_FR.UTF-8 ... in terminal, accent working great but in appz who use wine, only é and ç working, all other accent (è,ê,à,ô) are replace by ç. Where can modify the config of keyboard under

Re: oleaut32: Copying a NULL BSTR should result in an empty BSTR in VariantCopy

2006-07-07 Thread Robert Shearman
qingdoa daoo wrote: Hi, This patch should fix Bug 4141 Changelog: Copying a NULL BSTR should result in an empty BSTR in VariantCopy --- dlls/oleaut32/variant.c.cvs 2006-07-05 17:23:04.0 +0800 +++ dlls/oleaut32/v

Re: [AppDB] - cleanup require/require_once()/include()

2006-07-07 Thread Jonathan Ernst
Le vendredi 07 juillet 2006 à 00:37 -0400, Chris Morgan a écrit : > Use require() for path.php and include/incl.php. We can't proceed without > these files. Use require_once() for all include/*.php files. To simplify > inclusion each file includes the other files it needs. In this manner we

Re: [ntdll/tests] Added some NULL testing

2006-07-07 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > It's just that I'm going through a lot of the Coverity reports. A great > deal of them mention NULL parameters passed. That why I started writing > these checks and found that we're not always a 100% in line with M$. Yes, but that's deliberate, we don't w

Re: FIXED: Running siap and modules under wine, first steps

2006-07-07 Thread Alex Villací­s Lasso
Maximiliano Curia wrote: On Monday 12 June 2006 14:59, you wrote: As of 2006-06-09, the CVS snapshot of Wine seems to run SIAP correctly. No crashes at all. Could you please be so kind as to test with the *most recent CVS snapshot* and confirm? I tested SIAP under one of the 0.9.15 nig

Re: [ntdll/tests] Added some NULL testing

2006-07-07 Thread Paul Vriens
On Fri, 2006-07-07 at 18:24 +0200, Alexandre Julliard wrote: > Paul Vriens <[EMAIL PROTECTED]> writes: > > > Hi, > > > > added some tests with NULL parameters. > > > > Changelog > > Added some NULL testing > > I appreciate your willingness to write tests, but please don't spend > too much effor

Re: [AppDB] - preferences.php cleanups

2006-07-07 Thread Jonathan Ernst
Le vendredi 07 juillet 2006 à 01:06 -0400, Chris Morgan a écrit : > Stop using global variables in preferences.php. Reorder functions so we > don't > have php code running and functions in the middle of it. Rename a couple of > variables to match our current variable naming convention. > > Chr

Re: [AppDB] - move getMaintainersUserIds...() to version::getMaintainersUserIds()

2006-07-07 Thread Jonathan Ernst
Le vendredi 07 juillet 2006 à 01:21 -0400, Chris Morgan a écrit : > Move getMaintainersUserIds...() to version::getMaintainersUserIds() and fixup > callers of this function. > > Chris > > > This one looks fine to me. signature.asc Description: Ceci est une partie de message numériquement si

Re: [ntdll/tests] Added some NULL testing

2006-07-07 Thread Alexandre Julliard
Paul Vriens <[EMAIL PROTECTED]> writes: > Hi, > > added some tests with NULL parameters. > > Changelog > Added some NULL testing I appreciate your willingness to write tests, but please don't spend too much effort on testing NULL inputs, it's not an interesting case unless there's a specific ap

Re: Testing help needed: Pixel format whitelisting

2006-07-07 Thread Jason Green
On 7/7/06, Jason Green <[EMAIL PROTECTED]> wrote: On 7/1/06, Stefan Dösinger <[EMAIL PROTECTED]> wrote: Half Life 2, on the other hand, won't launch the level after the patch (at least with pixel shaders enabled). I've attached the d3d_caps logs grepped for "CheckDeviceFormat" from before and af

Re: ole32: Get the threading model value for inproc classes and output a fixme if we should create it in an apartment of another type.

2006-07-07 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: dlls/ole32/compobj.c | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) This one crashes the urlmon tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../

Re: Cursor patches

2006-07-07 Thread H. Verbeet
On 07/07/06, Robert Shearman <[EMAIL PROTECTED]> wrote: This appears to be the only place where a cursor is destroyed. Thus, a bad application could end up wineserver to leak memory. I think you need to investigate when Windows frees cursors that have not had DestroyCursor called on them. My gues

Re: wine's fullscreen code has no effect on metacity

2006-07-07 Thread Elijah Newren
On 7/6/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: From http://standards.freedesktop.org/wm-spec/1.3/ar01s05.html "_NET_WM_STATE_FULLSCREEN indicates that the window should fill the entire screen and have no window decorations. Additionally the Window Manager is responsible for restoring the

Re: wine's fullscreen code has no effect on metacity

2006-07-07 Thread Havoc Pennington
Dmitry Timoshkov wrote: Anyway, few WM bugs can be resolved by appeal to specifications alone... Ok, let's appeal to the fact that Wine's fullscreen stuff works in KDE and doesn't in GNOME :-) If you could point out what Wine is doing in wrong way I'm all ears. Don't get defensive, everyone i

Re: wine's fullscreen code has no effect on metacity

2006-07-07 Thread Havoc Pennington
Dmitry Timoshkov wrote: An algorithm in Wine which asks a WM to activate fullscreen state for a window is quite simple: it checks the size of a just resized visible window and if it's equal or larger than screen size sends an event to a WM. We are trying to understand at the moment why metacity s

Re: wine's fullscreen code has no effect on metacity

2006-07-07 Thread Havoc Pennington
Dmitry Timoshkov wrote: So, all the checks metacity does for window decorations and window size are contradicting the spec IMO. Both the ICCCM and EWMH are specs for "hints" - they have a big "any of these hints may be ignored" disclaimer attached. In practice, categorically ignoring (or mis

Re: Debugging _CheckNotSysLevel() errors?

2006-07-07 Thread Dan Kegel
On 7/6/06, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > http://bugs.winehq.org/show_bug.cgi?id=4063 is a crash > on exit from a VB6 app due to a _CheckNotSysLevel() error. > What typically causes these - are they a bug in the windows > program? And is there a good reference from understanding >

Re: winecfg: Shift Graphics page up to fill the empty place.

2006-07-07 Thread Ivan Gyurdiev
Speaking of the graphics page... 1. Is there a reason why we allow the user to choose software vs hardware shaders? (i.e. why isn't this a developers' option, or no option at all) 2. Is there a reason why we allow the user to disable vertex and/or pixel shaders?

Re: Debugging _CheckNotSysLevel() errors?

2006-07-07 Thread Mike Hearn
On Fri, 07 Jul 2006 00:24:49 -0700, Dan Kegel wrote: > http://bugs.winehq.org/show_bug.cgi?id=4063 is a crash > on exit from a VB6 app due to a _CheckNotSysLevel() error. > What typically causes these - are they a bug in the windows > program? And is there a good reference from understanding > the

Re: wine packages for Fedora Extras

2006-07-07 Thread Mike Hearn
That's great, thanks!

Re: Cursor patches

2006-07-07 Thread Dmitry Timoshkov
"Robert Shearman" <[EMAIL PROTECTED]> wrote: -DELAYIMPORTS = imm32 +DELAYIMPORTS = imm32 winmm EXTRALIBS = $(LIBUNICODE) SPEC_SRCS16 = \ I'm not sure it is acceptable to import winmm from user32, even if it is a delay import. Rob is right, native user32 doesn't import winmm by any mean

Re: ole32: Get the threading model value for inproc classes and output a fixme if we should create it in an apartment of another type.

2006-07-07 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > dlls/ole32/compobj.c | 45 + > 1 files changed, 45 insertions(+), 0 deletions(-) This one crashes the urlmon tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.

Re: Cursor patches

2006-07-07 Thread Robert Shearman
H. Verbeet wrote: Attached to this mail are a couple of patches that should fix some issues with mouse cursors. It would be nice if some people could have a look and see if the patches break anything. Patches 1-4 move cursors into the server, 5 adds support for Xcursor cursors, 6 & 7 are cleanup

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
> From: Ge van Geldorp [mailto:[EMAIL PROTECTED] > > Yes, this works fine, both with and without the change to > include/msvcrt/string.h. Sorry, I only tested dlls/msvcrt. When doing a full rebuild I get errors, will investigate and let you know. Ge.

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
> From: Alexandre Julliard > > We really shouldn't be including string.h here. Does this work for > you? > > diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h > index fc330ce..dcba4ae 100644 > --- a/dlls/msvcrt/msvcrt.h > +++ b/dlls/msvcrt/msvcrt.h > @@ -37,8 +37,6 @@ > #ifndef __WINE_MSV

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Alexandre Julliard
"Ge van Geldorp" <[EMAIL PROTECTED]> writes: > In file included from data.c:21: > ./../msvcrt.h:625: error: conflicting types for _strnset > ../../../include/msvcrt/string.h:62: error: previous declaration of _strnset > was here > > The patch I submitted fixes the problem by moving the include of

Re: Debugging _CheckNotSysLevel() errors?

2006-07-07 Thread Dmitry Timoshkov
"Dan Kegel" <[EMAIL PROTECTED]> wrote: http://bugs.winehq.org/show_bug.cgi?id=4063 is a crash on exit from a VB6 app due to a _CheckNotSysLevel() error. What typically causes these - are they a bug in the windows program? And is there a good reference from understanding the whole syslevel thing

Re: wine's fullscreen code has no effect on metacity

2006-07-07 Thread Dmitry Timoshkov
"Havoc Pennington" <[EMAIL PROTECTED]> wrote: Anyway, few WM bugs can be resolved by appeal to specifications alone... Ok, let's appeal to the fact that Wine's fullscreen stuff works in KDE and doesn't in GNOME :-) If you could point out what Wine is doing in wrong way I'm all ears. Don't ge

Debugging _CheckNotSysLevel() errors?

2006-07-07 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=4063 is a crash on exit from a VB6 app due to a _CheckNotSysLevel() error. What typically causes these - are they a bug in the windows program? And is there a good reference from understanding the whole syslevel thing in gdi? Thanks!

[AppDB] Re: appdb/include incl.php

2006-07-07 Thread Jonathan Ernst
Le jeudi 06 juillet 2006 à 21:36 -0500, WineHQ a écrit : [...] > > +/** > + * rename $_REQUEST variables to preserve backwards compatibility > + * with bugzilla links and urls in emails and on google from before our > + * mass rename of GPC variables to use our coding standard prefixing > + * > +

[AppDB] Re: appdb/include filter.php

2006-07-07 Thread Jonathan Ernst
Le jeudi 06 juillet 2006 à 23:49 -0500, WineHQ a écrit : > ChangeSet ID: 26258 > CVSROOT: /opt/cvs-commit > Module name: appdb > Changes by: [EMAIL PROTECTED] 2006/07/06 23:49:32 > > Modified files: > include: filter.php > > Log message: > Tony Lambregts <[EMAIL