Re: WineD3D: Flip WINED3DFMT_R8G8B8 to GL_RGB

2006-07-04 Thread Ivan Gyurdiev
Stefan Dösinger wrote: WINED3DFMT_R8G8B8 means that the 8 most significant bits contain the red color channel, and the 8 least significant ones the blue channel. But in memory the least significant bits are at the highest address, so the surface ends up as BGR in memory. This patch finally chan

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Saulius Krasuckas
* On Wed, 5 Jul 2006, Dmitry Timoshkov wrote: > * "Saulius Krasuckas" wrote: > > > > > strcat wrapper creates an illusion that it solves some problem when > > > it actually doesn't. > > > > So you agree there is a problem which isn't solved in current test > > code? > > I have no idea how it's

Re: [WiKI] Common site menu 4/4

2006-07-04 Thread Dimi Paun
On Sat, 2006-06-03 at 16:20 -0600, Tony Lambregts wrote: > Change log: update menus for all sites to have a common "WineHQ Menu". OK, it's in, it needed a few fixes, but it should be good now. My apologies for the long delay in getting this in. -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: strcat wrapper creates an illusion that it solves some problem when it actually doesn't. So you agree there is a problem which isn't solved in current test code? I have no idea how it's possible to make such a conclusion from what I've said. --

Re: wine packages for Fedora Extras

2006-07-04 Thread Neal Gompa
So, does that mean that the wine debugger is now available in extras? Because it seems its not there, and I could find a such package that would contain it...On 7/4/06, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: Tuesday, July 4, 2006, 12:06:00 PM, Andreas Bierfert wrote:> Hi,> some of you might h

Re: [dinput-0/6] multiple devices - Resend #2

2006-07-04 Thread Robert Reif
Christoph Frick wrote: hiho this is again my patch for handling more than one /dev/input/event* joystick within dinput. there are several other patches now to follow, that expect this patch to be applied. so i label this one 0 of 6. against the previous version it only has some "detect first jo

Question about regedit:listview.c:AddEntryToList()

2006-07-04 Thread Andrew Talbot
In the above function, am I right in thinking that the "(not set)" string literal ought to be represented by something of type LPTSTR? Thanks, -- Andy.

Re: wine packages for Fedora Extras

2006-07-04 Thread Vitaliy Margolen
Tuesday, July 4, 2006, 12:06:00 PM, Andreas Bierfert wrote: > Hi, > some of you might have noticed that building 0.9.16 for Fedora Extras took me > more time then the releases before. This was because of the discussions from a > couple of weeks ago on this list. As a result I did spent some time o

Re: [wininet][3] Use a blank password if a NULL password is given

2006-07-04 Thread James Hawkins
On 7/4/06, Paul Vriens <[EMAIL PROTECTED]> wrote: Hi, MSDN states that we should use a blank password when a NULL password is given together with a NON-NULL username. Ethereal confirms this :-) Changelog Use a blank password if a NULL password is given uh oh: Hi, See msdn: http://m

Re: msi: Update the files' target paths as well, because they may have changed if a parent directory is changed

2006-07-04 Thread James Hawkins
On 7/4/06, Andrey Turkin <[EMAIL PROTECTED]> wrote: Hi James, Funny, your patch looks just identical to mine (submitted but rejected by some reason) except for comments :) hmm I haven't seen your patch. If the code is similar, it's probably because we both copied and pasted from ACTION_Cost

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Saulius Krasuckas
* On Tue, 4 Jul 2006, Dmitry Timoshkov wrote: > * "Saulius Krasuckas" wrote: > > > > It was one "if" that I removed in my patch. Maybe you mean this way? > > Yes, that's a perfect way of checking for a possible buffer overflow, > there is no need to complicate things. It may be perfect from so

wine packages for Fedora Extras

2006-07-04 Thread Andreas Bierfert
Hi, some of you might have noticed that building 0.9.16 for Fedora Extras took me more time then the releases before. This was because of the discussions from a couple of weeks ago on this list. As a result I did spent some time on the mentioned issues and came across an easy solution: If you ins

Re: wine's fullscreen code has no effect on metacity

2006-07-04 Thread Vincent Povirk
I've enabled that key combination, and I can now make gedit fullscreen with alt+f11 so I think that's working properly (this is nifty; wonder how I missed it..). Pressing alt+f11 when windows firefox thinks it's in fullscreen mode has no effect. xprop shows no _NET_WM_STATE. However, it does wor

Re: wine's fullscreen code has no effect on metacity

2006-07-04 Thread Vincent Povirk
running metacity: [EMAIL PROTECTED]:~$ xprop | grep _NET_WM_STATE _NET_WM_STATE(ATOM) = running kwin: [EMAIL PROTECTED]:~$ xprop | grep _NET_WM_STATE _NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN Not that I understood how this was supposed to work to begin with, but this really doesn't make

Re: Strange behavior in debugging of bug #5245, looking for comments

2006-07-04 Thread Alex Villací­s Lasso
Louis Lenders wrote: Alex Villací­s Lasso palosanto.com> writes: Robert Shearman wrote: Alex Villací­s Lasso wrote: Last weekend, I was trying to trace down bug #5245 (Run-Time error '6' overflow in terragen). With current CVS, the bug manifests itself with an "Overflow" dia

Re: wine's fullscreen code has no effect on metacity

2006-07-04 Thread Vincent Povirk
I've tried that; it didn't work in this case. :/ On 7/4/06, Mike Hearn <[EMAIL PROTECTED]> wrote: On Sun, 02 Jul 2006 13:09:59 -0400, Vincent Povirk wrote: > So, uh, metacity people, under what circumstances would metacity be > likely to put a window that had sent the proper _NET_WM_STATE_ADD >

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: There are other ways to achieve that. Once Alexandre already commented out an almost the same approach someone tried to port from ReactOS to Wine. Hm, I don't remember this. Can you give me an example of a nice way, please? It was one "if" tha

Re: msi: Update the files' target paths as well, because they may have changed if a parent directory is changed

2006-07-04 Thread Andrey Turkin
James Hawkins wrote: > Hi, > > This fixes bug 5595. The Lotus Notes installer was calling > MsiSetTargetPath after the CostFinalize action, which is where the > target paths are originally set for installation files. Originally, > the directories were being changed, but that doesn't trickle down

Re: wine's fullscreen code has no effect on metacity

2006-07-04 Thread Mike Hearn
On Sun, 02 Jul 2006 13:09:59 -0400, Vincent Povirk wrote: > So, uh, metacity people, under what circumstances would metacity be > likely to put a window that had sent the proper _NET_WM_STATE_ADD > message for _NET_WM_STATE_FULLSCREEN behind panels? Run metacity from the command line so you can se

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Saulius Krasuckas
* On Tue, 4 Jul 2006, Dmitry Timoshkov wrote: > * "Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: > > > > By "safe" I meant it doesn't overflow buffer. Does it do? > > There are other ways to achieve that. Once Alexandre already commented > out an almost the same approach someone tried to port f

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: By "safe" I meant it doesn't overflow buffer. Does it do? There are other ways to achieve that. Once Alexandre already commented out an almost the same approach someone tried to port from ReactOS to Wine. But well, would your reactions was the t

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Saulius Krasuckas
* On Tue, 4 Jul 2006, Dmitry Timoshkov wrote: > * "Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: > > > +static void safe_strcatA(char *dst, DWORD dst_len, const char *src) > > +{ > > +UINT length; > > +char *buff; > > + > > +length = lstrlenA(dst); > > +length += lstrlenA(src); > >

Re: [WINED3D: Review] Hook software shaders into drawStridedSlow

2006-07-04 Thread Ivan Gyurdiev
To make it clear, this doesn't implement software shaders - it just moves code around so when they're implemented it would be easier to do. I already have one more or less working implementation, but it's based on executing small functions for each opcode (like the previous code does), except

Re: [PATCH 1/2] kernel/tests: Implement safe local strcat function.

2006-07-04 Thread Dmitry Timoshkov
"Saulius Krasuckas" <[EMAIL PROTECTED]> wrote: +static void safe_strcatA(char *dst, DWORD dst_len, const char *src) +{ +UINT length; +char *buff; + +length = lstrlenA(dst); +length += lstrlenA(src); +buff = HeapAlloc(GetProcessHeap(), 0, length + 1); + +lstrcpyA(buff, dst

Re: [WINED3D 1] Rework shader mode selection

2006-07-04 Thread Ivan Gyurdiev
H. Verbeet wrote: On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: - Store the shader selected mode into the shader itself. Different types of shaders can be combined, so this is an improvement. In fact, storing the mode into the settings globally is a mistake as well - it should be done pe

Re: [WINED3D 2] Allow mix of SW vertex and GLSL pixel shader.

2006-07-04 Thread H. Verbeet
On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Well, this might be true, but that's no reason to disallow it Sure, but adding complexity could be.

Re: [WINED3D 3] Only link and use GLSL programs if at least one GLSL shader is available.

2006-07-04 Thread H. Verbeet
On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: H. Verbeet wrote: > On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: >> There's something wrong with this patch... I'm not sure what it is yet, > The 0 program (fixed function) doesn't get set anymore when there are > no shaders. The fixe

Re: [WINED3D 2] Allow mix of SW vertex and GLSL pixel shader.

2006-07-04 Thread Ivan Gyurdiev
H. Verbeet wrote: On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Do not attach non-GLSL shaders to the GLSL program, that will cause a crash. Mix with ARB shaders is never going to happen, because the selection code will always choose GLSL for both or ARB for both. As mentioned on IRC, I

Re: [WINED3D 3] Only link and use GLSL programs if at least one GLSL shader is available.

2006-07-04 Thread Ivan Gyurdiev
H. Verbeet wrote: On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: There's something wrong with this patch... I'm not sure what it is yet, The 0 program (fixed function) doesn't get set anymore when there are no shaders. The fixed function is a GLSL program?

Re: [WINED3D 1] Rework shader mode selection

2006-07-04 Thread H. Verbeet
On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: - Store the shader selected mode into the shader itself. Different types of shaders can be combined, so this is an improvement. In fact, storing the mode into the settings globally is a mistake as well - it should be done per device, since dif

Re: [WINED3D 2] Allow mix of SW vertex and GLSL pixel shader.

2006-07-04 Thread H. Verbeet
On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: Do not attach non-GLSL shaders to the GLSL program, that will cause a crash. Mix with ARB shaders is never going to happen, because the selection code will always choose GLSL for both or ARB for both. As mentioned on IRC, I'm not sure using a

Re: [WINED3D 3] Only link and use GLSL programs if at least one GLSL shader is available.

2006-07-04 Thread H. Verbeet
On 04/07/06, Ivan Gyurdiev <[EMAIL PROTECTED]> wrote: There's something wrong with this patch... I'm not sure what it is yet, The 0 program (fixed function) doesn't get set anymore when there are no shaders.